-
Type:
Bug
-
Status: Done
-
Priority:
High
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: Carry Over - Fall
-
Labels:None
-
Company:All Clients/Multiple Clients
Environment: Production
1. Email > Link > Review and Sign HTML Doc > Blank popup appearing
Refer screen capture.
This issue is regarding the specific admin unable to Review and Sign document sent to other company candidate. we have workaround for yesterday.
Need to implement on both Preprod and Production.
Task Done:
- Code debugging and Issue repro
- Discussion with Ganesh and Priya
- Code fixing and unit testing
Komal Barde (Inactive)
added a comment - Task Done :
Code debugging and Issue repro
Discussion with Ganesh and Priya
Code fixing and unit testing
List of modified files:
- DMS/DMS.App/src/DMS_AppLogic/Common/CommonRoutines.cs
- DMS/DMS.App/src/DMS_Localization/DMSConstants.cs
- DMS/DMS.App/src/DMS_Localization/Resources/DMSResource.en.resx
- DMS/DMS.App/src/DMS_Localization/Resources/DMSResource.es.resx
- DMS/DMS.App/src/DMS_Localization/Resources/DMSResource.fr.resx
- DMS/DMS.App/src/DMS_Localization/Resources/DMSResource.zh.resx
- DMS/DMS.App/src/DMS_WebApi/Controllers/Document/FormsLibraryController.cs
- DMS/DMS.Web/src/DMS_WebApp/ClientApp/src/app/Forms/sendformdetails/sendformdetails.component.ts
- DMS/DMS.Web/src/DMS_WebApp/ClientApp/src/app/Person/editable-pdf/editable-pdf.component.ts
- DMS/DMS.Web/src/DMS_WebApp/ClientApp/src/app/Shared/Components/modals/modals.component.ts
- DMS/DMS.Web/src/DMS_WebApp/ClientApp/src/app/Shared/Components/viewer/viewer.component.html
- DMS/DMS.Web/src/DMS_WebApp/ClientApp/src/app/Shared/Components/viewer/viewer.component.ts
Komal Barde (Inactive)
added a comment - List of modified files :
DMS/DMS.App/src/DMS_AppLogic/Common/CommonRoutines.cs
DMS/DMS.App/src/DMS_Localization/DMSConstants.cs
DMS/DMS.App/src/DMS_Localization/Resources/DMSResource.en.resx
DMS/DMS.App/src/DMS_Localization/Resources/DMSResource.es.resx
DMS/DMS.App/src/DMS_Localization/Resources/DMSResource.fr.resx
DMS/DMS.App/src/DMS_Localization/Resources/DMSResource.zh.resx
DMS/DMS.App/src/DMS_WebApi/Controllers/Document/FormsLibraryController.cs
DMS/DMS.Web/src/DMS_WebApp/ClientApp/src/app/Forms/sendformdetails/sendformdetails.component.ts
DMS/DMS.Web/src/DMS_WebApp/ClientApp/src/app/Person/editable-pdf/editable-pdf.component.ts
DMS/DMS.Web/src/DMS_WebApp/ClientApp/src/app/Shared/Components/modals/modals.component.ts
DMS/DMS.Web/src/DMS_WebApp/ClientApp/src/app/Shared/Components/viewer/viewer.component.html
DMS/DMS.Web/src/DMS_WebApp/ClientApp/src/app/Shared/Components/viewer/viewer.component.ts
Unit testing:
- Send form to user which is having company same as admin
- Send form to user which is not having company same as admin
- Send form to new user
- Handle blank popup for old send form
Komal Barde (Inactive)
added a comment - Unit testing:
Send form to user which is having company same as admin
Send form to user which is not having company same as admin
Send form to new user
Handle blank popup for old send form
Task Done:
- Code debugging and Issue fixing
- Discussion with Ganesh and Priya
- Unit testing
- Code merge and send for code review
Komal Barde (Inactive)
added a comment - Task Done :
Code debugging and Issue fixing
Discussion with Ganesh and Priya
Unit testing
Code merge and send for code review
Environment: PreProd
Scenarios covered during testing
1. Same Company, Admin and Candidate > Able to complete entire flow > Pass
2. Same Company, Admin and different Company Candidate > Validation message in Preview > Pass
3. Same Company , Admin and New User > Able to complete entire flow > Pass
4. Same Company, Admin and different Company Existing Candidate > File not found message displayed > Pass
As all scenarios worked as expected, marking jira Done. Refer screen capture.
Hi Priya Dhamande,
I am unable to replicate the case. I am testing with sign_test_html template in pre-prod.
Can u please look into this once more also clear the cache and try again.
cc - Samir, Swapnil Pandhare
Thanks