-
Type:
New Feature
-
Status: Done
-
Priority:
Medium
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: Enhancements - Fall
-
Labels:None
-
Company:All Clients/Multiple Clients
-
Epic Link:
-
Sprint:DMS - Fall Sprint 1, DMS - Fall Sprint 2, DMS - Fall Sprint 3, DMS - Fall Sprint 4, DMS - Fall Sprint 5, DMS - Fall Sprint 6, DMS - Fall Sprint 7, DMS - Fall Sprint 8, DMS - Gap Fall & Win Sprint 1, DMS - Gap Fall & Win Sprint 2
Hi
Please find attached DMS-1170_ETA.xls document that contains ETA for
DMS-1170.
For 'Delete' and 'Open' action we have some queries as mentioned in above comment, so ETA for both will vary depending on client input.
Thanks,
Komal
CC:Samir, Swapnil Pandhare, Ganesh Sadawarte, Rohan J Khandave, Narendra Kumar
Task Done:
- Analysis to get candidate file details
- Analysis to download candidate file details
- Discussion with Swapnil
- Prepare ETA
Hi Komal Barde
Please find my answers inline.
- In case of candidate file 'Delete' action , does system need to delete file permanently from file server and database (hard deletion) or system will keep file but its 'Isdeleted' flag will set to yes (soft deletion)? Jilna: This action will be removed, that means we will no longer be showing the delete option to the candidate, the mock up's needs to be updated.
- For candidate file 'Open' action, what exactly API needs to perform? Jilna: "Open" opens document in browser's native preview app
Samir Swapnil Pandhare Ganesh Sadawarte Rohan J Khandave Narendra Kumar **
Task status:
- Download action: Completed
- Get details : Pagination and searching is Completed
- Get details : Sorting is in-progress
- Test case writing in current integration API - Not started
Hi
Please find DMS-1170_API.doc document for API details of get details and download or open files of candidate.
This API contains below action:
1. Get details of files : This will return list of candidate uploaded files and total no of records
2. Download candidate file and open candidate file: This will return file content for given file ID. (Note: We have a added common code for 'Download' and 'Open' action, as both need to return file content).
Thanks,
Komal
CC:Samir, Swapnil Pandhare,Ganesh Sadawarte
List of modified/added files:
- DMS/DMS.App/src/DMS_AppLogic/IntegrationLogic/ProvisioningApiLogic.cs
- DMS/DMS.App/src/DMS_AppLogic/Repository/IGenRepository.cs
- DMS/DMS.App/src/DMS_WebApi/Controllers/IntegrationAPI/ProvisioningAPIController.cs
- DMS/DMS.App/src/Entities/IntegrationDtos/CandidateFileDTO.cs
- DMS/DMS_App_Tests/ProvisioningApiTest.cs
Task Done:
- Get details : Sorting is
- Test case writing in current integration API
- Unit testing
- Code merge
Hi Swapnil Pandhare,
I have done suggested code changes in 'DMS-1170_Final' branch and assigned it to you for code review.
Thanks,
Komal
CC:Ganesh Sadawarte
Hi Jilna,
Please find updated DMS-1170_API_Updated.doc document for API details of get details and download files for a candidate.
Thanks,
Komal
Hi Komal Barde
There will be issues with the "Get details of files related to a specific candidate" when a specific candidate has two release associated with his email address.
When I fetch documents it will give me all files related to both the releases. What we need would be to fetch files by
releaseId
Also, can we have another endpoint to fetch(not download) files by Id?
Mason Michael Samir Swapnil Pandhare
Hi Harshveer Singh,
Please find below details of get file data of candidate API:
API Endpoint details:
HTTP Method : GET
URL : /api/get/candidate/upload/hbcandidate@hb.com/2/1/DMS/filename/ desc
API Input:
- PersonEmail (Required):This will contain person email address whose uploaded file list needs to provide.
- PageSize: This will contain no of records to be provided for given page.
- PageNumber: This will contain page no to be provided.
- SearchTerm: This will contain string that will be used to search data in list.
- Sortcolumn: This will be used to sort candidates uploaded file(s) list by specific column and this will contain – filename, uploadedby, datetime, description, orderID, releaseID .
- Sortby: This will be used to sort candidates uploaded file(s) list in ascending or descending order and this will contain – asc, desc .
API Return value:
List of candidate uploaded files and total no of records
API Success Response:
On success following response will be returned:
HTTP/1.1 200
{
"data": [
{
"UploadFileobj":
,
"attchementID": 231,
"CreatedDateTime": "2019-04-29T12:19:47"
},
{
"UploadFileobj":
,
"attchementID": 232,
"CreatedDateTime": "2019-04-29T12:22:32"
}
],
"noofrecords": 5
}
Thanks,
Komal
CC:Swapnil Pandhare, Ganesh Sadawarte,Samir
Hi Harshveer Singh,
Can you please look into Jilna's https://jira.workterra.net/browse/DMS-1170?focusedCommentId=264175&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-264175 comment ?
Thanks,
Komal
Created PR: https://github.com/cbdr/DMS/pull/612
API EndPoint is : /api/candidateattachments?page=1&count=10&sortorder=asc&sortcolumn=&searchterm=&releaseid=0&orderid=0
Above specified are the query string parameters supported with default values. Either releaseid or orderid parameter must be specified to filter otherwise no results will be retured.
Values for sortOrder is 'asc' or 'desc', and possible values for sortcolumn are: filename, uploadedby, datetime, description, orderid, releaseid
No Testing required from Qa end, So, marking jira done.
Hi Jilna,
We have below queries for API to get details and download files of candidate:
Can you please provide your input on same?
Thanks,
Komal
CC:Samir, Swapnil Pandhare, Rohan J Khandave, Ganesh Sadawarte, Narendra Kumar