Details

    • Type: Bug
    • Status: Done
    • Priority: Medium
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: Carry Over - Fall
    • Labels:
      None

      Description

      1. Register company return 200 status even company already exists.
      2. Return 404 when company & user not found in getCompany & getUser API
      3. By pass get company API , so need to pass userdid
      4. Make UserDid optional for creating user & get user details.

        Attachments

        1. CompanyAlreadyExists.png
          CompanyAlreadyExists.png
          85 kB
        2. Company Not Found.png
          Company Not Found.png
          203 kB
        3. GetCompany_2.jpg
          GetCompany_2.jpg
          258 kB
        4. getCompany.png
          getCompany.png
          258 kB

          Activity

          rohan.khandave Rohan J Khandave (Inactive) created issue -
          rohan.khandave Rohan J Khandave (Inactive) made changes -
          Field Original Value New Value
          Epic Link DMS-473 [ 75966 ]
          rohan.khandave Rohan J Khandave (Inactive) made changes -
          Remaining Estimate 16h [ 57600 ]
          Original Estimate 16h [ 57600 ]
          rohan.khandave Rohan J Khandave (Inactive) made changes -
          Attachment getCompany.png [ 104417 ]
          rohan.khandave Rohan J Khandave (Inactive) made changes -
          Attachment CompanyAlreadyExists.png [ 104418 ]
          rohan.khandave Rohan J Khandave (Inactive) made changes -
          Description 1. Register company return 200 status even company already exists.
          2. Return 404 when company & user not found in getCompany & getUser API
          2. By pass get company API , so need to pass userdid
          1. Register company return 200 status even company already exists.
          2. Return 404 when company & user not found in getCompany & getUser API
          3. By pass get company API , so need to pass userdid
          4. Make UserDid optional for creating user & get user details.
          swapnil.pandhare Swapnil Pandhare (Inactive) made changes -
          Fix Version/s Candidate portfolio in DMS [ 10446 ]
          Sprint DMS - Fall Sprint 1 [ 160 ]
          Hide
          rohan.khandave Rohan J Khandave (Inactive) added a comment -

          Below points will get consider into DMS-1149.

          3. By pass get company API , so need to pass userdid
          4. Make UserDid optional for creating user & get user details.

          Show
          rohan.khandave Rohan J Khandave (Inactive) added a comment - Below points will get consider into DMS-1149 . 3. By pass get company API , so need to pass userdid 4. Make UserDid optional for creating user & get user details.
          rohan.khandave Rohan J Khandave (Inactive) made changes -
          Status To Do [ 10000 ] In Progress [ 3 ]
          rohan.khandave Rohan J Khandave (Inactive) made changes -
          Assignee Samir [ samir ] Rohan J Khandave [ rohan.khandave ]
          shashikant.mishra ShashiKant Mishra (Inactive) made changes -
          Fix Version/s Carry Over - Fall [ 10608 ]
          Fix Version/s Integration with CBAT [ 10445 ]
          Fix Version/s Candidate portfolio in DMS [ 10446 ]
          Hide
          rohan.khandave Rohan J Khandave (Inactive) added a comment -

          Remaining 2 points are covered under DMS-1204.

          Show
          rohan.khandave Rohan J Khandave (Inactive) added a comment - Remaining 2 points are covered under DMS-1204 .
          rohan.khandave Rohan J Khandave (Inactive) made changes -
          Status In Progress [ 3 ] Code Review [ 11801 ]
          Hide
          rohan.khandave Rohan J Khandave (Inactive) added a comment -

          Please check deployed with DMS-1204

          Show
          rohan.khandave Rohan J Khandave (Inactive) added a comment - Please check deployed with DMS-1204
          rohan.khandave Rohan J Khandave (Inactive) made changes -
          Assignee Rohan J Khandave [ rohan.khandave ] Priya Dhamande [ priya.dhamande ]
          rohan.khandave Rohan J Khandave (Inactive) made changes -
          Status Code Review [ 11801 ] In QA Testing [ 11901 ]
          rohan.khandave Rohan J Khandave (Inactive) logged work - 17/Apr/19 07:40 AM
          • Time Spent:
            2h
             

            analysis

          rohan.khandave Rohan J Khandave (Inactive) made changes -
          Remaining Estimate 16h [ 57600 ] 14h [ 50400 ]
          Time Spent 2h [ 7200 ]
          Worklog Id 173601 [ 173601 ]
          jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
          Attachment GetCompany_2.jpg [ 105345 ]
          Hide
          jayshree.nagpure Jayshree Nagpure (Inactive) added a comment - - edited

          Verified on Preproduction

          1. Register company return 200 status even company already exists - showing "Company already exist" - Pass
          2. Return 404 when company & user not found in getCompany & getUser API
          -get company - fail
          -getUser - pass(Showing user not found with 404 error)
          3. By pass get company API , so need to pass userdid - Pass- Incase of userdid is invalid showing company details.
          -But if Accountdid is incorrect showing Redhiglight, instead is should show 404 error with proper validation message
          4. Make UserDid optional for creating user & get user details - UserDid when not given- "{"Errors":[

          {"type":"Error","message":"Invalid authorization header","code":401}

          ]}"
          Enter dummy userDid - created user and get user details correctly.

          Refer screen capture for failed point.

          Re-opening this ticket

          Thanks,
          Jayshree

          Priya Dhamande Sachin Hingole Hrishikesh Deshpande Satya

          Show
          jayshree.nagpure Jayshree Nagpure (Inactive) added a comment - - edited Verified on Preproduction 1. Register company return 200 status even company already exists - showing "Company already exist" - Pass 2. Return 404 when company & user not found in getCompany & getUser API - get company - fail -getUser - pass(Showing user not found with 404 error) 3. By pass get company API , so need to pass userdid - Pass- Incase of userdid is invalid showing company details. - But if Accountdid is incorrect showing Redhiglight, instead is should show 404 error with proper validation message 4. Make UserDid optional for creating user & get user details - UserDid when not given- "{"Errors":[ {"type":"Error","message":"Invalid authorization header","code":401} ]}" Enter dummy userDid - created user and get user details correctly. Refer screen capture for failed point. Re-opening this ticket Thanks, Jayshree Priya Dhamande Sachin Hingole Hrishikesh Deshpande Satya
          jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
          Status In QA Testing [ 11901 ] In Progress [ 3 ]
          jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
          Assignee Priya Dhamande [ priya.dhamande ] Rohan J Khandave [ rohan.khandave ]
          rohan.khandave Rohan J Khandave (Inactive) made changes -
          Assignee Rohan J Khandave [ rohan.khandave ] Swapnil Pandhare [ swapnil.pandhare ]
          jayshree.nagpure Jayshree Nagpure (Inactive) logged work - 22/Apr/19 04:44 AM
          • Time Spent:
            1h
             

            testing

          jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
          Remaining Estimate 14h [ 50400 ] 13h [ 46800 ]
          Time Spent 2h [ 7200 ] 3h [ 10800 ]
          Worklog Id 174163 [ 174163 ]
          rohan.khandave Rohan J Khandave (Inactive) made changes -
          Assignee Swapnil Pandhare [ swapnil.pandhare ] Rohan J Khandave [ rohan.khandave ]
          rohan.khandave Rohan J Khandave (Inactive) made changes -
          Attachment Company Not Found.png [ 105579 ]
          Hide
          rohan.khandave Rohan J Khandave (Inactive) added a comment - - edited

          Hello Jayshree Nagpure,

          We checked this issue , this issue occurred due to large account did. This issue exists at CB API portal.

          We checked wrong account did with less characters and we get proper response.

          Please refer attached screen shot for same.

          Thanks,
          RohanK

          CC – Swapnil Pandhare , Priya Dhamande

          Show
          rohan.khandave Rohan J Khandave (Inactive) added a comment - - edited Hello Jayshree Nagpure , We checked this issue , this issue occurred due to large account did. This issue exists at CB API portal. We checked wrong account did with less characters and we get proper response. Please refer attached screen shot for same. Thanks, RohanK CC – Swapnil Pandhare , Priya Dhamande
          rohan.khandave Rohan J Khandave (Inactive) made changes -
          Status In Progress [ 3 ] In QA Testing [ 11901 ]
          rohan.khandave Rohan J Khandave (Inactive) made changes -
          Assignee Rohan J Khandave [ rohan.khandave ] Jayshree Nagpure [ jayshree.nagpure ]
          ashwin.wankhede Ashwin Wankhede (Inactive) made changes -
          Status In QA Testing [ 11901 ] In QA Testing [ 11901 ]
          rohan.khandave Rohan J Khandave (Inactive) logged work - 24/Apr/19 07:36 AM
          • Time Spent:
            0.5h
             

            Analysis

          rohan.khandave Rohan J Khandave (Inactive) made changes -
          Remaining Estimate 13h [ 46800 ] 12.5h [ 45000 ]
          Time Spent 3h [ 10800 ] 3.5h [ 12600 ]
          Worklog Id 174676 [ 174676 ]
          Hide
          jayshree.nagpure Jayshree Nagpure (Inactive) added a comment -

          Working fine
          Closing this ticket

          Show
          jayshree.nagpure Jayshree Nagpure (Inactive) added a comment - Working fine Closing this ticket
          jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
          Resolution Done [ 10000 ]
          Status In QA Testing [ 11901 ] Done [ 10001 ]
          jayshree.nagpure Jayshree Nagpure (Inactive) logged work - 25/Apr/19 07:35 AM
          • Time Spent:
            1h
             

            testing

          jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
          Remaining Estimate 12.5h [ 45000 ] 11.5h [ 41400 ]
          Time Spent 3.5h [ 12600 ] 4.5h [ 16200 ]
          Worklog Id 174911 [ 174911 ]
          jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
          Assignee Jayshree Nagpure [ jayshree.nagpure ] Rohan J Khandave [ rohan.khandave ]
          Transition Time In Source Status Execution Times
          Rohan J Khandave (Inactive) made transition -
          To Do In Progress
          3d 4h 28m 1
          Rohan J Khandave (Inactive) made transition -
          In Progress Code Review
          1d 17h 10m 1
          Rohan J Khandave (Inactive) made transition -
          Code Review In QA Testing
          1h 47m 1
          Jayshree Nagpure (Inactive) made transition -
          In QA Testing In Progress
          4d 21h 56m 1
          Rohan J Khandave (Inactive) made transition -
          In Progress In QA Testing
          2d 2h 44m 1
          Ashwin Wankhede (Inactive) made transition -
          In QA Testing In QA Testing
          17m 20s 1
          Jayshree Nagpure (Inactive) made transition -
          In QA Testing Done
          19h 37m 1

            People

            Assignee:
            rohan.khandave Rohan J Khandave (Inactive)
            Reporter:
            rohan.khandave Rohan J Khandave (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 16h
                16h
                Remaining:
                Time Spent - 4.5h Remaining Estimate - 11.5h
                11.5h
                Logged:
                Time Spent - 4.5h Remaining Estimate - 11.5h
                4.5h