[DMS-1221] Offer letter CBAT - API Changes to save & update logic - Workterra Jira

Details

Type: Sub-task
Status: Done
Priority: Medium
Resolution: Done
Affects Version/s: None
Fix Version/s: CBAT - offer letter module
Labels:
None

Company:
All Clients/Multiple Clients

Description

API Changes to save logic

Ganesh Sadawarte (Inactive) created issue - 17/Apr/19 12:21 AM

Ganesh Sadawarte (Inactive) made changes - 17/Apr/19 04:28 AM

Field	Original Value	New Value
Status	To Do [ 10000 ]	In Progress [ 3 ]

Ganesh Sadawarte (Inactive) made changes - 17/Apr/19 05:23 AM

Summary

API Changes to save logic

API Changes to save & update logic

Permalink

Ganesh Sadawarte (Inactive) logged work - 17/Apr/19 05:51 AM

Time Spent:

3h

<No comment>

Ganesh Sadawarte (Inactive) made changes - 17/Apr/19 05:51 AM

Remaining Estimate	24h [ 86400 ]	21h [ 75600 ]
Time Spent		3h [ 10800 ]
Worklog Id	173545 [ 173545 ]

Hide

Permalink

Ganesh Sadawarte (Inactive) added a comment - 17/Apr/19 05:55 AM

4/17/2019 Task Details.

Added New Property [FileContent] to get html text from CK Editor.
Added new function in common routine to generate file from file content.
Modified Save logic to update newly created file name.
Will continue on update part tomorrow.

CC-Samir,Swapnil Pandhare,Rohan J Khandave

Show

Ganesh Sadawarte (Inactive) added a comment - 17/Apr/19 05:55 AM 4/17/2019 Task Details. Added New Property [FileContent] to get html text from CK Editor. Added new function in common routine to generate file from file content. Modified Save logic to update newly created file name. Will continue on update part tomorrow. CC- Samir , Swapnil Pandhare , Rohan J Khandave

Ganesh Sadawarte (Inactive) made changes - 18/Apr/19 02:41 AM

Remaining Estimate	21h [ 75600 ]	16h [ 57600 ]
Time Spent	3h [ 10800 ]	8h [ 28800 ]
Worklog Id	173768 [ 173768 ]

Permalink

Ganesh Sadawarte (Inactive) logged work - 18/Apr/19 05:41 PM

Time Spent:

5h

<No comment>

Permalink

Ganesh Sadawarte (Inactive) logged work - 19/Apr/19 04:40 AM - edited

Time Spent:

6.5h
- Completed Save and Update API modification.
- Discussion with Swapnil Pandhare & Rohan J Khandave.
- Unit testing.
- Code push to GIT and assign for code review.

Ganesh Sadawarte (Inactive) made changes - 19/Apr/19 04:40 AM

Remaining Estimate	16h [ 57600 ]	11h [ 39600 ]
Time Spent	8h [ 28800 ]	13h [ 46800 ]
Worklog Id	173934 [ 173934 ]

Hide

Permalink

Ganesh Sadawarte (Inactive) added a comment - 19/Apr/19 04:42 AM

4/17/2019 Task Details.

Completed Save and Update API modification.
Discussion with Swapnil Pandhare & Rohan J Khandave.
Unit testing.
Code push to GIT and assign for code review.

CC-Swapnil Pandhare,Rohan J Khandave,Mohd Belal,Samir

Show

Ganesh Sadawarte (Inactive) added a comment - 19/Apr/19 04:42 AM 4/17/2019 Task Details. Completed Save and Update API modification. Discussion with Swapnil Pandhare & Rohan J Khandave . Unit testing. Code push to GIT and assign for code review. CC- Swapnil Pandhare , Rohan J Khandave , Mohd Belal , Samir

Ganesh Sadawarte (Inactive) made changes - 19/Apr/19 04:42 AM

Worklog Id

173934 [ 173934 ]

Ganesh Sadawarte (Inactive) made changes - 19/Apr/19 04:42 AM

Status

In Progress [ 3 ]

Code Review [ 11801 ]

Ganesh Sadawarte (Inactive) made changes - 19/Apr/19 06:31 AM

Remaining Estimate	11h [ 39600 ]	9.5h [ 34200 ]
Time Spent	13h [ 46800 ]	14.5h [ 52200 ]
Worklog Id	173934 [ 173934 ]

Permalink

Rohan J Khandave (Inactive) logged work - 19/Apr/19 07:32 AM

Time Spent:

0.5h

Code Review

Rohan J Khandave (Inactive) made changes - 19/Apr/19 07:32 AM

Remaining Estimate	9.5h [ 34200 ]	9h [ 32400 ]
Time Spent	14.5h [ 52200 ]	15h [ 54000 ]
Worklog Id	174021 [ 174021 ]

Ganesh Sadawarte (Inactive) made changes - 21/Apr/19 09:26 PM

Summary

API Changes to save & update logic

Offer letter CBAT - API Changes to save & update logic

Raj Hawaldar (Inactive) made changes - 22/Apr/19 12:49 AM

Status

Code Review [ 11801 ]

In QA Testing [ 11901 ]

Raj Hawaldar (Inactive) made changes - 22/Apr/19 12:49 AM

Assignee

Ganesh Sadawarte [ ganesh.sadawarte ]

Jayshree Nagpure [ jayshree.nagpure ]

Ganesh Sadawarte (Inactive) made changes - 22/Apr/19 01:47 AM

Assignee

Jayshree Nagpure [ jayshree.nagpure ]

Ganesh Sadawarte [ ganesh.sadawarte ]

Hide

Permalink

Ganesh Sadawarte (Inactive) added a comment - 22/Apr/19 01:48 AM

Hi Mohd Belal,

The save API changes are deployed on pre-prod. could you please check and let me know you face any issue.

CC-Samir,Swapnil Pandhare

Thanks,
Ganesh

Show

Ganesh Sadawarte (Inactive) added a comment - 22/Apr/19 01:48 AM Hi Mohd Belal , The save API changes are deployed on pre-prod. could you please check and let me know you face any issue. CC- Samir , Swapnil Pandhare Thanks, Ganesh

Ganesh Sadawarte (Inactive) made changes - 22/Apr/19 01:48 AM

Resolution		Done [ 10000 ]
Status	In QA Testing [ 11901 ]	Done [ 10001 ]

Ganesh Sadawarte (Inactive) made changes - 22/Apr/19 01:49 AM

Remaining Estimate	9h [ 32400 ]	8h 40m [ 31200 ]
Time Spent	15h [ 54000 ]	15h 20m [ 55200 ]
Worklog Id	174134 [ 174134 ]

Hide

Permalink

Mohd Belal (Inactive) added a comment - 22/Apr/19 07:40 AM

Hi Ganesh Sadawarte,

I am trying to update the Offer letter document along with the changes discussed of
FileContent, but while saving the file I am getting error of Document Name missing.
Attaching screenshot for the same.

cc - Samir, Swapnil Pandhare
Thanks

Show

Mohd Belal (Inactive) added a comment - 22/Apr/19 07:40 AM Hi Ganesh Sadawarte , I am trying to update the Offer letter document along with the changes discussed of FileContent , but while saving the file I am getting error of Document Name missing . Attaching screenshot for the same. cc - Samir , Swapnil Pandhare Thanks

Mohd Belal (Inactive) made changes - 22/Apr/19 07:41 AM

Attachment

Screenshot 2019-04-22 at 8.07.11 PM.png [ 105381 ]

Hide

Permalink

Mohd Belal (Inactive) added a comment - 22/Apr/19 07:43 AM

{"fieldRights":[

{"key":"Person.Legal ID","adminRights":"31","userRights":"31"}

{"key":"Person.Gender","adminRights":"31","userRights":"31"}

{"key":"Person.Residence Country","adminRights":"31","userRights":"31"}

],"Id":0,"TemplateName":"test_meta_cbat","Description":"damhbf","SourceProductId":"16","TemplateStatusId":"23","TemplateDocumentSource":0,"TemplateTypeId":"26","DocumentType":"14","TemplateFileName":null,"FileType":"67","TemplateFileTypeId":"67","FileContent":"<html>\n<head>\n\t<title></title>\n</head>\n<body>\n<p><a class=\"dmsTag\" href=\"mailto:Person.Legal ID\" id=\"1\">Person.Legal ID</a> ,masndlzfx <a class=\"dmsTag\" href=\"mailto:Person.Gender\" id=\"3\">Person.Gender</a> ljksdn <a class=\"dmsTag\" href=\"mailto:Person.Residence Country\" id=\"5\">Person.Residence Country</a> </p>\n</body>\n</html>\n","lstMappedFields":"","LanguageId":"1","strFieldMapping":"1~Person.Legal ID$^$1@$3~Person.Gender$^$3@$5~Person.Residence Country$^$5"}

Payload for your reference.

Show

Mohd Belal (Inactive) added a comment - 22/Apr/19 07:43 AM {"fieldRights":[ {"key":"Person.Legal ID","adminRights":"31","userRights":"31"} , {"key":"Person.Gender","adminRights":"31","userRights":"31"} , {"key":"Person.Residence Country","adminRights":"31","userRights":"31"} ],"Id":0,"TemplateName":"test_meta_cbat","Description":"damhbf","SourceProductId":"16","TemplateStatusId":"23","TemplateDocumentSource":0,"TemplateTypeId":"26","DocumentType":"14","TemplateFileName":null,"FileType":"67","TemplateFileTypeId":"67","FileContent":"<html>\n<head>\n\t<title></title>\n</head>\n<body>\n<p><a class=\"dmsTag\" href=\"mailto:Person.Legal ID\" id=\"1\">Person.Legal ID</a> ,masndlzfx <a class=\"dmsTag\" href=\"mailto:Person.Gender\" id=\"3\">Person.Gender</a> ljksdn <a class=\"dmsTag\" href=\"mailto:Person.Residence Country\" id=\"5\">Person.Residence Country</a> </p>\n</body>\n</html>\n","lstMappedFields":"","LanguageId":"1","strFieldMapping":"1~Person.Legal ID$ $1@ $3~Person.Gender$ $3@ $5~Person.Residence Country$^$5"} Payload for your reference.

Permalink

Ganesh Sadawarte (Inactive) logged work - 22/Apr/19 05:48 PM - edited

Time Spent:

0.5h

<No comment>

Ganesh Sadawarte (Inactive) made changes - 25/Apr/19 06:44 AM

Remaining Estimate	8h 40m [ 31200 ]	8.5h [ 30600 ]
Time Spent	15h 20m [ 55200 ]	15.5h [ 55800 ]
Worklog Id	174134 [ 174134 ]

Transition	Time In Source Status	Execution Times

Ganesh Sadawarte (Inactive) made transition - 17/Apr/19 04:28 AM

To Do

In Progress

4h 6m

Ganesh Sadawarte (Inactive) made transition - 19/Apr/19 04:42 AM

In Progress

Code Review

2d 14m

Raj Hawaldar (Inactive) made transition - 22/Apr/19 12:49 AM

Code Review

In QA Testing

2d 20h 6m

Ganesh Sadawarte (Inactive) made transition - 22/Apr/19 01:48 AM

In QA Testing

Done

59m 26s

People

Assignee:: Ganesh Sadawarte (Inactive)

Reporter:: Ganesh Sadawarte (Inactive)

Developer:: Ganesh Sadawarte (Inactive)

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Dates

Created:: 17/Apr/19 12:21 AM

Updated:: 25/Apr/19 06:44 AM

Resolved:: 22/Apr/19 01:48 AM

Time Tracking

Estimated:

24h

Remaining:

8.5h

Logged:

15.5h

Details

Description

Attachments

Attachments

Activity

People

Dates

Time Tracking