Document Management SystemProject Type: software

Document Management System

Uploaded image for project: 'Document Management System'
  1. Document Management System
  2. DMS-1227

CBATS : User API Changes

    Details

    • Type: Bug
    • Status: Done
    • Priority: Medium
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: CBAT Offer Letter - Fall
    • Labels:
      None

      Description

      Needs to allow to disabled all permissions for user , so needs to remove validation for at least one role needs to assigned.

      API's Affected

      GET : /api/userPermissions/

      {UserId}

      POST : /api/users
      PUT : /api/users

        Attachments

        1. DMS-1227.jpg
          DMS-1227.jpg
          237 kB
        2. DMS-1227.jpg
          DMS-1227.jpg
          265 kB

          Activity

          Ascending order - Click to sort in descending order
          rohan.khandave Rohan J Khandave (Inactive) created issue -
          rohan.khandave Rohan J Khandave (Inactive) made changes -
          Field Original Value New Value
          Epic Link DMS-473 [ 75966 ]
          rohan.khandave Rohan J Khandave (Inactive) made changes -
          Assignee Samir [ samir ] Rohan J Khandave [ rohan.khandave ]
          rohan.khandave Rohan J Khandave (Inactive) made changes -
          Description Needs to allow to disabled all permissions for user , so needs to remove validation for at least one role needs to assigned. Needs to allow to disabled all permissions for user , so needs to remove validation for at least one role needs to assigned.

          API's Affected

          GET : /api/userPermissions/{UserId}
          POST : /api/users
          PUT : /api/users
          rohan.khandave Rohan J Khandave (Inactive) made changes -
          Sprint DMS - Fall Sprint 1 [ 160 ]
          Remaining Estimate 8h [ 28800 ]
          Original Estimate 8h [ 28800 ]
          Permalink
          rohan.khandave Rohan J Khandave (Inactive) logged work - 18/Apr/19 03:04 AM
          • Time Spent:
            1.5h
             

            Analysis & Coding 

          rohan.khandave Rohan J Khandave (Inactive) made changes -
          Remaining Estimate 8h [ 28800 ] 6.5h [ 23400 ]
          Time Spent 1.5h [ 5400 ]
          Worklog Id 173818 [ 173818 ]
          rohan.khandave Rohan J Khandave (Inactive) made changes -
          Status To Do [ 10000 ] In Progress [ 3 ]
          Hide
          Permalink
          rohan.khandave Rohan J Khandave (Inactive) added a comment - - edited

          Previously we had validation for roles like at least one role should be assigned to user.

          We have removed this validation ,now we can add/update user with no assigned roles.

          Also we bypass userdid for update user api [PUT : /api/users]

          Show
          rohan.khandave Rohan J Khandave (Inactive) added a comment - - edited Previously we had validation for roles like at least one role should be assigned to user. We have removed this validation ,now we can add/update user with no assigned roles. Also we bypass userdid for update user api [PUT : /api/users]
          rohan.khandave Rohan J Khandave (Inactive) made changes -
          Remaining Estimate 6.5h [ 23400 ] 4.5h [ 16200 ]
          Time Spent 1.5h [ 5400 ] 3.5h [ 12600 ]
          Worklog Id 173906 [ 173906 ]
          rohan.khandave Rohan J Khandave (Inactive) made changes -
          Status In Progress [ 3 ] Code Review [ 11801 ]
          Raj.Hawaldar Raj Hawaldar (Inactive) made changes -
          Status Code Review [ 11801 ] In QA Testing [ 11901 ]
          Raj.Hawaldar Raj Hawaldar (Inactive) made changes -
          Assignee Rohan J Khandave [ rohan.khandave ] Jayshree Nagpure [ jayshree.nagpure ]
          rohan.khandave Rohan J Khandave (Inactive) made changes -
          Worklog Id 173906 [ 173906 ]
          Permalink
          rohan.khandave Rohan J Khandave (Inactive) logged work - 19/Apr/19 11:43 AM - edited
          • Time Spent:
            2h
             

            Coding & testing.

          Hide
          Permalink
          jayshree.nagpure Jayshree Nagpure (Inactive) added a comment - - edited

          Hi Rohan J Khandave,

          We are getting Invalid user id message for PUT request.

          Can you please check this

          Thanks,
          Jayshree

          Priya Dhamande Sachin Hingole Hrishikesh Deshpande

          Show
          jayshree.nagpure Jayshree Nagpure (Inactive) added a comment - - edited Hi Rohan J Khandave , We are getting Invalid user id message for PUT request. Can you please check this Thanks, Jayshree Priya Dhamande Sachin Hingole Hrishikesh Deshpande
          jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
          Status In QA Testing [ 11901 ] In Progress [ 3 ]
          jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
          Assignee Jayshree Nagpure [ jayshree.nagpure ] Rohan J Khandave [ rohan.khandave ]
          samir Samir made changes -
          Fix Version/s CBAT Offer Letter - Fall [ 10607 ]
          Fix Version/s Integration with CBAT [ 10445 ]
          Permalink
          jayshree.nagpure Jayshree Nagpure (Inactive) logged work - 22/Apr/19 04:44 AM
          • Time Spent:
            2h
             

            testing

          jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
          Remaining Estimate 4.5h [ 16200 ] 2.5h [ 9000 ]
          Time Spent 3.5h [ 12600 ] 5.5h [ 19800 ]
          Worklog Id 174162 [ 174162 ]
          Permalink
          rohan.khandave Rohan J Khandave (Inactive) logged work - 22/Apr/19 07:03 AM
          • Time Spent:
            3h
             

            Coding & Testing

          rohan.khandave Rohan J Khandave (Inactive) made changes -
          Remaining Estimate 2.5h [ 9000 ] 0h [ 0 ]
          Time Spent 5.5h [ 19800 ] 8.5h [ 30600 ]
          Worklog Id 174215 [ 174215 ]
          rohan.khandave Rohan J Khandave (Inactive) made changes -
          Status In Progress [ 3 ] Code Review [ 11801 ]
          rohan.khandave Rohan J Khandave (Inactive) made changes -
          Status Code Review [ 11801 ] Code Review [ 11801 ]
          rohan.khandave Rohan J Khandave (Inactive) made changes -
          Status Code Review [ 11801 ] In QA Testing [ 11901 ]
          Hide
          Permalink
          rohan.khandave Rohan J Khandave (Inactive) added a comment -

          Hello Jayshree Nagpure,

          Fix is deployed under DMS-1204.

          Thanks,
          RohanK

          Show
          rohan.khandave Rohan J Khandave (Inactive) added a comment - Hello Jayshree Nagpure , Fix is deployed under DMS-1204 . Thanks, RohanK
          rohan.khandave Rohan J Khandave (Inactive) made changes -
          Assignee Rohan J Khandave [ rohan.khandave ] Jayshree Nagpure [ jayshree.nagpure ]
          Permalink
          rohan.khandave Rohan J Khandave (Inactive) logged work - 24/Apr/19 07:36 AM
          • Time Spent:
            1h
             

            Coding

          rohan.khandave Rohan J Khandave (Inactive) made changes -
          Time Spent 8.5h [ 30600 ] 9.5h [ 34200 ]
          Worklog Id 174677 [ 174677 ]
          jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
          Attachment DMS-1227.jpg [ 105823 ]
          Hide
          Permalink
          jayshree.nagpure Jayshree Nagpure (Inactive) added a comment -

          Hi Rohan J Khandave,

          We have verified PUT request on Preproduction :

          corporate/dms/api/users
          ACC did - A7F0PT78MTMZ470WBBT
          User did - CHECK

          Payload :
          {
          "sourceProductList": [
          "string"
          ],
          "id": 0,
          "firstName": "Vinanti",
          "lastName": "Yadav",
          "userDid": "CHECK",
          "sourceUserId": "789789",
          "emailaddress": "TestHspl@harbingergroup.com",
          "userroles": [
          {
          "id": 0,
          "name": "ADMIN",
          "isroleassigned": true,
          "featuretype": "string",
          "featuredetailslist": [
          {
          "id": 0,
          "featureid": 0,
          "featurename": "string",
          "featurenamedescription": "string",
          "roleid": 0,
          "menupermission":

          { "norights": false, "readonly": true, "create": true, "update": true, "delete": true, "readpiidata": true }

          }
          ]
          }
          ],
          "usertype": 34
          }

          Getting USER not found message.
          Can you please look into this

          Thanks,
          Jayshree

          Priya Dhamande Sachin Hingole Hrishikesh Deshpande Satya

          Show
          jayshree.nagpure Jayshree Nagpure (Inactive) added a comment - Hi Rohan J Khandave , We have verified PUT request on Preproduction : corporate/dms/api/users ACC did - A7F0PT78MTMZ470WBBT User did - CHECK Payload : { "sourceProductList": [ "string" ], "id": 0, "firstName": "Vinanti", "lastName": "Yadav", "userDid": "CHECK", "sourceUserId": "789789", "emailaddress": "TestHspl@harbingergroup.com", "userroles": [ { "id": 0, "name": "ADMIN", "isroleassigned": true, "featuretype": "string", "featuredetailslist": [ { "id": 0, "featureid": 0, "featurename": "string", "featurenamedescription": "string", "roleid": 0, "menupermission": { "norights": false, "readonly": true, "create": true, "update": true, "delete": true, "readpiidata": true } } ] } ], "usertype": 34 } Getting USER not found message. Can you please look into this Thanks, Jayshree Priya Dhamande Sachin Hingole Hrishikesh Deshpande Satya
          jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
          Status In QA Testing [ 11901 ] In Progress [ 3 ]
          jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
          Assignee Jayshree Nagpure [ jayshree.nagpure ] Rohan J Khandave [ rohan.khandave ]
          Permalink
          jayshree.nagpure Jayshree Nagpure (Inactive) logged work - 25/Apr/19 07:36 AM
          • Time Spent:
            1h
             

            testing

          jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
          Time Spent 9.5h [ 34200 ] 10.5h [ 37800 ]
          Worklog Id 174913 [ 174913 ]
          Permalink
          rohan.khandave Rohan J Khandave (Inactive) logged work - 26/Apr/19 12:05 AM
          • Time Spent:
            2h
             

            Coding & Testing.

          Hide
          Permalink
          rohan.khandave Rohan J Khandave (Inactive) added a comment -

          Issue is resolved.

          We can update user using userid.

          Also sync API end point names to api/user for all user API's.

          Show
          rohan.khandave Rohan J Khandave (Inactive) added a comment - Issue is resolved. We can update user using userid. Also sync API end point names to api/user for all user API's.
          rohan.khandave Rohan J Khandave (Inactive) made changes -
          Status In Progress [ 3 ] Code Review [ 11801 ]
          rohan.khandave Rohan J Khandave (Inactive) made changes -
          Assignee Rohan J Khandave [ rohan.khandave ] Swapnil Pandhare [ swapnil.pandhare ]
          rohan.khandave Rohan J Khandave (Inactive) made changes -
          Time Spent 10.5h [ 37800 ] 12.5h [ 45000 ]
          Worklog Id 175065 [ 175065 ]
          Permalink
          swapnil.pandhare Swapnil Pandhare (Inactive) logged work - 26/Apr/19 05:46 AM
          • Time Spent:
            0.5h
             

            Code review and discussion

          swapnil.pandhare Swapnil Pandhare (Inactive) made changes -
          Time Spent 12.5h [ 45000 ] 13h [ 46800 ]
          Worklog Id 175121 [ 175121 ]
          Raj.Hawaldar Raj Hawaldar (Inactive) made changes -
          Status Code Review [ 11801 ] In QA Testing [ 11901 ]
          Raj.Hawaldar Raj Hawaldar (Inactive) made changes -
          Assignee Swapnil Pandhare [ swapnil.pandhare ] Priya Dhamande [ priya.dhamande ]
          shashikant.mishra ShashiKant Mishra (Inactive) made changes -
          Sprint DMS - Fall Sprint 1 [ 160 ] DMS - Fall Sprint 1, DMS - Fall Sprint 2 [ 160, 161 ]
          samir Samir made changes -
          Remaining Estimate 0h [ 0 ] 8h [ 28800 ]
          Hide
          Permalink
          jayshree.nagpure Jayshree Nagpure (Inactive) added a comment -

          Hi Rohan J Khandave,

          Verified PUT request on preproduction for User API.
          In response only ID is generated.
          Can you please show User id in proper format to make them sync with all API formating.

          Thanks,
          Jayshree

          Priya Dhamande Sachin Hingole Hrishikesh Deshpande

          Show
          jayshree.nagpure Jayshree Nagpure (Inactive) added a comment - Hi Rohan J Khandave , Verified PUT request on preproduction for User API. In response only ID is generated. Can you please show User id in proper format to make them sync with all API formating. Thanks, Jayshree Priya Dhamande Sachin Hingole Hrishikesh Deshpande
          jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
          Attachment DMS-1227.jpg [ 106079 ]
          jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
          Status In QA Testing [ 11901 ] In Progress [ 3 ]
          jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
          Assignee Priya Dhamande [ priya.dhamande ] Rohan J Khandave [ rohan.khandave ]
          Permalink
          jayshree.nagpure Jayshree Nagpure (Inactive) logged work - 29/Apr/19 05:48 AM
          • Time Spent:
            1h
             

            Re-testing

          jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
          Remaining Estimate 8h [ 28800 ] 7h [ 25200 ]
          Time Spent 13h [ 46800 ] 14h [ 50400 ]
          Worklog Id 175388 [ 175388 ]
          rohan.khandave Rohan J Khandave (Inactive) made changes -
          Status In Progress [ 3 ] Code Review [ 11801 ]
          Raj.Hawaldar Raj Hawaldar (Inactive) made changes -
          Status Code Review [ 11801 ] In QA Testing [ 11901 ]
          Raj.Hawaldar Raj Hawaldar (Inactive) made changes -
          Assignee Rohan J Khandave [ rohan.khandave ] Priya Dhamande [ priya.dhamande ]
          jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
          Assignee Priya Dhamande [ priya.dhamande ] Jayshree Nagpure [ jayshree.nagpure ]
          Hide
          Permalink
          jayshree.nagpure Jayshree Nagpure (Inactive) added a comment -

          Verified on Preproduction.
          Now in Put request, User ID is shown in proper format.

          Closing this ticket

          Thanks,
          Jayshree

          Priya Dhamande Sachin Hingole Hrishikesh Deshpande Satya

          Show
          jayshree.nagpure Jayshree Nagpure (Inactive) added a comment - Verified on Preproduction. Now in Put request, User ID is shown in proper format. Closing this ticket Thanks, Jayshree Priya Dhamande Sachin Hingole Hrishikesh Deshpande Satya
          jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
          Resolution Done [ 10000 ]
          Status In QA Testing [ 11901 ] Done [ 10001 ]
          jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
          Assignee Jayshree Nagpure [ jayshree.nagpure ] Rohan J Khandave [ rohan.khandave ]
          Permalink
          jayshree.nagpure Jayshree Nagpure (Inactive) logged work - 02/May/19 04:23 AM
          • Time Spent:
            1h
             

            retesting

          jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
          Remaining Estimate 7h [ 25200 ] 6h [ 21600 ]
          Time Spent 14h [ 50400 ] 15h [ 54000 ]
          Worklog Id 175931 [ 175931 ]
          Transition Time In Source Status Execution Times
          Rohan J Khandave (Inactive) made transition -
          To Do In Progress
          		21h 31m 1
          Rohan J Khandave (Inactive) made transition -
          Code Review Code Review
          		3h 40m 1
          Jayshree Nagpure (Inactive) made transition -
          In QA Testing In Progress
          		3d 17h 32m 3
          Rohan J Khandave (Inactive) made transition -
          In Progress Code Review
          		4d 52m 4
          Raj Hawaldar (Inactive) made transition -
          Code Review In QA Testing
          		3d 6h 18m 4
          Jayshree Nagpure (Inactive) made transition -
          In QA Testing Done
          		2d 1h 17m 1

            People

            Assignee:
            rohan.khandave Rohan J Khandave (Inactive)
            Reporter:
            rohan.khandave Rohan J Khandave (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 8h Original Estimate - 8h
                8h
                Remaining:
                Time Spent - 15h Remaining Estimate - 6h
                6h
                Logged:
                Time Spent - 15h Remaining Estimate - 6h
                15h