-
Type:
Sub-task
-
Status: Done
-
Priority:
Medium
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: Carry Over - Fall
-
Labels:None
-
Company:All Clients/Multiple Clients
Needs to add a filter to get only signed document detail in completed forms library API.
| Fix Version/s | Carry Over - Fall [ 10608 ] |
| Status | To Do [ 10000 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | To Do [ 10000 ] |
| Assignee | Ganesh Sadawarte [ ganesh.sadawarte ] | Ramya Tantry [ ramya.tantry ] |
Hi Ramya Tantry
It should consider companyID and logged in UserID.
Exclude deleted templates from this count
Regards,
Samir
Ramya Tantry (Inactive)
made changes -
| Status | To Do [ 10000 ] | In Progress [ 3 ] |
Ramya Tantry (Inactive)
made changes -
| Remaining Estimate | 0h [ 0 ] | |
| Time Spent | 3h [ 10800 ] | |
| Worklog Id | 174865 [ 174865 ] |
Ramya Tantry (Inactive)
made changes -
| Attachment | Document_Signed.JPG [ 105947 ] |
Here, 19 is the total count of active and archived documents that are created on all companies of the logged in user and its latest status is completed.
79 is the total active and archived document sent out by the logged in user
Ramya Tantry (Inactive)
added a comment -
Here, 19 is the total count of active and archived documents that are created on all companies of the logged in user and its latest status is completed.
79 is the total active and archived document sent out by the logged in user The url that will be configured for Document Signed tile : /completedFormsLibrary?completed=true
The value of 'completed' will be assigned to a variable (e.g filterCompleted) on completed forms library page from route params. Default value of filterCompleted is false.
If undefined, it will be set to false.
This will be set to param variable in completed forms library like
this.param = this.actionName + '/' + this.pageNumber + '/' + this.pageSize + '/' + this.filterCompleted;
API will see the value of filterCompleted variable. if true, will filter the results as per completed status else will show all results for that logged in user.
Ramya Tantry (Inactive)
added a comment - Hi Narendra Kumar
The url that will be configured for Document Signed tile : /completedFormsLibrary?completed=true
The value of 'completed' will be assigned to a variable (e.g filterCompleted) on completed forms library page from route params. Default value of filterCompleted is false.
If undefined, it will be set to false.
This will be set to param variable in completed forms library like
this.param = this.actionName + '/' + this.pageNumber + '/' + this.pageSize + '/' + this.filterCompleted;
API will see the value of filterCompleted variable. if true, will filter the results as per completed status else will show all results for that logged in user. Ramya Tantry (Inactive)
made changes -
| Status | In Progress [ 3 ] | Code Review [ 11801 ] |
Earlier implementation: All the active and archived document belonging to logged in user's companyid are shown. No condition of user ID was present.
New Implementation: All the active and archived document created by the logged in user including global document sent are shown.
On admin login, completed forms library will show document records that are sent out by logged in user. If navigated to completed forms library from dashboard, then the results will be filtered to show only those records whose status is completed.
Ramya Tantry (Inactive)
added a comment - Earlier implementation: All the active and archived document belonging to logged in user's companyid are shown. No condition of user ID was present.
New Implementation : All the active and archived document created by the logged in user including global document sent are shown.
On admin login, completed forms library will show document records that are sent out by logged in user. If navigated to completed forms library from dashboard, then the results will be filtered to show only those records whose status is completed.
Ramya Tantry (Inactive)
logged work - 26/Apr/19 05:44 AM -
- Time Spent:
- 3h
-
Code changes
Discussion
Testing
Ramya Tantry (Inactive)
made changes -
| Time Spent | 3h [ 10800 ] | 6h [ 21600 ] |
| Worklog Id | 175120 [ 175120 ] |
Ramya Tantry (Inactive)
made changes -
| Assignee | Ramya Tantry [ ramya.tantry ] | Swapnil Pandhare [ swapnil.pandhare ] |
Raj Hawaldar (Inactive)
made changes -
| Status | Code Review [ 11801 ] | In QA Testing [ 11901 ] |
Raj Hawaldar (Inactive)
made changes -
| Assignee | Swapnil Pandhare [ swapnil.pandhare ] | Priya Dhamande [ priya.dhamande ] |
| Original Estimate | 8h [ 28800 ] |
Hi Ramya Tantry,
Verified on Preproduction.
Verified below scenario :
- All the active and archived document created by the logged in user including global document sent are shown - Pass
- On admin login, completed forms library will show document records that are sent out by logged in user. If navigated to completed forms library from dashboard, then the results will be filtered to show only those records whose status is completed - Pass
- Document signed count is updated in dashboard - Pass
Working fine.
Closing this ticket
Thanks,
Jayshree
Jayshree Nagpure (Inactive)
added a comment - Hi Ramya Tantry ,
Verified on Preproduction.
Verified below scenario :
All the active and archived document created by the logged in user including global document sent are shown - Pass
On admin login, completed forms library will show document records that are sent out by logged in user. If navigated to completed forms library from dashboard, then the results will be filtered to show only those records whose status is completed - Pass
Document signed count is updated in dashboard - Pass
Working fine.
Closing this ticket
Thanks,
Jayshree
Priya Dhamande Sachin Hingole Hrishikesh Deshpande Satya
Jayshree Nagpure (Inactive)
made changes -
| Time Spent | 6h [ 21600 ] | 7.5h [ 27000 ] |
| Worklog Id | 175383 [ 175383 ] |
Jayshree Nagpure (Inactive)
made changes -
| Resolution | Done [ 10000 ] | |
| Status | In QA Testing [ 11901 ] | Done [ 10001 ] |
Jayshree Nagpure (Inactive)
made changes -
| Assignee | Priya Dhamande [ priya.dhamande ] | Ramya Tantry [ ramya.tantry ] |
| Transition | Time In Source Status | Execution Times |
|---|
|
2s | 1 |
Ramya Tantry (Inactive)
made transition
-
|
1d 6h 42m | 2 |
Ramya Tantry (Inactive)
made transition
-
|
22h 27m | 1 |
Raj Hawaldar (Inactive)
made transition
-
|
2d 20h 15m | 1 |
Jayshree Nagpure (Inactive)
made transition
-
|
5h 8m | 1 |
Hi Samir,
On Document Signed tile, there are two numbers which indicate documents signed by candidates and total documents sent by the admin. As of now, the document count shown is related to the user logged in irrespective of companyid.
Query here is, should the count consider companyID, isarchived and isdeleted. Since this is a dashboard tile and on click of it , it will be navigated to completed forms library. Existing API of completed forms library uses companyID, isarchived and isdeleted conditions.
Please let me know your views.