Environment: Production
Login: Admin and Candidate
Browser: FF and Chrome
Page: Review and Sign
File Type: text

Image in Text File Type

• Can be seen on Preview of Admin
• Review and Sign of Candidate
• Able to Submit text Image document
• Able to Decline text Image document

Refer screen capture. So, marking jira done.

Sachin Hingole Hrishikesh Deshpande Samir Rohan J Khandave

Refer screen capture. So, marking jira done.

Hi All,

This branch will be merged after DMS-1342 changes.it was pending for test case structure changes done inside 1342 branch.

performing a test to make it ready to merge into develop.

Thanks,

Akash Thakur

Samir Narendra Kumar Harshveer Singh Rohan J Khandave Ganesh Sadawarte

Hi Samir,

I have completed all the changes suggested by Rohan J Khandave & Harshveer Singh the code is refactored multiple time in order to be optimized. I have written a test case for the changes but it requires session data so once Ganesh Sadawarte commits his structure changes we will update the test case for this bug.

Rohan J Khandave (Harshveer Singh has reviewed all the changes he suggested). please request you to review the template date related changes & test case wrote.

Thanks,
Akash Thakur
Ganesh Sadawarte

Please review comments from code review.

Hi Rohan J Khandave ,

Please have a review of the changes suggested.

PR:- https://github.com/cbdr/DMS/pull/620

Thanks,

Akash Thakur

Rohan J Khandave

Hi All,

Please Find below 3'Cs for this Jira

Concern:-  In Email we are not getting the images added in document template with file type TEXT.

Cause:-  For Template type TEXT we are using CKEditor for HTML body Creation. & it uses Base64 encoding by default to embed images inserted in the body which is almost blocked on email servers for security purpose thus images are not displayed in the received email.

Correction:- We are converting Base64 encoded string used as a source in image tags from the HTML body of template to the actual image and writing them on fileserver once this is done we move these images from file server to web server and replace the respective image source with the total absolute path of the image  copied to web server folder.

Rohan J Khandave please request you to review the code.

PFA:- Affected Files & image_3g.png for reference.

Thanks,

Akash Thakur

Swapnil Pandhare Rohan J Khandave Samir

In Review and Sign page the images are getting populated, but in email we are not getting the images added in Text document.