Uploaded image for project: 'Document Management System'
  1. Document Management System
  2. DMS-1415

DMS Integration API : Preview API changes to return file & data

    Details

    • Type: New Feature
    • Status: Done
    • Priority: Medium
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: CBAT Offer Letter - Fall
    • Labels:
      None

      Description

      DMS Integration API : Preview API changes to return file & data

      CC-Samir,Rohan J Khandave,Swapnil Pandhare,Mohd Belal

        Attachments

          Issue Links

            Activity

            Ganesh.sadawarte Ganesh Sadawarte (Inactive) created issue -
            swapnil.pandhare Swapnil Pandhare (Inactive) made changes -
            Field Original Value New Value
            Link This issue relates to DMS-1127 [ DMS-1127 ]
            ramya.tantry Ramya Tantry (Inactive) made changes -
            Status To Do [ 10000 ] In Progress [ 3 ]
            samir Samir made changes -
            Remaining Estimate 24h [ 86400 ]
            Original Estimate 24h [ 86400 ]
            ramya.tantry Ramya Tantry (Inactive) made changes -
            Remaining Estimate 24h [ 86400 ] 16h [ 57600 ]
            Original Estimate 24h [ 86400 ] 16h [ 57600 ]
            ramya.tantry Ramya Tantry (Inactive) logged work - 13/May/19 05:28 AM
            • Time Spent:
              5h
               

              Discussion with Ganesh and Rohan

              Code changes

               

            ramya.tantry Ramya Tantry (Inactive) made changes -
            Remaining Estimate 16h [ 57600 ] 11h [ 39600 ]
            Time Spent 5h [ 18000 ]
            Worklog Id 177704 [ 177704 ]
            Hide
            ramya.tantry Ramya Tantry (Inactive) added a comment - - edited

            API Details :

            API : [GET]- /api/User/ValidatePreviewToken/{token}

            Response :

            In case of HTML, we will be returning form details and for PDF, form details will be null as form details is required only in the case of HTML

            HTML response :

            {
            "docType": 1,
            "companyid": "1",
            "fileName": "HTMLLatestVersion_1557483471049.html",
            "formDetails": [

            { "Key": "first_name", "Value": "Sue", "AccessRightsID": 31 }

            ,

            { "Key": "last_name", "Value": "Vincent", "AccessRightsID": 31 }

            ,

            { "Key": "email", "Value": "ramya.tantry@careerbuilder.com", "AccessRightsID": 31 }

            ],
            "fileExtension": ".html"
            }

            PDF response : 

            { "docType": 3, "companyid": "1", "fileName": "0435996587348727.pdf", "formDetails": null, "fileExtension": ".pdf" }

            NOTE : Multiple document form details not yet considered.

             

             

            Show
            ramya.tantry Ramya Tantry (Inactive) added a comment - - edited API Details : API : [GET] - /api/User/ValidatePreviewToken/{token} Response : In case of HTML, we will be returning form details and for PDF, form details will be null as form details is required only in the case of HTML HTML response : { "docType": 1, "companyid": "1", "fileName": "HTMLLatestVersion_1557483471049.html", "formDetails": [ { "Key": "first_name", "Value": "Sue", "AccessRightsID": 31 } , { "Key": "last_name", "Value": "Vincent", "AccessRightsID": 31 } , { "Key": "email", "Value": "ramya.tantry@careerbuilder.com", "AccessRightsID": 31 } ], "fileExtension": ".html" } PDF response :   { "docType": 3, "companyid": "1", "fileName": "0435996587348727.pdf", "formDetails": null, "fileExtension": ".pdf" } NOTE : Multiple document form details not yet considered.    
            ramya.tantry Ramya Tantry (Inactive) logged work - 14/May/19 05:28 AM
            • Time Spent:
              7.5h
               

              Code changes

              Discussion with Rohan and Ganesh

              Unit testing

            ramya.tantry Ramya Tantry (Inactive) made changes -
            Status In Progress [ 3 ] Code Review [ 11801 ]
            ramya.tantry Ramya Tantry (Inactive) made changes -
            Remaining Estimate 11h [ 39600 ] 3.5h [ 12600 ]
            Time Spent 5h [ 18000 ] 12.5h [ 45000 ]
            Worklog Id 177928 [ 177928 ]
            ramya.tantry Ramya Tantry (Inactive) made changes -
            Assignee Ramya Tantry [ ramya.tantry ] Harshveer Singh [ harshveer.singh ]
            ramya.tantry Ramya Tantry (Inactive) logged work - 15/May/19 05:40 AM
            • Time Spent:
              2h
               

              Code changes

              discussion with Rohan

              Code review changes

            ramya.tantry Ramya Tantry (Inactive) made changes -
            Remaining Estimate 3.5h [ 12600 ] 1.5h [ 5400 ]
            Time Spent 12.5h [ 45000 ] 14.5h [ 52200 ]
            Worklog Id 178214 [ 178214 ]
            Raj.Hawaldar Raj Hawaldar (Inactive) made changes -
            Status Code Review [ 11801 ] In QA Testing [ 11901 ]
            Raj.Hawaldar Raj Hawaldar (Inactive) made changes -
            Assignee Harshveer Singh [ harshveer.singh ] Priya Dhamande [ priya.dhamande ]
            mohd.belal Mohd Belal (Inactive) logged work - 16/May/19 01:16 AM
            • Time Spent:
              1h
               

              Checking the API implemented

            Hide
            mohd.belal Mohd Belal (Inactive) added a comment -

            Hi Rohan J Khandave,

            As discussed earlier this with Ganesh Sadawarte we need to get the filetype i.e HTML / PDF beforehand calling the API

            API : [GET]- /api/User/ValidatePreviewToken/{token}

            As when downloading the file we use format as ArrayBuffer in case of PDF and String in case of HTML in Preview and Review and Sign page. Same needs to be implemented here as well.

             

            Can we have the option to pass the file type in Query Params along with Token and Key ?

             

            cc - Samir, Swapnil Pandhare

            Thanks

             

            Show
            mohd.belal Mohd Belal (Inactive) added a comment - Hi Rohan J Khandave , As discussed earlier this with Ganesh Sadawarte we need to get the filetype i.e HTML / PDF beforehand calling the API API : [GET] - /api/User/ValidatePreviewToken/{token} As when downloading the file we use format as ArrayBuffer in case of PDF and String in case of HTML in Preview and Review and Sign page . Same needs to be implemented here as well.   Can we have the option to pass the file type in Query Params along with Token and Key ?   cc - Samir , Swapnil Pandhare Thanks  
            mohd.belal Mohd Belal (Inactive) made changes -
            Remaining Estimate 1.5h [ 5400 ] 0.5h [ 1800 ]
            Time Spent 14.5h [ 52200 ] 15.5h [ 55800 ]
            Worklog Id 178453 [ 178453 ]
            priya.dhamande Priya Dhamande (Inactive) logged work - 16/May/19 01:31 AM
            • Time Spent:
              0.25h
               

              discussion

            Hide
            priya.dhamande Priya Dhamande (Inactive) added a comment -

            Environment: Preprod

            The patch is not yet implemented on UI end. So, unable to verify the same.
            So, assigning to Swapnil Pandhare.

            Rohan J Khandave

            Show
            priya.dhamande Priya Dhamande (Inactive) added a comment - Environment: Preprod The patch is not yet implemented on UI end. So, unable to verify the same. So, assigning to Swapnil Pandhare . Rohan J Khandave
            priya.dhamande Priya Dhamande (Inactive) made changes -
            Remaining Estimate 0.5h [ 1800 ] 0.25h [ 900 ]
            Time Spent 15.5h [ 55800 ] 15.75h [ 56700 ]
            Worklog Id 178455 [ 178455 ]
            priya.dhamande Priya Dhamande (Inactive) made changes -
            Status In QA Testing [ 11901 ] In Progress [ 3 ]
            priya.dhamande Priya Dhamande (Inactive) made changes -
            Assignee Priya Dhamande [ priya.dhamande ] Swapnil Pandhare [ swapnil.pandhare ]
            Hide
            rohan.khandave Rohan J Khandave (Inactive) added a comment -

            Hello Mohd Belal,

            As per our discussion i call. You will get all details for forms. With that you can call download file api.

            Also please check feasibility for approach we discussed for preview of multiple HTML files.

            Thanks,
            RohanK

            CC – Samir , Swapnil Pandhare ,Ganesh Sadawarte

            Show
            rohan.khandave Rohan J Khandave (Inactive) added a comment - Hello Mohd Belal , As per our discussion i call. You will get all details for forms. With that you can call download file api. Also please check feasibility for approach we discussed for preview of multiple HTML files. Thanks, RohanK CC – Samir , Swapnil Pandhare , Ganesh Sadawarte
            Hide
            mohd.belal Mohd Belal (Inactive) added a comment -

            Hi Rohan J Khandave,

            Yes I will implement the API changes mentioned. 

            Also please check feasibility for approach we discussed for preview of multiple HTML files ->  DMS-1440 is created and I will update the Analysis to it.

             

            cc- Samir, Swapnil Pandhare

            Thanks

            Show
            mohd.belal Mohd Belal (Inactive) added a comment - Hi Rohan J Khandave , Yes I will implement the API changes mentioned.  Also please check feasibility for approach we discussed for preview of multiple HTML files ->   DMS-1440 is created and I will update the Analysis to it.   cc- Samir , Swapnil Pandhare Thanks
            Hide
            mohd.belal Mohd Belal (Inactive) added a comment -

            HI Rohan J Khandave,

            As discussed please look into the issue of API response for FileExtension

            API: http://40.124.26.81:88/api/User/ValidatePreviewToken

            {"docType":1,"companyid":"1","fileName":"test2_1552564474493.html","formDetails":"","fileExtension":""}

             

            We need fileExtension value from api.

             

            cc - Samir, Swapnil Pandhare

            Thanks

            Show
            mohd.belal Mohd Belal (Inactive) added a comment - HI Rohan J Khandave , As discussed please look into the issue of API response for FileExtension API:  http://40.124.26.81:88/api/User/ValidatePreviewToken {"docType":1,"companyid":"1","fileName":"test2_1552564474493.html","formDetails":"","fileExtension":""}   We need fileExtension value from api.   cc - Samir , Swapnil Pandhare Thanks
            Hide
            mohd.belal Mohd Belal (Inactive) added a comment -

            Hi Rohan J Khandave

            Also check for  formDetails values in case of HTML as well.

             

            cc - Samir, Swapnil Pandhare

            Show
            mohd.belal Mohd Belal (Inactive) added a comment - Hi Rohan J Khandave Also check for  formDetails values in case of HTML as well.   cc - Samir , Swapnil Pandhare
            samir Samir made changes -
            Assignee Swapnil Pandhare [ swapnil.pandhare ] Rohan J Khandave [ rohan.khandave ]
            Hide
            rohan.khandave Rohan J Khandave (Inactive) added a comment -

            Hello Mohd Belal,

            I have provided new document links for PDF ,HTML & Text.

            Previous links are created long time back , before this JIRA's development.

            Please check new provided links.

            Thanks,
            RohanK

            CC – Samir , Swapnil Pandhare , Harshveer Singh

            Show
            rohan.khandave Rohan J Khandave (Inactive) added a comment - Hello Mohd Belal , I have provided new document links for PDF ,HTML & Text. Previous links are created long time back , before this JIRA's development. Please check new provided links. Thanks, RohanK CC – Samir , Swapnil Pandhare , Harshveer Singh
            rohan.khandave Rohan J Khandave (Inactive) made changes -
            Assignee Rohan J Khandave [ rohan.khandave ] Mohd Belal [ mohd.belal ]
            mohd.belal Mohd Belal (Inactive) logged work - 19/May/19 10:35 PM
            • Time Spent:
              4h
               

              DMS-1127 | Added changes for API formData

            mohd.belal Mohd Belal (Inactive) made changes -
            Status In Progress [ 3 ] Code Review [ 11801 ]
            mohd.belal Mohd Belal (Inactive) made changes -
            Remaining Estimate 0.25h [ 900 ] 0h [ 0 ]
            Time Spent 15.75h [ 56700 ] 19.75h [ 71100 ]
            Worklog Id 178808 [ 178808 ]
            mohd.belal Mohd Belal (Inactive) made changes -
            Link This issue relates to DMS-1448 [ DMS-1448 ]
            mohd.belal Mohd Belal (Inactive) made changes -
            Status Code Review [ 11801 ] In QA Testing [ 11901 ]
            shashikant.mishra ShashiKant Mishra (Inactive) made changes -
            Sprint DMS - Fall Sprint 3 [ 162 ] DMS - Fall Sprint 3, DMS - Fall Sprint 4 [ 162, 163 ]
            samir Samir made changes -
            Assignee Mohd Belal [ mohd.belal ] Priya Dhamande [ priya.dhamande ]
            shashikant.mishra ShashiKant Mishra (Inactive) made changes -
            Sprint DMS - Fall Sprint 3, DMS - Fall Sprint 4 [ 162, 163 ] DMS - Fall Sprint 3, DMS - Fall Sprint 4, DMS - Fall Sprint 5 [ 162, 163, 164 ]
            samir Samir made changes -
            Epic Link DMS-480 [ 75973 ]
            shashikant.mishra ShashiKant Mishra (Inactive) made changes -
            Sprint DMS - Fall Sprint 3, DMS - Fall Sprint 4, DMS - Fall Sprint 5 [ 162, 163, 164 ] DMS - Fall Sprint 3, DMS - Fall Sprint 4, DMS - Fall Sprint 5, DMS - Fall Sprint 6 [ 162, 163, 164, 165 ]
            samir Samir made changes -
            Sprint DMS - Fall Sprint 3, DMS - Fall Sprint 4, DMS - Fall Sprint 5, DMS - Fall Sprint 6 [ 162, 163, 164, 165 ] DMS - Fall Sprint 3, DMS - Fall Sprint 4, DMS - Fall Sprint 5, DMS - Fall Sprint 7 [ 162, 163, 164, 166 ]
            shashikant.mishra ShashiKant Mishra (Inactive) made changes -
            Sprint DMS - Fall Sprint 3, DMS - Fall Sprint 4, DMS - Fall Sprint 5, DMS - Fall Sprint 7 [ 162, 163, 164, 166 ] DMS - Fall Sprint 3, DMS - Fall Sprint 4, DMS - Fall Sprint 5, DMS - Fall Sprint 7, DMS - Fall Sprint 8 [ 162, 163, 164, 166, 167 ]
            shashikant.mishra ShashiKant Mishra (Inactive) made changes -
            Sprint DMS - Fall Sprint 3, DMS - Fall Sprint 4, DMS - Fall Sprint 5, DMS - Fall Sprint 7, DMS - Fall Sprint 8 [ 162, 163, 164, 166, 167 ] DMS - Fall Sprint 3, DMS - Fall Sprint 4, DMS - Fall Sprint 5, DMS - Fall Sprint 7, DMS - Fall Sprint 8, DMS - Gap Fall & Win Sprint 1 [ 162, 163, 164, 166, 167, 173 ]
            shashikant.mishra ShashiKant Mishra (Inactive) made changes -
            Sprint DMS - Fall Sprint 3, DMS - Fall Sprint 4, DMS - Fall Sprint 5, DMS - Fall Sprint 7, DMS - Fall Sprint 8, DMS - Gap Fall & Win Sprint 1 [ 162, 163, 164, 166, 167, 173 ] DMS - Fall Sprint 3, DMS - Fall Sprint 4, DMS - Fall Sprint 5, DMS - Fall Sprint 7, DMS - Fall Sprint 8, DMS - Gap Fall & Win Sprint 1, DMS - Gap Fall & Win Sprint 2 [ 162, 163, 164, 166, 167, 173, 174 ]
            priya.dhamande Priya Dhamande (Inactive) made changes -
            Attachment Screenshot (3905).png [ 116786 ]
            Attachment Screenshot (3906).png [ 116787 ]
            priya.dhamande Priya Dhamande (Inactive) logged work - 20/Aug/19 05:32 AM - edited
            • Time Spent:
              1h
               

              Prod testing
              Discussion

            Hide
            priya.dhamande Priya Dhamande (Inactive) added a comment -

            Environment: Prod
            Login: Admin and Candidate
            Browser: FF and Chrome

            Points covered:
            1. Able to see mapped fields
            2. Mapped fields data saved after editing
            3. Map fields data displayed with Admin login

            Refer screen capture. So, marking jira done.
            Samir Rohan J Khandave Sachin Hingole Hrishikesh Deshpande

            Show
            priya.dhamande Priya Dhamande (Inactive) added a comment - Environment: Prod Login: Admin and Candidate Browser: FF and Chrome Points covered: 1. Able to see mapped fields 2. Mapped fields data saved after editing 3. Map fields data displayed with Admin login Refer screen capture. So, marking jira done. Samir Rohan J Khandave Sachin Hingole Hrishikesh Deshpande
            priya.dhamande Priya Dhamande (Inactive) made changes -
            Resolution Done [ 10000 ]
            Status In QA Testing [ 11901 ] Done [ 10001 ]
            priya.dhamande Priya Dhamande (Inactive) made changes -
            Assignee Priya Dhamande [ priya.dhamande ] Ramya Tantry [ ramya.tantry ]
            priya.dhamande Priya Dhamande (Inactive) made changes -
            Time Spent 19.75h [ 71100 ] 20.25h [ 72900 ]
            Worklog Id 195797 [ 195797 ]
            priya.dhamande Priya Dhamande (Inactive) made changes -
            Time Spent 20.25h [ 72900 ] 20.75h [ 74700 ]
            Worklog Id 195797 [ 195797 ]
            Transition Time In Source Status Execution Times
            Ramya Tantry (Inactive) made transition -
            To Do In Progress
            2h 43m 1
            Priya Dhamande (Inactive) made transition -
            In QA Testing In Progress
            4h 13m 1
            Mohd Belal (Inactive) made transition -
            In Progress Code Review
            5d 55m 2
            Mohd Belal (Inactive) made transition -
            Code Review In QA Testing
            8d 20h 14m 2
            Priya Dhamande (Inactive) made transition -
            In QA Testing Done
            85d 2h 40m 1

              People

              Assignee:
              ramya.tantry Ramya Tantry (Inactive)
              Reporter:
              Ganesh.sadawarte Ganesh Sadawarte (Inactive)
              Developer:
              Ramya Tantry (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - 16h Original Estimate - 16h
                  16h
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 20.75h
                  20.75h