Document Management SystemProject Type: software

Document Management System

Uploaded image for project: 'Document Management System'
  1. Document Management System
  2. DMS-1419

Unhanded exception in DocumentData.GetFormDetailsWithValues

    Details

    • Type: Bug
    • Status: Done
    • Priority: Medium
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: Enhancements - Fall
    • Labels:
      None
    • Company:
      All Clients/Multiple Clients

      Description

      There is line of code 'parsedKeyValuePdfDataparam = parsedKeyValuePdfData.ToDictionary(d => d.Key, d => d.Value);' in DocumentData.GetFormDetailsWithValues where possible exception is not handled. Now when parsedKeyValuePdfData has any duplicate column name, this method throws exception. Here if duplicate keys exist, then either that key should be skipped or value be overridden. 

        Attachments

        1. Screenshot (2997).png
          Screenshot (2997).png
          215 kB
        2. Screenshot (2998).png
          Screenshot (2998).png
          146 kB
        3. test2 (2).html
          4 kB

          Activity

          Ascending order - Click to sort in descending order
          Hide
          Permalink
          akash.thakur Akash Thakur (Inactive) added a comment -

          Hi Harshveer Singh,

          I have given a fix for this unhandled exception occurrence point.Please review the code 

          Thanks,

          Akash Thakur

          Ganesh Sadawarte Rohan J Khandave

          Show
          akash.thakur Akash Thakur (Inactive) added a comment - Hi Harshveer Singh , I have given a fix for this unhandled exception occurrence point.Please review the code  Thanks, Akash Thakur Ganesh Sadawarte Rohan J Khandave
          Hide
          Permalink
          priya.dhamande Priya Dhamande (Inactive) added a comment -

          Akash Thakur Harshveer Singh,

          can you please let us know, where to verify teh issue?

          Samir Hrishikesh Deshpande Rohan J Khandave

          Show
          priya.dhamande Priya Dhamande (Inactive) added a comment - Akash Thakur Harshveer Singh , can you please let us know, where to verify teh issue? Samir Hrishikesh Deshpande Rohan J Khandave
          Hide
          Permalink
          akash.thakur Akash Thakur (Inactive) added a comment -

          Hi Priya Dhamande,

          Please test this with HTML template having two fields with same control name in it.

          PFA: attached sample HTML file.

          Thanks,

          Akash Thakur

           

          Ganesh Sadawarte Priya Dhamande Rohan J Khandave Samir

          Show
          akash.thakur Akash Thakur (Inactive) added a comment - Hi Priya Dhamande , Please test this with HTML template having two fields with same control name in it. PFA: attached sample HTML file. Thanks, Akash Thakur   Ganesh Sadawarte Priya Dhamande Rohan J Khandave Samir
          Hide
          Permalink
          priya.dhamande Priya Dhamande (Inactive) added a comment -

          Environment: Production
          Company: CB internal Beta
          File Type: HTML
          Added 2 fields with same name

          Steps:
          1. Admin Login
          2. Send Forms [Template with double FName]
          3. Preview > Name is appearing twice.

          Example:
          FNAme of candidate is ABC

          Preview
          FName: ABC ABC
          Fname: ABC ABC

          Expected:
          FName: ABC
          Fname: ABC

          Refer screen capture.

          So, reopening for the same.

          Rohan J Khandave Samir Hrishikesh Deshpande

          Show
          priya.dhamande Priya Dhamande (Inactive) added a comment - Environment: Production Company: CB internal Beta File Type: HTML Added 2 fields with same name Steps: 1. Admin Login 2. Send Forms [Template with double FName] 3. Preview > Name is appearing twice. Example: FNAme of candidate is ABC Preview FName: ABC ABC Fname: ABC ABC Expected: FName: ABC Fname: ABC Refer screen capture. So, reopening for the same. Rohan J Khandave Samir Hrishikesh Deshpande
          Hide
          Permalink
          Ganesh.sadawarte Ganesh Sadawarte (Inactive) added a comment - - edited

          Hi Priya Dhamande,

          The scenario you verified under this is not correct. The Scenario is.

          Valid Scenario:

          • HTML file does not have two fields with same name.
          • Issue: Its throwing error- Exception 

          Issue Fixed.

          • We handle expectation under this. Priya Dhamande please create separate Jira to handle that file does not have same field name more than one.

          CC-Rohan J Khandave,Samir,Hrishikesh Deshpande

          Thanks,
          Ganesh

           

          Show
          Ganesh.sadawarte Ganesh Sadawarte (Inactive) added a comment - - edited Hi Priya Dhamande , The scenario you verified under this is not correct. The Scenario is. Valid Scenario: HTML file does not have two fields with same name. Issue : Its throwing error- Exception  Issue Fixed. We handle expectation under this. Priya Dhamande please create separate Jira to handle that file does not have same field name more than one. CC- Rohan J Khandave , Samir , Hrishikesh Deshpande Thanks, Ganesh  
          Hide
          Permalink
          priya.dhamande Priya Dhamande (Inactive) added a comment -

          As per above comment, considering this change done. As the expectation thrown is handled.

          Creating new jira for redundant name with ID: DMS-1645.

          Ganesh Sadawarte Akash Thakur Samir Hrishikesh Deshpande Rohan J Khandave

          Show
          priya.dhamande Priya Dhamande (Inactive) added a comment - As per above comment, considering this change done. As the expectation thrown is handled. Creating new jira for redundant name with ID: DMS-1645 . Ganesh Sadawarte Akash Thakur Samir Hrishikesh Deshpande Rohan J Khandave

            People

            Assignee:
            akash.thakur Akash Thakur (Inactive)
            Reporter:
            harshveer.singh Harshveer Singh (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 4h Original Estimate - 4h
                4h
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 5.25h
                5.25h