Uploaded image for project: 'Document Management System'
  1. Document Management System
  2. DMS-1419

Unhanded exception in DocumentData.GetFormDetailsWithValues

    Details

    • Type: Bug
    • Status: Done
    • Priority: Medium
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: Enhancements - Fall
    • Labels:
      None
    • Company:
      All Clients/Multiple Clients

      Description

      There is line of code 'parsedKeyValuePdfDataparam = parsedKeyValuePdfData.ToDictionary(d => d.Key, d => d.Value);' in DocumentData.GetFormDetailsWithValues where possible exception is not handled. Now when parsedKeyValuePdfData has any duplicate column name, this method throws exception. Here if duplicate keys exist, then either that key should be skipped or value be overridden. 

        Attachments

        1. Screenshot (2997).png
          Screenshot (2997).png
          215 kB
        2. Screenshot (2998).png
          Screenshot (2998).png
          146 kB
        3. test2 (2).html
          4 kB

          Activity

          harshveer.singh Harshveer Singh (Inactive) created issue -
          harshveer.singh Harshveer Singh (Inactive) made changes -
          Field Original Value New Value
          Issue Type New Feature [ 2 ] Bug [ 1 ]
          samir Samir made changes -
          Remaining Estimate 4h [ 14400 ]
          Original Estimate 4h [ 14400 ]
          shashikant.mishra ShashiKant Mishra (Inactive) made changes -
          Fix Version/s Enhancements - Fall [ 10610 ]
          samir Samir made changes -
          Assignee Samir [ samir ] Harshveer Singh [ harshveer.singh ]
          shashikant.mishra ShashiKant Mishra (Inactive) made changes -
          Sprint DMS - Fall Sprint 3 [ 162 ] DMS - Fall Sprint 3, DMS - Fall Sprint 4 [ 162, 163 ]
          shashikant.mishra ShashiKant Mishra (Inactive) made changes -
          Sprint DMS - Fall Sprint 3, DMS - Fall Sprint 4 [ 162, 163 ] DMS - Fall Sprint 3, DMS - Fall Sprint 4, DMS - Fall Sprint 5 [ 162, 163, 164 ]
          samir Samir made changes -
          Assignee Harshveer Singh [ harshveer.singh ] Akash Thakur [ akash.thakur ]
          akash.thakur Akash Thakur (Inactive) made changes -
          Status To Do [ 10000 ] In Progress [ 3 ]
          akash.thakur Akash Thakur (Inactive) logged work - 18/Jun/19 01:42 AM
          • Time Spent:
            4h
             
            • Understanding Bug
            • Analysis.
            • Reproduction with Template creation for duplicate values.
            • bug fix approach suitability.
            • discussion with Ganesh
            • code fix & code merges PR creation.
            • Unit testing with a duplicate key.
            • etc efforts.
          akash.thakur Akash Thakur (Inactive) made changes -
          Remaining Estimate 4h [ 14400 ] 0h [ 0 ]
          Time Spent 4h [ 14400 ]
          Worklog Id 183784 [ 183784 ]
          akash.thakur Akash Thakur (Inactive) made changes -
          Assignee Akash Thakur [ akash.thakur ] Harshveer Singh [ harshveer.singh ]
          akash.thakur Akash Thakur (Inactive) made changes -
          Status In Progress [ 3 ] Code Review [ 11801 ]
          Hide
          akash.thakur Akash Thakur (Inactive) added a comment -

          Hi Harshveer Singh,

          I have given a fix for this unhandled exception occurrence point.Please review the code 

          Thanks,

          Akash Thakur

          Ganesh Sadawarte Rohan J Khandave

          Show
          akash.thakur Akash Thakur (Inactive) added a comment - Hi Harshveer Singh , I have given a fix for this unhandled exception occurrence point.Please review the code  Thanks, Akash Thakur Ganesh Sadawarte Rohan J Khandave
          samir Samir made changes -
          Assignee Harshveer Singh [ harshveer.singh ] Samir [ samir ]
          shashikant.mishra ShashiKant Mishra (Inactive) made changes -
          Sprint DMS - Fall Sprint 3, DMS - Fall Sprint 4, DMS - Fall Sprint 5 [ 162, 163, 164 ] DMS - Fall Sprint 3, DMS - Fall Sprint 4, DMS - Fall Sprint 5, DMS - Fall Sprint 6 [ 162, 163, 164, 165 ]
          Raj.Hawaldar Raj Hawaldar (Inactive) made changes -
          Status Code Review [ 11801 ] In QA Testing [ 11901 ]
          shashikant.mishra ShashiKant Mishra (Inactive) made changes -
          Sprint DMS - Fall Sprint 3, DMS - Fall Sprint 4, DMS - Fall Sprint 5, DMS - Fall Sprint 6 [ 162, 163, 164, 165 ] DMS - Fall Sprint 3, DMS - Fall Sprint 4, DMS - Fall Sprint 5, DMS - Fall Sprint 6, DMS - Fall Sprint 7 [ 162, 163, 164, 165, 166 ]
          priya.dhamande Priya Dhamande (Inactive) made changes -
          Assignee Samir [ samir ] Priya Dhamande [ priya.dhamande ]
          Hide
          priya.dhamande Priya Dhamande (Inactive) added a comment -

          Akash Thakur Harshveer Singh,

          can you please let us know, where to verify teh issue?

          Samir Hrishikesh Deshpande Rohan J Khandave

          Show
          priya.dhamande Priya Dhamande (Inactive) added a comment - Akash Thakur Harshveer Singh , can you please let us know, where to verify teh issue? Samir Hrishikesh Deshpande Rohan J Khandave
          priya.dhamande Priya Dhamande (Inactive) made changes -
          Status In QA Testing [ 11901 ] In Progress [ 3 ]
          priya.dhamande Priya Dhamande (Inactive) made changes -
          Assignee Priya Dhamande [ priya.dhamande ] Akash Thakur [ akash.thakur ]
          akash.thakur Akash Thakur (Inactive) made changes -
          Status In Progress [ 3 ] In QA Testing [ 11901 ]
          akash.thakur Akash Thakur (Inactive) made changes -
          Assignee Akash Thakur [ akash.thakur ] Priya Dhamande [ priya.dhamande ]
          Hide
          akash.thakur Akash Thakur (Inactive) added a comment -

          Hi Priya Dhamande,

          Please test this with HTML template having two fields with same control name in it.

          PFA: attached sample HTML file.

          Thanks,

          Akash Thakur

           

          Ganesh Sadawarte Priya Dhamande Rohan J Khandave Samir

          Show
          akash.thakur Akash Thakur (Inactive) added a comment - Hi Priya Dhamande , Please test this with HTML template having two fields with same control name in it. PFA: attached sample HTML file. Thanks, Akash Thakur   Ganesh Sadawarte Priya Dhamande Rohan J Khandave Samir
          akash.thakur Akash Thakur (Inactive) made changes -
          Attachment test2 (2).html [ 112295 ]
          Hide
          priya.dhamande Priya Dhamande (Inactive) added a comment -

          Environment: Production
          Company: CB internal Beta
          File Type: HTML
          Added 2 fields with same name

          Steps:
          1. Admin Login
          2. Send Forms [Template with double FName]
          3. Preview > Name is appearing twice.

          Example:
          FNAme of candidate is ABC

          Preview
          FName: ABC ABC
          Fname: ABC ABC

          Expected:
          FName: ABC
          Fname: ABC

          Refer screen capture.

          So, reopening for the same.

          Rohan J Khandave Samir Hrishikesh Deshpande

          Show
          priya.dhamande Priya Dhamande (Inactive) added a comment - Environment: Production Company: CB internal Beta File Type: HTML Added 2 fields with same name Steps: 1. Admin Login 2. Send Forms [Template with double FName] 3. Preview > Name is appearing twice. Example: FNAme of candidate is ABC Preview FName: ABC ABC Fname: ABC ABC Expected: FName: ABC Fname: ABC Refer screen capture. So, reopening for the same. Rohan J Khandave Samir Hrishikesh Deshpande
          priya.dhamande Priya Dhamande (Inactive) logged work - 15/Jul/19 12:25 AM
          • Time Spent:
            1h
             

            Prod testing
            discussion

          priya.dhamande Priya Dhamande (Inactive) made changes -
          Attachment Screenshot (2997).png [ 112499 ]
          Attachment Screenshot (2998).png [ 112500 ]
          priya.dhamande Priya Dhamande (Inactive) made changes -
          Time Spent 4h [ 14400 ] 5h [ 18000 ]
          Worklog Id 188356 [ 188356 ]
          priya.dhamande Priya Dhamande (Inactive) made changes -
          Status In QA Testing [ 11901 ] To Do [ 10000 ]
          priya.dhamande Priya Dhamande (Inactive) made changes -
          Assignee Priya Dhamande [ priya.dhamande ] Akash Thakur [ akash.thakur ]
          Hide
          Ganesh.sadawarte Ganesh Sadawarte (Inactive) added a comment - - edited

          Hi Priya Dhamande,

          The scenario you verified under this is not correct. The Scenario is.

          Valid Scenario:

          • HTML file does not have two fields with same name.
          • Issue: Its throwing error- Exception 

          Issue Fixed.

          • We handle expectation under this. Priya Dhamande please create separate Jira to handle that file does not have same field name more than one.

          CC-Rohan J Khandave,Samir,Hrishikesh Deshpande

          Thanks,
          Ganesh

           

          Show
          Ganesh.sadawarte Ganesh Sadawarte (Inactive) added a comment - - edited Hi Priya Dhamande , The scenario you verified under this is not correct. The Scenario is. Valid Scenario: HTML file does not have two fields with same name. Issue : Its throwing error- Exception  Issue Fixed. We handle expectation under this. Priya Dhamande please create separate Jira to handle that file does not have same field name more than one. CC- Rohan J Khandave , Samir , Hrishikesh Deshpande Thanks, Ganesh  
          Ganesh.sadawarte Ganesh Sadawarte (Inactive) made changes -
          Status To Do [ 10000 ] In QA Testing [ 11901 ]
          Ganesh.sadawarte Ganesh Sadawarte (Inactive) made changes -
          Assignee Akash Thakur [ akash.thakur ] Priya Dhamande [ priya.dhamande ]
          priya.dhamande Priya Dhamande (Inactive) logged work - 15/Jul/19 01:35 AM
          • Time Spent:
            0.25h
             

            Discussion and updates

          Hide
          priya.dhamande Priya Dhamande (Inactive) added a comment -

          As per above comment, considering this change done. As the expectation thrown is handled.

          Creating new jira for redundant name with ID: DMS-1645.

          Ganesh Sadawarte Akash Thakur Samir Hrishikesh Deshpande Rohan J Khandave

          Show
          priya.dhamande Priya Dhamande (Inactive) added a comment - As per above comment, considering this change done. As the expectation thrown is handled. Creating new jira for redundant name with ID: DMS-1645 . Ganesh Sadawarte Akash Thakur Samir Hrishikesh Deshpande Rohan J Khandave
          priya.dhamande Priya Dhamande (Inactive) made changes -
          Resolution Done [ 10000 ]
          Status In QA Testing [ 11901 ] Done [ 10001 ]
          priya.dhamande Priya Dhamande (Inactive) made changes -
          Assignee Priya Dhamande [ priya.dhamande ] Akash Thakur [ akash.thakur ]
          priya.dhamande Priya Dhamande (Inactive) made changes -
          Time Spent 5h [ 18000 ] 5.25h [ 18900 ]
          Worklog Id 188364 [ 188364 ]
          Transition Time In Source Status Execution Times
          Akash Thakur (Inactive) made transition -
          To Do In Progress
          35d 22h 24m 1
          Akash Thakur (Inactive) made transition -
          In Progress Code Review
          11m 7s 1
          Raj Hawaldar (Inactive) made transition -
          Code Review In QA Testing
          8d 2h 48m 1
          Priya Dhamande (Inactive) made transition -
          In QA Testing In Progress
          15d 56m 1
          Akash Thakur (Inactive) made transition -
          In Progress In QA Testing
          53m 49s 1
          Priya Dhamande (Inactive) made transition -
          In QA Testing To Do
          3d 18h 1m 1
          Ganesh Sadawarte (Inactive) made transition -
          To Do In QA Testing
          50m 32s 1
          Priya Dhamande (Inactive) made transition -
          In QA Testing Done
          19m 34s 1

            People

            Assignee:
            akash.thakur Akash Thakur (Inactive)
            Reporter:
            harshveer.singh Harshveer Singh (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 4h Original Estimate - 4h
                4h
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 5.25h
                5.25h