Uploaded image for project: 'Document Management System'
  1. Document Management System
  2. DMS-1544

CBAT: API Create document API (CBAT Id Changes for Fields)

    Details

    • Type: New Feature
    • Status: Done
    • Priority: High
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: CBAT Offer Letter - Fall
    • Labels:
      None

      Description

      Update Create document API (CBAT Id Changes for Fields)

      API will accept Source Fields Id and Value

      As per mapping in DMS , system will save those details

        Attachments

        1. Screenshot (2897).png
          Screenshot (2897).png
          144 kB
        2. Screenshot (2913).png
          Screenshot (2913).png
          99 kB
        3. Screenshot (2914).png
          Screenshot (2914).png
          151 kB
        4. Testcases -DMS-1544.xls
          13 kB

          Issue Links

            Activity

            samir Samir created issue -
            samir Samir made changes -
            Field Original Value New Value
            Fix Version/s CBAT Offer Letter - Fall [ 10607 ]
            samir Samir made changes -
            Epic Link DMS-473 [ 75966 ]
            samir Samir made changes -
            Sprint DMS - Fall Sprint 6 [ 165 ]
            samir Samir made changes -
            Remaining Estimate 24h [ 86400 ]
            Original Estimate 24h [ 86400 ]
            samir Samir made changes -
            Assignee Samir [ samir ] Akash Thakur [ akash.thakur ]
            akash.thakur Akash Thakur (Inactive) made changes -
            Status To Do [ 10000 ] In Progress [ 3 ]
            akash.thakur Akash Thakur (Inactive) logged work - 24/Jun/19 09:35 PM - edited
            • Time Spent:
              8h
               

              Analysis.

              scenario discussion with Rohan.

              understanding task.

              Planning & execution.

              etc

            akash.thakur Akash Thakur (Inactive) logged work - 25/Jun/19 09:29 PM - edited
            • Time Spent:
              8h
               

              Development.

              code changes.

              debugging.

              etc

            akash.thakur Akash Thakur (Inactive) made changes -
            Remaining Estimate 24h [ 86400 ] 16h [ 57600 ]
            Time Spent 8h [ 28800 ]
            Worklog Id 185197 [ 185197 ]
            akash.thakur Akash Thakur (Inactive) made changes -
            Remaining Estimate 16h [ 57600 ] 8h [ 28800 ]
            Time Spent 8h [ 28800 ] 16h [ 57600 ]
            Worklog Id 185200 [ 185200 ]
            akash.thakur Akash Thakur (Inactive) made changes -
            Status In Progress [ 3 ] On Hold [ 10507 ]
            Hide
            akash.thakur Akash Thakur (Inactive) added a comment -

            keeping this on hold as working on DMS-1342 priority.

            Show
            akash.thakur Akash Thakur (Inactive) added a comment - keeping this on hold as working on DMS-1342 priority.
            akash.thakur Akash Thakur (Inactive) made changes -
            Status On Hold [ 10507 ] In Progress [ 3 ]
            akash.thakur Akash Thakur (Inactive) made changes -
            Worklog Id 185200 [ 185200 ]
            akash.thakur Akash Thakur (Inactive) made changes -
            Worklog Id 185197 [ 185197 ]
            akash.thakur Akash Thakur (Inactive) made changes -
            Status In Progress [ 3 ] On Hold [ 10507 ]
            Hide
            akash.thakur Akash Thakur (Inactive) added a comment -

            keeping this on hold as working on DMS-1342 corrections.

            Show
            akash.thakur Akash Thakur (Inactive) added a comment - keeping this on hold as working on  DMS-1342 corrections.
            akash.thakur Akash Thakur (Inactive) logged work - 01/Jul/19 07:31 AM
            • Time Spent:
              8h
               

              Code changes were done in ETA.

              worked on code suggestions for this Jira completed those suggestions.

              currently writing test cases for these will raise PR once all suggestions are covered and test case are complete.

              was delayed because worked on DMS-1342 on Friday.

            akash.thakur Akash Thakur (Inactive) made changes -
            Status On Hold [ 10507 ] In Progress [ 3 ]
            akash.thakur Akash Thakur (Inactive) made changes -
            Remaining Estimate 8h [ 28800 ] 0h [ 0 ]
            Time Spent 16h [ 57600 ] 24h [ 86400 ]
            Worklog Id 186084 [ 186084 ]
            akash.thakur Akash Thakur (Inactive) made changes -
            Original Estimate 24h [ 86400 ] 32h [ 115200 ]
            Hide
            akash.thakur Akash Thakur (Inactive) added a comment -

            Note:- ETA are updated for code changes suggested.

            Show
            akash.thakur Akash Thakur (Inactive) added a comment - Note:- ETA are updated for code changes suggested.
            akash.thakur Akash Thakur (Inactive) made changes -
            Time Spent 24h [ 86400 ] 30h [ 108000 ]
            Worklog Id 186180 [ 186180 ]
            akash.thakur Akash Thakur (Inactive) made changes -
            Status In Progress [ 3 ] Code Review [ 11801 ]
            akash.thakur Akash Thakur (Inactive) made changes -
            Time Spent 30h [ 108000 ] 32h [ 115200 ]
            Worklog Id 186192 [ 186192 ]
            akash.thakur Akash Thakur (Inactive) made changes -
            Assignee Akash Thakur [ akash.thakur ] Rohan J Khandave [ rohan.khandave ]
            Hide
            akash.thakur Akash Thakur (Inactive) added a comment -

            HI Rohan J Khandave,

            I have written these API, as discussed I have made all changes suggested (code level & Db) & have written integration test case for this API. I have done testing for all scenario's in our list on local both API are working fine please proceed with code review.

            Thanks,

            Akash Thakur

            Samir Ganesh Sadawarte Ramya Tantry

            Show
            akash.thakur Akash Thakur (Inactive) added a comment - HI Rohan J Khandave , I have written these API, as discussed I have made all changes suggested (code level & Db) & have written integration test case for this API. I have done testing for all scenario's in our list on local both API are working fine please proceed with code review. Thanks, Akash Thakur Samir Ganesh Sadawarte Ramya Tantry
            akash.thakur Akash Thakur (Inactive) logged work - 02/Jul/19 11:11 PM
            • Time Spent:
              2h
               
              1. wrote test case for API.
              2. testing API with a test case.
              3. etc 
            akash.thakur Akash Thakur (Inactive) made changes -
            Remaining Estimate 0h [ 0 ] 6h [ 21600 ]
            Time Spent 32h [ 115200 ] 26h [ 93600 ]
            Worklog Id 186180 [ 186180 ]
            Worklog Time Spent 6h [ 21600 ]
            Hide
            rohan.khandave Rohan J Khandave (Inactive) added a comment -

            Hello Akash Thakur,

            Your code changes are merged into DMS-1542 & reviewed.

            Thanks,
            RohanK

            Show
            rohan.khandave Rohan J Khandave (Inactive) added a comment - Hello Akash Thakur , Your code changes are merged into DMS-1542 & reviewed. Thanks, RohanK
            rohan.khandave Rohan J Khandave (Inactive) made changes -
            Assignee Rohan J Khandave [ rohan.khandave ] Akash Thakur [ akash.thakur ]
            Raj.Hawaldar Raj Hawaldar (Inactive) made changes -
            Status Code Review [ 11801 ] In QA Testing [ 11901 ]
            Raj.Hawaldar Raj Hawaldar (Inactive) made changes -
            Assignee Akash Thakur [ akash.thakur ] Samir [ samir ]
            rohan.khandave Rohan J Khandave (Inactive) made changes -
            Link This issue relates to DMS-1542 [ DMS-1542 ]
            shashikant.mishra ShashiKant Mishra (Inactive) made changes -
            Sprint DMS - Fall Sprint 6 [ 165 ] DMS - Fall Sprint 6, DMS - Fall Sprint 7 [ 165, 166 ]
            akash.thakur Akash Thakur (Inactive) logged work - 08/Jul/19 04:02 AM
            • Time Spent:
              1h
               

              Testing API after pre-prod deployment.

              unit testing & affected areas verification.

              testing OLD API & new API.

            Hide
            akash.thakur Akash Thakur (Inactive) added a comment -

            Hi Priya Dhamande,

            Please find details for these API 

            URL:- corporate/dms/api/candidate/custom/document/create

            PAYLOAD SAMPLE:- 

            {
            "email": "priya.dhamande@harbingergroup.com",
            "payload":

            { "17": "7620030080", "29": "Pune", "5": "test1", "179": "Test2" }

            ,
            "requisitionId": "1417",
            "sendDocument": 0,
            "sourceProduct": "CBATS",
            "sourceUserId": "ABSSB",
            "templateIds": [401]
            }

             

            Thanks,

            Akash Thakur

            Rohan J Khandave 

            Show
            akash.thakur Akash Thakur (Inactive) added a comment - Hi Priya Dhamande , Please find details for these API  URL :- corporate/dms/api/candidate/custom/document/create PAYLOAD SAMPLE :-  { "email": "priya.dhamande@harbingergroup.com", "payload": { "17": "7620030080", "29": "Pune", "5": "test1", "179": "Test2" } , "requisitionId": "1417", "sendDocument": 0, "sourceProduct": "CBATS", "sourceUserId": "ABSSB", "templateIds": [401] }   Thanks, Akash Thakur Rohan J Khandave  
            akash.thakur Akash Thakur (Inactive) made changes -
            Remaining Estimate 6h [ 21600 ] 5h [ 18000 ]
            Time Spent 26h [ 93600 ] 27h [ 97200 ]
            Worklog Id 186911 [ 186911 ]
            priya.dhamande Priya Dhamande (Inactive) made changes -
            Assignee Samir [ samir ] Priya Dhamande [ priya.dhamande ]
            Raj.Hawaldar Raj Hawaldar (Inactive) made changes -
            Status In QA Testing [ 11901 ] In QA Testing [ 11901 ]
            akash.thakur Akash Thakur (Inactive) logged work - 09/Jul/19 05:42 AM
            • Time Spent:
              0.4h
               

              corrections.

              code suggestions.

              explaining QA about API.

              testing.

              code merge & PR creation.

            akash.thakur Akash Thakur (Inactive) made changes -
            Remaining Estimate 5h [ 18000 ] 4.6h [ 16560 ]
            Time Spent 27h [ 97200 ] 27.4h [ 98640 ]
            Worklog Id 187226 [ 187226 ]
            priya.dhamande Priya Dhamande (Inactive) made changes -
            Attachment Testcases -DMS-1544.xls [ 112173 ]
            Hide
            priya.dhamande Priya Dhamande (Inactive) added a comment -

            Environment: OneIM - Preprod
            Browser: Chrome
            API: api/candidate/custom/document/create
            File Type: PDF, HTML and Text

            The enhancement is verified for attached test cases for HTML, PDf and text file type.

            The data appeared on link as expected.

            Also verified against the DB. Refer screen capture. So, marking jira done.

            Robert Malony, can you please confirm the same.

            Hrishikesh Deshpande Rohan J Khandave Akash Thakur Samir

            Show
            priya.dhamande Priya Dhamande (Inactive) added a comment - Environment: OneIM - Preprod Browser: Chrome API: api/candidate/custom/document/create File Type: PDF, HTML and Text The enhancement is verified for attached test cases for HTML, PDf and text file type. The data appeared on link as expected. Also verified against the DB. Refer screen capture. So, marking jira done. Robert Malony , can you please confirm the same. Hrishikesh Deshpande Rohan J Khandave Akash Thakur Samir
            priya.dhamande Priya Dhamande (Inactive) made changes -
            Attachment Screenshot (2914).png [ 112174 ]
            Attachment Screenshot (2913).png [ 112175 ]
            priya.dhamande Priya Dhamande (Inactive) logged work - 10/Jul/19 04:11 AM
            • Time Spent:
              2h
               

              Test cases
              discussion
              OneIm testing

            priya.dhamande Priya Dhamande (Inactive) made changes -
            Attachment Screenshot (2897).png [ 112176 ]
            priya.dhamande Priya Dhamande (Inactive) made changes -
            Resolution Done [ 10000 ]
            Status In QA Testing [ 11901 ] Done [ 10001 ]
            priya.dhamande Priya Dhamande (Inactive) made changes -
            Assignee Priya Dhamande [ priya.dhamande ] Robert Malony [ robert.malony ]
            priya.dhamande Priya Dhamande (Inactive) made changes -
            Remaining Estimate 4.6h [ 16560 ] 2.6h [ 9360 ]
            Time Spent 27.4h [ 98640 ] 29.4h [ 105840 ]
            Worklog Id 187450 [ 187450 ]
            Transition Time In Source Status Execution Times
            Akash Thakur (Inactive) made transition -
            To Do In Progress
            2d 21h 23m 1
            Akash Thakur (Inactive) made transition -
            In Progress On Hold
            3d 17h 44m 2
            Akash Thakur (Inactive) made transition -
            On Hold In Progress
            3d 13h 59m 2
            Akash Thakur (Inactive) made transition -
            In Progress Code Review
            15h 40m 1
            Raj Hawaldar (Inactive) made transition -
            Code Review In QA Testing
            6d 1h 4m 1
            Raj Hawaldar (Inactive) made transition -
            In QA Testing In QA Testing
            1d 2h 41m 1
            Priya Dhamande (Inactive) made transition -
            In QA Testing Done
            1d 1h 14m 1

              People

              Assignee:
              Robert.Malony Robert Malony (Inactive)
              Reporter:
              samir Samir
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - 32h
                  32h
                  Remaining:
                  Time Spent - 29.4h Remaining Estimate - 2.6h
                  2.6h
                  Logged:
                  Time Spent - 29.4h Remaining Estimate - 2.6h
                  29.4h