[DMS-1620] DMS | Preprod | Candidate Login | Navigation issue for review and Sign - Workterra Jira

Details

Type: Bug
Status: Done
Priority: Medium
Resolution: Done
Affects Version/s: None
Fix Version/s: Enhancements - Fall
Labels:
None

Company:
All Clients/Multiple Clients

Sprint:
DMS - Fall Sprint 7, DMS - Fall Sprint 8, DMS - Gap Fall & Win Sprint 1, DMS - Gap Fall & Win Sprint 2, DMS - Gap Fall & Win Sprint 3, DMS - Gap Fall & Win Sprint 4

Description

1.Candidate to receive Review and Sign email
2.Click on review and sign
3.sign the document
4.submit
5.Candidate should redirect to review and sign page

Actual : Its staying on document itself.
Same issue exists for Decline functionality also

Priya Dhamande

Attachments

Activity

Ascending order - Click to sort in descending order

Jayshree Nagpure (Inactive) created issue - 09/Jul/19 04:22 AM

Jayshree Nagpure (Inactive) made changes - 09/Jul/19 04:22 AM

Field	Original Value	New Value
Priority	High [ 2 ]	Medium [ 3 ]

Hide

Permalink

Jayshree Nagpure (Inactive) added a comment - 09/Jul/19 04:22 AM

Before production deployment, this issue need to be fixed.

Show

Jayshree Nagpure (Inactive) added a comment - 09/Jul/19 04:22 AM Before production deployment, this issue need to be fixed.

Samir made changes - 09/Jul/19 04:40 AM

Assignee

Samir [ samir ]

Ramya Tantry [ ramya.tantry ]

Ramya Tantry (Inactive) made changes - 09/Jul/19 04:53 AM

Status

To Do [ 10000 ]

In Progress [ 3 ]

Permalink

Ramya Tantry (Inactive) logged work - 09/Jul/19 06:33 AM

Time Spent:

1.5h

Inital analysis

discussion with Rohan

Hide

Permalink

Ramya Tantry (Inactive) added a comment - 09/Jul/19 06:33 AM

Initial Analysis : Previous URL is getting set to current url which results in navigation issue.

Need to check on changes related previous url which results in setting current url in getPreviousUrl() of RoutingState.ts file.

CC:Rohan J Khandave

Show

Ramya Tantry (Inactive) added a comment - 09/Jul/19 06:33 AM Initial Analysis : Previous URL is getting set to current url which results in navigation issue. Need to check on changes related previous url which results in setting current url in getPreviousUrl() of RoutingState.ts file. CC: Rohan J Khandave

Ramya Tantry (Inactive) made changes - 09/Jul/19 06:33 AM

Remaining Estimate		0h [ 0 ]
Time Spent		1.5h [ 5400 ]
Worklog Id	187254 [ 187254 ]

Ramya Tantry (Inactive) made changes - 09/Jul/19 11:11 PM

Sprint		DMS - Fall Sprint 7 [ 166 ]
Original Estimate		0h [ 0 ]

Jayshree Nagpure (Inactive) made changes - 09/Jul/19 11:11 PM

Fix Version/s

Enhancements - Fall [ 10610 ]

Ramya Tantry (Inactive) made changes - 09/Jul/19 11:13 PM

Remaining Estimate	0h [ 0 ]	6.5h [ 23400 ]
Original Estimate	0h [ 0 ]	8h [ 28800 ]

Hide

Permalink

Jayshree Nagpure (Inactive) added a comment - 10/Jul/19 12:16 AM

Same issue exists for Email templates

Show

Jayshree Nagpure (Inactive) added a comment - 10/Jul/19 12:16 AM Same issue exists for Email templates

Hide

Permalink

Jayshree Nagpure (Inactive) added a comment - 10/Jul/19 04:02 AM

Also back arrow not working for Preview page.(Admin login)

Show

Jayshree Nagpure (Inactive) added a comment - 10/Jul/19 04:02 AM Also back arrow not working for Preview page.(Admin login)

Hide

Permalink

Ramya Tantry (Inactive) added a comment - 10/Jul/19 04:14 AM

3C's

Concern: Previous URL is getting set to current url which results in navigation issue.

Cause: App Component Constructor was getting called twice which resulted in adding URLs into history array twice. As we fetch previous url from this history array, it was returning current url (due to double insertion). On further analysis it was found that, app component changes done by Belal under ~~DMS-1509~~ was causing App Component Constructor to call twice.

Correction: Removed additional call of App component as provider from app.module.ts and it's injection in login component.

Tested Scenarios : Verified review and sign and email template redirection.

Affected Files:

DMS\DMS.Web\src\DMS_WebApp\ClientApp\src\app\app.module.ts

DMS\DMS.Web\src\DMS_WebApp\ClientApp\src\app\user\login\login.component.ts

CC: Rohan J Khandave,Ganesh Sadawarte,Samir,Narendra Kumar,Mohd Belal

Show

Ramya Tantry (Inactive) added a comment - 10/Jul/19 04:14 AM 3C's Concern : Previous URL is getting set to current url which results in navigation issue. Cause : App Component Constructor was getting called twice which resulted in adding URLs into history array twice. As we fetch previous url from this history array, it was returning current url (due to double insertion). On further analysis it was found that, app component changes done by Belal under DMS-1509 was causing App Component Constructor to call twice. Correction : Removed additional call of App component as provider from app.module.ts and it's injection in login component. Tested Scenarios : Verified review and sign and email template redirection. Affected Files: DMS\DMS.Web\src\DMS_WebApp\ClientApp\src\app\app.module.ts DMS\DMS.Web\src\DMS_WebApp\ClientApp\src\app\user\login\login.component.ts CC: Rohan J Khandave , Ganesh Sadawarte , Samir , Narendra Kumar , Mohd Belal

Permalink

Ramya Tantry (Inactive) logged work - 10/Jul/19 04:17 AM

Time Spent:

6.5h

Get previous url issue analysis

code fix

unit testing

Ramya Tantry (Inactive) made changes - 10/Jul/19 04:17 AM

Status

In Progress [ 3 ]

Code Review [ 11801 ]

Ramya Tantry (Inactive) made changes - 10/Jul/19 04:17 AM

Assignee

Ramya Tantry [ ramya.tantry ]

Narendra Kumar [ narendra.kumar ]

Ramya Tantry (Inactive) made changes - 10/Jul/19 04:18 AM

Remaining Estimate	6.5h [ 23400 ]	0h [ 0 ]
Time Spent	1.5h [ 5400 ]	8h [ 28800 ]
Worklog Id	187452 [ 187452 ]

Raj Hawaldar (Inactive) made changes - 10/Jul/19 11:00 PM

Status

Code Review [ 11801 ]

In QA Testing [ 11901 ]

Raj Hawaldar (Inactive) made changes - 10/Jul/19 11:02 PM

Assignee

Narendra Kumar [ narendra.kumar ]

Samir [ samir ]

ShashiKant Mishra (Inactive) made changes - 22/Jul/19 03:21 AM

Sprint

DMS - Fall Sprint 7 [ 166 ]

DMS - Fall Sprint 7, DMS - Fall Sprint 8 [ 166, 167 ]

ShashiKant Mishra (Inactive) made changes - 05/Aug/19 02:12 AM

Sprint

DMS - Fall Sprint 7, DMS - Fall Sprint 8 [ 166, 167 ]

DMS - Fall Sprint 7, DMS - Fall Sprint 8, DMS - Gap Fall & Win Sprint 1 [ 166, 167, 173 ]

ShashiKant Mishra (Inactive) made changes - 19/Aug/19 02:33 AM

Sprint

DMS - Fall Sprint 7, DMS - Fall Sprint 8, DMS - Gap Fall & Win Sprint 1 [ 166, 167, 173 ]

DMS - Fall Sprint 7, DMS - Fall Sprint 8, DMS - Gap Fall & Win Sprint 1, DMS - Gap Fall & Win Sprint 2 [ 166, 167, 173, 174 ]

ShashiKant Mishra (Inactive) made changes - 30/Aug/19 09:30 PM

Sprint

DMS - Fall Sprint 7, DMS - Fall Sprint 8, DMS - Gap Fall & Win Sprint 1, DMS - Gap Fall & Win Sprint 2 [ 166, 167, 173, 174 ]

DMS - Fall Sprint 7, DMS - Fall Sprint 8, DMS - Gap Fall & Win Sprint 1, DMS - Gap Fall & Win Sprint 2, DMS - Gap Fall & Win Sprint 3 [ 166, 167, 173, 174, 177 ]

ShashiKant Mishra (Inactive) made changes - 16/Sep/19 01:52 AM

Sprint

DMS - Fall Sprint 7, DMS - Fall Sprint 8, DMS - Gap Fall & Win Sprint 1, DMS - Gap Fall & Win Sprint 2, DMS - Gap Fall & Win Sprint 3 [ 166, 167, 173, 174, 177 ]

DMS - Fall Sprint 7, DMS - Fall Sprint 8, DMS - Gap Fall & Win Sprint 1, DMS - Gap Fall & Win Sprint 2, DMS - Gap Fall & Win Sprint 3, DMS - Gap Fall & Win Sprint 4 [ 166, 167, 173, 174, 177, 179 ]

Permalink

Priya Dhamande (Inactive) logged work - 19/Sep/19 04:09 AM

Time Spent:

0.5h

prod testing

Hide

Permalink

Priya Dhamande (Inactive) added a comment - 19/Sep/19 04:09 AM

Environment: Prod
Login: Candidate
File Type: PDF, TEXT and HTML
Browser: FF and Chrome

Able to navigate to review and Sign page of candidate after submit for all file type.

Refer screen capture. So, marking jira done.

Samir Rohan J Khandave Hrishikesh Deshpande Sachin Hingole

Show

Priya Dhamande (Inactive) added a comment - 19/Sep/19 04:09 AM Environment: Prod Login: Candidate File Type: PDF, TEXT and HTML Browser: FF and Chrome Able to navigate to review and Sign page of candidate after submit for all file type. Refer screen capture. So, marking jira done. Samir Rohan J Khandave Hrishikesh Deshpande Sachin Hingole

Priya Dhamande (Inactive) made changes - 19/Sep/19 04:09 AM

Resolution		Done [ 10000 ]
Status	In QA Testing [ 11901 ]	Done [ 10001 ]

Priya Dhamande (Inactive) made changes - 19/Sep/19 04:09 AM

Time Spent	8h [ 28800 ]	8.5h [ 30600 ]
Worklog Id	201250 [ 201250 ]

Transition	Time In Source Status	Execution Times

Ramya Tantry (Inactive) made transition - 09/Jul/19 04:53 AM

To Do

In Progress

31m 31s

Ramya Tantry (Inactive) made transition - 10/Jul/19 04:17 AM

In Progress

Code Review

23h 23m

Raj Hawaldar (Inactive) made transition - 10/Jul/19 11:00 PM

Code Review

In QA Testing

18h 42m

Priya Dhamande (Inactive) made transition - 19/Sep/19 04:09 AM

In QA Testing

Done

70d 5h 8m

People

Assignee:: Samir

Reporter:: Jayshree Nagpure (Inactive)

Votes:: 0 Vote for this issue

Watchers:: 3 Start watching this issue

Dates

Created:: 09/Jul/19 04:22 AM

Updated:: 19/Sep/19 04:09 AM

Resolved:: 19/Sep/19 04:09 AM

Time Tracking

Estimated:

Remaining:

Logged:

8.5h