Document Management SystemProject Type: software

Document Management System

Uploaded image for project: 'Document Management System'
  1. Document Management System
  2. DMS-1655

Signed HTML preview and Downloaded HTML are different

    Details

    • Type: Bug
    • Status: Done
    • Priority: Medium
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: Enhancements - Fall
    • Labels:
      None
    • Company:
      All Clients/Multiple Clients

      Description

      Environment: Prod

      Edit signed HTML file
      Download It
      Compare Both view

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          narendra.kumar Narendra Kumar created issue -
          Hide
          Permalink
          harshveer.singh Harshveer Singh (Inactive) added a comment -

          When changes are made for this in UI, 'api/document/download' also needs to be modified to reflect the same. Or alternatively, instead of filling HTML document in UI, directly call this API to download filled HTML document, and this bug will need to be fixed only on backend.
          Mohd Belal, Narendra Kumar

          Show
          harshveer.singh Harshveer Singh (Inactive) added a comment - When changes are made for this in UI, 'api/document/download' also needs to be modified to reflect the same. Or alternatively, instead of filling HTML document in UI, directly call this API to download filled HTML document, and this bug will need to be fixed only on backend. Mohd Belal , Narendra Kumar
          mohd.belal Mohd Belal (Inactive) made changes -
          Field Original Value New Value
          Remaining Estimate 16h [ 57600 ]
          Original Estimate 16h [ 57600 ]
          Hide
          Permalink
          harshveer.singh Harshveer Singh (Inactive) added a comment -

          Please use this API for downloading PDF and HTML files:

          /api/document/download?id=2046&stream=true

          Show
          harshveer.singh Harshveer Singh (Inactive) added a comment - Please use this API for downloading PDF and HTML files: /api/document/download?id=2046&stream=true
          mohd.belal Mohd Belal (Inactive) made changes -
          Status To Do [ 10000 ] In Progress [ 3 ]
          mohd.belal Mohd Belal (Inactive) made changes -
          Status In Progress [ 3 ] To Do [ 10000 ]
          Hide
          Permalink
          samir Samir added a comment -

          Please verify this

          Show
          samir Samir added a comment - Please verify this
          samir Samir made changes -
          Assignee Mohd Belal [ mohd.belal ] Narendra Kumar [ narendra.kumar ]
          narendra.kumar Narendra Kumar made changes -
          Status To Do [ 10000 ] In Progress [ 3 ]
          shashikant.mishra ShashiKant Mishra (Inactive) made changes -
          Sprint DMS - Fall Sprint 8 [ 167 ] DMS - Fall Sprint 8, DMS - Gap Fall & Win Sprint 1 [ 167, 173 ]
          shashikant.mishra ShashiKant Mishra (Inactive) made changes -
          Sprint DMS - Fall Sprint 8, DMS - Gap Fall & Win Sprint 1 [ 167, 173 ] DMS - Fall Sprint 8, DMS - Gap Fall & Win Sprint 1, DMS - Gap Fall & Win Sprint 2 [ 167, 173, 174 ]
          Hide
          Permalink
          rohan.khandave Rohan J Khandave (Inactive) added a comment -

          Hello Ganesh Sadawarte,

          As per discussion look into this.

          Thanks,
          RohanK

          Show
          rohan.khandave Rohan J Khandave (Inactive) added a comment - Hello Ganesh Sadawarte , As per discussion look into this. Thanks, RohanK
          rohan.khandave Rohan J Khandave (Inactive) made changes -
          Assignee Narendra Kumar [ narendra.kumar ] Ganesh Sadawarte [ ganesh.sadawarte ]
          Hide
          Permalink
          Ganesh.sadawarte Ganesh Sadawarte (Inactive) added a comment - - edited

          Hi Sonali Farakate,

          Please check this.

          CC-Samir

           Thanks,

          Ganesh

          Show
          Ganesh.sadawarte Ganesh Sadawarte (Inactive) added a comment - - edited Hi Sonali Farakate , Please check this. CC- Samir  Thanks, Ganesh
          Ganesh.sadawarte Ganesh Sadawarte (Inactive) made changes -
          Assignee Ganesh Sadawarte [ ganesh.sadawarte ] Sonali Farakate [ sonali.farakate ]
          samir Samir made changes -
          Assignee Sonali Farakate [ sonali.farakate ] Ramya Tantry [ ramya.tantry ]
          ramya.tantry Ramya Tantry (Inactive) made changes -
          Status In Progress [ 3 ] In Progress [ 3 ]
          Permalink
          ramya.tantry Ramya Tantry (Inactive) logged work - 22/Aug/19 05:51 AM
          • Time Spent:
            2h
             

            Issue analysis

          ramya.tantry Ramya Tantry (Inactive) made changes -
          Remaining Estimate 16h [ 57600 ] 14h [ 50400 ]
          Time Spent 2h [ 7200 ]
          Worklog Id 196369 [ 196369 ]
          Permalink
          ramya.tantry Ramya Tantry (Inactive) logged work - 23/Aug/19 06:03 AM
          • Time Spent:
            1.5h
             

            Issue analysis

          ramya.tantry Ramya Tantry (Inactive) made changes -
          Remaining Estimate 14h [ 50400 ] 12.5h [ 45000 ]
          Time Spent 2h [ 7200 ] 3.5h [ 12600 ]
          Worklog Id 196604 [ 196604 ]
          Permalink
          ramya.tantry Ramya Tantry (Inactive) logged work - 26/Aug/19 05:20 AM
          • Time Spent:
            6h
             

            Code changes

            Unit testing

          ramya.tantry Ramya Tantry (Inactive) made changes -
          Remaining Estimate 12.5h [ 45000 ] 6.5h [ 23400 ]
          Time Spent 3.5h [ 12600 ] 9.5h [ 34200 ]
          Worklog Id 196857 [ 196857 ]
          Hide
          Permalink
          ramya.tantry Ramya Tantry (Inactive) added a comment - - edited

          3C's

          Concern:  Signed HTML preview and Downloaded HTML are different

          Cause: Specific conditions were added in code which was overwriting the actual value of radio button that resulted in discrepancy in the HTML view of download.

          Correction : Added radio button and checkbox conditions to come up properly on HTML view.

          Files Affected :

          1. DMS\DMS.Web\src\DMS_WebApp\ClientApp\src\app\admin\document\document-completed\document-completed.component.ts
          2. DMS\DMS.Web\src\DMS_WebApp\ClientApp\src\app\admin\send-forms\forms-preview\forms-preview.component.ts
          3. DMS\DMS.Web\src\DMS_WebApp\ClientApp\src\app\candidate\document-review\document-review.component.ts
          4. DMS/DMS.App/src/DMS_AppLogic/BuisnessLogic/DocumentData.cs
          Show
          ramya.tantry Ramya Tantry (Inactive) added a comment - - edited 3C's Concern :  Signed HTML preview and Downloaded HTML are different Cause : Specific conditions were added in code which was overwriting the actual value of radio button that resulted in discrepancy in the HTML view of download. Correction : Added radio button and checkbox conditions to come up properly on HTML view. Files Affected : DMS\DMS.Web\src\DMS_WebApp\ClientApp\src\app\admin\document\document-completed\document-completed.component.ts DMS\DMS.Web\src\DMS_WebApp\ClientApp\src\app\admin\send-forms\forms-preview\forms-preview.component.ts DMS\DMS.Web\src\DMS_WebApp\ClientApp\src\app\candidate\document-review\document-review.component.ts DMS/DMS.App/src/DMS_AppLogic/BuisnessLogic/DocumentData.cs
          Permalink
          ramya.tantry Ramya Tantry (Inactive) logged work - 26/Aug/19 10:38 PM
          • Time Spent:
            1.5h
             

            Create PR

            Unit testing

          ramya.tantry Ramya Tantry (Inactive) made changes -
          Remaining Estimate 6.5h [ 23400 ] 5h [ 18000 ]
          Time Spent 9.5h [ 34200 ] 11h [ 39600 ]
          Worklog Id 197073 [ 197073 ]
          ramya.tantry Ramya Tantry (Inactive) made changes -
          Status In Progress [ 3 ] Code Review [ 11801 ]
          ramya.tantry Ramya Tantry (Inactive) made changes -
          Assignee Ramya Tantry [ ramya.tantry ] Mohd Belal [ mohd.belal ]
          ramya.tantry Ramya Tantry (Inactive) made changes -
          Status Code Review [ 11801 ] In Progress [ 3 ]
          ramya.tantry Ramya Tantry (Inactive) made changes -
          Assignee Mohd Belal [ mohd.belal ] Ramya Tantry [ ramya.tantry ]
          ramya.tantry Ramya Tantry (Inactive) made changes -
          Assignee Ramya Tantry [ ramya.tantry ] Harshveer Singh [ harshveer.singh ]
          ramya.tantry Ramya Tantry (Inactive) made changes -
          Status In Progress [ 3 ] Code Review [ 11801 ]
          Permalink
          ramya.tantry Ramya Tantry (Inactive) logged work - 29/Aug/19 05:37 AM
          • Time Spent:
            3h
             

            Code changes

            Unit testing

          ramya.tantry Ramya Tantry (Inactive) made changes -
          Remaining Estimate 5h [ 18000 ] 2h [ 7200 ]
          Time Spent 11h [ 39600 ] 14h [ 50400 ]
          Worklog Id 197757 [ 197757 ]
          shashikant.mishra ShashiKant Mishra (Inactive) made changes -
          Sprint DMS - Fall Sprint 8, DMS - Gap Fall & Win Sprint 1, DMS - Gap Fall & Win Sprint 2 [ 167, 173, 174 ] DMS - Fall Sprint 8, DMS - Gap Fall & Win Sprint 1, DMS - Gap Fall & Win Sprint 2, DMS - Gap Fall & Win Sprint 3 [ 167, 173, 174, 177 ]
          Permalink
          ramya.tantry Ramya Tantry (Inactive) logged work - 03/Sep/19 12:25 AM
          • Time Spent:
            1h
             

            code changes

            discussion

          ramya.tantry Ramya Tantry (Inactive) made changes -
          Assignee Harshveer Singh [ harshveer.singh ] Mohd Belal [ mohd.belal ]
          ramya.tantry Ramya Tantry (Inactive) made changes -
          Remaining Estimate 2h [ 7200 ] 1h [ 3600 ]
          Time Spent 14h [ 50400 ] 15h [ 54000 ]
          Worklog Id 198189 [ 198189 ]
          Ashish.Durani Ashish Durani made changes -
          Status Code Review [ 11801 ] In QA Testing [ 11901 ]
          Ashish.Durani Ashish Durani made changes -
          Assignee Mohd Belal [ mohd.belal ] Priya Dhamande [ priya.dhamande ]
          Hide
          Permalink
          priya.dhamande Priya Dhamande (Inactive) added a comment -

          Environment: Preprod
          Login: Admin
          Browser: FF and Chrome

          The issue is verified on Prerod, refer screen capture.

          So, marking jira done.

          Samir Rohan J Khandave Hrishikesh Deshpande Sachin Hingole

          Show
          priya.dhamande Priya Dhamande (Inactive) added a comment - Environment: Preprod Login: Admin Browser: FF and Chrome The issue is verified on Prerod, refer screen capture. So, marking jira done. Samir Rohan J Khandave Hrishikesh Deshpande Sachin Hingole
          Permalink
          priya.dhamande Priya Dhamande (Inactive) logged work - 04/Sep/19 12:01 AM - edited
          • Time Spent:
            0.5h
             

            preprod testing

          priya.dhamande Priya Dhamande (Inactive) made changes -
          Status In QA Testing [ 11901 ] Code Review [ 11801 ]
          priya.dhamande Priya Dhamande (Inactive) made changes -
          Resolution Done [ 10000 ]
          Status Code Review [ 11801 ] Done [ 10001 ]
          priya.dhamande Priya Dhamande (Inactive) made changes -
          Attachment Screenshot (234).png [ 118359 ]
          Attachment Screenshot (235).png [ 118360 ]
          priya.dhamande Priya Dhamande (Inactive) made changes -
          Remaining Estimate 1h [ 3600 ] 0h [ 0 ]
          Time Spent 15h [ 54000 ] 45h [ 162000 ]
          Worklog Id 198400 [ 198400 ]
          priya.dhamande Priya Dhamande (Inactive) made changes -
          Remaining Estimate 0h [ 0 ] 29.5h [ 106200 ]
          Time Spent 45h [ 162000 ] 15.5h [ 55800 ]
          Worklog Id 198400 [ 198400 ]
          Transition Time In Source Status Execution Times
          Mohd Belal (Inactive) made transition -
          In Progress To Do
          		52m 26s 1
          Narendra Kumar made transition -
          To Do In Progress
          		16d 15h 22m 2
          Ramya Tantry (Inactive) made transition -
          In Progress In Progress
          		20d 1h 50m 1
          Ramya Tantry (Inactive) made transition -
          Code Review In Progress
          		1d 22h 55m 1
          Ramya Tantry (Inactive) made transition -
          In Progress Code Review
          		5d 1h 50m 2
          Ashish Durani made transition -
          Code Review In QA Testing
          		5d 6h 25m 1
          Priya Dhamande (Inactive) made transition -
          In QA Testing Code Review
          		18h 18m 1
          Priya Dhamande (Inactive) made transition -
          Code Review Done
          		3s 1

            People

            Assignee:
            priya.dhamande Priya Dhamande (Inactive)
            Reporter:
            narendra.kumar Narendra Kumar
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 16h Original Estimate - 16h
                16h
                Remaining:
                Time Spent - 15.5h Remaining Estimate - 29.5h
                29.5h
                Logged:
                Time Spent - 15.5h Remaining Estimate - 29.5h
                15.5h