Document Management SystemProject Type: software

Document Management System

Uploaded image for project: 'Document Management System'
  1. Document Management System
  2. DMS-1665

Create document API - Single quote issue.

    Details

    • Type: Bug
    • Status: Done
    • Priority: Medium
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: Enhancements - Fall
    • Labels:
      None
    • Company:
      All Clients/Multiple Clients

      Description

      • When we give single quote in values throws as error as we creating query dynamically.
      • If requisition Id is not exists is throws an error.

        Attachments

        1. Screenshot (3489).png
          Screenshot (3489).png
          137 kB
        2. Screenshot (3490).png
          Screenshot (3490).png
          165 kB
        3. Screenshot (3491).png
          Screenshot (3491).png
          166 kB
        4. Screenshot (3492).png
          Screenshot (3492).png
          162 kB

          Activity

          Ascending order - Click to sort in descending order
          Ganesh.sadawarte Ganesh Sadawarte (Inactive) created issue -
          Permalink
          Ganesh.sadawarte Ganesh Sadawarte (Inactive) logged work - 18/Jul/19 05:27 PM
          • Time Spent:
            3h
             
            • Checked Issue reported by client
            • Analysis & code debug.
            • Details provide to the client
          rohan.khandave Rohan J Khandave (Inactive) made changes -
          Field Original Value New Value
          Status To Do [ 10000 ] In Progress [ 3 ]
          Hide
          Permalink
          rohan.khandave Rohan J Khandave (Inactive) added a comment -

          Below are details

          Concern: Server error for create custom API.

          Cause: API payload contains single quote which causing issue while creating dynamic query.

          Correction: We have replace single quote with "`".

          CC – Samir , Ganesh Sadawarte 

          Show
          rohan.khandave Rohan J Khandave (Inactive) added a comment - Below are details Concern: Server error for create custom API. Cause: API payload contains single quote which causing issue while creating dynamic query. Correction: We have replace single quote with " ` ". CC – Samir , Ganesh Sadawarte  
          rohan.khandave Rohan J Khandave (Inactive) made changes -
          Status In Progress [ 3 ] Code Review [ 11801 ]
          rohan.khandave Rohan J Khandave (Inactive) made changes -
          Assignee Rohan J Khandave [ rohan.khandave ] Ganesh Sadawarte [ ganesh.sadawarte ]
          Ganesh.sadawarte Ganesh Sadawarte (Inactive) made changes -
          Remaining Estimate 0h [ 0 ]
          Time Spent 20m [ 1200 ]
          Worklog Id 189714 [ 189714 ]
          Ganesh.sadawarte Ganesh Sadawarte (Inactive) made changes -
          Assignee Ganesh Sadawarte [ ganesh.sadawarte ] Rohan J Khandave [ rohan.khandave ]
          Hide
          Permalink
          Ganesh.sadawarte Ganesh Sadawarte (Inactive) added a comment -

          Code review completed

          Show
          Ganesh.sadawarte Ganesh Sadawarte (Inactive) added a comment - Code review completed
          Hide
          Permalink
          rohan.khandave Rohan J Khandave (Inactive) added a comment -

          As per discussion with Alex.

          We will always consider Email, sourceUserId ,requisitionId from main payload.

          Needs to ignore these fields values from candidate & requisition payload.

          CC – Samir , Ganesh Sadawarte

          Show
          rohan.khandave Rohan J Khandave (Inactive) added a comment - As per discussion with Alex. We will always consider Email, sourceUserId ,requisitionId from main payload. Needs to ignore these fields values from candidate & requisition payload. CC – Samir , Ganesh Sadawarte
          Ganesh.sadawarte Ganesh Sadawarte (Inactive) made changes -
          Time Spent 20m [ 1200 ] 3h 20m [ 12000 ]
          Worklog Id 189804 [ 189804 ]
          Permalink
          rohan.khandave Rohan J Khandave (Inactive) logged work - 19/Jul/19 07:51 AM
          • Time Spent:
            4h
             

            Analysis , Coding , Adding validations , Changes as per client comments

          rohan.khandave Rohan J Khandave (Inactive) made changes -
          Time Spent 3h 20m [ 12000 ] 7h 20m [ 26400 ]
          Worklog Id 189913 [ 189913 ]
          Permalink
          Ganesh.sadawarte Ganesh Sadawarte (Inactive) logged work - 19/Jul/19 05:35 PM
          • Time Spent:
            20m
             
            • Code review
          Permalink
          Ganesh.sadawarte Ganesh Sadawarte (Inactive) logged work - 19/Jul/19 05:46 PM - edited
          • Time Spent:
            2h
             
            • Analysis & Discussion
            • Checked issue with Rohan.
          Raj.Hawaldar Raj Hawaldar (Inactive) made changes -
          Status Code Review [ 11801 ] In QA Testing [ 11901 ]
          Raj.Hawaldar Raj Hawaldar (Inactive) made changes -
          Assignee Rohan J Khandave [ rohan.khandave ] Priya Dhamande [ priya.dhamande ]
          Ganesh.sadawarte Ganesh Sadawarte (Inactive) made changes -
          Time Spent 7h 20m [ 26400 ] 9h 20m [ 33600 ]
          Worklog Id 190011 [ 190011 ]
          Ganesh.sadawarte Ganesh Sadawarte (Inactive) made changes -
          Worklog Id 190011 [ 190011 ]
          Permalink
          priya.dhamande Priya Dhamande (Inactive) logged work - 25/Jul/19 10:15 PM
          • Time Spent:
            1h
             
            <No comment>
          Permalink
          priya.dhamande Priya Dhamande (Inactive) logged work - 28/Jul/19 11:38 PM
          • Time Spent:
            1h
             

            Prod testing
            Discussion with Ganesh

          Hide
          Permalink
          priya.dhamande Priya Dhamande (Inactive) added a comment -

          Environment: Production - One IM
          API: api/candidate/custom/document/create

          Points verified:
          1. Email ID - different
          2. Email ID - same
          3. Single quote added for one of the

          Mentioned scenarios worked out. Refer screen capture. So, marking jira done.

          Sachin Hingole Hrishikesh Deshpande Rohan J Khandave Samir

          Show
          priya.dhamande Priya Dhamande (Inactive) added a comment - Environment: Production - One IM API: api/candidate/custom/document/create Points verified: 1. Email ID - different 2. Email ID - same 3. Single quote added for one of the Mentioned scenarios worked out. Refer screen capture. So, marking jira done. Sachin Hingole Hrishikesh Deshpande Rohan J Khandave Samir
          priya.dhamande Priya Dhamande (Inactive) made changes -
          Attachment Screenshot (3490).png [ 114693 ]
          Attachment Screenshot (3489).png [ 114694 ]
          Attachment Screenshot (3492).png [ 114695 ]
          Attachment Screenshot (3491).png [ 114696 ]
          priya.dhamande Priya Dhamande (Inactive) made changes -
          Status In QA Testing [ 11901 ] Code Review [ 11801 ]
          priya.dhamande Priya Dhamande (Inactive) made changes -
          Resolution Done [ 10000 ]
          Status Code Review [ 11801 ] Done [ 10001 ]
          priya.dhamande Priya Dhamande (Inactive) made changes -
          Time Spent 9h 20m [ 33600 ] 10h 20m [ 37200 ]
          Worklog Id 191845 [ 191845 ]
          priya.dhamande Priya Dhamande (Inactive) made changes -
          Time Spent 10h 20m [ 37200 ] 11h 20m [ 40800 ]
          Worklog Id 192641 [ 192641 ]
          Transition Time In Source Status Execution Times
          Rohan J Khandave (Inactive) made transition -
          To Do In Progress
          		19h 35m 1
          Rohan J Khandave (Inactive) made transition -
          In Progress Code Review
          		4m 46s 1
          Raj Hawaldar (Inactive) made transition -
          Code Review In QA Testing
          		2d 21h 1
          Priya Dhamande (Inactive) made transition -
          In QA Testing Code Review
          		7d 1h 4m 1
          Priya Dhamande (Inactive) made transition -
          Code Review Done
          		3s 1

            People

            Assignee:
            priya.dhamande Priya Dhamande (Inactive)
            Reporter:
            Ganesh.sadawarte Ganesh Sadawarte (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 11h 20m
                11h 20m