Document Management SystemProject Type: software

Document Management System

Uploaded image for project: 'Document Management System'
  1. Document Management System
  2. DMS-1681

Make payload and source userId optional for create document

    Details

    • Company:
      All Clients/Multiple Clients

      Description

      Make payload and source userId optional for create document. Remove required attribute and validations related to source userId from create document API.

      Also below points needs to consider

      1. Fetch global custom fields.
      2. Allow form alias in payload.
      3. Make template ids optional. Payload may contain Template ids & Form Alias.
      4. In response payload of this API, make properties in camelCasing

       

        Attachments

        1. DMS-1681 Payload Changes.txt
          11 kB
        2. Screenshot (3549).png
          Screenshot (3549).png
          158 kB
        3. Screenshot (3550).png
          Screenshot (3550).png
          146 kB
        4. Screenshot (3551).png
          Screenshot (3551).png
          130 kB
        5. Screenshot (3552).png
          Screenshot (3552).png
          128 kB
        6. Screenshot (3553).png
          Screenshot (3553).png
          130 kB
        7. Screenshot (3554).png
          Screenshot (3554).png
          138 kB
        8. Screenshot (3555).png
          Screenshot (3555).png
          134 kB
        9. Screenshot (3556).png
          Screenshot (3556).png
          135 kB
        10. Testcases -DMS-1681.xls
          15 kB

          Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. DMS-1687 document/create API is not working is templateIds are not passed

          • High - Serious problem that could block progress.
          • Done

            Activity

            Ascending order - Click to sort in descending order
            harshveer.singh Harshveer Singh (Inactive) created issue -
            samir Samir made changes -
            Field Original Value New Value
            Fix Version/s Integration with CBES [ 10448 ]
            samir Samir made changes -
            Labels Integration-CBES
            harshveer.singh Harshveer Singh (Inactive) made changes -
            Summary Make payload, email, and source userId optional for create document Make payload and source userId optional for create document
            harshveer.singh Harshveer Singh (Inactive) made changes -
            Description Make payload, email, and source userId optional for create document Make payload and source userId optional for create document. Remove required attribute and validations related to source userId from create document API.
            samir Samir made changes -
            Assignee Harshveer Singh [ harshveer.singh ] Ramya Tantry [ ramya.tantry ]
            samir Samir made changes -
            Assignee Ramya Tantry [ ramya.tantry ] Ganesh Sadawarte [ ganesh.sadawarte ]
            rohan.khandave Rohan J Khandave (Inactive) made changes -
            Description Make payload and source userId optional for create document. Remove required attribute and validations related to source userId from create document API. Make payload and source userId optional for create document. Remove required attribute and validations related to source userId from create document API.

            Also below points needs to consider
             # Fetch global custom fields.
             # Allow form alias in payload.
             # Make template ids optional. Payload may contain Template ids & Form Alias.

             
            Hide
            Permalink
            Ganesh.sadawarte Ganesh Sadawarte (Inactive) added a comment - - edited
            • Will we use custom create document API: POST URL : /api/candidate/custom/document/create
            Show
            Ganesh.sadawarte Ganesh Sadawarte (Inactive) added a comment - - edited Will we use custom create document API: POST URL : /api/candidate/custom/document/create
            harshveer.singh Harshveer Singh (Inactive) made changes -
            Description Make payload and source userId optional for create document. Remove required attribute and validations related to source userId from create document API.

            Also below points needs to consider
             # Fetch global custom fields.
             # Allow form alias in payload.
             # Make template ids optional. Payload may contain Template ids & Form Alias.

                          		Make payload and source userId optional for create document. Remove required attribute and validations related to source userId from create document API.

            Also below points needs to consider
             # Fetch global custom fields.
             # Allow form alias in payload.
             # Make template ids optional. Payload may contain Template ids & Form Alias.
             # In response payload of this API, make properties in camelCasing

             
            Ganesh.sadawarte Ganesh Sadawarte (Inactive) made changes -
            Status To Do [ 10000 ] In Progress [ 3 ]
            Ganesh.sadawarte Ganesh Sadawarte (Inactive) made changes -
            Developer Ganesh Sadawarte [ ganesh.sadawarte ]
            Remaining Estimate 16h [ 57600 ]
            Original Estimate 16h [ 57600 ]
            Permalink
            Ganesh.sadawarte Ganesh Sadawarte (Inactive) logged work - 26/Jul/19 05:51 PM - edited
            • Time Spent:
              3h
               
              <No comment>
            Ganesh.sadawarte Ganesh Sadawarte (Inactive) made changes -
            Remaining Estimate 16h [ 57600 ] 13h [ 46800 ]
            Time Spent 3h [ 10800 ]
            Worklog Id 191780 [ 191780 ]
            Ganesh.sadawarte Ganesh Sadawarte (Inactive) made changes -
            Worklog Id 191780 [ 191780 ]
            Ganesh.sadawarte Ganesh Sadawarte (Inactive) made changes -
            Attachment DMS-1681 Payload Changes.txt [ 114743 ]
            Hide
            Permalink
            Ganesh.sadawarte Ganesh Sadawarte (Inactive) added a comment - - edited

            Adding Payload Changes DMS-1681 Payload Changes.txt

            We have change casing for below response properties.

            • documentTemplateId
            • documentId

            CC-Samir,Rohan J Khandave

            Show
            Ganesh.sadawarte Ganesh Sadawarte (Inactive) added a comment - - edited Adding Payload Changes DMS-1681 Payload Changes.txt We have change casing for below response properties. documentTemplateId documentId CC- Samir , Rohan J Khandave
            Hide
            Permalink
            Ganesh.sadawarte Ganesh Sadawarte (Inactive) added a comment -

            Hi All,

            We have done with below changes.

            • Fetch global custom fields.
            • Allow form alias in payload: created common logic and applied for custom and create document API.
            • Make template ids optional. Payload may contain Template ids & Form Alias.
            • In response payload of this API, make properties in camelCasing: Changes done for properties and error response key.

            Harshveer Singh please have review & let me know any changes needed for camelCasing.

            CC-Samir,Rohan J Khandave

            Thanks,
            Ganesh

            Show
            Ganesh.sadawarte Ganesh Sadawarte (Inactive) added a comment - Hi All, We have done with below changes. Fetch global custom fields. Allow form alias in payload: created common logic and applied for custom and create document API. Make template ids optional. Payload may contain Template ids & Form Alias. In response payload of this API, make properties in camelCasing: Changes done for properties and error response key. Harshveer Singh please have review & let me know any changes needed for camelCasing. CC- Samir , Rohan J Khandave Thanks, Ganesh
            Ganesh.sadawarte Ganesh Sadawarte (Inactive) made changes -
            Remaining Estimate 13h [ 46800 ] 6h [ 21600 ]
            Time Spent 3h [ 10800 ] 10h [ 36000 ]
            Worklog Id 191951 [ 191951 ]
            Ganesh.sadawarte Ganesh Sadawarte (Inactive) made changes -
            Status In Progress [ 3 ] Code Review [ 11801 ]
            Permalink
            Ganesh.sadawarte Ganesh Sadawarte (Inactive) logged work - 29/Jul/19 07:03 PM
            • Time Spent:
              7h
               
              • Fetch global custom fields.
              • Allow form alias in payload: created common logic and applied for custom and create document API.
              • Make template ids optional. Payload may contain Template ids & Form Alias.
              • In response payload of this API, make properties in camelCasing: Changes done for properties and error response key.
            Ganesh.sadawarte Ganesh Sadawarte (Inactive) made changes -
            Link This issue relates to DMS-1687 [ DMS-1687 ]
            ashwin.wankhede Ashwin Wankhede (Inactive) made changes -
            Status Code Review [ 11801 ] In QA Testing [ 11901 ]
            ashwin.wankhede Ashwin Wankhede (Inactive) made changes -
            Assignee Ganesh Sadawarte [ ganesh.sadawarte ] Priya Dhamande [ priya.dhamande ]
            Permalink
            rohan.khandave Rohan J Khandave (Inactive) logged work - 30/Jul/19 01:54 AM
            • Time Spent:
              3h
               

              Analysis , Discussion , Testing , call with Harshveer

            Ganesh.sadawarte Ganesh Sadawarte (Inactive) made changes -
            Status In QA Testing [ 11901 ] Code Review [ 11801 ]
            Ganesh.sadawarte Ganesh Sadawarte (Inactive) made changes -
            Assignee Priya Dhamande [ priya.dhamande ] Ganesh Sadawarte [ ganesh.sadawarte ]
            Ganesh.sadawarte Ganesh Sadawarte (Inactive) made changes -
            Remaining Estimate 6h [ 21600 ] 3h [ 10800 ]
            Time Spent 10h [ 36000 ] 13h [ 46800 ]
            Worklog Id 192144 [ 192144 ]
            Ganesh.sadawarte Ganesh Sadawarte (Inactive) made changes -
            Status Code Review [ 11801 ] In QA Testing [ 11901 ]
            Ganesh.sadawarte Ganesh Sadawarte (Inactive) made changes -
            Assignee Ganesh Sadawarte [ ganesh.sadawarte ] Priya Dhamande [ priya.dhamande ]
            Permalink
            Ganesh.sadawarte Ganesh Sadawarte (Inactive) logged work - 30/Jul/19 05:51 PM
            • Time Spent:
              3h
               
              • Unit tesing
              • Code changes
              • Code review and merged to develop
              • Pre Production testing.
            Permalink
            Ganesh.sadawarte Ganesh Sadawarte (Inactive) logged work - 30/Jul/19 05:54 PM
            • Time Spent:
              5.5h
               
              • Checked Issue On Pre-Production
              • Call with Samir & Harshveer.
            rohan.khandave Rohan J Khandave (Inactive) made changes -
            Remaining Estimate 3h [ 10800 ] 0h [ 0 ]
            Time Spent 13h [ 46800 ] 16h [ 57600 ]
            Worklog Id 192411 [ 192411 ]
            Ganesh.sadawarte Ganesh Sadawarte (Inactive) made changes -
            Time Spent 16h [ 57600 ] 21.5h [ 77400 ]
            Worklog Id 192413 [ 192413 ]
            Permalink
            Ganesh.sadawarte Ganesh Sadawarte (Inactive) logged work - 31/Jul/19 05:31 PM
            • Time Spent:
              3h
               
              • Pre-production testing
              • Call with harshveer
              • File copy iss fixes.
            Ganesh.sadawarte Ganesh Sadawarte (Inactive) made changes -
            Time Spent 21.5h [ 77400 ] 24.5h [ 88200 ]
            Worklog Id 192657 [ 192657 ]
            priya.dhamande Priya Dhamande (Inactive) made changes -
            Attachment Testcases -DMS-1681.xls [ 115113 ]
            priya.dhamande Priya Dhamande (Inactive) made changes -
            Attachment Screenshot (3552).png [ 115114 ]
            Attachment Screenshot (3551).png [ 115115 ]
            Attachment Screenshot (3550).png [ 115116 ]
            Attachment Screenshot (3549).png [ 115117 ]
            Attachment Screenshot (3556).png [ 115118 ]
            Attachment Screenshot (3555).png [ 115119 ]
            Attachment Screenshot (3554).png [ 115120 ]
            Attachment Screenshot (3553).png [ 115121 ]
            Hide
            Permalink
            priya.dhamande Priya Dhamande (Inactive) added a comment -

            Environment: Preprod OneIM
            Browser: FF and Chrome
            API: api/candidate/custom/document/create and api/candidate/document/create

            Scenarios verified:
            1. Custom create document without Source ID
            2. Create document without Source ID
            3. Custom create document with Form Alias
            4. Create document with Form Alias
            5. Custom create document with Form Template ID
            6. Create document with Template ID
            7. Custom create document with Send document: 0, 1 and 2
            8. Create document with Send document: 0, 1 and 2

            Issue found in Send document 1 and 0. Logged jira with ID: DMS-1700.

            Refer screen capture. So, marking jira done.

            Sachin Hingole Hrishikesh Deshpande Rohan J Khandave Harshveer Singh Samir

            Show
            priya.dhamande Priya Dhamande (Inactive) added a comment - Environment: Preprod OneIM Browser: FF and Chrome API: api/candidate/custom/document/create and api/candidate/document/create Scenarios verified: 1. Custom create document without Source ID 2. Create document without Source ID 3. Custom create document with Form Alias 4. Create document with Form Alias 5. Custom create document with Form Template ID 6. Create document with Template ID 7. Custom create document with Send document: 0, 1 and 2 8. Create document with Send document: 0, 1 and 2 Issue found in Send document 1 and 0. Logged jira with ID: DMS-1700 . Refer screen capture. So, marking jira done. Sachin Hingole Hrishikesh Deshpande Rohan J Khandave Harshveer Singh Samir
            Permalink
            priya.dhamande Priya Dhamande (Inactive) logged work - 01/Aug/19 12:12 AM
            • Time Spent:
              1.5h
               

              Preprod testing

            priya.dhamande Priya Dhamande (Inactive) made changes -
            Time Spent 24.5h [ 88200 ] 26h [ 93600 ]
            Worklog Id 192676 [ 192676 ]
            priya.dhamande Priya Dhamande (Inactive) made changes -
            Resolution Done [ 10000 ]
            Status In QA Testing [ 11901 ] Done [ 10001 ]
            priya.dhamande Priya Dhamande (Inactive) made changes -
            Assignee Priya Dhamande [ priya.dhamande ] Harshveer Singh [ harshveer.singh ]
            Raj.Hawaldar Raj Hawaldar (Inactive) made changes -
            Assignee Harshveer Singh [ harshveer.singh ] Priya Dhamande [ priya.dhamande ]
            Raj.Hawaldar Raj Hawaldar (Inactive) made changes -
            Status Done [ 10001 ] In QA Testing [ 11901 ]
            shashikant.mishra ShashiKant Mishra (Inactive) made changes -
            Sprint DMS - Fall Sprint 8 [ 167 ] DMS - Fall Sprint 8, DMS - Gap Fall & Win Sprint 1 [ 167, 173 ]
            shashikant.mishra ShashiKant Mishra (Inactive) made changes -
            Sprint DMS - Fall Sprint 8, DMS - Gap Fall & Win Sprint 1 [ 167, 173 ] DMS - Fall Sprint 8, DMS - Gap Fall & Win Sprint 1, DMS - Gap Fall & Win Sprint 2 [ 167, 173, 174 ]
            Raj.Hawaldar Raj Hawaldar (Inactive) made changes -
            Status In QA Testing [ 11901 ] In QA Testing [ 11901 ]
            shashikant.mishra ShashiKant Mishra (Inactive) made changes -
            Sprint DMS - Fall Sprint 8, DMS - Gap Fall & Win Sprint 1, DMS - Gap Fall & Win Sprint 2 [ 167, 173, 174 ] DMS - Fall Sprint 8, DMS - Gap Fall & Win Sprint 1, DMS - Gap Fall & Win Sprint 2, DMS - Gap Fall & Win Sprint 3 [ 167, 173, 174, 177 ]
            shashikant.mishra ShashiKant Mishra (Inactive) made changes -
            Sprint DMS - Fall Sprint 8, DMS - Gap Fall & Win Sprint 1, DMS - Gap Fall & Win Sprint 2, DMS - Gap Fall & Win Sprint 3 [ 167, 173, 174, 177 ] DMS - Fall Sprint 8, DMS - Gap Fall & Win Sprint 1, DMS - Gap Fall & Win Sprint 2, DMS - Gap Fall & Win Sprint 3, DMS - Gap Fall & Win Sprint 4 [ 167, 173, 174, 177, 179 ]
            priya.dhamande Priya Dhamande (Inactive) made changes -
            Status In QA Testing [ 11901 ] Done [ 10001 ]
            Transition Time In Source Status Execution Times
            Ganesh Sadawarte (Inactive) made transition -
            To Do In Progress
            		1d 22h 29m 1
            Ganesh Sadawarte (Inactive) made transition -
            In Progress Code Review
            		3d 5h 1
            Ganesh Sadawarte (Inactive) made transition -
            In QA Testing Code Review
            		1h 12m 1
            Ganesh Sadawarte (Inactive) made transition -
            Code Review In QA Testing
            		19h 35m 2
            Raj Hawaldar (Inactive) made transition -
            Done In QA Testing
            		12m 30s 1
            Raj Hawaldar (Inactive) made transition -
            In QA Testing In QA Testing
            		26d 22h 53m 1
            Priya Dhamande (Inactive) made transition -
            In QA Testing Done
            		25d 35m 2

              People

              Assignee:
              priya.dhamande Priya Dhamande (Inactive)
              Reporter:
              harshveer.singh Harshveer Singh (Inactive)
              Developer:
              Ganesh Sadawarte (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - 16h Original Estimate - 16h
                  16h
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 26h
                  26h