Details

    • Type: New Feature
    • Status: Done
    • Priority: High
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: CBAT Offer Letter - Fall
    • Labels:
      None
    • Company:
      All Clients/Multiple Clients

      Description

      Get document template list API details

       GET : /api/documentTemplates/{sourceProduct}

      GET : /api/documentTemplates/{sourceProduct}/{templateType}

      API there is no check for user id to show only those templates which were created by same user.  Also no check for archived & deleted templates.

       

      Shamooka Mohapatra

        Attachments

        1. Pre-prod_1705.jpg
          Pre-prod_1705.jpg
          161 kB
        2. Prod_1705.jpg
          Prod_1705.jpg
          173 kB
        3. Screenshot (115).png
          Screenshot (115).png
          147 kB
        4. Screenshot (116).png
          Screenshot (116).png
          152 kB
        5. Screenshot (117).png
          Screenshot (117).png
          151 kB
        6. Screenshot (99).png
          Screenshot (99).png
          142 kB
        7. Screenshot (99).png
          Screenshot (99).png
          142 kB

          Activity

          samir Samir created issue -
          samir Samir made changes -
          Field Original Value New Value
          Assignee Samir [ samir ] Ramya Tantry [ ramya.tantry ]
          samir Samir made changes -
          Fix Version/s CBAT Offer Letter - Fall [ 10607 ]
          samir Samir made changes -
          Sprint DMS - Fall Sprint 8 [ 167 ]
          samir Samir made changes -
          Remaining Estimate 8h [ 28800 ]
          Original Estimate 8h [ 28800 ]
          samir Samir made changes -
          Description Get document template list API details

           GET : /api/documentTemplates/\{sourceProduct}

          GET : /api/documentTemplates/\{sourceProduct}/\{templateType}

          API there is no check for user id to show only those templates which were created by same user.  Also no check for archived & deleted templates.
          Get document template list API details

           GET : /api/documentTemplates/\{sourceProduct}

          GET : /api/documentTemplates/\{sourceProduct}/\{templateType}

          API there is no check for user id to show only those templates which were created by same user.  Also no check for archived & deleted templates.

           

          [~Shamooka.Mohapatra]
          ramya.tantry Ramya Tantry (Inactive) made changes -
          Status To Do [ 10000 ] In Progress [ 3 ]
          ramya.tantry Ramya Tantry (Inactive) logged work - 01/Aug/19 05:27 AM
          • Time Spent:
            4h
             

            Discussion with Rohan

            Code changes

            Testing

          ramya.tantry Ramya Tantry (Inactive) made changes -
          Remaining Estimate 8h [ 28800 ] 4h [ 14400 ]
          Time Spent 4h [ 14400 ]
          Worklog Id 192714 [ 192714 ]
          Hide
          ramya.tantry Ramya Tantry (Inactive) added a comment -

          Files Affected :

          1. DMS\DMS.App\src\DMS_AppLogic\IntegrationLogic\GenerateDocument.cs
          2. DMS\DMS.App\src\DMS_WebApi\Controllers\IntegrationAPI\GenerateDocumentController.cs
          3. DMS\DMS.App\src\DMS_WebApi\Controllers\IntegrationAPI\SwaggerStubController.cs
          4. DMS\DMS.App\src\Entities\IntegrationDtos\DocumentDetailsDTO.cs
          5. DMS\DMS_App_Tests\GenerateDocumentControllerTest.cs

          Implementation done

          • Added check for user id to show only those templates which were created by same(logged in) user.
          • Also added check for archived & deleted template.
          Show
          ramya.tantry Ramya Tantry (Inactive) added a comment - Files Affected : DMS\DMS.App\src\DMS_AppLogic\IntegrationLogic\GenerateDocument.cs DMS\DMS.App\src\DMS_WebApi\Controllers\IntegrationAPI\GenerateDocumentController.cs DMS\DMS.App\src\DMS_WebApi\Controllers\IntegrationAPI\SwaggerStubController.cs DMS\DMS.App\src\Entities\IntegrationDtos\DocumentDetailsDTO.cs DMS\DMS_App_Tests\GenerateDocumentControllerTest.cs Implementation done Added check for user id to show only those templates which were created by same(logged in) user. Also added check for archived & deleted template.
          ramya.tantry Ramya Tantry (Inactive) logged work - 01/Aug/19 10:47 PM
          • Time Spent:
            2h
             

            Unit testing
            Create PR
            Draft comment

          ramya.tantry Ramya Tantry (Inactive) made changes -
          Remaining Estimate 4h [ 14400 ] 2h [ 7200 ]
          Time Spent 4h [ 14400 ] 6h [ 21600 ]
          Worklog Id 192917 [ 192917 ]
          ramya.tantry Ramya Tantry (Inactive) made changes -
          Status In Progress [ 3 ] In QA Testing [ 11901 ]
          ramya.tantry Ramya Tantry (Inactive) made changes -
          Status In QA Testing [ 11901 ] Code Review [ 11801 ]
          ramya.tantry Ramya Tantry (Inactive) made changes -
          Assignee Ramya Tantry [ ramya.tantry ] Harshveer Singh [ harshveer.singh ]
          shashikant.mishra ShashiKant Mishra (Inactive) made changes -
          Sprint DMS - Fall Sprint 8 [ 167 ] DMS - Fall Sprint 8, DMS - Gap Fall & Win Sprint 1 [ 167, 173 ]
          Raj.Hawaldar Raj Hawaldar (Inactive) made changes -
          Assignee Harshveer Singh [ harshveer.singh ] Priya Dhamande [ priya.dhamande ]
          Raj.Hawaldar Raj Hawaldar (Inactive) made changes -
          Status Code Review [ 11801 ] In QA Testing [ 11901 ]
          ramya.tantry Ramya Tantry (Inactive) made changes -
          Attachment Pre-prod_1705.jpg [ 115552 ]
          ramya.tantry Ramya Tantry (Inactive) logged work - 06/Aug/19 02:40 AM
          • Time Spent:
            0.5h
             

            Discussion with Samir and Testing on preprod

          Hide
          ramya.tantry Ramya Tantry (Inactive) added a comment - - edited

          Verified API and its count on Pre-prod.

           

          Verified API and its count on Prod.

          Show
          ramya.tantry Ramya Tantry (Inactive) added a comment - - edited Verified API and its count on Pre-prod.   Verified API and its count on Prod.
          ramya.tantry Ramya Tantry (Inactive) made changes -
          Remaining Estimate 2h [ 7200 ] 1.5h [ 5400 ]
          Time Spent 6h [ 21600 ] 6.5h [ 23400 ]
          Worklog Id 193379 [ 193379 ]
          ramya.tantry Ramya Tantry (Inactive) made changes -
          Attachment Prod_1705.jpg [ 115553 ]
          priya.dhamande Priya Dhamande (Inactive) made changes -
          Attachment Screenshot (99).png [ 115558 ]
          priya.dhamande Priya Dhamande (Inactive) made changes -
          Attachment Screenshot (99).png [ 115569 ]
          priya.dhamande Priya Dhamande (Inactive) logged work - 06/Aug/19 04:44 AM
          • Time Spent:
            1h
             

            Testing on Pre and prod
            Discussion

          Hide
          priya.dhamande Priya Dhamande (Inactive) added a comment -

          Environment: Production - OneIM
          API: /api/documentTemplates/CBATS
          /api/documentTemplates/CBATS/Compliance

          Points covered:
          1. With Source product
          2. With Source Product and Template Type
          3. If Template with mentioned Template type doesnot exits

          Scenarios worked as expected, Screen captures attached.

          So, marking jira done on Production.

          Sachin Hingole Hrishikesh Deshpande Samir Rohan J Khandave

          Show
          priya.dhamande Priya Dhamande (Inactive) added a comment - Environment: Production - OneIM API: /api/documentTemplates/CBATS /api/documentTemplates/CBATS/Compliance Points covered: 1. With Source product 2. With Source Product and Template Type 3. If Template with mentioned Template type doesnot exits Scenarios worked as expected, Screen captures attached. So, marking jira done on Production. Sachin Hingole Hrishikesh Deshpande Samir Rohan J Khandave
          priya.dhamande Priya Dhamande (Inactive) made changes -
          Resolution Done [ 10000 ]
          Status In QA Testing [ 11901 ] Done [ 10001 ]
          priya.dhamande Priya Dhamande (Inactive) made changes -
          Attachment Screenshot (115).png [ 115570 ]
          Attachment Screenshot (117).png [ 115571 ]
          Attachment Screenshot (116).png [ 115572 ]
          priya.dhamande Priya Dhamande (Inactive) made changes -
          Remaining Estimate 1.5h [ 5400 ] 0.5h [ 1800 ]
          Time Spent 6.5h [ 23400 ] 7.5h [ 27000 ]
          Worklog Id 193402 [ 193402 ]
          Raj.Hawaldar Raj Hawaldar (Inactive) made changes -
          Status Done [ 10001 ] In QA Testing [ 11901 ]
          priya.dhamande Priya Dhamande (Inactive) made changes -
          Status In QA Testing [ 11901 ] Done [ 10001 ]
          Transition Time In Source Status Execution Times
          Ramya Tantry (Inactive) made transition -
          To Do In Progress
          1h 55m 1
          Ramya Tantry (Inactive) made transition -
          In Progress In QA Testing
          22h 8m 1
          Ramya Tantry (Inactive) made transition -
          In QA Testing Code Review
          2s 1
          Raj Hawaldar (Inactive) made transition -
          Code Review In QA Testing
          4d 3h 36m 1
          Raj Hawaldar (Inactive) made transition -
          Done In QA Testing
          21d 18h 33m 1
          Priya Dhamande (Inactive) made transition -
          In QA Testing Done
          22d 8h 9m 2

            People

            Assignee:
            priya.dhamande Priya Dhamande (Inactive)
            Reporter:
            samir Samir
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 8h
                8h
                Remaining:
                Time Spent - 7.5h Remaining Estimate - 0.5h
                0.5h
                Logged:
                Time Spent - 7.5h Remaining Estimate - 0.5h
                7.5h