[DMS-1718] CBAT : Add check for active candidate - Workterra Jira

Details

Type: Sub-task
Status: Done
Priority: Medium
Resolution: Done
Affects Version/s: None
Fix Version/s: Enhancements - Fall
Labels:
None

Company:
All Clients/Multiple Clients

Sprint:
DMS - Gap Fall & Win Sprint 1, DMS - Gap Fall & Win Sprint 2, DMS - Gap Fall & Win Sprint 3, DMS - Gap Fall & Win Sprint 4
QA Estimates:
1

Description

We have a new API to delete a candidate profile. which soft deletes the candidate from the DMS system.

We have attached the list of affected areas into parent Jira ~~DMS-1696~~.

We need a check for person deletion at this points into the system.

Samir Rohan J Khandave

Akash Thakur (Inactive) created issue - 01/Aug/19 11:16 PM

Akash Thakur (Inactive) made changes - 01/Aug/19 11:16 PM

Field	Original Value	New Value
Link		This issue relates to ~~DMS-1689~~ [ ~~DMS-1689~~ ]

Rohan J Khandave (Inactive) made changes - 01/Aug/19 11:19 PM

Summary

CBAT Support task changes in logic for delete candidate profile API

CBAT : Support task changes in logic for delete candidate profile API

Rohan J Khandave (Inactive) made changes - 01/Aug/19 11:20 PM

Summary

CBAT : Support task changes in logic for delete candidate profile API

CBAT : Add check for active candidate

Rohan J Khandave (Inactive) made changes - 01/Aug/19 11:21 PM

Link

This issue relates to ~~DMS-1689~~ [ ~~DMS-1689~~ ]

Ramya Tantry (Inactive) made changes - 01/Aug/19 11:52 PM

Status

To Do [ 10000 ]

In Progress [ 3 ]

Ramya Tantry (Inactive) made changes - 01/Aug/19 11:52 PM

Description

We have a new API to delete a candidate profile. which soft deletes the candidate from the DMS system.

We have attached the list of affected areas into parent Jira ~~DMS-1689~~.

We need a check for person deletion at this points into the system.

[~samir] [~rohan.khandave]

We have a new API to delete a candidate profile. which soft deletes the candidate from the DMS system.

We have attached the list of affected areas into parent Jira ~~DMS-1696~~.

We need a check for person deletion at this points into the system.

[~samir] [~rohan.khandave]

Hide

Permalink

Ramya Tantry (Inactive) added a comment - 02/Aug/19 05:21 AM - edited

Affected Areas identified with ~~DMS-1696~~

/api/documents/ {documentTemplateId}/{personId}/send
/api/documents/sendBulk
/api/candidate/document/create
/api/candidate/custom/document/create
VerifyUserCompanyMapping (send forms)
CheckUserLogin
GetCandidateSearchDetails
GetAssignedFormDetails
GetPersonIdFromEmail
GetPersonIdFromPersonIdentity
IsPersonDataInconsistent
GetSourceUserIDFromEmail
GetUserDetails
GetUserData (setUserPermission)
GetUserTypeFromUserId
/api/document/ {personID}/{templateID}/preview
/api/userRolesPermissions/ {userDid}
/api/documents/ {sourceProductId}/person/{id}/LatestStatus
/api/documents/{sourceProductId}/person/{id}/statusHistory
/api/documents/ {sourceProduct}/statusSummary
/api/documents/send
api/candidateProfile/{emailAddress}/{sourceProduct}/{documentId}
/api/user/{userDid}
HttpPut("/api/user")

Show

Ramya Tantry (Inactive) added a comment - 02/Aug/19 05:21 AM - edited Affected Areas identified with DMS-1696 /api/documents/ {documentTemplateId}/{personId}/send /api/documents/sendBulk /api/candidate/document/create /api/candidate/custom/document/create VerifyUserCompanyMapping (send forms) CheckUserLogin GetCandidateSearchDetails GetAssignedFormDetails GetPersonIdFromEmail GetPersonIdFromPersonIdentity IsPersonDataInconsistent GetSourceUserIDFromEmail GetUserDetails GetUserData (setUserPermission) GetUserTypeFromUserId /api/document/ {personID}/{templateID}/preview /api/userRolesPermissions/ {userDid} /api/documents/ {sourceProductId}/person/{id}/LatestStatus /api/documents/{sourceProductId}/person/{id}/statusHistory /api/documents/ {sourceProduct}/statusSummary /api/documents/send api/candidateProfile/{emailAddress}/{sourceProduct}/{documentId} /api/user/{userDid} HttpPut("/api/user")

Permalink

Ramya Tantry (Inactive) logged work - 02/Aug/19 05:24 AM

Time Spent:

4.5h

Analysis

Discussion with Akash and Rohan

Code changes

Ramya Tantry (Inactive) made changes - 02/Aug/19 05:26 AM

Remaining Estimate	20h [ 72000 ]	15.5h [ 55800 ]
Time Spent		4.5h [ 16200 ]
Worklog Id	192999 [ 192999 ]

Hide

Permalink

Ramya Tantry (Inactive) added a comment - 05/Aug/19 12:38 AM

Below Email related areas to be considered for isdeleted check for person/user while adding/fetching in the system :

saveSendFormDetails
GetSecretquestionsForUser
CheckedEmailIsExists
IsPersonDataInconsistent
GetPersonInfo
Update (candidateprofile)
GenerateUser
DMS_SP_GetTemplateFormMappedDetails

Adding 8 hours to the original estimate for email code changes and verification

CC:Rohan J Khandave

Show

Ramya Tantry (Inactive) added a comment - 05/Aug/19 12:38 AM Below Email related areas to be considered for isdeleted check for person/user while adding/fetching in the system : saveSendFormDetails GetSecretquestionsForUser CheckedEmailIsExists IsPersonDataInconsistent GetPersonInfo Update (candidateprofile) GenerateUser DMS_SP_GetTemplateFormMappedDetails Adding 8 hours to the original estimate for email code changes and verification CC: Rohan J Khandave

Ramya Tantry (Inactive) made changes - 05/Aug/19 12:38 AM

Remaining Estimate	15.5h [ 55800 ]	23.5h [ 84600 ]
Original Estimate	20h [ 72000 ]	28h [ 100800 ]

Permalink

Ramya Tantry (Inactive) logged work - 05/Aug/19 03:12 AM

Time Spent:

5h

Code changes

Testing

Ramya Tantry (Inactive) made changes - 05/Aug/19 03:13 AM

Remaining Estimate	23.5h [ 84600 ]	18.5h [ 66600 ]
Time Spent	4.5h [ 16200 ]	9.5h [ 34200 ]
Worklog Id	193187 [ 193187 ]

Permalink

Ramya Tantry (Inactive) logged work - 06/Aug/19 05:51 AM

Time Spent:

7h

Code changes
Unit testing

Ramya Tantry (Inactive) made changes - 06/Aug/19 05:52 AM

Remaining Estimate	18.5h [ 66600 ]	11.5h [ 41400 ]
Time Spent	9.5h [ 34200 ]	16.5h [ 59400 ]
Worklog Id	193429 [ 193429 ]

Permalink

Ramya Tantry (Inactive) logged work - 07/Aug/19 05:58 AM

Time Spent:

7h

Code changes
Testing

Ramya Tantry (Inactive) made changes - 07/Aug/19 05:58 AM

Remaining Estimate	11.5h [ 41400 ]	4.5h [ 16200 ]
Time Spent	16.5h [ 59400 ]	23.5h [ 84600 ]
Worklog Id	193690 [ 193690 ]

Ramya Tantry (Inactive) made changes - 07/Aug/19 09:02 PM

Attachment

ImpactAreasAndScenariosTested.xls [ 115811 ]

Hide

Permalink

Ramya Tantry (Inactive) added a comment - 07/Aug/19 09:35 PM - edited

As discussed with Samir, Updating ETA to incorporate camelcase changes.

Show

Ramya Tantry (Inactive) added a comment - 07/Aug/19 09:35 PM - edited As discussed with Samir, Updating ETA to incorporate camelcase changes.

Ramya Tantry (Inactive) made changes - 07/Aug/19 09:35 PM

Remaining Estimate	4.5h [ 16200 ]	10.5h [ 37800 ]
Original Estimate	28h [ 100800 ]	38h [ 136800 ]

Ramya Tantry (Inactive) made changes - 07/Aug/19 09:36 PM

Original Estimate

38h [ 136800 ]

34h [ 122400 ]

Ramya Tantry (Inactive) made changes - 08/Aug/19 05:17 AM

Attachment

ImpactAreasAndScenariosTested.xls [ 115811 ]

Ramya Tantry (Inactive) made changes - 08/Aug/19 05:18 AM

Attachment

ImpactAreasAndScenariosTested.xls [ 115857 ]

Permalink

Ramya Tantry (Inactive) logged work - 08/Aug/19 05:23 AM - edited

Time Spent:

6.5h

Code changes

Unit testing

discussion

Hide

Permalink

Ramya Tantry (Inactive) added a comment - 08/Aug/19 05:23 AM

Impact Areas and Scenarios mentioned in ImpactAreasAndScenariosTested.xls.

Files Affected:

DMS\Databases Objects\04_Stored Procedures\DMS_SP_GetTemplateFormMappedDetails.sql
DMS\Databases Objects\04_Stored Procedures\DMS_SP_GetUserDetails.sql
DMS\Databases Objects\04_Stored Procedures\Get_DocumentHistoryData.sql
DMS\DMS.App\src\DMS_AppLogic\BuisnessLogic\CandidateData.cs
DMS\DMS.App\src\DMS_AppLogic\BuisnessLogic\DocumentData.cs
DMS\DMS.App\src\DMS_AppLogic\BuisnessLogic\PersonData.cs
DMS\DMS.App\src\DMS_AppLogic\BuisnessLogic\UserData.cs
DMS\DMS.App\src\DMS_AppLogic\CommonRoutines\CommonRoutines.cs
DMS\DMS.App\src\DMS_AppLogic\CommonRoutines\Person.cs
DMS\DMS.App\src\DMS_AppLogic\IntegrationLogic\CandidateProfile.cs
DMS\DMS.App\src\DMS_AppLogic\IntegrationLogic\GenerateDocument.cs
DMS\DMS.App\src\DMS_AppLogic\IntegrationLogic\ProvisioningApiLogic.cs
DMS\DMS.App\src\DMS_WebApi\Controllers\IntegrationAPI\GenerateDocumentController.cs
DMS\DMS.Web\src\DMS_WebApp\ClientApp\src\app\Integration\BasicIntegration\BasicIntegration\BasicIntegration.component.ts

Note: As impact areas are spread over system, Regression testing needs to be done with deleted candidate/user scenarios.

Show

Ramya Tantry (Inactive) added a comment - 08/Aug/19 05:23 AM Impact Areas and Scenarios mentioned in ImpactAreasAndScenariosTested.xls . Files Affected: DMS\Databases Objects\04_Stored Procedures\DMS_SP_GetTemplateFormMappedDetails.sql DMS\Databases Objects\04_Stored Procedures\DMS_SP_GetUserDetails.sql DMS\Databases Objects\04_Stored Procedures\Get_DocumentHistoryData.sql DMS\DMS.App\src\DMS_AppLogic\BuisnessLogic\CandidateData.cs DMS\DMS.App\src\DMS_AppLogic\BuisnessLogic\DocumentData.cs DMS\DMS.App\src\DMS_AppLogic\BuisnessLogic\PersonData.cs DMS\DMS.App\src\DMS_AppLogic\BuisnessLogic\UserData.cs DMS\DMS.App\src\DMS_AppLogic\CommonRoutines\CommonRoutines.cs DMS\DMS.App\src\DMS_AppLogic\CommonRoutines\Person.cs DMS\DMS.App\src\DMS_AppLogic\IntegrationLogic\CandidateProfile.cs DMS\DMS.App\src\DMS_AppLogic\IntegrationLogic\GenerateDocument.cs DMS\DMS.App\src\DMS_AppLogic\IntegrationLogic\ProvisioningApiLogic.cs DMS\DMS.App\src\DMS_WebApi\Controllers\IntegrationAPI\GenerateDocumentController.cs DMS\DMS.Web\src\DMS_WebApp\ClientApp\src\app\Integration\BasicIntegration\BasicIntegration\BasicIntegration.component.ts Note : As impact areas are spread over system, Regression testing needs to be done with deleted candidate/user scenarios.

Ramya Tantry (Inactive) made changes - 08/Aug/19 05:23 AM

Status

In Progress [ 3 ]

Code Review [ 11801 ]

Ramya Tantry (Inactive) made changes - 08/Aug/19 05:23 AM

Assignee

Ramya Tantry [ ramya.tantry ]

Harshveer Singh [ harshveer.singh ]

Ramya Tantry (Inactive) made changes - 08/Aug/19 05:24 AM

Remaining Estimate	10.5h [ 37800 ]	4.5h [ 16200 ]
Time Spent	23.5h [ 84600 ]	29.5h [ 106200 ]
Worklog Id	193883 [ 193883 ]

Ramya Tantry (Inactive) made changes - 08/Aug/19 05:26 AM

Remaining Estimate	4.5h [ 16200 ]	4h [ 14400 ]
Time Spent	29.5h [ 106200 ]	30h [ 108000 ]
Worklog Id	193883 [ 193883 ]

Raj Hawaldar (Inactive) made changes - 11/Aug/19 11:38 PM

Status

Code Review [ 11801 ]

In QA Testing [ 11901 ]

Raj Hawaldar (Inactive) made changes - 11/Aug/19 11:40 PM

Assignee

Harshveer Singh [ harshveer.singh ]

Priya Dhamande [ priya.dhamande ]

Raj Hawaldar (Inactive) made changes - 27/Aug/19 11:18 PM

Status

In QA Testing [ 11901 ]

Priya Dhamande (Inactive) made changes - 16/Sep/19 02:45 AM

QA Estimates

Priya Dhamande (Inactive) made changes - 16/Sep/19 04:39 AM

Remaining Estimate

4h [ 14400 ]

5h [ 18000 ]

Hide

Permalink

Priya Dhamande (Inactive) added a comment - 19/Sep/19 10:20 PM

mentioned API's are verified during BAT are working as expected.

So, marking jira done.

Samir Rohan J Khandave Ramya Tantry

Show

Priya Dhamande (Inactive) added a comment - 19/Sep/19 10:20 PM mentioned API's are verified during BAT are working as expected. So, marking jira done. Samir Rohan J Khandave Ramya Tantry

Priya Dhamande (Inactive) made changes - 19/Sep/19 10:20 PM

Resolution		Done [ 10000 ]
Status	In QA Testing [ 11901 ]	Done [ 10001 ]

Priya Dhamande (Inactive) made changes - 19/Sep/19 10:20 PM

Assignee

Priya Dhamande [ priya.dhamande ]

Ramya Tantry [ ramya.tantry ]

Transition	Time In Source Status	Execution Times

Ramya Tantry (Inactive) made transition - 01/Aug/19 11:52 PM

To Do

In Progress

35m 37s

Ramya Tantry (Inactive) made transition - 08/Aug/19 05:23 AM

In Progress

Code Review

6d 5h 31m

Raj Hawaldar (Inactive) made transition - 11/Aug/19 11:38 PM

Code Review

In QA Testing

3d 18h 15m

Raj Hawaldar (Inactive) made transition - 27/Aug/19 11:18 PM

In QA Testing

15d 23h 39m

Priya Dhamande (Inactive) made transition - 19/Sep/19 10:20 PM

In QA Testing

Done

22d 23h 2m

People

Assignee:: Ramya Tantry (Inactive)

Reporter:: Akash Thakur (Inactive)

Developer:: Ramya Tantry (Inactive)

Votes:: 0 Vote for this issue

Watchers:: 3 Start watching this issue

Dates

Created:: 01/Aug/19 11:16 PM

Updated:: 19/Sep/19 10:20 PM

Resolved:: 19/Sep/19 10:20 PM

Time Tracking

Estimated:

34h

Remaining:

Logged:

30h

Details

Description

Attachments

Attachments

Activity

People

Dates

Time Tracking