Uploaded image for project: 'Document Management System'
  1. Document Management System
  2. DMS-1757

Document Preview: Show document data when document get sent

    Details

    • Type: New Feature
    • Status: Done
    • Priority: Medium
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: CBAT Offer Letter - Fall
    • Labels:
      None
    • Company:
      All Clients/Multiple Clients

      Description

      Document Preview: Show document data when document get sent

      CC-Samir,Rohan J Khandave

        Attachments

          Activity

          Ganesh.sadawarte Ganesh Sadawarte (Inactive) created issue -
          Ganesh.sadawarte Ganesh Sadawarte (Inactive) made changes -
          Field Original Value New Value
          Status To Do [ 10000 ] In Progress [ 3 ]
          Hide
          Ganesh.sadawarte Ganesh Sadawarte (Inactive) added a comment - - edited

          Hi Samir,

          Please find below details.

          Current Implementation:

          • On sent form preview will save mapped field data to database.
          • On review and sign page will update data for mapped to database and non mapped fields & JSON attribute along with mapped fields.

          Questions:

          • If we are showing data of document when it was sent. So should we considered this in all places like.
            • DMS preview after completing document by candidate[Admin and Candidate]
            • DMS download completed forms.
            • Integration API Viewer screen
            • Integration API Preview.
            • Integration API Download [CBAT & CBES].
            • Embedded UI.
            • Document completion email thumbnail.
          • If we are implementing this in all place, then when latest data get shown.

          Samir Please provide details on above so we will proceed further.

          CC-Rohan J Khandave,Priya Dhamande

          Thanks,
          Ganesh

          Show
          Ganesh.sadawarte Ganesh Sadawarte (Inactive) added a comment - - edited Hi Samir , Please find below details. Current Implementation: On sent form preview will save mapped field data to database. On review and sign page will update data for mapped to database and non mapped fields & JSON attribute along with mapped fields. Questions: If we are showing data of document when it was sent. So should we considered this in all places like. DMS preview after completing document by candidate [Admin and Candidate] DMS download completed forms. Integration API Viewer screen Integration API Preview. Integration API Download [CBAT & CBES] . Embedded UI. Document completion email thumbnail. If we are implementing this in all place, then when latest data get shown. Samir Please provide details on above so we will proceed further. CC- Rohan J Khandave , Priya Dhamande Thanks, Ganesh
          Ganesh.sadawarte Ganesh Sadawarte (Inactive) made changes -
          Remaining Estimate 24h [ 86400 ] 19.5h [ 70200 ]
          Time Spent 4.5h [ 16200 ]
          Worklog Id 194442 [ 194442 ]
          Ganesh.sadawarte Ganesh Sadawarte (Inactive) logged work - 12/Aug/19 06:19 PM
          • Time Spent:
            4.5h
             
            • Call with Samir for Requirement
            • Analysis & Discussion rohan
            • Checked current implementation.
            • Identified impacted areas for
            • Jira update with details.
          Ganesh.sadawarte Ganesh Sadawarte (Inactive) made changes -
          Assignee Ganesh Sadawarte [ ganesh.sadawarte ] Ramya Tantry [ ramya.tantry ]
          Hide
          Ganesh.sadawarte Ganesh Sadawarte (Inactive) added a comment - - edited

          Adding scenario to on above if JSON attribute not present then will show the data from database.

          CC-Rohan J Khandave,Samir

          Show
          Ganesh.sadawarte Ganesh Sadawarte (Inactive) added a comment - - edited Adding scenario to on above if JSON attribute not present then will show the data from database. CC- Rohan J Khandave , Samir
          ramya.tantry Ramya Tantry (Inactive) made changes -
          Attachment DMS-1757.doc [ 116216 ]
          Hide
          ramya.tantry Ramya Tantry (Inactive) added a comment -

          Hi Samir, Harshveer Singh,

          Please review DMS-1757.doc document and let me know in case of any changes.

          CC: Rohan J Khandave,Ganesh Sadawarte,Priya Dhamande

          Show
          ramya.tantry Ramya Tantry (Inactive) added a comment - Hi Samir , Harshveer Singh , Please review  DMS-1757.doc  document and let me know in case of any changes. CC: Rohan J Khandave , Ganesh Sadawarte , Priya Dhamande
          ramya.tantry Ramya Tantry (Inactive) made changes -
          Developer Ganesh Sadawarte [ ganesh.sadawarte ] Ramya Tantry [ ramya.tantry ]
          Remaining Estimate 19.5h [ 70200 ] 25.5h [ 91800 ]
          Original Estimate 24h [ 86400 ] 30h [ 108000 ]
          ramya.tantry Ramya Tantry (Inactive) logged work - 13/Aug/19 05:39 AM
          • Time Spent:
            5h
             

            Analysis

            Document creation

            Code changes

          ramya.tantry Ramya Tantry (Inactive) made changes -
          Remaining Estimate 25.5h [ 91800 ] 20.5h [ 73800 ]
          Time Spent 4.5h [ 16200 ] 9.5h [ 34200 ]
          Worklog Id 194682 [ 194682 ]
          ramya.tantry Ramya Tantry (Inactive) logged work - 14/Aug/19 05:44 AM
          • Time Spent:
            7h
             

            Code changes

            Testing

             

          ramya.tantry Ramya Tantry (Inactive) made changes -
          Remaining Estimate 20.5h [ 73800 ] 13.5h [ 48600 ]
          Time Spent 9.5h [ 34200 ] 16.5h [ 59400 ]
          Worklog Id 194891 [ 194891 ]
          ramya.tantry Ramya Tantry (Inactive) logged work - 16/Aug/19 05:22 AM
          • Time Spent:
            6h
             

            Code changes

            Unit testing

             

          ramya.tantry Ramya Tantry (Inactive) made changes -
          Remaining Estimate 13.5h [ 48600 ] 7.5h [ 27000 ]
          Time Spent 16.5h [ 59400 ] 22.5h [ 81000 ]
          Worklog Id 195219 [ 195219 ]
          shashikant.mishra ShashiKant Mishra (Inactive) made changes -
          Sprint DMS - Gap Fall & Win Sprint 1 [ 173 ] DMS - Gap Fall & Win Sprint 1, DMS - Gap Fall & Win Sprint 2 [ 173, 174 ]
          Hide
          ramya.tantry Ramya Tantry (Inactive) added a comment -

          Implementation details :
          1. Document when sent through Send forms from UI, all form data will be saved as JSON against that document.
          2. When document is opened by candidate,data will be populated from saved JSON. On Submit or decline, form data (JSON) will be updated for that document.
          3. Document when sent through Custom API's by Admin (senddocument as 0,1,2), form data is not saved in this case. When candidate opens the link, latest data from DB will get populated on PDF. Data will be saved once candidate clicks on Submit or decline.
          4. Form data will be saved when document is saved by Admin when it is sent from Custom API with senddocument as 3 and same will be populated when candidates opens the document.
          5. Signature will always be fetched from DB. 

          Basic Scenarios:
          1. Send document from Send forms -> Candidate opens the document -> Candidate Declines -> Admin changes the document and send through send form -> Candidate accepts
          When document is opened/downloaded from Review/Sign or Completed Forms Library, data of that particular document will be downloaded.
           2. Document sent with Custom API's (api/candidate/custom/document/create and api/candidate/document/create) 
          When senddocument = 0,1,2 => DB data will be fetched when candidate opens the document
          When senddocument = 3 => Admin opens the link to make changes ->changes saved -> data is saved against that document -> candidate opens document -> recently saved data will be displayed.

          Files Affected :

          1. DMS\Databases Objects\04_Stored Procedures\DMS_SP_GetTemplateFormMappedDetails.sql
          2. DMS\DMS.App\src\DMS_AppLogic\BuisnessLogic\DocumentData.cs
          3. DMS\DMS.App\src\DMS_AppLogic\BuisnessLogic\PersonData.cs
          4. DMS\DMS.App\src\DMS_AppLogic\IntegrationLogic\GenerateDocument.cs
          5. DMS\DMS.Web\src\DMS_WebApp\ClientApp\src\app\admin\send-forms\forms-preview\forms-preview.component.ts
          6. DMS\DMS.Web\src\DMS_WebApp\ClientApp\src\app\candidate\document-review\document-review.component.ts
          7. DMS\DMS.Web\src\DMS_WebApp\ClientApp\src\app\Shared\Components\modals\modals.component.ts

           

          Show
          ramya.tantry Ramya Tantry (Inactive) added a comment - Implementation details : 1. Document when sent through Send forms from UI, all form data will be saved as JSON against that document. 2. When document is opened by candidate,data will be populated from saved JSON. On Submit or decline, form data (JSON) will be updated for that document. 3. Document when sent through Custom API's by Admin (senddocument as 0,1,2), form data is not saved in this case. When candidate opens the link, latest data from DB will get populated on PDF. Data will be saved once candidate clicks on Submit or decline. 4. Form data will be saved when document is saved by Admin when it is sent from Custom API with senddocument as 3 and same will be populated when candidates opens the document. 5. Signature will always be fetched from DB.  Basic Scenarios: 1. Send document from Send forms -> Candidate opens the document -> Candidate Declines -> Admin changes the document and send through send form -> Candidate accepts When document is opened/downloaded from Review/Sign or Completed Forms Library, data of that particular document will be downloaded.  2. Document sent with Custom API's (api/candidate/custom/document/create and api/candidate/document/create)  When senddocument = 0,1,2 => DB data will be fetched when candidate opens the document When senddocument = 3 => Admin opens the link to make changes ->changes saved -> data is saved against that document -> candidate opens document -> recently saved data will be displayed. Files Affected : DMS\Databases Objects\04_Stored Procedures\DMS_SP_GetTemplateFormMappedDetails.sql DMS\DMS.App\src\DMS_AppLogic\BuisnessLogic\DocumentData.cs DMS\DMS.App\src\DMS_AppLogic\BuisnessLogic\PersonData.cs DMS\DMS.App\src\DMS_AppLogic\IntegrationLogic\GenerateDocument.cs DMS\DMS.Web\src\DMS_WebApp\ClientApp\src\app\admin\send-forms\forms-preview\forms-preview.component.ts DMS\DMS.Web\src\DMS_WebApp\ClientApp\src\app\candidate\document-review\document-review.component.ts DMS\DMS.Web\src\DMS_WebApp\ClientApp\src\app\Shared\Components\modals\modals.component.ts  
          ramya.tantry Ramya Tantry (Inactive) logged work - 19/Aug/19 03:46 AM
          • Time Spent:
            6h
             

            Unit testing

            Draft reply

            create PR

          ramya.tantry Ramya Tantry (Inactive) made changes -
          Status In Progress [ 3 ] Code Review [ 11801 ]
          ramya.tantry Ramya Tantry (Inactive) made changes -
          Assignee Ramya Tantry [ ramya.tantry ] Harshveer Singh [ harshveer.singh ]
          ramya.tantry Ramya Tantry (Inactive) made changes -
          Remaining Estimate 7.5h [ 27000 ] 1.5h [ 5400 ]
          Time Spent 22.5h [ 81000 ] 28.5h [ 102600 ]
          Worklog Id 195464 [ 195464 ]
          Raj.Hawaldar Raj Hawaldar (Inactive) made changes -
          Status Code Review [ 11801 ] In QA Testing [ 11901 ]
          Raj.Hawaldar Raj Hawaldar (Inactive) made changes -
          Assignee Harshveer Singh [ harshveer.singh ] Priya Dhamande [ priya.dhamande ]
          Raj.Hawaldar Raj Hawaldar (Inactive) made changes -
          Status In QA Testing [ 11901 ] In QA Testing [ 11901 ]
          samir Samir made changes -
          Fix Version/s CBAT Offer Letter - Fall [ 10607 ]
          priya.dhamande Priya Dhamande (Inactive) logged work - 21/Aug/19 09:06 PM
          • Time Spent:
            3h
             

            Test Case writing
            discussion
            APi testing for Send documents

          priya.dhamande Priya Dhamande (Inactive) made changes -
          Resolution Done [ 10000 ]
          Status In QA Testing [ 11901 ] Done [ 10001 ]
          priya.dhamande Priya Dhamande (Inactive) made changes -
          Assignee Priya Dhamande [ priya.dhamande ] Ramya Tantry [ ramya.tantry ]
          priya.dhamande Priya Dhamande (Inactive) logged work - 22/Aug/19 09:08 PM
          • Time Spent:
            1.5h
             

            Pro testing for UI points

          priya.dhamande Priya Dhamande (Inactive) made changes -
          Remaining Estimate 1.5h [ 5400 ] 0h [ 0 ]
          Time Spent 28.5h [ 102600 ] 31.5h [ 113400 ]
          Worklog Id 196500 [ 196500 ]
          priya.dhamande Priya Dhamande (Inactive) made changes -
          Time Spent 31.5h [ 113400 ] 33h [ 118800 ]
          Worklog Id 196501 [ 196501 ]
          priya.dhamande Priya Dhamande (Inactive) made changes -
          Status Done [ 10001 ] Done [ 10001 ]
          Hide
          priya.dhamande Priya Dhamande (Inactive) added a comment -

          Environment: production
          login: Admin and Candidate
          Browser: FF and Chrome

          Points covered:

          1. Able to send document to different candidate with different data
          2. Different candidate should reflect data as per added by Admin on Completed Sent Forms Library
          3. Data updated by Admin should be saved
          4. Checked Candidate 1 for its respective data
          5. Checked Candidate 2 for its respective data
          6. Two same document send to same candidate - latest saved
          7. Two different documents send to same candidate - latest saved
          8. Send documents 0, 1, 2 and 3 through API

          All scenarios worked as expected.

          So, marking jira done.

          Samir Rohan J Khandave Hrishikesh Deshpande Sachin Hingole Ramya Tantry

          Show
          priya.dhamande Priya Dhamande (Inactive) added a comment - Environment: production login: Admin and Candidate Browser: FF and Chrome Points covered: 1. Able to send document to different candidate with different data 2. Different candidate should reflect data as per added by Admin on Completed Sent Forms Library 3. Data updated by Admin should be saved 4. Checked Candidate 1 for its respective data 5. Checked Candidate 2 for its respective data 6. Two same document send to same candidate - latest saved 7. Two different documents send to same candidate - latest saved 8. Send documents 0, 1, 2 and 3 through API All scenarios worked as expected. So, marking jira done. Samir Rohan J Khandave Hrishikesh Deshpande Sachin Hingole Ramya Tantry
          Raj.Hawaldar Raj Hawaldar (Inactive) made changes -
          Status Done [ 10001 ] In QA Testing [ 11901 ]
          Raj.Hawaldar Raj Hawaldar (Inactive) made changes -
          Assignee Ramya Tantry [ ramya.tantry ] Priya Dhamande [ priya.dhamande ]
          priya.dhamande Priya Dhamande (Inactive) logged work - 29/Aug/19 11:47 PM - edited
          • Time Spent:
            2h
             

            Prod testing

          priya.dhamande Priya Dhamande (Inactive) made changes -
          Attachment Testcases -DMS-1757.xls [ 118083 ]
          priya.dhamande Priya Dhamande (Inactive) made changes -
          Status In QA Testing [ 11901 ] Done [ 10001 ]
          priya.dhamande Priya Dhamande (Inactive) made changes -
          Time Spent 33h [ 118800 ] 35h [ 126000 ]
          Worklog Id 197939 [ 197939 ]
          priya.dhamande Priya Dhamande (Inactive) made changes -
          Worklog Id 197939 [ 197939 ]
          Transition Time In Source Status Execution Times
          Ganesh Sadawarte (Inactive) made transition -
          To Do In Progress
          33m 45s 1
          Ramya Tantry (Inactive) made transition -
          In Progress Code Review
          7d 4h 1
          Raj Hawaldar (Inactive) made transition -
          Code Review In QA Testing
          19h 44m 1
          Raj Hawaldar (Inactive) made transition -
          In QA Testing In QA Testing
          22h 2m 1
          Priya Dhamande (Inactive) made transition -
          Done Done
          2m 27s 1
          Raj Hawaldar (Inactive) made transition -
          Done In QA Testing
          5d 2h 9m 1
          Priya Dhamande (Inactive) made transition -
          In QA Testing Done
          4d 2m 2

            People

            Assignee:
            priya.dhamande Priya Dhamande (Inactive)
            Reporter:
            Ganesh.sadawarte Ganesh Sadawarte (Inactive)
            Developer:
            Ramya Tantry (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 30h Original Estimate - 30h
                30h
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 35h
                35h