[DMS-1766] Template Type defaults to offer letter- no drop down - Workterra Jira

Details

Type: New Feature
Status: Done
Priority: High
Resolution: Done
Affects Version/s: None
Fix Version/s: CBAT Offer Letter - Fall
Labels:
None

Company:
All Clients/Multiple Clients

Description

As a recruiter, I don't want fields that provide no value and aren't used on the offer letter template so that I am not confused or overwhelmed by unnecessary fields

Entry: Open Add New Template

Acceptance Criteria:

Template Type defaults to offer letter- no drop down

Document source is removed

Template status of Active and Draft only- remove expired

Exit: Candidate can save template

Attachments

Activity

Ascending order - Click to sort in descending order

Samir created issue - 14/Aug/19 04:26 AM

Samir made changes - 14/Aug/19 04:26 AM

Field	Original Value	New Value
Assignee	Samir [ samir ]	Rohan J Khandave [ rohan.khandave ]

Akash Thakur (Inactive) made changes - 18/Aug/19 10:44 PM

Assignee

Rohan J Khandave [ rohan.khandave ]

Akash Thakur [ akash.thakur ]

Akash Thakur (Inactive) made changes - 18/Aug/19 10:45 PM

Status

To Do [ 10000 ]

In Progress [ 3 ]

Akash Thakur (Inactive) made changes - 19/Aug/19 01:53 AM

Developer		Akash Thakur [ akash.thakur ]
Remaining Estimate		14h [ 50400 ]
Original Estimate		14h [ 50400 ]

Rohan J Khandave (Inactive) made changes - 19/Aug/19 06:32 AM

Sprint

DMS - Gap Fall & Win Sprint 2 [ 174 ]

Permalink

Akash Thakur (Inactive) logged work - 19/Aug/19 09:30 PM

Time Spent:

7h

development

Akash Thakur (Inactive) made changes - 19/Aug/19 09:30 PM

Remaining Estimate	14h [ 50400 ]	7h [ 25200 ]
Time Spent		7h [ 25200 ]
Worklog Id	195668 [ 195668 ]

Akash Thakur (Inactive) made changes - 20/Aug/19 02:46 AM

Status

In Progress [ 3 ]

Code Review [ 11801 ]

Akash Thakur (Inactive) made changes - 20/Aug/19 03:13 AM

Assignee

Akash Thakur [ akash.thakur ]

Narendra Kumar [ narendra.kumar ]

Akash Thakur (Inactive) made changes - 20/Aug/19 04:24 AM

Status

Code Review [ 11801 ]

In Progress [ 3 ]

Akash Thakur (Inactive) made changes - 20/Aug/19 04:24 AM

Assignee

Narendra Kumar [ narendra.kumar ]

Akash Thakur [ akash.thakur ]

Permalink

Akash Thakur (Inactive) logged work - 20/Aug/19 09:05 PM

Time Spent:

7h

unit-testing & development points.

Akash Thakur (Inactive) made changes - 20/Aug/19 09:05 PM

Original Estimate

14h [ 50400 ]

18h [ 64800 ]

Akash Thakur (Inactive) made changes - 20/Aug/19 09:05 PM

Remaining Estimate	7h [ 25200 ]	0h [ 0 ]
Time Spent	7h [ 25200 ]	14h [ 50400 ]
Worklog Id	195925 [ 195925 ]

Akash Thakur (Inactive) made changes - 21/Aug/19 12:10 AM

Status

In Progress [ 3 ]

Code Review [ 11801 ]

Permalink

Akash Thakur (Inactive) logged work - 21/Aug/19 12:11 AM

Time Spent:

3h

code review and corrections & one round unit testing.

Akash Thakur (Inactive) made changes - 21/Aug/19 12:11 AM

Assignee

Akash Thakur [ akash.thakur ]

Narendra Kumar [ narendra.kumar ]

Akash Thakur (Inactive) made changes - 21/Aug/19 12:11 AM

Time Spent	14h [ 50400 ]	17h [ 61200 ]
Worklog Id	195958 [ 195958 ]

Hide

Permalink

Akash Thakur (Inactive) added a comment - 21/Aug/19 12:25 AM

Hi Narendra Kumar,

I have made the above changes for system UI & embedded UI also have raised PR for same in ~~DMS-1766~~ branch please review code and let me know if any changes are required.

points verified for embedded UI

if Souce product is CBATS we are hiding Document source drop-down & Template status of expired.
if Souce product is CBATS & single template type is provided in embedded URL then Template Type defaults to provided in URL -with dropdown disabled.
if Souce product is CBATS & multiple template type is provided in embedded URL then Template Type shows that two value in the dropdown.
if Souce product is other than CBATS then the Document source drop-down & Template status of expired is visible on the screen.

points verified for system UI

create a template select source product to CBATS the Document source drop-down & Template status of expired is removed.
edit template with CBATS as source product the Document source drop-down & Template status of expired is not visible.
for other source products, no change in the UI should be there.

Regards,

Akash Thakur

Rohan J Khandave Narendra Kumar Samir Priya Dhamande

Show

Akash Thakur (Inactive) added a comment - 21/Aug/19 12:25 AM Hi Narendra Kumar , I have made the above changes for system UI & embedded UI also have raised PR for same in DMS-1766 branch please review code and let me know if any changes are required. points verified for embedded UI if Souce product is CBATS we are hiding Document source drop-down & Template status of expired. if Souce product is CBATS & single template type is provided in embedded URL then Template Type defaults to provided in URL -with dropdown disabled. if Souce product is CBATS & multiple template type is provided in embedded URL then Template Type shows that two value in the dropdown. if Souce product is other than CBATS then the Document source drop-down & Template status of expired is visible on the screen. points verified for system UI create a template select source product to CBATS the Document source drop-down & Template status of expired is removed. edit template with CBATS as source product the Document source drop-down & Template status of expired is not visible. for other source products, no change in the UI should be there. Regards, Akash Thakur Rohan J Khandave Narendra Kumar Samir Priya Dhamande

Samir made changes - 21/Aug/19 02:21 AM

Fix Version/s

CBAT Offer Letter - Fall [ 10607 ]

Hide

Permalink

Narendra Kumar added a comment - 21/Aug/19 10:46 PM

Hi Akash Thakur

I have reviewed the PR and merged it.

Show

Narendra Kumar added a comment - 21/Aug/19 10:46 PM Hi Akash Thakur I have reviewed the PR and merged it.

Narendra Kumar made changes - 21/Aug/19 10:46 PM

Assignee

Narendra Kumar [ narendra.kumar ]

Akash Thakur [ akash.thakur ]

Permalink

Akash Thakur (Inactive) logged work - 22/Aug/19 12:21 AM

Time Spent:

0.3h

code review call & corrections/ suggestions from narendra

Akash Thakur (Inactive) made changes - 22/Aug/19 12:22 AM

Time Spent	17h [ 61200 ]	17.3h [ 62280 ]
Worklog Id	196313 [ 196313 ]

Akash Thakur (Inactive) made changes - 23/Aug/19 02:38 AM

Assignee

Akash Thakur [ akash.thakur ]

Priya Dhamande [ priya.dhamande ]

Hide

Permalink

Shamooka Mohapatra (Inactive) added a comment - 26/Aug/19 06:10 AM

Samir Is the change deployed?

Show

Shamooka Mohapatra (Inactive) added a comment - 26/Aug/19 06:10 AM Samir Is the change deployed?

Hide

Permalink

Samir added a comment - 27/Aug/19 01:37 AM

Hi Shamooka Mohapatra,

Deployed on production

Regards,

Samir

Show

Samir added a comment - 27/Aug/19 01:37 AM Hi Shamooka Mohapatra , Deployed on production Regards, Samir

Raj Hawaldar (Inactive) made changes - 27/Aug/19 11:18 PM

Status

Code Review [ 11801 ]

In QA Testing [ 11901 ]

ShashiKant Mishra (Inactive) made changes - 30/Aug/19 09:30 PM

Sprint

DMS - Gap Fall & Win Sprint 2 [ 174 ]

DMS - Gap Fall & Win Sprint 2, DMS - Gap Fall & Win Sprint 3 [ 174, 177 ]

Permalink

Priya Dhamande (Inactive) logged work - 04/Sep/19 12:02 AM

Time Spent:

0.25h

Discussion with akash

Priya Dhamande (Inactive) made changes - 04/Sep/19 12:02 AM

Time Spent	17.3h [ 62280 ]	17.55h [ 63180 ]
Worklog Id	198401 [ 198401 ]

Permalink

Priya Dhamande (Inactive) logged work - 04/Sep/19 12:03 AM

Time Spent:

0.5h

Preprod testing

Hide

Permalink

Priya Dhamande (Inactive) added a comment - 04/Sep/19 12:03 AM

Environment: Preprod
Login: Admin
Browser: FF and Chrome

Points verified:
1. create a template select source product to CBATS the Document source drop-down & Template status of expired is removed. Pass
2. edit template with CBATS as source product the Document source drop-down & Template status of expired is not visible. Pass
3. for other source products, no change in the UI should be there. Pass

Samir Rohan J Khandave

Show

Priya Dhamande (Inactive) added a comment - 04/Sep/19 12:03 AM Environment: Preprod Login: Admin Browser: FF and Chrome Points verified: 1. create a template select source product to CBATS the Document source drop-down & Template status of expired is removed. Pass 2. edit template with CBATS as source product the Document source drop-down & Template status of expired is not visible. Pass 3. for other source products, no change in the UI should be there. Pass Samir Rohan J Khandave

Priya Dhamande (Inactive) made changes - 04/Sep/19 12:03 AM

Time Spent	17.55h [ 63180 ]	18.05h [ 64980 ]
Worklog Id	198402 [ 198402 ]

Priya Dhamande (Inactive) made changes - 04/Sep/19 12:03 AM

Resolution		Done [ 10000 ]
Status	In QA Testing [ 11901 ]	Done [ 10001 ]

Priya Dhamande (Inactive) made changes - 04/Sep/19 12:03 AM

Assignee

Priya Dhamande [ priya.dhamande ]

Akash Thakur [ akash.thakur ]

Transition	Time In Source Status	Execution Times

Akash Thakur (Inactive) made transition - 18/Aug/19 10:45 PM

To Do

In Progress

4d 18h 19m

Akash Thakur (Inactive) made transition - 20/Aug/19 04:24 AM

Code Review

In Progress

1h 38m

Akash Thakur (Inactive) made transition - 21/Aug/19 12:10 AM

In Progress

Code Review

1d 23h 47m

Raj Hawaldar (Inactive) made transition - 27/Aug/19 11:18 PM

Code Review

In QA Testing

6d 23h 7m

Priya Dhamande (Inactive) made transition - 04/Sep/19 12:03 AM

In QA Testing

Done

7d 45m

People

Assignee:: Akash Thakur (Inactive)

Reporter:: Samir

Developer:: Akash Thakur (Inactive)

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 14/Aug/19 04:26 AM

Updated:: 04/Sep/19 12:03 AM

Resolved:: 04/Sep/19 12:03 AM

Time Tracking

Estimated:

18h

Remaining:

Logged:

18.05h