[DMS-1771] Clicking save sends the document and clicking send doesn't save the document - Workterra Jira

Details

Type: Bug
Status: Done
Priority: Medium
Resolution: Done
Affects Version/s: None
Fix Version/s: Between Fall and Winter 2019
Labels:
None

Company:
All Clients/Multiple Clients
Epic Link:
Integration with CBAT

Description

The expected behavior should be that when I click save it saves my updates and then I have to click send to send the document. Today, when I hit save, it saves the document. And when I click send, it doesn't send the updated values.

Attachments

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

Attachments

Screenshot (4136).png
216 kB
29/Aug/19 03:33 AM

Activity

Ascending order - Click to sort in descending order

Shamooka Mohapatra (Inactive) created issue - 19/Aug/19 12:16 AM

Hide

Permalink

Samir added a comment - 19/Aug/19 04:03 AM

Hi Shamooka Mohapatra,

As per our testing this is not an issue. We tried with 2 candidate its working fine

Regards,

Samir

Show

Samir added a comment - 19/Aug/19 04:03 AM Hi Shamooka Mohapatra , As per our testing this is not an issue. We tried with 2 candidate its working fine Regards, Samir

Samir made changes - 19/Aug/19 04:03 AM

Field	Original Value	New Value
Assignee	Samir [ samir ]	Shamooka Mohapatra [ shamooka.mohapatra ]

Samir made changes - 19/Aug/19 04:03 AM

Resolution		Cannot Reproduce [ 5 ]
Status	To Do [ 10000 ]	Done [ 10001 ]

Ravi Banda (Inactive) made changes - 20/Aug/19 06:43 PM

Assignee

Shamooka Mohapatra [ shamooka.mohapatra ]

Samir [ samir ]

Ravi Banda (Inactive) made changes - 20/Aug/19 06:44 PM

Resolution	Cannot Reproduce [ 5 ]
Status	Done [ 10001 ]	To Do [ 10000 ]

Hide

Permalink

Ravi Banda (Inactive) added a comment - 20/Aug/19 06:44 PM

Able to reproduce the issue on CBINTERNALBETA - recording link - https://cb.zoom.us/recording/share/Zfg-lpnuw9Q1s7GLT43g7tWCkOAZ19z5bg0ILBy1W8GwIumekTziMw

FYI - Samir Shamooka Mohapatra Patrick Phillips

Show

Ravi Banda (Inactive) added a comment - 20/Aug/19 06:44 PM Able to reproduce the issue on CBINTERNALBETA - recording link - https://cb.zoom.us/recording/share/Zfg-lpnuw9Q1s7GLT43g7tWCkOAZ19z5bg0ILBy1W8GwIumekTziMw FYI - Samir Shamooka Mohapatra Patrick Phillips

Hide

Permalink

Samir added a comment - 20/Aug/19 10:26 PM

Hi Ravi Banda,

Thanks for sharing the video. We got the issue. Below Jira also covers the same issue. We are taking this on priority

~~DMS-1775~~

Regards,

Samir

Show

Samir added a comment - 20/Aug/19 10:26 PM Hi Ravi Banda , Thanks for sharing the video. We got the issue. Below Jira also covers the same issue. We are taking this on priority DMS-1775 Regards, Samir

Samir made changes - 20/Aug/19 10:26 PM

Assignee

Samir [ samir ]

Ramya Tantry [ ramya.tantry ]

Samir made changes - 20/Aug/19 10:26 PM

Sprint

DMS - Gap Fall & Win Sprint 2 [ 174 ]

Samir made changes - 21/Aug/19 02:37 AM

Fix Version/s		Between Fall and Winter 2019 [ 10919 ]
Fix Version/s	Integration with CBAT [ 10445 ]

Samir made changes - 21/Aug/19 02:37 AM

Epic Link

DMS-473 [ 75966 ]

Hide

Permalink

Ramya Tantry (Inactive) added a comment - 21/Aug/19 05:42 AM

Implementation details :
1. When document is sent with senddocument=3, document will be saved with status as Draft.
2. Documents with draft status will not be visible for review and sign.
3. Once Send API is called, Status will be changed to initial from draft.
4. Draft documents will be visible on completed forms library.

3C's

Concern: Clicking save sends the document.

Cause: Once document is saved from embedded UI, it is actually sent to the candidate for review inside DMS system. However for CBAT system, there is a separate Send option which sends the document.

Correction: We have set draft status to the document sent from CBAT. Draft status documents will not be visible to candidate and on click of send, status will change to initial.

Files Affected:

DMS\DMS.App\src\DMS_AppLogic\BuisnessLogic\DocumentData.cs
DMS\DMS.App\src\DMS_AppLogic\BuisnessLogic\PersonData.cs
DMS\DMS.App\src\DMS_AppLogic\Common\Routines\CommonRoutines.cs
DMS\DMS.App\src\DMS_AppLogic\Common\Routines\Document.cs
DMS\DMS.App\src\DMS_AppLogic\IntegrationLogic\CandidateProfile.cs

Show

Ramya Tantry (Inactive) added a comment - 21/Aug/19 05:42 AM Implementation details : 1. When document is sent with senddocument=3, document will be saved with status as Draft. 2. Documents with draft status will not be visible for review and sign. 3. Once Send API is called, Status will be changed to initial from draft. 4. Draft documents will be visible on completed forms library. 3C's Concern : Clicking save sends the document. Cause : Once document is saved from embedded UI, it is actually sent to the candidate for review inside DMS system. However for CBAT system, there is a separate Send option which sends the document. Correction : We have set draft status to the document sent from CBAT. Draft status documents will not be visible to candidate and on click of send, status will change to initial. Files Affected: DMS\DMS.App\src\DMS_AppLogic\BuisnessLogic\DocumentData.cs DMS\DMS.App\src\DMS_AppLogic\BuisnessLogic\PersonData.cs DMS\DMS.App\src\DMS_AppLogic\Common\Routines\CommonRoutines.cs DMS\DMS.App\src\DMS_AppLogic\Common\Routines\Document.cs DMS\DMS.App\src\DMS_AppLogic\IntegrationLogic\CandidateProfile.cs

Ramya Tantry (Inactive) made changes - 21/Aug/19 05:43 AM

Status

To Do [ 10000 ]

Code Review [ 11801 ]

Ramya Tantry (Inactive) made changes - 21/Aug/19 05:43 AM

Assignee

Ramya Tantry [ ramya.tantry ]

Harshveer Singh [ harshveer.singh ]

Permalink

Ramya Tantry (Inactive) logged work - 21/Aug/19 05:46 AM

Time Spent:

5h

Code changes

Testing

Ramya Tantry (Inactive) made changes - 21/Aug/19 05:47 AM

Remaining Estimate		0h [ 0 ]
Time Spent		5h [ 18000 ]
Worklog Id	196015 [ 196015 ]

Ramya Tantry (Inactive) made changes - 27/Aug/19 04:16 AM

Status

Code Review [ 11801 ]

In QA Testing [ 11901 ]

Ramya Tantry (Inactive) made changes - 27/Aug/19 04:16 AM

Assignee

Harshveer Singh [ harshveer.singh ]

Priya Dhamande [ priya.dhamande ]

Raj Hawaldar (Inactive) made changes - 27/Aug/19 11:18 PM

Status

In QA Testing [ 11901 ]

Priya Dhamande (Inactive) made changes - 29/Aug/19 03:33 AM

Attachment

Screenshot (4136).png [ 117958 ]

Permalink

Priya Dhamande (Inactive) logged work - 29/Aug/19 03:34 AM

Time Spent:

1.5h

Preprod testing

Hide

Permalink

Priya Dhamande (Inactive) added a comment - 29/Aug/19 03:34 AM

Environment: Preprod

Verified using API and DB
API: 1. api/candidate/custom/document/create
Senddocument: 3
2. /api/documents/send

Using documentrouting;

Not verified using CBAT

So, marking jira done.

Show

Priya Dhamande (Inactive) added a comment - 29/Aug/19 03:34 AM Environment: Preprod Verified using API and DB API: 1. api/candidate/custom/document/create Senddocument: 3 2. /api/documents/send Using documentrouting; Not verified using CBAT So, marking jira done.

Priya Dhamande (Inactive) made changes - 29/Aug/19 03:34 AM

Resolution		Done [ 10000 ]
Status	In QA Testing [ 11901 ]	Done [ 10001 ]

Priya Dhamande (Inactive) made changes - 29/Aug/19 03:34 AM

Time Spent	5h [ 18000 ]	6.5h [ 23400 ]
Worklog Id	197734 [ 197734 ]

Transition	Time In Source Status	Execution Times

Samir made transition - 19/Aug/19 04:03 AM

To Do

Done

3h 47m

Ravi Banda (Inactive) made transition - 20/Aug/19 06:44 PM

Done

To Do

1d 14h 40m

Ramya Tantry (Inactive) made transition - 21/Aug/19 05:43 AM

To Do

Code Review

10h 59m

Ramya Tantry (Inactive) made transition - 27/Aug/19 04:16 AM

Code Review

In QA Testing

5d 22h 33m

Raj Hawaldar (Inactive) made transition - 27/Aug/19 11:18 PM

In QA Testing

19h 1m

Priya Dhamande (Inactive) made transition - 29/Aug/19 03:34 AM

In QA Testing

Done

1d 4h 15m

People

Assignee:: Priya Dhamande (Inactive)

Reporter:: Shamooka Mohapatra (Inactive)

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 19/Aug/19 12:16 AM

Updated:: 29/Aug/19 03:34 AM

Resolved:: 29/Aug/19 03:34 AM

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

6.5h