As discussed, We will need to check responsiveness of the review and sign page on the other devices not a pdf responsiveness under this jira. We will handling PDF responsiveness(custom fields and edit fields) dynamically. We will not make a pdf responsive using css, Do you have made changes for pdf responsiveness under jira: DMS-1763?
Please let me know once you free then we will make a changes for review and sign responsiveness for other devices not for pdf responsiveness.
Namrata Kakade (Inactive)
added a comment - - edited Hi Mohd Belal ,
As discussed, We will need to check responsiveness of the review and sign page on the other devices not a pdf responsiveness under this jira. We will handling PDF responsiveness(custom fields and edit fields) dynamically. We will not make a pdf responsive using css, Do you have made changes for pdf responsiveness under jira: DMS-1763 ?
Please let me know once you free then we will make a changes for review and sign responsiveness for other devices not for pdf responsiveness.
Regards,
Namrata
Samir Ganesh Sadawarte Rohan J Khandave Mohd Belal Narendra Kumar
Just had a discussion with Ganesh Sadawarte and Narendra Kumar regarding the responsiveness of PDF to be handled dynamically from the Angular side. But unluckily we don't have any option to fix the PDF according to the screen size for different devices from Angular.
We need to handle this by css using media query for different device and resolution apart from the standard devices of iOS and android which is fixed for now.
Need to make sure that the custom inputs of PDF are aligned optimally to different screen resolutions.
Mohd Belal (Inactive)
added a comment - - edited Hi Namrata Kakade ,
Just had a discussion with Ganesh Sadawarte and Narendra Kumar regarding the responsiveness of PDF to be handled dynamically from the Angular side. But unluckily we don't have any option to fix the PDF according to the screen size for different devices from Angular.
The responsiveness for ng2-pdf-viewer is an open issue right now. https://github.com/VadimDez/ng2-pdf-viewer/issues/472
We need to handle this by css using media query for different device and resolution apart from the standard devices of iOS and android which is fixed for now.
Need to make sure that the custom inputs of PDF are aligned optimally to different screen resolutions.
cc- Samir
Thanks
Namrata Kakade (Inactive)
added a comment - Hi Mohd Belal ,
I have targeted android devices through media query in the css. Please find the attachment of CSS files and targeted resolution with devices.
Please let me know when we merge this css in previous pdf responsive css.
Regards,
Namrata
Samir Narendra Kumar device list.txt responsive-pdf.css
Today, we have updated css changes in file "document-review.component.scss" locally. document-review.component.scss
There is another file named "forms-preview.component.scss" which requires css changes but for that we require Mohd Belals help.
We were facing below error while sending file from dev environment.
Due to this error we were not able to test css fix on the devices.
Code Check-in is pending, Mohd Belal we are waiting for your inputs.
Namrata Kakade (Inactive)
added a comment - Hi,
Today, we have updated css changes in file "document-review.component.scss" locally.
document-review.component.scss
There is another file named "forms-preview.component.scss" which requires css changes but for that we require Mohd Belal s help.
We were facing below error while sending file from dev environment.
Due to this error we were not able to test css fix on the devices.
Code Check-in is pending, Mohd Belal we are waiting for your inputs.
Regards,
Namrata
Samir Narendra Kumar
Hi Namrata Kakade,
As discussed over call, please add font-size as well in forms-preview component as we do have in document-review component.
This font-size was added to handle the inputs values to be viewable for iOS devices.
Mohd Belal (Inactive)
added a comment - Hi Namrata Kakade ,
As discussed over call, please add font-size as well in forms-preview component as we do have in document-review component.
This font-size was added to handle the inputs values to be viewable for iOS devices.
cc - Samir
Thanks
I have updated css changes in file "document-review.component.scss" and "forms-preview.component.scss" locally with the help of Raj and tested on browser with devices resolutions. We need to check it on actual devices after build. We have tested 2-3 pdf with responsiveness on browser.
Namrata Kakade (Inactive)
added a comment - Hi Samir ,
I have updated css changes in file "document-review.component.scss" and "forms-preview.component.scss" locally with the help of Raj and tested on browser with devices resolutions. We need to check it on actual devices after build. We have tested 2-3 pdf with responsiveness on browser.
Regards,
Namrata
Samir Mohd Belal Raj Hawaldar
Narendra Kumar
added a comment - Hi Namrata Kakade
Please have a look at the attached images. Responsive CSS is not working fine. Previously It was good but now it has more issues.
cc: Raj Hawaldar , Samir
Thanks
Narendra
Namrata Kakade (Inactive)
added a comment - Hi Narendra Kumar ,
We have tested locally on Raj machine and its working properly. Please find the attachment for your reference.
Regards,
Namrata
Samir Raj Hawaldar
I have updated css changes in file "document-review.component.scss" and "forms-preview.component.scss" locally and tested on browser with devices resolutions. We need to check it on actual devices after build. We have tested 2 pdf with responsiveness on browser.
I have updated CSS files under raised PR. document-review.component.scss
Regards,
Namrata SamirRaj Hawaldar
Namrata Kakade (Inactive)
added a comment - Hi Narendra Kumar ,
I have updated css changes in file "document-review.component.scss" and "forms-preview.component.scss" locally and tested on browser with devices resolutions. We need to check it on actual devices after build. We have tested 2 pdf with responsiveness on browser.
I have updated CSS files under raised PR.
document-review.component.scss
Regards,
Namrata
Samir Raj Hawaldar
I have taken screenshot of mention device resolution locally. Please check for your reference. local-screenshots.zip
Please let me know if you have any query.
Namrata Kakade (Inactive)
added a comment - Hi Narendra Kumar ,
I have taken screenshot of mention device resolution locally. Please check for your reference. local-screenshots.zip
Please let me know if you have any query.
Regards,
Namrata
Samir
We have verified changes locally for 2 pdf but its working fine for that pdf but not for all pdf. We need fixed issue the fields position dynamically with coding. I am not right person for dynamic coding to handle that scenario, developer can be handle fields position with dynamic coding(left, top position with respective width and height) as per resolution.
@Narendra will be share zoom details for tomorrows meeting.
Namrata Kakade (Inactive)
added a comment - Hi Samir ,
We have verified changes locally for 2 pdf but its working fine for that pdf but not for all pdf. We need fixed issue the fields position dynamically with coding. I am not right person for dynamic coding to handle that scenario, developer can be handle fields position with dynamic coding(left, top position with respective width and height) as per resolution.
@Narendra will be share zoom details for tomorrows meeting.
Regards,
Namrata
Narendra Kumar Samir Rohan J Khandave Ganesh Sadawarte
Namrata Kakade (Inactive)
added a comment - Hi Samir ,
As discussed, I have put this task on hold from two months. Now I am assign this ticket you,
please reassign it to me for when changes needed.
Regards,
Namrata
Bug
Critical
Namrata Kakade (Inactive)
made changes -
we have updated css changes in file "document-review.component.scss" locally. 
Raj Hawaldar (Inactive)
logged work - 30/Aug/19 06:00 AM 
ShashiKant Mishra (Inactive)
made changes -
.JPG){kind=link}
Hi Mohd Belal,
As discussed, We will need to check responsiveness of the review and sign page on the other devices not a pdf responsiveness under this jira. We will handling PDF responsiveness(custom fields and edit fields) dynamically. We will not make a pdf responsive using css, Do you have made changes for pdf responsiveness under jira:
DMS-1763?Please let me know once you free then we will make a changes for review and sign responsiveness for other devices not for pdf responsiveness.
Regards,
Namrata
Samir Ganesh Sadawarte Rohan J Khandave Mohd Belal Narendra Kumar