[DMS-2104] CBAT: DMS Offer Letter "Underline" Issue - Workterra Jira

Details

Type: Bug
Status: Done
Priority: Medium
Resolution: Done
Affects Version/s: None
Fix Version/s: Winter 2020 CBAT Integration
Labels:
None

Company:
All Clients/Multiple Clients

Description

System: cbinternalbeta
Test Candidate: Jane Doe ID: 001182
Offer Letter Template: Gee Group Offer Test 12.17.19

When I open an offer letter as a test candidate sent via DMS I am seeing underlined sections. I believe this should be seen in the preview _only _not when the candidate opens the offer letter to sign.

Step 1: Select to send an offer letter

Step 2: Select Gee Group Offer Test 12.17.19 Notice the lines in the preview. This I believe is intended

Step 3: When I send and then open the letter I see the line as the candidate would but should not see.

Step 4: When I open the finished letter as a CBAT user the lines are not there. This is what I would expect the letter to look like when the candidate opens the offer letter in the DMS signing portal.

https://careerbuilder.atlassian.net/browse/ATAO-1858

Attachments

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

Attachments

1.jpg
16/Jan/20 11:40 PM
29 kB
Narendra Kumar
2.jpg
16/Jan/20 11:41 PM
86 kB
Narendra Kumar
3.jpg
16/Jan/20 11:42 PM
107 kB
Narendra Kumar
4.jpg
16/Jan/20 11:44 PM
141 kB
Narendra Kumar
5.jpg
16/Jan/20 11:43 PM
226 kB
Narendra Kumar
Editable.png
05/Feb/20 02:39 AM
63 kB
Narendra Kumar
No Rights.png
05/Feb/20 02:39 AM
57 kB
Narendra Kumar
Required.png
05/Feb/20 02:39 AM
69 kB
Narendra Kumar
View Only.png
05/Feb/20 02:39 AM
63 kB
Narendra Kumar

Activity

Ascending order - Click to sort in descending order

Narendra Kumar created issue - 16/Jan/20 11:45 PM

Narendra Kumar made changes - 16/Jan/20 11:46 PM

Field	Original Value	New Value
Status	To Do [ 10000 ]	In Progress [ 3 ]

Narendra Kumar made changes - 16/Jan/20 11:47 PM

Description

System: cbinternalbeta
Test Candidate: Jane Doe ID: 001182
Offer Letter Template: Gee Group Offer Test 12.17.19

When I open an offer letter as a test candidate sent via DMS I am seeing underlined sections. I believe this should be seen in the preview _only _not when the candidate opens the offer letter to sign.

*Step 1:* Select to send an offer letter

!1.jpg|width=221,height=136!

*Step 2:* Select Gee Group Offer Test 12.17.19 Notice the lines in the preview. This I believe is intended

!2.jpg|width=223,height=154!

*Step 3:* When I send and then open the letter I see the line as the candidate would but should not see.

!3.jpg|width=229,height=107!

!4.jpg|width=216,height=115!

*Step 4:* When I open the finished letter as a CBAT user the lines are not there. This is what I would expect the letter to look like when the candidate opens the offer letter in the DMS signing portal.

!5.jpg|width=228,height=188!

Hide

Permalink

Narendra Kumar added a comment - 16/Jan/20 11:48 PM

cc: Samir, Patrick Phillips, Amrendra Kumar, Shamooka Mohapatra

Show

Narendra Kumar added a comment - 16/Jan/20 11:48 PM cc: Samir , Patrick Phillips , Amrendra Kumar , Shamooka Mohapatra

Hide

Permalink

Narendra Kumar added a comment - 17/Jan/20 12:11 AM

HI Shamooka Mohapatra,

I have removed the underline from everywhere. So you can check it with Mohd Belal how PDF is looking after removing the underlines. If you are good with that we will merge that PR and will deploy in the pre-prod environment.

Show

Narendra Kumar added a comment - 17/Jan/20 12:11 AM HI Shamooka Mohapatra , I have removed the underline from everywhere. So you can check it with Mohd Belal how PDF is looking after removing the underlines. If you are good with that we will merge that PR and will deploy in the pre-prod environment.

Narendra Kumar made changes - 17/Jan/20 12:11 AM

Status

In Progress [ 3 ]

Code Review [ 11801 ]

Permalink

Narendra Kumar logged work - 17/Jan/20 01:22 AM

Time Spent:

3h

<No comment>

Narendra Kumar made changes - 17/Jan/20 01:22 AM

Remaining Estimate	8h [ 28800 ]	5h [ 18000 ]
Time Spent		3h [ 10800 ]
Worklog Id	222108 [ 222108 ]

Hide

Permalink

Narendra Kumar added a comment - 22/Jan/20 01:39 AM

Hi Shamooka Mohapatra,

Any update on this?

Show

Narendra Kumar added a comment - 22/Jan/20 01:39 AM Hi Shamooka Mohapatra , Any update on this?

Hide

Permalink

Shamooka Mohapatra (Inactive) added a comment - 23/Jan/20 04:04 AM

Narendra Kumar I checked it. Please check the comments in https://careerbuilder.atlassian.net/browse/ATAO-1856

Need to be discussed with Patrick in SOS call.

Thanks!

cc : Samir Patrick Phillips Amrendra Kumar

Show

Shamooka Mohapatra (Inactive) added a comment - 23/Jan/20 04:04 AM Narendra Kumar I checked it. Please check the comments in https://careerbuilder.atlassian.net/browse/ATAO-1856 Need to be discussed with Patrick in SOS call. Thanks! cc : Samir Patrick Phillips Amrendra Kumar

Narendra Kumar made changes - 27/Jan/20 09:04 PM

Sprint

Winter-2020 Sprint 7 [ 193 ]

Winter-2020 Sprint 7, Winter-2020 Sprint 8 [ 193, 197 ]

Narendra Kumar made changes - 02/Feb/20 08:43 PM

Sprint

Winter-2020 Sprint 7, Winter-2020 Sprint 8 [ 193, 197 ]

Winter-2020 Sprint 7, Winter-2020 Sprint 8, Winter-2020 Sprint 9 [ 193, 197, 198 ]

Narendra Kumar made changes - 04/Feb/20 01:12 AM

Status

Code Review [ 11801 ]

To Do [ 10000 ]

Narendra Kumar made changes - 04/Feb/20 01:12 AM

Fix Version/s

Winter 2020 CBAT Integration [ 11316 ]

Hide

Permalink

Narendra Kumar added a comment - 05/Feb/20 01:48 AM

Got the requirements from Patrick Phillips

To be clear after our call: Any field that is editable should have an underline. If a field is mapped but not editable, there should be no underline.

Show

Narendra Kumar added a comment - 05/Feb/20 01:48 AM Got the requirements from Patrick Phillips To be clear after our call: Any field that is editable should have an underline. If a field is mapped but not editable, there should be no underline.

Narendra Kumar made changes - 05/Feb/20 02:10 AM

Status

To Do [ 10000 ]

In Progress [ 3 ]

Narendra Kumar made changes - 05/Feb/20 02:39 AM

Attachment		Editable.png [ 133766 ]
Attachment		View Only.png [ 133767 ]
Attachment		No Rights.png [ 133768 ]
Attachment		Required.png [ 133769 ]

Hide

Permalink

Narendra Kumar added a comment - 05/Feb/20 02:44 AM

Hi Patrick Phillips

We have removed the underline from PDF file as per your requirements. Please have a look at all four cases.

Editable: Underline will appear with data

View Only: Underlines will not appear only data will appear.

No Rights: Neigher underline will appear nor data.

Required: Underlines will appear in red with data.

Please confirm if this is fine.

cc: Samir, Shamooka Mohapatra, Amrendra Kumar

Thanks

Narendra

Show

Narendra Kumar added a comment - 05/Feb/20 02:44 AM Hi Patrick Phillips We have removed the underline from PDF file as per your requirements. Please have a look at all four cases. Editable: Underline will appear with data View Only: Underlines will not appear only data will appear. No Rights: Neigher underline will appear nor data. Required: Underlines will appear in red with data. Please confirm if this is fine. cc: Samir , Shamooka Mohapatra , Amrendra Kumar Thanks Narendra

Narendra Kumar made changes - 05/Feb/20 02:44 AM

Status

In Progress [ 3 ]

Code Review [ 11801 ]

Narendra Kumar made changes - 05/Feb/20 02:45 AM

Remaining Estimate	5h [ 18000 ]	1h [ 3600 ]
Time Spent	3h [ 10800 ]	7h [ 25200 ]
Worklog Id	225571 [ 225571 ]

Permalink

Narendra Kumar logged work - 05/Feb/20 04:45 AM

Time Spent:

4h

Removed underlines as per Patric requirements.

Narendra Kumar made changes - 06/Feb/20 02:02 AM

Assignee

Narendra Kumar [ narendra.kumar ]

Patrick Phillips [ patrick.phillips ]

Ashish Durani made changes - 06/Feb/20 02:23 AM

Status

Code Review [ 11801 ]

In QA Testing [ 11901 ]

Ashish Durani made changes - 06/Feb/20 02:23 AM

Assignee

Patrick Phillips [ patrick.phillips ]

Prateek [ prateeks ]

Hide

Permalink

Shamooka Mohapatra (Inactive) added a comment - 10/Feb/20 01:22 AM

Narendra Kumar,
Is there any update on this?

cc: Samir Amrendra Kumar Patrick Phillips

Show

Shamooka Mohapatra (Inactive) added a comment - 10/Feb/20 01:22 AM Narendra Kumar , Is there any update on this? cc: Samir Amrendra Kumar Patrick Phillips

Hide

Permalink

Narendra Kumar added a comment - 10/Feb/20 01:26 AM

Hi Shamooka Mohapatra,

This will be deployed tomorrow on the prod because Ashish is not available today.

Show

Narendra Kumar added a comment - 10/Feb/20 01:26 AM Hi Shamooka Mohapatra , This will be deployed tomorrow on the prod because Ashish is not available today.

Narendra Kumar made changes - 18/Feb/20 08:40 PM

Sprint

Winter-2020 Sprint 7, Winter-2020 Sprint 8, Spring-2020 - Sprint 2 [ 193, 197, 198 ]

Winter-2020 Sprint 7, Winter-2020 Sprint 8, Spring-2020 - Sprint 2, Spring-2020 - Sprint 3 [ 193, 197, 198, 199 ]

Narendra Kumar made changes - 27/Feb/20 02:23 AM

Resolution		Done [ 10000 ]
Status	In QA Testing [ 11901 ]	Done [ 10001 ]

Narendra Kumar made changes - 27/Feb/20 02:23 AM

Assignee

Prateek [ prateeks ]

Narendra Kumar [ narendra.kumar ]

Permalink

Narendra Kumar logged work - 05/Mar/20 04:17 AM

Time Spent:

4h

<No comment>

Narendra Kumar made changes - 18/Mar/20 12:18 AM

Remaining Estimate	1h [ 3600 ]	0h [ 0 ]
Time Spent	7h [ 25200 ]	11h [ 39600 ]
Worklog Id	232943 [ 232943 ]

Transition	Time In Source Status	Execution Times

Narendra Kumar made transition - 04/Feb/20 01:12 AM

Code Review

To Do

18d 1h 1m

Narendra Kumar made transition - 05/Feb/20 02:10 AM

To Do

In Progress

1d 58m

Narendra Kumar made transition - 05/Feb/20 02:44 AM

In Progress

Code Review

59m 38s

Ashish Durani made transition - 06/Feb/20 02:23 AM

Code Review

In QA Testing

23h 38m

Narendra Kumar made transition - 27/Feb/20 02:23 AM

In QA Testing

Done

20d 23h 59m

People

Assignee:: Narendra Kumar

Reporter:: Narendra Kumar

Votes:: 0 Vote for this issue

Watchers:: 1 Start watching this issue

Dates

Created:: 16/Jan/20 11:45 PM

Updated:: 18/Mar/20 12:18 AM

Resolved:: 27/Feb/20 02:23 AM

Time Tracking

Estimated:

Remaining:

Logged:

11h