Document Management SystemProject Type: software

Document Management System

Uploaded image for project: 'Document Management System'
  1. Document Management System
  2. DMS-2447

CBAT-DMS | On Updating email template throwing "Invalid Template name" Error

    Details

    • Type: Bug
    • Status: In QA Testing
    • Priority: Low
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      On CBAT-DMS , While user try to edit any Email template and than save it , changes get saved successfully while throwing an error related to "Template Invalid name" . This issue occurs on below Email type:

      1. Form(s) Delinquent Email
      2.  Form(s) Completion Email

      attaching screenshots for the same

       

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          poonam.rana poonam.rana (Inactive) created issue -
          poonam.rana poonam.rana (Inactive) made changes -
          Field Original Value New Value
          Epic Link DMS-2406 [ 126511 ]
          poonam.rana poonam.rana (Inactive) made changes -
          Priority Medium [ 3 ] Low [ 4 ]
          narendra.kumar Narendra Kumar made changes -
          Sprint April 2021 Release - Sprint 1 [ 264 ] April 2021 Release - Sprint 1, April 2021 Release - Sprint 2 [ 264, 265 ]
          narendra.kumar Narendra Kumar made changes -
          Remaining Estimate 8h [ 28800 ]
          Original Estimate 8h [ 28800 ]
          narendra.kumar Narendra Kumar made changes -
          Status To Do [ 10000 ] In Progress [ 3 ]
          Hide
          Permalink
          narendra.kumar Narendra Kumar added a comment -

          Hi Mohd Belal

          I have fixed the issue of the validation message. It was the previous implementation when we do not support the special characters in the email template name. But we had removed the check from the backend but not at the front-end. So now I have removed the pattern check from the UI side as well.

          Apart from that also provided the fix for one more issue in this: 

          During edit the email template if we refresh the page it becomes the create a new email template. So this is now fixed.

          Here is the PR for this: https://github.com/cbdr/DMS/pull/1231 Please review it.

           

          Thanks

          Narendra K.

          Show
          narendra.kumar Narendra Kumar added a comment - Hi Mohd Belal I have fixed the issue of the validation message. It was the previous implementation when we do not support the special characters in the email template name. But we had removed the check from the backend but not at the front-end. So now I have removed the pattern check from the UI side as well. Apart from that also provided the fix for one more issue in this:  During edit the email template if we refresh the page it becomes the create a new email template. So this is now fixed. Here is the PR for this: https://github.com/cbdr/DMS/pull/1231  Please review it.   Thanks Narendra K.
          narendra.kumar Narendra Kumar made changes -
          Status In Progress [ 3 ] Code Review [ 11801 ]
          Permalink
          narendra.kumar Narendra Kumar logged work - 20/Apr/21 04:06 AM - edited
          • Time Spent:
            3h
             

            Fixed the issue.

          narendra.kumar Narendra Kumar made changes -
          Remaining Estimate 8h [ 28800 ] 4h [ 14400 ]
          Time Spent 4h [ 14400 ]
          Worklog Id 303598 [ 303598 ]
          narendra.kumar Narendra Kumar made changes -
          Remaining Estimate 4h [ 14400 ] 5h [ 18000 ]
          Time Spent 4h [ 14400 ] 3h [ 10800 ]
          Worklog Id 303598 [ 303598 ]
          poonam.rana poonam.rana (Inactive) made changes -
          Status Code Review [ 11801 ] In QA Testing [ 11901 ]
          Permalink
          poonam.rana poonam.rana (Inactive) logged work - 22/Apr/21 03:02 AM
          • Time Spent:
            1h
             
            <No comment>
          Hide
          Permalink
          poonam.rana poonam.rana (Inactive) added a comment -

          Hello Narendra Kumar,

          Above reported Issue has been verified on CBAT STAGE environment, It is Working as Expected now.  No more error is displaying for "Template Name" on entering correct data .

          We can move the same to PROD.

           

          Thanks,
          Poonam Rana

          Show
          poonam.rana poonam.rana (Inactive) added a comment - Hello Narendra Kumar , Above reported Issue has been verified on CBAT STAGE environment, It is Working as Expected now.  No more error is displaying for "Template Name" on entering correct data . We can move the same to PROD.   Thanks, Poonam Rana
          poonam.rana poonam.rana (Inactive) made changes -
          Status In QA Testing [ 11901 ] To Do [ 10000 ]
          poonam.rana poonam.rana (Inactive) made changes -
          Status To Do [ 10000 ] In QA Testing [ 11901 ]
          poonam.rana poonam.rana (Inactive) made changes -
          Remaining Estimate 5h [ 18000 ] 4h [ 14400 ]
          Time Spent 3h [ 10800 ] 4h [ 14400 ]
          Worklog Id 304021 [ 304021 ]
          Hide
          Permalink
          narendra.kumar Narendra Kumar added a comment -

          Hi poonam.rana

          This is now deployed on prod.  Please verify it.

          Show
          narendra.kumar Narendra Kumar added a comment - Hi poonam.rana This is now deployed on prod.  Please verify it.
          narendra.kumar Narendra Kumar made changes -
          Assignee Narendra Kumar [ narendra.kumar ] poonam.rana [ poonam.rana ]
          Transition Time In Source Status Execution Times
          Narendra Kumar made transition -
          To Do In Progress
          		7d 11h 46m 1
          Narendra Kumar made transition -
          In Progress Code Review
          		3h 33m 1
          poonam.rana (Inactive) made transition -
          Code Review In QA Testing
          		2d 2h 53m 1
          poonam.rana (Inactive) made transition -
          In QA Testing To Do
          		3m 42s 1
          poonam.rana (Inactive) made transition -
          To Do In QA Testing
          		4s 1

            People

            Assignee:
            poonam.rana poonam.rana (Inactive)
            Reporter:
            poonam.rana poonam.rana (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:

                Time Tracking

                Estimated:
                Original Estimate - 8h
                8h
                Remaining:
                Time Spent - 4h Remaining Estimate - 4h
                4h
                Logged:
                Time Spent - 4h Remaining Estimate - 4h
                4h