Uploaded image for project: 'Document Management System'
  1. Document Management System
  2. DMS-537

DMS | Registration | Add note for Upload image

    Details

    • Type: Bug
    • Status: Done
    • Priority: Medium
    • Resolution: Done
    • Affects Version/s: None
    • Labels:
      None
    • Company:
      All Clients/Multiple Clients

      Description

      Environment: PreProd

      Molly's comment:
      Upload your file – still seems weird to have this field / what is it for? We have no explanation to candidate.

      • Either add note
      • check with Aruna Raheja, whether it is required.

      Swapnil Pandhare Aruna Raheja

        Attachments

        1. Registration.png
          Registration.png
          214 kB
        2. Registration-Upload-Profile.jpg
          Registration-Upload-Profile.jpg
          157 kB
        3. Screenshot (1086).png
          Screenshot (1086).png
          124 kB
        4. Upload-File.jpg
          Upload-File.jpg
          49 kB
        5. user_image.svg
          5 kB

          Activity

          priya.dhamande Priya Dhamande (Inactive) created issue -
          aruna.raheja Aruna Raheja logged work - 14/Jan/19 12:57 AM
          • Time Spent:
            10m
             
            <No comment>
          Hide
          aruna.raheja Aruna Raheja added a comment -

          Priya Dhamande : This field was suggested by Samir at the time of designing. I think we should kept it as we are creating candidate profile page and i have given the option of user image there. 

          Also final decision, whether we need to keep it or not , of this can be taken by Molly Ronovsky

          CC: Swapnil Pandhare Kristen

          Show
          aruna.raheja Aruna Raheja added a comment - Priya Dhamande : This field was suggested by Samir at the time of designing. I think we should kept it as we are creating candidate profile page and i have given the option of user image there.  Also final decision, whether we need to keep it or not , of this can be taken by Molly Ronovsky CC: Swapnil Pandhare Kristen
          aruna.raheja Aruna Raheja made changes -
          Field Original Value New Value
          Remaining Estimate 0h [ 0 ]
          Time Spent 10m [ 600 ]
          Worklog Id 155076 [ 155076 ]
          Hide
          molly.ronovsky Molly Ronovsky (Inactive) added a comment -

          Aruna Raheja What is the intended use of this? An image? If so we just need to have verbiage around it so that it is clear to a candidate what it is for as well its super big so i dont want it to take away focus.

          Show
          molly.ronovsky Molly Ronovsky (Inactive) added a comment - Aruna Raheja What is the intended use of this? An image? If so we just need to have verbiage around it so that it is clear to a candidate what it is for as well its super big so i dont want it to take away focus.
          Hide
          aruna.raheja Aruna Raheja added a comment -

          Molly Ronovsky : Actually it is for profile pic as we are showing profile pic on Candidate Profile page. So we need that it should get uploaded somewhere. Need your thoughts on this.

          CC:Kristen

          Show
          aruna.raheja Aruna Raheja added a comment - Molly Ronovsky : Actually it is for profile pic as we are showing profile pic on Candidate Profile page. So we need that it should get uploaded somewhere. Need your thoughts on this. CC: Kristen
          Hide
          molly.ronovsky Molly Ronovsky (Inactive) added a comment -

          Aruna Raheja Got it - as long as it's not a huge spot on the page I think that is fine.

          Show
          molly.ronovsky Molly Ronovsky (Inactive) added a comment - Aruna Raheja Got it - as long as it's not a huge spot on the page I think that is fine.
          aruna.raheja Aruna Raheja made changes -
          Attachment Registration.png [ 95101 ]
          Hide
          aruna.raheja Aruna Raheja added a comment -

          Molly Ronovsky : Please check the attached design for Profile Pic section

          CC:Kristen Samir Swapnil Pandhare Priya Dhamande

          Show
          aruna.raheja Aruna Raheja added a comment - Molly Ronovsky : Please check the attached design for Profile Pic section CC: Kristen Samir Swapnil Pandhare Priya Dhamande
          Hide
          molly.ronovsky Molly Ronovsky (Inactive) added a comment -

          Aruna Raheja Yes, looks good - as long as it doesn't take over the screen once it comes to fruition because the mock-ups always look good, but i feel like when they get developed they get much bigger / zoomed....can we make sure that doesn't happen? Swapnil Pandhare

          Show
          molly.ronovsky Molly Ronovsky (Inactive) added a comment - Aruna Raheja Yes, looks good - as long as it doesn't take over the screen once it comes to fruition because the mock-ups always look good, but i feel like when they get developed they get much bigger / zoomed....can we make sure that doesn't happen? Swapnil Pandhare
          aruna.raheja Aruna Raheja logged work - 15/Jan/19 08:22 PM
          • Time Spent:
            1h
             
            <No comment>
          aruna.raheja Aruna Raheja made changes -
          Time Spent 10m [ 600 ] 1h 10m [ 4200 ]
          Worklog Id 155431 [ 155431 ]
          Hide
          aruna.raheja Aruna Raheja added a comment -

          Smita Pawar : Kindly use the attached designs for upload profile pic.

          CC: Swapnil Pandhare Samir Priya Dhamande Kristen

          Show
          aruna.raheja Aruna Raheja added a comment - Smita Pawar : Kindly use the attached designs for upload profile pic. CC: Swapnil Pandhare Samir Priya Dhamande Kristen
          smita.v.pawar Smita Pawar (Inactive) made changes -
          Attachment image-2019-01-17-10-22-32-998.png [ 95284 ]
          smita.v.pawar Smita Pawar (Inactive) made changes -
          Attachment image-2019-01-17-10-22-32-998.png [ 95284 ]
          smita.v.pawar Smita Pawar (Inactive) made changes -
          Attachment Upload-File.jpg [ 95285 ]
          Hide
          smita.v.pawar Smita Pawar (Inactive) added a comment -

          Hi Aruna Raheja,

          Here for User image upload we have changed the border styling compare to Upload files component used previously. Below is the screenshot:

           

           

          Is there anything specific thought behind. It would be good if we keep it consistent throughout, we can accommodate profile image circle but I feel other styling can be same.

          CC: Molly Ronovsky, Kristen, Swapnil Pandhare

           

          Show
          smita.v.pawar Smita Pawar (Inactive) added a comment - Hi Aruna Raheja , Here for User image upload we have changed the border styling compare to Upload files component used previously. Below is the screenshot:     Is there anything specific thought behind. It would be good if we keep it consistent throughout, we can accommodate profile image circle but I feel other styling can be same. CC:  Molly Ronovsky , Kristen , Swapnil Pandhare  
          Hide
          aruna.raheja Aruna Raheja added a comment -

          Hi Smita Pawar : As we are not using inner component in this that's why i have used only outer border. Also if we are using inner styling then it will be look much bigger that's why removed it.

          If you still feel that we should go the other way then do share the mock and we can have a discussion with Molly Ronovsky and Kristen onto the same.

          CC: Molly RonovskyKristenSwapnil Pandhare

          Show
          aruna.raheja Aruna Raheja added a comment - Hi Smita Pawar : As we are not using inner component in this that's why i have used only outer border. Also if we are using inner styling then it will be look much bigger that's why removed it. If you still feel that we should go the other way then do share the mock and we can have a discussion with Molly Ronovsky and Kristen onto the same. CC:  Molly Ronovsky ,  Kristen ,  Swapnil Pandhare
          smita.v.pawar Smita Pawar (Inactive) made changes -
          Attachment BRUSHSCI.TTF [ 95290 ]
          smita.v.pawar Smita Pawar (Inactive) made changes -
          Attachment BRUSHSCI.TTF [ 95290 ]
          smita.v.pawar Smita Pawar (Inactive) made changes -
          Attachment Registration-Upload-Profile.jpg [ 95292 ]
          Hide
          smita.v.pawar Smita Pawar (Inactive) added a comment -

          Hi Aruna Raheja,

          Not suggesting a different way of doing it, but just consistent with other upload image control.

          Have a look at attached screen: Registration-Upload-Profile.jpg. Why I am suggesting, this way we can reuse the previously built components and reduce the code/CSS line numbers with consistency.

          Will take a approval from Molly Ronovsky and Kristen.

           

           

          Show
          smita.v.pawar Smita Pawar (Inactive) added a comment - Hi Aruna Raheja , Not suggesting a different way of doing it, but just consistent with other upload image control. Have a look at attached screen: Registration-Upload-Profile.jpg. Why I am suggesting, this way we can reuse the previously built components and reduce the code/CSS line numbers with consistency. Will take a approval from Molly Ronovsky and Kristen .    
          Hide
          smita.v.pawar Smita Pawar (Inactive) added a comment -

          Molly Ronovsky Please find my comments below on:

          "but i feel like when they get developed they get much bigger / zoomed....can we make sure that doesn't happen?"

          Ideally in responsive web app scenario, we keep widths flexible for the developed components/page, our DMS layout is having Fluid Layout. And the page gets adjusted on any resolution or screen size. If you switch to the medium screens/laptops, there you'll find it small compare to larger monitors/screens. And that is the standard practice.

          But as discussed in the previous calls, for now I have fixed Dashboard tiles for larger screens. And once finalizing the approach will accommodate throughout. 

          Let me know for any queries.

           

          Show
          smita.v.pawar Smita Pawar (Inactive) added a comment - Molly Ronovsky  Please find my comments below on: "but i feel like when they get developed they get much bigger / zoomed....can we make sure that doesn't happen?" Ideally in responsive web app scenario, we keep widths flexible for the developed components/page, our DMS layout is having Fluid Layout . And the page gets adjusted on any resolution or screen size. If you switch to the medium screens/laptops, there you'll find it small compare to larger monitors/screens. And that is the standard practice. But as discussed in the previous calls, for now I have fixed Dashboard tiles for larger screens. And once finalizing the approach will accommodate throughout.  Let me know for any queries.  
          Hide
          Ruel Kristen (Inactive) added a comment -

          Smita Pawar As for the fluid layout for responsiveness, I understand that the page adjusts based on screen size, however we need to define a max container size. This will help to keep screens looking like the designs and not feel odd to users if they are on larger devices.

          cc: Molly Ronovsky, Aruna Raheja

          As for the profile image upload, I think that the dotted line is fine, but I would remove the solid line outside of the dotted line, there is no need for both.

          Show
          Ruel Kristen (Inactive) added a comment - Smita Pawar As for the fluid layout for responsiveness, I understand that the page adjusts based on screen size, however we need to define a max container size. This will help to keep screens looking like the designs and not feel odd to users if they are on larger devices. cc: Molly Ronovsky , Aruna Raheja As for the profile image upload, I think that the dotted line is fine, but I would remove the solid line outside of the dotted line, there is no need for both.
          Hide
          molly.ronovsky Molly Ronovsky (Inactive) added a comment -
          Show
          molly.ronovsky Molly Ronovsky (Inactive) added a comment - Smita Pawar Agree with Kristen Aruna Raheja
          Hide
          smita.v.pawar Smita Pawar (Inactive) added a comment -

          Hi, Kristen, Molly Ronovsky,

          yes, we have fixed the container for larger screens as per requirement and will implement the same for rest of the pages.

          Show
          smita.v.pawar Smita Pawar (Inactive) added a comment - Hi, Kristen , Molly Ronovsky , yes, we have fixed the container for larger screens as per requirement and will implement the same for rest of the pages.
          smita.v.pawar Smita Pawar (Inactive) made changes -
          Assignee Swapnil Pandhare [ swapnil.pandhare ] Smita Pawar [ smita.v.pawar ]
          Hide
          smita.v.pawar Smita Pawar (Inactive) added a comment -

          Aruna Raheja, can you please provide me the default user image, which shown in the mockup.

          Show
          smita.v.pawar Smita Pawar (Inactive) added a comment - Aruna Raheja , can you please provide me the default user image, which shown in the mockup.
          aruna.raheja Aruna Raheja made changes -
          Attachment user_image.svg [ 95464 ]
          Hide
          aruna.raheja Aruna Raheja added a comment -

          Smita Pawar : Please check the attached svg image

          Show
          aruna.raheja Aruna Raheja added a comment - Smita Pawar : Please check the attached svg image
          Hide
          smita.v.pawar Smita Pawar (Inactive) added a comment -

          Hi Swapnil Pandhare,

          I am done with HTML changes, for profile upload.

          Show
          smita.v.pawar Smita Pawar (Inactive) added a comment - Hi Swapnil Pandhare , I am done with HTML changes, for profile upload.
          smita.v.pawar Smita Pawar (Inactive) made changes -
          Assignee Smita Pawar [ smita.v.pawar ] Swapnil Pandhare [ swapnil.pandhare ]
          smita.v.pawar Smita Pawar (Inactive) logged work - 18/Jan/19 10:18 PM
          • Time Spent:
            4h
             

            Updated HTML for upload control.

          smita.v.pawar Smita Pawar (Inactive) made changes -
          Time Spent 1h 10m [ 4200 ] 5h 10m [ 18600 ]
          Worklog Id 158329 [ 158329 ]
          Hide
          smita.v.pawar Smita Pawar (Inactive) added a comment -

          Hi Swapnil,

          Can you please take this ahead for DEV team?

           

          Samir Priya Dhamande

          Show
          smita.v.pawar Smita Pawar (Inactive) added a comment - Hi Swapnil, Can you please take this ahead for DEV team?   Samir Priya Dhamande
          samir Samir made changes -
          Sprint DMS - Sprint 6 [ 159 ]
          samir Samir made changes -
          Original Estimate 4h [ 14400 ]
          samir Samir made changes -
          Fix Version/s Candidate portfolio in DMS [ 10446 ]
          narendra.kumar Narendra Kumar made changes -
          Assignee Swapnil Pandhare [ swapnil.pandhare ] Narendra Kumar [ narendra.kumar ]
          narendra.kumar Narendra Kumar made changes -
          Status To Do [ 10000 ] In Progress [ 3 ]
          Hide
          narendra.kumar Narendra Kumar added a comment -

          Hi Priya Dhamande,

          This is already fixed. Please check it again. Assigning this to you. 

           

          Thanks

          Narendra

          Show
          narendra.kumar Narendra Kumar added a comment - Hi Priya Dhamande , This is already fixed. Please check it again. Assigning this to you.    Thanks Narendra
          narendra.kumar Narendra Kumar made changes -
          Status In Progress [ 3 ] In QA Testing [ 11901 ]
          narendra.kumar Narendra Kumar made changes -
          Assignee Narendra Kumar [ narendra.kumar ] Priya Dhamande [ priya.dhamande ]
          priya.dhamande Priya Dhamande (Inactive) made changes -
          Attachment Screenshot (1086).png [ 102473 ]
          priya.dhamande Priya Dhamande (Inactive) logged work - 28/Mar/19 02:51 AM
          • Time Spent:
            0.25h
             

            Preprod testing and discussion with narendra

          Hide
          priya.dhamande Priya Dhamande (Inactive) added a comment -

          Hi Narendra Kumar,

          Environment: PreProd
          Page: Registration

          The issue is resolved by giving appropriate name to component. Screen capture attached for reference.
          Marking jira Done.

          Swapnil Pandhare

          Show
          priya.dhamande Priya Dhamande (Inactive) added a comment - Hi Narendra Kumar , Environment: PreProd Page: Registration The issue is resolved by giving appropriate name to component. Screen capture attached for reference. Marking jira Done. Swapnil Pandhare
          priya.dhamande Priya Dhamande (Inactive) made changes -
          Time Spent 5h 10m [ 18600 ] 5h 25m [ 19500 ]
          Worklog Id 169146 [ 169146 ]
          priya.dhamande Priya Dhamande (Inactive) made changes -
          Status In QA Testing [ 11901 ] Code Review [ 11801 ]
          priya.dhamande Priya Dhamande (Inactive) made changes -
          Resolution Done [ 10000 ]
          Status Code Review [ 11801 ] Done [ 10001 ]
          priya.dhamande Priya Dhamande (Inactive) made changes -
          Assignee Priya Dhamande [ priya.dhamande ] Narendra Kumar [ narendra.kumar ]
          Transition Time In Source Status Execution Times
          Narendra Kumar made transition -
          To Do In Progress
          73d 42m 1
          Narendra Kumar made transition -
          In Progress In QA Testing
          12s 1
          Priya Dhamande (Inactive) made transition -
          In QA Testing Code Review
          17m 10s 1
          Priya Dhamande (Inactive) made transition -
          Code Review Done
          2s 1

            People

            Assignee:
            narendra.kumar Narendra Kumar
            Reporter:
            priya.dhamande Priya Dhamande (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 4h Original Estimate - 4h
                4h
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 5h 25m
                5h 25m