-
Type:
Bug
-
Status: Done
-
Priority:
Medium
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: Candidate portfolio in DMS
-
Labels:None
Environment: PreProd
Molly's comment:
Upload your file – still seems weird to have this field / what is it for? We have no explanation to candidate.
- Either add note
- check with Aruna Raheja, whether it is required.
- Registration.png
- 214 kB
- Screenshot (1086).png
- 124 kB
- Upload-File.jpg
- 49 kB
- user_image.svg
- 5 kB
Aruna Raheja What is the intended use of this? An image? If so we just need to have verbiage around it so that it is clear to a candidate what it is for as well its super big so i dont want it to take away focus.
Molly Ronovsky : Actually it is for profile pic as we are showing profile pic on Candidate Profile page. So we need that it should get uploaded somewhere. Need your thoughts on this.
CC:Kristen
Aruna Raheja Got it - as long as it's not a huge spot on the page I think that is fine.
Molly Ronovsky : Please check the attached design for Profile Pic section
Aruna Raheja Yes, looks good - as long as it doesn't take over the screen once it comes to fruition because the mock-ups always look good, but i feel like when they get developed they get much bigger / zoomed....can we make sure that doesn't happen? Swapnil Pandhare
Smita Pawar : Kindly use the attached designs for upload profile pic.
Hi Aruna Raheja,
Here for User image upload we have changed the border styling compare to Upload files component used previously. Below is the screenshot:
Is there anything specific thought behind. It would be good if we keep it consistent throughout, we can accommodate profile image circle but I feel other styling can be same.
CC: Molly Ronovsky, Kristen, Swapnil Pandhare
Hi Smita Pawar : As we are not using inner component in this that's why i have used only outer border. Also if we are using inner styling then it will be look much bigger that's why removed it.
If you still feel that we should go the other way then do share the mock and we can have a discussion with Molly Ronovsky and Kristen onto the same.
Hi Aruna Raheja,
Not suggesting a different way of doing it, but just consistent with other upload image control.
Have a look at attached screen: Registration-Upload-Profile.jpg. Why I am suggesting, this way we can reuse the previously built components and reduce the code/CSS line numbers with consistency.
Will take a approval from Molly Ronovsky and Kristen.
Molly Ronovsky Please find my comments below on:
"but i feel like when they get developed they get much bigger / zoomed....can we make sure that doesn't happen?"
Ideally in responsive web app scenario, we keep widths flexible for the developed components/page, our DMS layout is having Fluid Layout. And the page gets adjusted on any resolution or screen size. If you switch to the medium screens/laptops, there you'll find it small compare to larger monitors/screens. And that is the standard practice.
But as discussed in the previous calls, for now I have fixed Dashboard tiles for larger screens. And once finalizing the approach will accommodate throughout.
Let me know for any queries.
Smita Pawar As for the fluid layout for responsiveness, I understand that the page adjusts based on screen size, however we need to define a max container size. This will help to keep screens looking like the designs and not feel odd to users if they are on larger devices.
cc: Molly Ronovsky, Aruna Raheja
As for the profile image upload, I think that the dotted line is fine, but I would remove the solid line outside of the dotted line, there is no need for both.
Hi, Kristen, Molly Ronovsky,
yes, we have fixed the container for larger screens as per requirement and will implement the same for rest of the pages.
Aruna Raheja, can you please provide me the default user image, which shown in the mockup.
Smita Pawar : Please check the attached svg image
Hi Swapnil Pandhare,
I am done with HTML changes, for profile upload.
Hi Priya Dhamande,
This is already fixed. Please check it again. Assigning this to you.
Thanks
Narendra
Hi Narendra Kumar,
Environment: PreProd
Page: Registration
The issue is resolved by giving appropriate name to component. Screen capture attached for reference.
Marking jira Done.
Priya Dhamande : This field was suggested by Samir at the time of designing. I think we should kept it as we are creating candidate profile page and i have given the option of user image there.
Also final decision, whether we need to keep it or not , of this can be taken by Molly Ronovsky
CC: Swapnil Pandhare Kristen