Document Management SystemProject Type: software

Document Management System

Uploaded image for project: 'Document Management System'
  1. Document Management System
  2. DMS-243 Signing
  3. DMS-590

API - Fetch esign for candidate

    Details

    • Type: Sub-task
    • Status: Done
    • Priority: Medium
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None
    • Company:
      All Clients/Multiple Clients

      Description

      To fetch esign for candidate from data store and show on document.

        Attachments

        1. Sign_NoData.JPG
          Sign_NoData.JPG
          42 kB
        2. Sign_Success.JPG
          Sign_Success.JPG
          42 kB
        3. SignSuccess_New.JPG
          SignSuccess_New.JPG
          45 kB

          Issue Links

          clones

          Sub-task - The sub-task of the issue DMS-589 API - Save esign

          • Medium - Has the potential to affect progress.
          • Done

            Activity

            Ascending order - Click to sort in descending order
            swapnil.pandhare Swapnil Pandhare (Inactive) created issue -
            swapnil.pandhare Swapnil Pandhare (Inactive) made changes -
            Field Original Value New Value
            Link This issue clones DMS-589 [ DMS-589 ]
            swapnil.pandhare Swapnil Pandhare (Inactive) made changes -
            Description When employee signs and submit document, sign image should get stored in persistent data store. To fetch esign for candidate from data store and show on document.
            Hide
            Permalink
            ramya.tantry Ramya Tantry (Inactive) added a comment -

            Tasks in this Jira : 

            1. API to return base 64 encoded string from DB as per the personId passed.

            Show
            ramya.tantry Ramya Tantry (Inactive) added a comment - Tasks in this Jira :   1. API to return base 64 encoded string from DB as per the personId passed.
            ramya.tantry Ramya Tantry (Inactive) made changes -
            Remaining Estimate 6h [ 21600 ]
            Original Estimate 6h [ 21600 ]
            ramya.tantry Ramya Tantry (Inactive) made changes -
            Remaining Estimate 6h [ 21600 ] 5.5h [ 19800 ]
            Time Spent 0.5h [ 1800 ]
            Worklog Id 156085 [ 156085 ]
            ramya.tantry Ramya Tantry (Inactive) made changes -
            Remaining Estimate 5.5h [ 19800 ] 6h [ 21600 ]
            Time Spent 0.5h [ 1800 ] 0h [ 0 ]
            Worklog Id 156085 [ 156085 ]
            Worklog Time Spent 0.5h [ 1800 ]
            ramya.tantry Ramya Tantry (Inactive) made changes -
            Status To Do [ 10000 ] In Progress [ 3 ]
            ramya.tantry Ramya Tantry (Inactive) made changes -
            Status In Progress [ 3 ] To Do [ 10000 ]
            ramya.tantry Ramya Tantry (Inactive) made changes -
            Status To Do [ 10000 ] In Progress [ 3 ]
            Permalink
            ramya.tantry Ramya Tantry (Inactive) logged work - 21/Jan/19 05:13 AM
            • Time Spent:
              1h
               
              • Write an API to fetch saved string 
              • Unit Testing
            Hide
            Permalink
            ramya.tantry Ramya Tantry (Inactive) added a comment -

            Task Details (01/12/2019)

            • Write an API to fetch saved sign string 
            • Unit Testing
            Show
            ramya.tantry Ramya Tantry (Inactive) added a comment - Task Details (01/12/2019) Write an API to fetch saved sign string  Unit Testing
            ramya.tantry Ramya Tantry (Inactive) made changes -
            Remaining Estimate 6h [ 21600 ] 5h [ 18000 ]
            Time Spent 0h [ 0 ] 1h [ 3600 ]
            Worklog Id 156279 [ 156279 ]
            Permalink
            ramya.tantry Ramya Tantry (Inactive) logged work - 21/Jan/19 10:30 AM
            • Time Spent:
              2h
               

              Discussion with Swapnil and Narendra
              Code changes

            Hide
            Permalink
            ramya.tantry Ramya Tantry (Inactive) added a comment -

            Hi Narendra Kumar,

            Below are the API details for Fetch Sign :

            [GET] URL :  api/Person/GetPersonSign/{personID}  

            for eg: api/Person/GetPersonSign/10

            For success, the api will return the saved string from db.

            for eg: it will return "ramya.tantry" from db if present

            Incase of no sign is present in DB, then status code will be 204 No content.

            Note: with 204 status code, we cannot send custom message. Custom message need to be handled from Angular side. Also this message need to be in localization as well.

            Show
            ramya.tantry Ramya Tantry (Inactive) added a comment - Hi Narendra Kumar , Below are the API details for Fetch Sign : [GET]  URL :  api/Person/GetPersonSign/{personID}   for eg:  api/Person/GetPersonSign/10 For success, the api will return the saved string from db. for eg: it will return "ramya.tantry" from db if present Incase of no sign is present in DB, then status code will be 204 No content. Note : with 204 status code, we cannot send custom message. Custom message need to be handled from Angular side. Also this message need to be in localization as well.
            Hide
            Permalink
            narendra.kumar Narendra Kumar added a comment -

            Hi Ramya Tantry,

            I got it. But can you please send me actual response body along with all keys?

            Show
            narendra.kumar Narendra Kumar added a comment - Hi Ramya Tantry , I got it. But can you please send me actual response body along with all keys?
            ramya.tantry Ramya Tantry (Inactive) made changes -
            Attachment Sign_Success.JPG [ 95704 ]
            ramya.tantry Ramya Tantry (Inactive) made changes -
            Attachment Sign_NoData.JPG [ 95705 ]
            Hide
            Permalink
            ramya.tantry Ramya Tantry (Inactive) added a comment -

            Hi Narendra Kumar,

            PFA Screenshots of API responses in case of success and no data

            Success: 

            No data :

            No Specific keys have been added to the response body as it just returns a single value.

            Show
            ramya.tantry Ramya Tantry (Inactive) added a comment - Hi Narendra Kumar , PFA Screenshots of API responses in case of success and no data Success:  No data : No Specific keys have been added to the response body as it just returns a single value.
            ramya.tantry Ramya Tantry (Inactive) made changes -
            Remaining Estimate 5h [ 18000 ] 3h [ 10800 ]
            Time Spent 1h [ 3600 ] 3h [ 10800 ]
            Worklog Id 156546 [ 156546 ]
            Hide
            Permalink
            ramya.tantry Ramya Tantry (Inactive) added a comment -

            Task Details (01/22/2019)

            • Discussion with Swapnil and Narendra
            • Code changes
            Show
            ramya.tantry Ramya Tantry (Inactive) added a comment - Task Details (01/22/2019) Discussion with Swapnil and Narendra Code changes
            Permalink
            ramya.tantry Ramya Tantry (Inactive) logged work - 22/Jan/19 10:30 AM - edited
            • Time Spent:
              1.5h
               

              Code changes to fetch sign details
              Unit testing

            ramya.tantry Ramya Tantry (Inactive) made changes -
            Attachment SignSuccess_New.JPG [ 95818 ]
            Hide
            Permalink
            ramya.tantry Ramya Tantry (Inactive) added a comment -

            Hi Narendra Kumar,

            I have made changes to get the SignType and SignText as per required.
            The response on success will be now like this :

            { "SignType": "text", "SignText": "ramya.tantry" }

            On No data, it will same as before.

            Show
            ramya.tantry Ramya Tantry (Inactive) added a comment - Hi Narendra Kumar , I have made changes to get the SignType and SignText as per required. The response on success will be now like this : { "SignType": "text", "SignText": "ramya.tantry" } On No data, it will same as before.
            ramya.tantry Ramya Tantry (Inactive) made changes -
            Remaining Estimate 3h [ 10800 ] 1h [ 3600 ]
            Time Spent 3h [ 10800 ] 5h [ 18000 ]
            Worklog Id 156848 [ 156848 ]
            ramya.tantry Ramya Tantry (Inactive) made changes -
            Remaining Estimate 1h [ 3600 ] 1.5h [ 5400 ]
            Time Spent 5h [ 18000 ] 4.5h [ 16200 ]
            Worklog Id 156848 [ 156848 ]
            ramya.tantry Ramya Tantry (Inactive) made changes -
            Status In Progress [ 3 ] Code Review [ 11801 ]
            ramya.tantry Ramya Tantry (Inactive) made changes -
            Assignee Ramya Tantry [ ramya.tantry ] Swapnil Pandhare [ swapnil.pandhare ]
            Hide
            Permalink
            ramya.tantry Ramya Tantry (Inactive) added a comment - - edited

            Hi Swapnil Pandhare,

            PR has been raised for this. Please check

            Show
            ramya.tantry Ramya Tantry (Inactive) added a comment - - edited Hi Swapnil Pandhare , PR has been raised for this. Please check
            ashwin.wankhede Ashwin Wankhede (Inactive) made changes -
            Assignee Swapnil Pandhare [ swapnil.pandhare ] Jayshree Nagpure [ jayshree.nagpure ]
            ashwin.wankhede Ashwin Wankhede (Inactive) made changes -
            Status Code Review [ 11801 ] In QA Testing [ 11901 ]
            Hide
            Permalink
            jayshree.nagpure Jayshree Nagpure (Inactive) added a comment -

            Hi Ramya Tantry,

            Can you please elaborate what needs to be verified under this ticket

            Priya Dhamande Swapnil Pandhare Samir

            Show
            jayshree.nagpure Jayshree Nagpure (Inactive) added a comment - Hi Ramya Tantry , Can you please elaborate what needs to be verified under this ticket Priya Dhamande Swapnil Pandhare Samir
            Hide
            Permalink
            ramya.tantry Ramya Tantry (Inactive) added a comment -

            Hi Jayshree Nagpure,

            This API is the backend logic to fetch the data that was previous saved from UI.
            There is no specific API testing for this.
            CC: Priya Dhamande,Swapnil Pandhare,Samir

            Show
            ramya.tantry Ramya Tantry (Inactive) added a comment - Hi Jayshree Nagpure , This API is the backend logic to fetch the data that was previous saved from UI. There is no specific API testing for this. CC: Priya Dhamande , Swapnil Pandhare , Samir
            Hide
            Permalink
            jayshree.nagpure Jayshree Nagpure (Inactive) added a comment -

            Based on above comments closing this ticket

            Thanks,
            Jayshree

            Priya Dhamande Swapnil Pandhare Samir Sachin Hingole

            Show
            jayshree.nagpure Jayshree Nagpure (Inactive) added a comment - Based on above comments closing this ticket Thanks, Jayshree Priya Dhamande Swapnil Pandhare Samir Sachin Hingole
            jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
            Resolution Done [ 10000 ]
            Status In QA Testing [ 11901 ] Done [ 10001 ]
            Transition Time In Source Status Execution Times
            Ramya Tantry (Inactive) made transition -
            In Progress To Do
            		5s 1
            Ramya Tantry (Inactive) made transition -
            To Do In Progress
            		3d 8h 41m 2
            Ramya Tantry (Inactive) made transition -
            In Progress Code Review
            		2d 15h 42m 1
            Ashwin Wankhede (Inactive) made transition -
            Code Review In QA Testing
            		6d 2h 29m 1
            Jayshree Nagpure (Inactive) made transition -
            In QA Testing Done
            		7d 23h 28m 1

              People

              Assignee:
              jayshree.nagpure Jayshree Nagpure (Inactive)
              Reporter:
              swapnil.pandhare Swapnil Pandhare (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - 6h
                  6h
                  Remaining:
                  Time Spent - 4.5h Remaining Estimate - 1.5h
                  1.5h
                  Logged:
                  Time Spent - 4.5h Remaining Estimate - 1.5h
                  4.5h