Details

    • Type: Sub-task
    • Status: Done
    • Priority: Medium
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None
    • Company:
      All Clients/Multiple Clients

      Description

      To fetch esign for candidate from data store and show on document.

        Attachments

        1. Sign_NoData.JPG
          Sign_NoData.JPG
          42 kB
        2. Sign_Success.JPG
          Sign_Success.JPG
          42 kB
        3. SignSuccess_New.JPG
          SignSuccess_New.JPG
          45 kB

          Issue Links

            Activity

            Hide
            ramya.tantry Ramya Tantry (Inactive) added a comment -

            Tasks in this Jira : 

            1. API to return base 64 encoded string from DB as per the personId passed.

            Show
            ramya.tantry Ramya Tantry (Inactive) added a comment - Tasks in this Jira :   1. API to return base 64 encoded string from DB as per the personId passed.
            Hide
            ramya.tantry Ramya Tantry (Inactive) added a comment -

            Task Details (01/12/2019)

            • Write an API to fetch saved sign string 
            • Unit Testing
            Show
            ramya.tantry Ramya Tantry (Inactive) added a comment - Task Details (01/12/2019) Write an API to fetch saved sign string  Unit Testing
            Hide
            ramya.tantry Ramya Tantry (Inactive) added a comment -

            Hi Narendra Kumar,

            Below are the API details for Fetch Sign :

            [GET] URL :  api/Person/GetPersonSign/{personID}  

            for eg: api/Person/GetPersonSign/10

            For success, the api will return the saved string from db.

            for eg: it will return "ramya.tantry" from db if present

            Incase of no sign is present in DB, then status code will be 204 No content.

            Note: with 204 status code, we cannot send custom message. Custom message need to be handled from Angular side. Also this message need to be in localization as well.

            Show
            ramya.tantry Ramya Tantry (Inactive) added a comment - Hi Narendra Kumar , Below are the API details for Fetch Sign : [GET]  URL :  api/Person/GetPersonSign/{personID}   for eg:  api/Person/GetPersonSign/10 For success, the api will return the saved string from db. for eg: it will return "ramya.tantry" from db if present Incase of no sign is present in DB, then status code will be 204 No content. Note : with 204 status code, we cannot send custom message. Custom message need to be handled from Angular side. Also this message need to be in localization as well.
            Hide
            narendra.kumar Narendra Kumar added a comment -

            Hi Ramya Tantry,

            I got it. But can you please send me actual response body along with all keys?

            Show
            narendra.kumar Narendra Kumar added a comment - Hi Ramya Tantry , I got it. But can you please send me actual response body along with all keys?
            Hide
            ramya.tantry Ramya Tantry (Inactive) added a comment -

            Hi Narendra Kumar,

            PFA Screenshots of API responses in case of success and no data

            Success: 

            No data :

            No Specific keys have been added to the response body as it just returns a single value.

            Show
            ramya.tantry Ramya Tantry (Inactive) added a comment - Hi Narendra Kumar , PFA Screenshots of API responses in case of success and no data Success:  No data : No Specific keys have been added to the response body as it just returns a single value.
            Hide
            ramya.tantry Ramya Tantry (Inactive) added a comment -

            Task Details (01/22/2019)

            • Discussion with Swapnil and Narendra
            • Code changes
            Show
            ramya.tantry Ramya Tantry (Inactive) added a comment - Task Details (01/22/2019) Discussion with Swapnil and Narendra Code changes
            Hide
            ramya.tantry Ramya Tantry (Inactive) added a comment -

            Hi Narendra Kumar,

            I have made changes to get the SignType and SignText as per required.
            The response on success will be now like this :

            { "SignType": "text", "SignText": "ramya.tantry" }

            On No data, it will same as before.

            Show
            ramya.tantry Ramya Tantry (Inactive) added a comment - Hi Narendra Kumar , I have made changes to get the SignType and SignText as per required. The response on success will be now like this : { "SignType": "text", "SignText": "ramya.tantry" } On No data, it will same as before.
            Hide
            ramya.tantry Ramya Tantry (Inactive) added a comment - - edited

            Hi Swapnil Pandhare,

            PR has been raised for this. Please check

            Show
            ramya.tantry Ramya Tantry (Inactive) added a comment - - edited Hi Swapnil Pandhare , PR has been raised for this. Please check
            Hide
            jayshree.nagpure Jayshree Nagpure (Inactive) added a comment -

            Hi Ramya Tantry,

            Can you please elaborate what needs to be verified under this ticket

            Priya Dhamande Swapnil Pandhare Samir

            Show
            jayshree.nagpure Jayshree Nagpure (Inactive) added a comment - Hi Ramya Tantry , Can you please elaborate what needs to be verified under this ticket Priya Dhamande Swapnil Pandhare Samir
            Hide
            ramya.tantry Ramya Tantry (Inactive) added a comment -

            Hi Jayshree Nagpure,

            This API is the backend logic to fetch the data that was previous saved from UI.
            There is no specific API testing for this.
            CC: Priya Dhamande,Swapnil Pandhare,Samir

            Show
            ramya.tantry Ramya Tantry (Inactive) added a comment - Hi Jayshree Nagpure , This API is the backend logic to fetch the data that was previous saved from UI. There is no specific API testing for this. CC: Priya Dhamande , Swapnil Pandhare , Samir
            Hide
            jayshree.nagpure Jayshree Nagpure (Inactive) added a comment -

            Based on above comments closing this ticket

            Thanks,
            Jayshree

            Priya Dhamande Swapnil Pandhare Samir Sachin Hingole

            Show
            jayshree.nagpure Jayshree Nagpure (Inactive) added a comment - Based on above comments closing this ticket Thanks, Jayshree Priya Dhamande Swapnil Pandhare Samir Sachin Hingole

              People

              Assignee:
              jayshree.nagpure Jayshree Nagpure (Inactive)
              Reporter:
              swapnil.pandhare Swapnil Pandhare (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - 6h
                  6h
                  Remaining:
                  Time Spent - 4.5h Remaining Estimate - 1.5h
                  1.5h
                  Logged:
                  Time Spent - 4.5h Remaining Estimate - 1.5h
                  4.5h