Document Management SystemProject Type: software

Document Management System

Uploaded image for project: 'Document Management System'
  1. Document Management System
  2. DMS-705

SMB : Preview API Security

    Details

    • Type: New Feature
    • Status: Done
    • Priority: Medium
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: Integration with SMB
    • Labels:
      None

      Description

      Provide security for preview document.

        Attachments

        1. DMS-705.jpg
          DMS-705.jpg
          160 kB
        2. DMS-705.jpg
          DMS-705.jpg
          119 kB

          Issue Links

          is blocked by

          Bug - A problem which impairs or prevents the functions of the product. DMS-944 API | Preview Document not working

          • High - Serious problem that could block progress.
          • Done

            Activity

            Ascending order - Click to sort in descending order
            rohan.khandave Rohan J Khandave (Inactive) created issue -
            rohan.khandave Rohan J Khandave (Inactive) made changes -
            Field Original Value New Value
            Epic Link DMS-508 [ 76001 ]
            rohan.khandave Rohan J Khandave (Inactive) made changes -
            Assignee Samir [ samir ] Rohan J Khandave [ rohan.khandave ]
            Remaining Estimate 32h [ 115200 ]
            Original Estimate 32h [ 115200 ]
            rohan.khandave Rohan J Khandave (Inactive) made changes -
            Sprint DMS - Sprint 3 [ 152 ]
            Hide
            Permalink
            rohan.khandave Rohan J Khandave (Inactive) added a comment -

            Approach :

            1. Preview document link will have one token.
            2. At our end we validate token & will display document.
            3. Token will be valid for specific time period .
            4. If token expired / not valid , we will show message regarding same.

            Show
            rohan.khandave Rohan J Khandave (Inactive) added a comment - Approach : 1. Preview document link will have one token. 2. At our end we validate token & will display document. 3. Token will be valid for specific time period . 4. If token expired / not valid , we will show message regarding same.
            swapnil.pandhare Swapnil Pandhare (Inactive) made changes -
            Remaining Estimate 32h [ 115200 ] 24h [ 86400 ]
            Original Estimate 32h [ 115200 ] 24h [ 86400 ]
            samir Samir made changes -
            Assignee Rohan J Khandave [ rohan.khandave ] Suraj Sokasane [ suraj.sokasane ]
            suraj.sokasane Suraj Sokasane (Inactive) made changes -
            Status To Do [ 10000 ] In Progress [ 3 ]
            suraj.sokasane Suraj Sokasane (Inactive) made changes -
            Status In Progress [ 3 ] Code Review [ 11801 ]
            suraj.sokasane Suraj Sokasane (Inactive) made changes -
            Assignee Suraj Sokasane [ suraj.sokasane ] Rohan J Khandave [ rohan.khandave ]
            Raj.Hawaldar Raj Hawaldar (Inactive) made changes -
            Status Code Review [ 11801 ] In QA Testing [ 11901 ]
            Raj.Hawaldar Raj Hawaldar (Inactive) made changes -
            Assignee Rohan J Khandave [ rohan.khandave ] Jayshree Nagpure [ jayshree.nagpure ]
            Permalink
            rohan.khandave Rohan J Khandave (Inactive) logged work - 22/Feb/19 09:40 AM
            • Time Spent:
              2h
               

              Discussion & Code review

            swapnil.pandhare Swapnil Pandhare (Inactive) made changes -
            Sprint DMS - Sprint 3 [ 152 ] DMS - Sprint 3, DMS - Sprint 4 [ 152, 153 ]
            swapnil.pandhare Swapnil Pandhare (Inactive) made changes -
            Status In QA Testing [ 11901 ] Code Review [ 11801 ]
            Raj.Hawaldar Raj Hawaldar (Inactive) made changes -
            Status Code Review [ 11801 ] In QA Testing [ 11901 ]
            Hide
            Permalink
            jayshree.nagpure Jayshree Nagpure (Inactive) added a comment - - edited

            Hi Rohan J Khandave,

            Verified the token for Preview document.
            https://dms.workterra.net/viewer?Token=c93ef07906bc48c0a670350581dba3ce&key=da24842e1fae82bf714ee7be7edbfd06602d6b24b391967ead5718f29032c4f1

            Will check tomorrow for expiration scenario.

            Thanks,
            Jayshree

            Priya Dhamande Samir Swapnil Pandhare

            Show
            jayshree.nagpure Jayshree Nagpure (Inactive) added a comment - - edited Hi Rohan J Khandave , Verified the token for Preview document. https://dms.workterra.net/viewer?Token=c93ef07906bc48c0a670350581dba3ce&key=da24842e1fae82bf714ee7be7edbfd06602d6b24b391967ead5718f29032c4f1 Will check tomorrow for expiration scenario. Thanks, Jayshree Priya Dhamande Samir Swapnil Pandhare
            Permalink
            jayshree.nagpure Jayshree Nagpure (Inactive) logged work - 27/Feb/19 03:51 AM
            • Time Spent:
              1.5h
               

              testing

            jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
            Remaining Estimate 24h [ 86400 ] 22.5h [ 81000 ]
            Time Spent 1.5h [ 5400 ]
            Worklog Id 163569 [ 163569 ]
            rohan.khandave Rohan J Khandave (Inactive) made changes -
            Remaining Estimate 22.5h [ 81000 ] 20.5h [ 73800 ]
            Time Spent 1.5h [ 5400 ] 3.5h [ 12600 ]
            Worklog Id 163812 [ 163812 ]
            jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
            Attachment DMS-705.jpg [ 99907 ]
            Hide
            Permalink
            jayshree.nagpure Jayshree Nagpure (Inactive) added a comment -

            Hi Rohan J Khandave,

            As per our discussion . document will expire after 24 hours.
            But We are able to access document after 24 hours also.
            PFA -

            Re-opening for the same

            Thanks,
            Jayshree

            Priya Dhamande Swapnil Pandhare Samir

            Show
            jayshree.nagpure Jayshree Nagpure (Inactive) added a comment - Hi Rohan J Khandave , As per our discussion . document will expire after 24 hours. But We are able to access document after 24 hours also. PFA - Re-opening for the same Thanks, Jayshree Priya Dhamande Swapnil Pandhare Samir
            jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
            Status In QA Testing [ 11901 ] In Progress [ 3 ]
            jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
            Assignee Jayshree Nagpure [ jayshree.nagpure ] Rohan J Khandave [ rohan.khandave ]
            Hide
            Permalink
            rohan.khandave Rohan J Khandave (Inactive) added a comment -

            https://dmsstage.workterra.net/viewer?Token=056d679dbc66426aa347b1503dbd2de5&key=fec937f9831f37e540ffa173cc408b9d0ad117c35f03f4ddeb2357fa4637b3da

            https://dmsstage.workterra.net/viewer?Token=40c9908c146c4d2dadc29c8f8d345771&key=44a6d61fc47eed0329bc483ffbe83d942649cbc5060305556cc7f3388db4bbeb

            https://dmsstage.workterra.net/viewer?Token=b0ca64aefb374604bdce3f843df2cd68&key=00bfa26f6ca75bb8087e7d4c2cf963ab03277ed5e3736c097cd8f1f2cc0f5c92

            https://dmsstage.workterra.net/viewer?Token=7de4218b8954406c9c0a451f5d28ff58&key=6957896f9d99f40aca20e20dd0d24171a7a88368e8616f0723491ab47c1af034

            Show
            rohan.khandave Rohan J Khandave (Inactive) added a comment - https://dmsstage.workterra.net/viewer?Token=056d679dbc66426aa347b1503dbd2de5&key=fec937f9831f37e540ffa173cc408b9d0ad117c35f03f4ddeb2357fa4637b3da https://dmsstage.workterra.net/viewer?Token=40c9908c146c4d2dadc29c8f8d345771&key=44a6d61fc47eed0329bc483ffbe83d942649cbc5060305556cc7f3388db4bbeb https://dmsstage.workterra.net/viewer?Token=b0ca64aefb374604bdce3f843df2cd68&key=00bfa26f6ca75bb8087e7d4c2cf963ab03277ed5e3736c097cd8f1f2cc0f5c92 https://dmsstage.workterra.net/viewer?Token=7de4218b8954406c9c0a451f5d28ff58&key=6957896f9d99f40aca20e20dd0d24171a7a88368e8616f0723491ab47c1af034
            Permalink
            komal.barde Komal Barde (Inactive) logged work - 07/Mar/19 01:24 PM
            • Time Spent:
              1h
               

              Jira discussion with Suraj
              Issue repro on local

            rohan.khandave Rohan J Khandave (Inactive) made changes -
            Assignee Rohan J Khandave [ rohan.khandave ] Komal Barde [ komal.barde ]
            komal.barde Komal Barde (Inactive) made changes -
            Remaining Estimate 20.5h [ 73800 ] 19.5h [ 70200 ]
            Time Spent 3.5h [ 12600 ] 4.5h [ 16200 ]
            Worklog Id 165409 [ 165409 ]
            Permalink
            komal.barde Komal Barde (Inactive) logged work - 10/Mar/19 05:31 PM
            • Time Spent:
              2.5h
               
              1. Issue analysis and repro
              2. Code fixing for same (In-progress)
            swapnil.pandhare Swapnil Pandhare (Inactive) made changes -
            Sprint DMS - Sprint 3, DMS - Sprint 4 [ 152, 153 ] DMS - Sprint 3, DMS - Sprint 4, DMS - Sprint 5 [ 152, 153, 154 ]
            Hide
            Permalink
            komal.barde Komal Barde (Inactive) added a comment -

            Task Done:

            1. Issue analysis and repro
            2. Code fixing for same (In-progress)
               
            Show
            komal.barde Komal Barde (Inactive) added a comment - Task Done: Issue analysis and repro Code fixing for same (In-progress)  
            komal.barde Komal Barde (Inactive) made changes -
            Remaining Estimate 19.5h [ 70200 ] 17h [ 61200 ]
            Time Spent 4.5h [ 16200 ] 7h [ 25200 ]
            Worklog Id 165641 [ 165641 ]
            Permalink
            komal.barde Komal Barde (Inactive) logged work - 12/Mar/19 11:38 AM
            • Time Spent:
              3.5h
               
              • Code fixing and Unit testing
              • Discussion with Rohan
            komal.barde Komal Barde (Inactive) made changes -
            Assignee Komal Barde [ komal.barde ] Ganesh Sadawarte [ ganesh.sadawarte ]
            komal.barde Komal Barde (Inactive) made changes -
            Status In Progress [ 3 ] Code Review [ 11801 ]
            komal.barde Komal Barde (Inactive) made changes -
            Remaining Estimate 17h [ 61200 ] 13.5h [ 48600 ]
            Time Spent 7h [ 25200 ] 10.5h [ 37800 ]
            Worklog Id 166190 [ 166190 ]
            Permalink
            Ganesh.sadawarte Ganesh Sadawarte (Inactive) logged work - 13/Mar/19 07:07 AM
            • Time Spent:
              10m
               
              <No comment>
            Ganesh.sadawarte Ganesh Sadawarte (Inactive) made changes -
            Remaining Estimate 13.5h [ 48600 ] 13h 20m [ 48000 ]
            Time Spent 10.5h [ 37800 ] 10h 40m [ 38400 ]
            Worklog Id 166398 [ 166398 ]
            Hide
            Permalink
            Ganesh.sadawarte Ganesh Sadawarte (Inactive) added a comment -

            Code review completed.

            Show
            Ganesh.sadawarte Ganesh Sadawarte (Inactive) added a comment - Code review completed.
            Hide
            Permalink
            komal.barde Komal Barde (Inactive) added a comment -

            List of modified files:

            1. DMS/DMS.App/src/DMS_WebApi/Controllers/UserAccount/UserController.cs
            2. DMS/DMS.Web/src/DMS_WebApp/ClientApp/src/app/Shared/Components/viewer/viewer.component.ts

            Unit testing done:

            1. Access document with active token
            2. Access document with expired token
            Show
            komal.barde Komal Barde (Inactive) added a comment - List of modified files : DMS/DMS.App/src/DMS_WebApi/Controllers/UserAccount/UserController.cs DMS/DMS.Web/src/DMS_WebApp/ClientApp/src/app/Shared/Components/viewer/viewer.component.ts Unit testing done : Access document with active token Access document with expired token
            Raj.Hawaldar Raj Hawaldar (Inactive) made changes -
            Status Code Review [ 11801 ] In QA Testing [ 11901 ]
            Raj.Hawaldar Raj Hawaldar (Inactive) made changes -
            Assignee Ganesh Sadawarte [ ganesh.sadawarte ] Priya Dhamande [ priya.dhamande ]
            Hide
            Permalink
            jayshree.nagpure Jayshree Nagpure (Inactive) added a comment -

            1. Verified for old documents - Working as expected
            2. For newly created document, as Preview is not working , not able to verify the scenario

            For #2 - assigning this ticket.
            Assign back when preview issue is resolved.

            Thanks,
            Jayshree

            Show
            jayshree.nagpure Jayshree Nagpure (Inactive) added a comment - 1. Verified for old documents - Working as expected 2. For newly created document, as Preview is not working , not able to verify the scenario For #2 - assigning this ticket. Assign back when preview issue is resolved. Thanks, Jayshree
            jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
            Attachment DMS-705.jpg [ 101143 ]
            jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
            Link This issue is blocked by DMS-944 [ DMS-944 ]
            jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
            Status In QA Testing [ 11901 ] In Progress [ 3 ]
            jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
            Assignee Priya Dhamande [ priya.dhamande ] Komal Barde [ komal.barde ]
            Hide
            Permalink
            komal.barde Komal Barde (Inactive) added a comment -

            Hi Jayshree Nagpure,

            As discussed, the preview issue of second point is not related to this jira, so assigning this jira back to you. If you find any issue in preview of expire token then assign this jira back to me. And please create new jira for preview issue of second point.

            Thanks,
            Komal
            CC: Rohan J Khandave, Ganesh Sadawarte

            Show
            komal.barde Komal Barde (Inactive) added a comment - Hi Jayshree Nagpure , As discussed, the preview issue of second point is not related to this jira, so assigning this jira back to you. If you find any issue in preview of expire token then assign this jira back to me. And please create new jira for preview issue of second point. Thanks, Komal CC: Rohan J Khandave , Ganesh Sadawarte
            komal.barde Komal Barde (Inactive) made changes -
            Assignee Komal Barde [ komal.barde ] Jayshree Nagpure [ jayshree.nagpure ]
            komal.barde Komal Barde (Inactive) made changes -
            Status In Progress [ 3 ] In QA Testing [ 11901 ]
            Permalink
            komal.barde Komal Barde (Inactive) logged work - 14/Mar/19 05:50 AM
            • Time Spent:
              0.5h
               

              Discussion with Jayshree
              Issue analysis

            komal.barde Komal Barde (Inactive) made changes -
            Remaining Estimate 13h 20m [ 48000 ] 12h 50m [ 46200 ]
            Time Spent 10h 40m [ 38400 ] 11h 10m [ 40200 ]
            Worklog Id 166608 [ 166608 ]
            Permalink
            jayshree.nagpure Jayshree Nagpure (Inactive) logged work - 14/Mar/19 06:04 AM
            • Time Spent:
              1h
               

              testing

            jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
            Remaining Estimate 12h 50m [ 46200 ] 11h 50m [ 42600 ]
            Time Spent 11h 10m [ 40200 ] 12h 10m [ 43800 ]
            Worklog Id 166619 [ 166619 ]
            priya.dhamande Priya Dhamande (Inactive) made changes -
            Assignee Jayshree Nagpure [ jayshree.nagpure ] Priya Dhamande [ priya.dhamande ]
            Hide
            Permalink
            jayshree.nagpure Jayshree Nagpure (Inactive) added a comment -

            Based on above comments closing this ticket

            Thanks,
            Jayshree

            Show
            jayshree.nagpure Jayshree Nagpure (Inactive) added a comment - Based on above comments closing this ticket Thanks, Jayshree
            jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
            Resolution Done [ 10000 ]
            Status In QA Testing [ 11901 ] Done [ 10001 ]
            jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
            Assignee Priya Dhamande [ priya.dhamande ] Komal Barde [ komal.barde ]
            Transition Time In Source Status Execution Times
            Suraj Sokasane (Inactive) made transition -
            To Do In Progress
            		13d 54m 1
            Swapnil Pandhare (Inactive) made transition -
            In QA Testing Code Review
            		3d 1h 12m 1
            Komal Barde (Inactive) made transition -
            In Progress Code Review
            		14d 8h 4m 2
            Raj Hawaldar (Inactive) made transition -
            Code Review In QA Testing
            		2d 18h 54m 3
            Jayshree Nagpure (Inactive) made transition -
            In QA Testing In Progress
            		3d 23h 15m 2
            Komal Barde (Inactive) made transition -
            In Progress In QA Testing
            		50m 31s 1
            Jayshree Nagpure (Inactive) made transition -
            In QA Testing Done
            		10d 22h 14m 1

              People

              Assignee:
              komal.barde Komal Barde (Inactive)
              Reporter:
              rohan.khandave Rohan J Khandave (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - 24h
                  24h
                  Remaining:
                  Time Spent - 12h 10m Remaining Estimate - 11h 50m
                  11h 50m
                  Logged:
                  Time Spent - 12h 10m Remaining Estimate - 11h 50m
                  12h 10m