Task Details (03/05/2019)

• Code changes for Date format and human readable string.
• Discussion with Swapnil

Hi Swapnil Pandhare,

For points 1 and 6, We need to make changes in SMB offer letter PDF.
Point 1, we need to align the field correctly. Also set the font color as well.
Point 6, need to make the field multi-line. As of now, one one line can be seen.
Can Smita or Namrata, take this ahead?

CC:Samir,Smita Pawar

Hi Ramya Tantry,

Can you please get Point 1 and 6 done on Smita or Namrata's machine as they don't have update on details.

Thanks,
Swapnil P.

Hi Harshveer Singh,

I have raised PR for below points. Please review and merge the same.

1. 2019-09-02 - should be converted into correct region format. For US it is MM/DD/YYYY
2. fifteen_and_last_day - id to be converted into human readable string

Rest points will be done by Smita as they are changes to the PDF. There are no code changes for that.

CC: Swapnil Pandhare

Hi Ramya Tantry,

Please find attached updated PDF. Changes done for mentioned points.

Hi Priya Dhamande,

Below changes are done for mentioned points in Description.
1. Font for fields and template is diffrent should be the same
– We have matched the Font and Font color of the Main offer letter Text.
2. Gaps after inserted fields - should be smooth
– There will be Gaps as per the text field that has been have set in the PDF. We cannot change this length based on text and rearrange the remaining text.
3. 2019-09-02 - should be converted into correct region format. For US it is MM/DD/YYYY 
– This change has been done.
4. semi-monthly - id to be converted into human readable string
– No change done for this as this is dash seperated value.
5. fifteen_and_last_day - id to be converted into human readable string
– This is done. We have removed the underscore between the text.
6. Roles and Responsivilities... - we are planning to send multiline text with lines delimited by \n character. Please test multiline
– Multiline is done for Roles and responsibilities and Benefits.

Latest PDF has been updated on Pre-prod and Prod.
Please verify above points on Pre-prod(template ID : 412) and Prod(template ID: 400)

 CC: Swapnil Pandhare

1. Font for fields and template is different should be the same
   – We have matched the Font and Font color of the Main offer letter Text.
   QA Comments - Font color is matched as per PDF font color.

2. Gaps after inserted fields - should be smooth
– There will be Gaps as per the text field that has been have set in the PDF. We cannot change this length based on text and rearrange the remaining text. 
QA Comments - Gaps are not as smooth, as the text-field length is set.

3. 2019-09-02 - should be converted into correct region format. For US it is MM/DD/YYYY 
– This change has been done.
QA Comments - The date format is done as MM/DD/YYYY

4. semi-monthly - id to be converted into human readable string
– No change done for this as this is dash separated value.
QA Comments - This is as per text field width this cannot be changed.

5. fifteen_and_last_day - id to be converted into human readable string
– This is done. We have removed the underscore between the text.
QA Comments - Done

6. Roles and Responsivilities... - we are planning to send multiline text with lines delimited by \n character. Please test multiline
– Multiline is done for Roles and responsibilities and Benefits.
QA Comments - Checked by adding text

Latest PDf attched with Jira.

Preview-OfferLetter_SMB.pdf

Ramya Tantry, verified against teh points mentione.

Swapnil Pandhare Samir

As per discussion with Dmitry, below needs to changed:
2.Gaps after inserted fields - should be smooth - Need to take this point
4. semi-monthly - id to be converted into human readable string - Need to give more description
6. Roles and Responsivilities... - we are planning to send multiline text with lines delimited by \n character. Please test multiline - This should be flexible

Thanks,
Swapnil P.