Uploaded image for project: 'Document Management System'
  1. Document Management System
  2. DMS-985

CBATS : Update Existing Company Information

    Details

    • Type: New Feature
    • Status: Done
    • Priority: Medium
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: Integration with CBAT
    • Labels:
      None

      Description

      CBATS have update company page, so needed API to update company data.

        Attachments

          Activity

          rohan.khandave Rohan J Khandave (Inactive) created issue -
          rohan.khandave Rohan J Khandave (Inactive) made changes -
          Field Original Value New Value
          Epic Link DMS-473 [ 75966 ]
          samir Samir made changes -
          Assignee Samir [ samir ] Ramya Tantry [ ramya.tantry ]
          ramya.tantry Ramya Tantry (Inactive) made changes -
          Status To Do [ 10000 ] In Progress [ 3 ]
          Hide
          ramya.tantry Ramya Tantry (Inactive) added a comment -

          Approach: We will be using the same POST API of Add company [/api/company] for updating data.

          Items considered for updation:

          1. Address details
          2. Company details

          Shamooka Mohapatra : Should Source Product list and Language list be considered for updation. If Yes, which approach to consider -

          1. Earlier source product list and language list will be replaced with latest provided data   - OR-
          2. Should it be incremental(earlier data+latest data).

          Please let us know your views on above.

          CC: Rohan J Khandave,Swapnil Pandhare,Samir

          Show
          ramya.tantry Ramya Tantry (Inactive) added a comment - Approach : We will be using the same POST API of Add company [/api/company] for updating data. Items considered for updation: Address details Company details Shamooka Mohapatra : Should Source Product list and Language list be considered for updation. If Yes, which approach to consider - Earlier source product list and language list will be replaced with latest provided data   - OR- Should it be incremental(earlier data+latest data). Please let us know your views on above. CC: Rohan J Khandave , Swapnil Pandhare , Samir
          Hide
          ramya.tantry Ramya Tantry (Inactive) added a comment -

          As discussed, we will be creating new API with PUT for updating data.

          Items considered for updation:

          1. Address details
          2. Company details - except accountdid and sourcecompanyID
          3. Email details
          4. Phone details
          5. Incremental Update of Source product list and Language list

           

           

          Show
          ramya.tantry Ramya Tantry (Inactive) added a comment - As discussed, we will be creating new API with PUT for updating data. Items considered for updation: Address details Company details - except accountdid and sourcecompanyID Email details Phone details Incremental Update of Source product list and Language list    
          ramya.tantry Ramya Tantry (Inactive) made changes -
          Remaining Estimate 16h [ 57600 ] 22h [ 79200 ]
          Original Estimate 16h [ 57600 ] 22h [ 79200 ]
          ramya.tantry Ramya Tantry (Inactive) logged work - 26/Mar/19 05:47 AM
          • Time Spent:
            6h
             

            Discussion with Swapnil and Rohan

            Code change

          ramya.tantry Ramya Tantry (Inactive) made changes -
          Remaining Estimate 22h [ 79200 ] 16h [ 57600 ]
          Time Spent 6h [ 21600 ]
          Worklog Id 168625 [ 168625 ]
          ramya.tantry Ramya Tantry (Inactive) logged work - 27/Mar/19 06:07 AM - edited
          • Time Spent:
            5h
             

            Code changes

            Unit testing

             

          ramya.tantry Ramya Tantry (Inactive) made changes -
          Remaining Estimate 16h [ 57600 ] 10h [ 36000 ]
          Time Spent 6h [ 21600 ] 12h [ 43200 ]
          Worklog Id 168813 [ 168813 ]
          ramya.tantry Ramya Tantry (Inactive) made changes -
          Remaining Estimate 10h [ 36000 ] 11h [ 39600 ]
          Time Spent 12h [ 43200 ] 11h [ 39600 ]
          Worklog Id 168813 [ 168813 ]
          ramya.tantry Ramya Tantry (Inactive) made changes -
          Status In Progress [ 3 ] Code Review [ 11801 ]
          ramya.tantry Ramya Tantry (Inactive) logged work - 28/Mar/19 03:04 AM
          • Time Spent:
            4h
             

            Unit testing

            Script creation

            Raise PR

          ramya.tantry Ramya Tantry (Inactive) made changes -
          Remaining Estimate 11h [ 39600 ] 7h [ 25200 ]
          Time Spent 11h [ 39600 ] 15h [ 54000 ]
          Worklog Id 169166 [ 169166 ]
          ramya.tantry Ramya Tantry (Inactive) made changes -
          Assignee Ramya Tantry [ ramya.tantry ] Rohan J Khandave [ rohan.khandave ]
          ramya.tantry Ramya Tantry (Inactive) logged work - 29/Mar/19 03:03 AM
          • Time Spent:
            2h
             

            Code review changes and testing

          ramya.tantry Ramya Tantry (Inactive) made changes -
          Remaining Estimate 7h [ 25200 ] 5h [ 18000 ]
          Time Spent 15h [ 54000 ] 17h [ 61200 ]
          Worklog Id 169729 [ 169729 ]
          rohan.khandave Rohan J Khandave (Inactive) made changes -
          Assignee Rohan J Khandave [ rohan.khandave ] Ramya Tantry [ ramya.tantry ]
          Developer Ramya Tantry [ ramya.tantry ]
          Hide
          rohan.khandave Rohan J Khandave (Inactive) added a comment -

          Code review done.

          Show
          rohan.khandave Rohan J Khandave (Inactive) added a comment - Code review done.
          Raj.Hawaldar Raj Hawaldar (Inactive) made changes -
          Status Code Review [ 11801 ] In QA Testing [ 11901 ]
          Raj.Hawaldar Raj Hawaldar (Inactive) made changes -
          Assignee Ramya Tantry [ ramya.tantry ] Priya Dhamande [ priya.dhamande ]
          rohan.khandave Rohan J Khandave (Inactive) logged work - 01/Apr/19 07:47 AM
          • Time Spent:
            1h
             

            Code review

          priya.dhamande Priya Dhamande (Inactive) made changes -
          Assignee Priya Dhamande [ priya.dhamande ] Jayshree Nagpure [ jayshree.nagpure ]
          rohan.khandave Rohan J Khandave (Inactive) made changes -
          Remaining Estimate 5h [ 18000 ] 4h [ 14400 ]
          Time Spent 17h [ 61200 ] 18h [ 64800 ]
          Worklog Id 170430 [ 170430 ]
          jayshree.nagpure Jayshree Nagpure (Inactive) logged work - 03/Apr/19 05:38 AM
          • Time Spent:
            1h
             

            testing on Preproduction

          Hide
          jayshree.nagpure Jayshree Nagpure (Inactive) added a comment -

          Verified on Preproduction.

          Verified updating of Company information details :
          Address details
          Company details - except accountdid and sourcecompanyID
          Email details
          Phone details
          Incremental Update of Source product list and Language list

          Working fine as Expected

          Thanks,
          Jayshree

          Priya Dhamande Sachin Hingole Hrishikesh Deshpande Satya Samir

          Show
          jayshree.nagpure Jayshree Nagpure (Inactive) added a comment - Verified on Preproduction. Verified updating of Company information details : Address details Company details - except accountdid and sourcecompanyID Email details Phone details Incremental Update of Source product list and Language list Working fine as Expected Thanks, Jayshree Priya Dhamande Sachin Hingole Hrishikesh Deshpande Satya Samir
          jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
          Resolution Done [ 10000 ]
          Status In QA Testing [ 11901 ] Done [ 10001 ]
          jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
          Assignee Jayshree Nagpure [ jayshree.nagpure ] Ramya Tantry [ ramya.tantry ]
          jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
          Remaining Estimate 4h [ 14400 ] 3h [ 10800 ]
          Time Spent 18h [ 64800 ] 19h [ 68400 ]
          Worklog Id 170623 [ 170623 ]
          Transition Time In Source Status Execution Times
          Ramya Tantry (Inactive) made transition -
          To Do In Progress
          19h 45m 1
          Ramya Tantry (Inactive) made transition -
          In Progress Code Review
          2d 5h 7m 1
          Raj Hawaldar (Inactive) made transition -
          Code Review In QA Testing
          3d 23h 41m 1
          Jayshree Nagpure (Inactive) made transition -
          In QA Testing Done
          2d 2h 54m 1

            People

            Assignee:
            ramya.tantry Ramya Tantry (Inactive)
            Reporter:
            rohan.khandave Rohan J Khandave (Inactive)
            Developer:
            Ramya Tantry (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 22h
                22h
                Remaining:
                Time Spent - 19h Remaining Estimate - 3h
                3h
                Logged:
                Time Spent - 19h Remaining Estimate - 3h
                19h