[NF-1339] Bullhorn Integration->Proper message should be display instead of error message if credentials are invalid - Workterra Jira

Details

Type: Bug
Status: Closed
Priority: Low
Resolution: Done
Affects Version/s: None
Fix Version/s: None
Component/s: Integrations
Labels:
None

Bug Type:
Functional
Module:
Bullhorn
Reported by:
Harbinger
Item State:
Production Complete - Closed
Issue Importance:
Q2

Description

1] Access the tour details page using below URL:
https://10.0.2.120/api/app/TourListing/ListTours?requestFrom=wRnQ7Y%2fZWlCOXjmz9IS4jw%3d%3d&userName=%2bsj2KXYNrgm8O4Va%2bHPUTQ%3d%3d&password=T6NiPfpN8kLQSGDeUamNAw%3d%3d&corporationID=9587&entityType=Placement&entityID=3
2] In above URL mentioned any invalid value for password/userid/corporationID or entity ID.

Actual Result:
Below error message should is displaying:
Sorry, an error occurred while processing your request.
Expected Result:
Proper message should be display so that user can know about invalid credentials.
(Refer attached screenshot for more detials)

Attachments

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

Attachments

ErrorMessage.jpg
62 kB
05/May/17 11:10 AM
InvalidEntityID.jpg
61 kB
08/May/17 12:21 PM
Stage_Pass.jpg
82 kB
12/May/17 11:10 AM

Issue Links

relates to

NF-1063 Bullhorn Integration: Authentication and Authorization

Closed

Activity

Ascending order - Click to sort in descending order

Kunal Kedari (Inactive) created issue - 05/May/17 11:11 AM

Hide

Permalink

Ramya Tantry (Inactive) added a comment - 08/May/17 03:56 AM

Hi Saurabh Sablaka,

Please let me know your views on this scenario.
If we remove one of the characters from encoded value of password or username,validation of user fails and error page is shown(see screenshot attached by QA).
This is the generic error page that we show in case any validation fails.

Since we are going to set the URL in custom tab,will there be a scenario where user authentication fails,Unless someone manually changes the url.
Should we provide more specific error message for every validation?

Show

Ramya Tantry (Inactive) added a comment - 08/May/17 03:56 AM Hi Saurabh Sablaka , Please let me know your views on this scenario. If we remove one of the characters from encoded value of password or username,validation of user fails and error page is shown(see screenshot attached by QA). This is the generic error page that we show in case any validation fails. Since we are going to set the URL in custom tab,will there be a scenario where user authentication fails,Unless someone manually changes the url. Should we provide more specific error message for every validation?

Ramya Tantry (Inactive) made changes - 08/May/17 03:56 AM

Field	Original Value	New Value
Developer		Ramya Tantry [ ramya.tantry ]
Item State		Parent values: Development(10200)Level 1 values: In Analysis(10204)
Remaining Estimate		8h [ 28800 ]
Original Estimate		8h [ 28800 ]

Ramya Tantry (Inactive) made changes - 08/May/17 03:56 AM

Status

Open [ 1 ]

In Development [ 10007 ]

Hide

Permalink

Ramya Tantry (Inactive) added a comment - 08/May/17 07:02 AM

Files Affected:

WorkterraAPI/App_Start/AuthenticateAttribute.cs
WorkterraAPI/Controllers/BaseControllers/WorkterraAppBaseController.cs
WorkterraAPI/Controllers/OnBoard/TourListingController.cs
WorkterraAPI/Views/Shared/Error.cshtml

Show

Ramya Tantry (Inactive) added a comment - 08/May/17 07:02 AM Files Affected: WorkterraAPI/App_Start/AuthenticateAttribute.cs WorkterraAPI/Controllers/BaseControllers/WorkterraAppBaseController.cs WorkterraAPI/Controllers/OnBoard/TourListingController.cs WorkterraAPI/Views/Shared/Error.cshtml

Ramya Tantry (Inactive) made changes - 08/May/17 07:26 AM

Code Review Date		08/May/2017
Code Reviewed By		Saurabh Sablaka [ 11909 ]
Item State	Parent values: Development(10200)Level 1 values: In Analysis(10204)	Parent values: Development(10200)Level 1 values: Ready for Local Testing(10209)

Permalink

Ramya Tantry (Inactive) logged work - 08/May/17 07:29 AM - edited

Time Spent:

4h

Analysis and discussion
Code Changes
Unit testing
Code review
LB,local and UI refresh checkin

Hide

Permalink

Ramya Tantry (Inactive) added a comment - 08/May/17 07:29 AM

Concern:Proper message should be display instead of error message if credentials are invalid
Cause:Generic error page is shown in case any validation fails.
Correction:We have provided specific error message for validation checks.

Show

Ramya Tantry (Inactive) added a comment - 08/May/17 07:29 AM Concern :Proper message should be display instead of error message if credentials are invalid Cause :Generic error page is shown in case any validation fails. Correction :We have provided specific error message for validation checks.

Ramya Tantry (Inactive) made changes - 08/May/17 07:30 AM

Remaining Estimate	8h [ 28800 ]	4.5h [ 16200 ]
Time Spent		3.5h [ 12600 ]
Worklog Id		43665 [ 43665 ]

Khandu Kshirsagar (Inactive) made changes - 08/May/17 10:31 AM

Item State

Parent values: Development(10200)Level 1 values: Ready for Local Testing(10209)

Parent values: LB QA(10201)Level 1 values: LB Deployed(11600)

Ramya Tantry (Inactive) made changes - 08/May/17 10:44 AM

Assignee

Ramya Tantry [ ramya.tantry ]

Kunal Kedari [ kunal.kedari ]

Ramya Tantry (Inactive) made changes - 08/May/17 10:44 AM

Status

In Development [ 10007 ]

Local Testing [ 10200 ]

Kunal Kedari (Inactive) made changes - 08/May/17 12:16 PM

Item State

Parent values: LB QA(10201)Level 1 values: LB Deployed(11600)

Parent values: LB QA(10201)Level 1 values: In Testing(10210)

Kunal Kedari (Inactive) made changes - 08/May/17 12:21 PM

Attachment

InvalidEntityID.jpg [ 47232 ]

Hide

Permalink

Kunal Kedari (Inactive) added a comment - 08/May/17 12:22 PM

Hi Ramya Tantry,

We have verified the fix for below parameters:
1] requestForm
2] username
3] password
4] corporationID
5] entityID

Now proper message is displaying for all of the above parameters except entityID. If we entered invalid entityID still error message is shown please let us know if we can fix this too.

Cc: Prasad Pise, Saurabh Sablaka

Show

Kunal Kedari (Inactive) added a comment - 08/May/17 12:22 PM Hi Ramya Tantry , We have verified the fix for below parameters: 1] requestForm 2] username 3] password 4] corporationID 5] entityID Now proper message is displaying for all of the above parameters except entityID. If we entered invalid entityID still error message is shown please let us know if we can fix this too. Cc: Prasad Pise , Saurabh Sablaka

Kunal Kedari (Inactive) made changes - 08/May/17 12:22 PM

Assignee

Kunal Kedari [ kunal.kedari ]

Ramya Tantry [ ramya.tantry ]

Ramya Tantry (Inactive) made changes - 09/May/17 03:53 AM

Remaining Estimate	4.5h [ 16200 ]	4h [ 14400 ]
Time Spent	3.5h [ 12600 ]	4h [ 14400 ]
Worklog Id		43665 [ 43665 ]

Permalink

Ramya Tantry (Inactive) logged work - 09/May/17 04:18 AM

Time Spent:

0.75h

Issue fixing for invalid Entity ID. Unit testing
Checkin to LB,UIRefresh and Local

Ramya Tantry (Inactive) made changes - 09/May/17 04:20 AM

Remaining Estimate	4h [ 14400 ]	3.25h [ 11700 ]
Time Spent	4h [ 14400 ]	4.75h [ 17100 ]
Worklog Id		43848 [ 43848 ]

Khandu Kshirsagar (Inactive) made changes - 09/May/17 06:13 AM

Item State

Parent values: LB QA(10201)Level 1 values: In Testing(10210)

Parent values: LB QA(10201)Level 1 values: LB Deployed(11600)

Ramya Tantry (Inactive) made changes - 09/May/17 09:45 AM

Assignee

Ramya Tantry [ ramya.tantry ]

Kunal Kedari [ kunal.kedari ]

Hide

Permalink

Ramya Tantry (Inactive) added a comment - 09/May/17 09:45 AM

Hi Kunal Kedari,

Deployment issue is resolved now.
Please verify.

Show

Ramya Tantry (Inactive) added a comment - 09/May/17 09:45 AM Hi Kunal Kedari , Deployment issue is resolved now. Please verify.

Permalink

Ramya Tantry (Inactive) logged work - 09/May/17 09:46 AM

Time Spent:

1h

deployment issue analysis

Ramya Tantry (Inactive) made changes - 09/May/17 09:46 AM

Remaining Estimate	3.25h [ 11700 ]	2.25h [ 8100 ]
Time Spent	4.75h [ 17100 ]	5.75h [ 20700 ]
Worklog Id		44019 [ 44019 ]

Kunal Kedari (Inactive) made changes - 09/May/17 10:15 AM

Item State

Parent values: LB QA(10201)Level 1 values: LB Deployed(11600)

Parent values: LB QA(10201)Level 1 values: In Testing(10210)

Hide

Permalink

Kunal Kedari (Inactive) added a comment - 09/May/17 10:22 AM

We have verified the message for invalid entityID, now it is displaying as "Error in receiving candidate details from Bullhorn." We can move fix to Stage.

Cc: Prasad Pise, Saurabh Sablaka, Ramya Tantry

Show

Kunal Kedari (Inactive) added a comment - 09/May/17 10:22 AM We have verified the message for invalid entityID, now it is displaying as "Error in receiving candidate details from Bullhorn." We can move fix to Stage. Cc: Prasad Pise , Saurabh Sablaka , Ramya Tantry

Kunal Kedari (Inactive) made changes - 09/May/17 10:22 AM

Item State

Parent values: LB QA(10201)Level 1 values: In Testing(10210)

Parent values: LB QA(10201)Level 1 values: Ready for Stage(10213)

Khandu Kshirsagar (Inactive) made changes - 10/May/17 09:09 AM

Item State

Parent values: LB QA(10201)Level 1 values: Ready for Stage(10213)

Parent values: Stage QA(10202)Level 1 values: Stage Deployed(11602)

Kunal Kedari (Inactive) made changes - 12/May/17 11:07 AM

Item State

Parent values: Stage QA(10202)Level 1 values: Stage Deployed(11602)

Parent values: Stage QA(10202)Level 1 values: In Testing(10214)

Kunal Kedari (Inactive) made changes - 12/May/17 11:10 AM

Attachment

Stage_Pass.jpg [ 47923 ]

Hide

Permalink

Kunal Kedari (Inactive) added a comment - 12/May/17 11:10 AM

We have verified the changes on Stage, now proper validation message is displaying for invalid credentials.

Show

Kunal Kedari (Inactive) added a comment - 12/May/17 11:10 AM We have verified the changes on Stage, now proper validation message is displaying for invalid credentials.

Kunal Kedari (Inactive) made changes - 12/May/17 11:40 AM

Status

Local Testing [ 10200 ]

Stage Testing [ 10201 ]

Hide

Permalink

Kunal Kedari (Inactive) added a comment - 12/May/17 11:40 AM

As we are deploying all Bullhorn changes to Production in next week for time being marking this issue as "Production Deployment on Hold"

Show

Kunal Kedari (Inactive) added a comment - 12/May/17 11:40 AM As we are deploying all Bullhorn changes to Production in next week for time being marking this issue as "Production Deployment on Hold"

Kunal Kedari (Inactive) made changes - 12/May/17 11:41 AM

Item State

Parent values: Stage QA(10202)Level 1 values: In Testing(10214)

Parent values: Stage QA(10202)Level 1 values: Production Deployment on Hold(10224)

Kunal Kedari (Inactive) made changes - 30/May/17 08:08 AM

Link

This issue relates to ~~NF-1063~~ [ ~~NF-1063~~ ]

Kunal Kedari (Inactive) made changes - 21/Jun/17 12:39 PM

Item State

Parent values: Stage QA(10202)Level 1 values: Production Deployment on Hold(10224)

Parent values: Stage QA(10202)Level 1 values: Ready for Production(10217)

Khandu Kshirsagar (Inactive) made changes - 22/Jun/17 07:12 AM

Item State

Parent values: Stage QA(10202)Level 1 values: Ready for Production(10217)

Parent values: Production QA(10203)Level 1 values: Production Deployed(10221)

Kunal Kedari (Inactive) made changes - 22/Jun/17 12:48 PM

Item State

Parent values: Production QA(10203)Level 1 values: Production Deployed(10221)

Parent values: Production QA(10203)Level 1 values: In Testing(10218)

Hide

Permalink

Kunal Kedari (Inactive) added a comment - 23/Jun/17 04:56 AM

Verified the changes on Production, proper validation message is displaying for invalid credentials. Closing the ticket.

Show

Kunal Kedari (Inactive) added a comment - 23/Jun/17 04:56 AM Verified the changes on Production, proper validation message is displaying for invalid credentials. Closing the ticket.

Kunal Kedari (Inactive) made changes - 23/Jun/17 04:57 AM

Item State

Parent values: Production QA(10203)Level 1 values: In Testing(10218)

Parent values: Production Complete(10222)Level 1 values: Closed(10223)

Kunal Kedari (Inactive) made changes - 23/Jun/17 04:57 AM

Status

Stage Testing [ 10201 ]

Production Testing [ 10202 ]

Kunal Kedari (Inactive) made changes - 23/Jun/17 04:57 AM

Resolution		Fixed [ 1 ]
Status	Production Testing [ 10202 ]	Production Complete [ 10028 ]

Kunal Kedari (Inactive) made changes - 23/Jun/17 04:57 AM

Status

Production Complete [ 10028 ]

Closed [ 6 ]

Transition	Time In Source Status	Execution Times

Ramya Tantry (Inactive) made transition - 08/May/17 03:56 AM

Open

In Development

2d 16h 45m

Ramya Tantry (Inactive) made transition - 08/May/17 10:44 AM

In Development

In LB Testing

6h 47m

Kunal Kedari (Inactive) made transition - 12/May/17 11:40 AM

In LB Testing

Stage Testing

4d 55m

Kunal Kedari (Inactive) made transition - 23/Jun/17 04:57 AM

Stage Testing

In Production Testing

41d 17h 16m

Kunal Kedari (Inactive) made transition - 23/Jun/17 04:57 AM

In Production Testing

Production Complete

Kunal Kedari (Inactive) made transition - 23/Jun/17 04:57 AM

Production Complete

Closed

People

Assignee:: Kunal Kedari (Inactive)

Reporter:: Kunal Kedari (Inactive)

Developer:: Ramya Tantry (Inactive)

QA:: Kunal Kedari (Inactive)

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Dates

Created:: 05/May/17 11:11 AM

Updated:: 23/Jun/17 04:57 AM

Resolved:: 23/Jun/17 04:57 AM

Code Review Date:: 08/May/2017

Time Tracking

Estimated:

Remaining:

2.25h

Logged:

5.75h