Uploaded image for project: 'New Features 2017'
  1. New Features 2017
  2. NF-1339

Bullhorn Integration->Proper message should be display instead of error message if credentials are invalid

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Low
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Integrations
    • Labels:
      None
    • Bug Type:
      Functional
    • Module:
      Bullhorn
    • Reported by:
      Harbinger
    • Item State:
      Production Complete - Closed
    • Issue Importance:
      Q2

      Description

      1] Access the tour details page using below URL:
      https://10.0.2.120/api/app/TourListing/ListTours?requestFrom=wRnQ7Y%2fZWlCOXjmz9IS4jw%3d%3d&userName=%2bsj2KXYNrgm8O4Va%2bHPUTQ%3d%3d&password=T6NiPfpN8kLQSGDeUamNAw%3d%3d&corporationID=9587&entityType=Placement&entityID=3
      2] In above URL mentioned any invalid value for password/userid/corporationID or entity ID.

      Actual Result:
      Below error message should is displaying:
      Sorry, an error occurred while processing your request.
      Expected Result:
      Proper message should be display so that user can know about invalid credentials.
      (Refer attached screenshot for more detials)

        Attachments

        1. ErrorMessage.jpg
          ErrorMessage.jpg
          62 kB
        2. InvalidEntityID.jpg
          InvalidEntityID.jpg
          61 kB
        3. Stage_Pass.jpg
          Stage_Pass.jpg
          82 kB

          Issue Links

            Activity

            Hide
            ramya.tantry Ramya Tantry (Inactive) added a comment -

            Hi Saurabh Sablaka,

            Please let me know your views on this scenario.
            If we remove one of the characters from encoded value of password or username,validation of user fails and error page is shown(see screenshot attached by QA).
            This is the generic error page that we show in case any validation fails.

            Since we are going to set the URL in custom tab,will there be a scenario where user authentication fails,Unless someone manually changes the url.
            Should we provide more specific error message for every validation?

            Show
            ramya.tantry Ramya Tantry (Inactive) added a comment - Hi Saurabh Sablaka , Please let me know your views on this scenario. If we remove one of the characters from encoded value of password or username,validation of user fails and error page is shown(see screenshot attached by QA). This is the generic error page that we show in case any validation fails. Since we are going to set the URL in custom tab,will there be a scenario where user authentication fails,Unless someone manually changes the url. Should we provide more specific error message for every validation?
            Hide
            ramya.tantry Ramya Tantry (Inactive) added a comment -

            Files Affected:

            WorkterraAPI/App_Start/AuthenticateAttribute.cs
            WorkterraAPI/Controllers/BaseControllers/WorkterraAppBaseController.cs
            WorkterraAPI/Controllers/OnBoard/TourListingController.cs
            WorkterraAPI/Views/Shared/Error.cshtml

            Show
            ramya.tantry Ramya Tantry (Inactive) added a comment - Files Affected: WorkterraAPI/App_Start/AuthenticateAttribute.cs WorkterraAPI/Controllers/BaseControllers/WorkterraAppBaseController.cs WorkterraAPI/Controllers/OnBoard/TourListingController.cs WorkterraAPI/Views/Shared/Error.cshtml
            Hide
            ramya.tantry Ramya Tantry (Inactive) added a comment -

            Concern:Proper message should be display instead of error message if credentials are invalid
            Cause:Generic error page is shown in case any validation fails.
            Correction:We have provided specific error message for validation checks.

            Show
            ramya.tantry Ramya Tantry (Inactive) added a comment - Concern :Proper message should be display instead of error message if credentials are invalid Cause :Generic error page is shown in case any validation fails. Correction :We have provided specific error message for validation checks.
            Hide
            kunal.kedari Kunal Kedari (Inactive) added a comment -

            Hi Ramya Tantry,

            We have verified the fix for below parameters:
            1] requestForm
            2] username
            3] password
            4] corporationID
            5] entityID

            Now proper message is displaying for all of the above parameters except entityID. If we entered invalid entityID still error message is shown please let us know if we can fix this too.

            Cc: Prasad Pise, Saurabh Sablaka

            Show
            kunal.kedari Kunal Kedari (Inactive) added a comment - Hi Ramya Tantry , We have verified the fix for below parameters: 1] requestForm 2] username 3] password 4] corporationID 5] entityID Now proper message is displaying for all of the above parameters except entityID. If we entered invalid entityID still error message is shown please let us know if we can fix this too. Cc: Prasad Pise , Saurabh Sablaka
            Hide
            ramya.tantry Ramya Tantry (Inactive) added a comment -

            Hi Kunal Kedari,

            Deployment issue is resolved now.
            Please verify.

            Show
            ramya.tantry Ramya Tantry (Inactive) added a comment - Hi Kunal Kedari , Deployment issue is resolved now. Please verify.
            Hide
            kunal.kedari Kunal Kedari (Inactive) added a comment -

            We have verified the message for invalid entityID, now it is displaying as "Error in receiving candidate details from Bullhorn." We can move fix to Stage.

            Cc: Prasad Pise, Saurabh Sablaka, Ramya Tantry

            Show
            kunal.kedari Kunal Kedari (Inactive) added a comment - We have verified the message for invalid entityID, now it is displaying as "Error in receiving candidate details from Bullhorn." We can move fix to Stage. Cc: Prasad Pise , Saurabh Sablaka , Ramya Tantry
            Hide
            kunal.kedari Kunal Kedari (Inactive) added a comment -

            We have verified the changes on Stage, now proper validation message is displaying for invalid credentials.

            Show
            kunal.kedari Kunal Kedari (Inactive) added a comment - We have verified the changes on Stage, now proper validation message is displaying for invalid credentials.
            Hide
            kunal.kedari Kunal Kedari (Inactive) added a comment -

            As we are deploying all Bullhorn changes to Production in next week for time being marking this issue as "Production Deployment on Hold"

            Show
            kunal.kedari Kunal Kedari (Inactive) added a comment - As we are deploying all Bullhorn changes to Production in next week for time being marking this issue as "Production Deployment on Hold"
            Hide
            kunal.kedari Kunal Kedari (Inactive) added a comment -

            Verified the changes on Production, proper validation message is displaying for invalid credentials. Closing the ticket.

            Show
            kunal.kedari Kunal Kedari (Inactive) added a comment - Verified the changes on Production, proper validation message is displaying for invalid credentials. Closing the ticket.

              People

              Assignee:
              kunal.kedari Kunal Kedari (Inactive)
              Reporter:
              kunal.kedari Kunal Kedari (Inactive)
              Developer:
              Ramya Tantry (Inactive)
              QA:
              Kunal Kedari (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Code Review Date:

                  Time Tracking

                  Estimated:
                  Original Estimate - 8h
                  8h
                  Remaining:
                  Time Spent - 5.75h Remaining Estimate - 2.25h
                  2.25h
                  Logged:
                  Time Spent - 5.75h Remaining Estimate - 2.25h
                  5.75h