Uploaded image for project: 'New Features 2017'
  1. New Features 2017
  2. NF-1828

Bullhorn Integration->Tour completion status is get changed to 100% though employee not finished with last step.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Medium
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Integrations
    • Labels:
      None
    • Bug Type:
      Functional
    • Level:
      Admin
    • Module:
      Bullhorn
    • Reported by:
      Harbinger
    • Item State:
      Production Complete - Closed
    • Issue Importance:
      Q2
    • Browser:
      Google Chrome

      Description

      Environment - Local (wt-stage)

      1] Access the tour details page using below URL:
      https://10.0.2.120/api/app/TourListing/ListTours?requestFrom=wRnQ7Y%2fZWlCOXjmz9IS4jw%3d%3d&userName=%2bsj2KXYNrgm8O4Va%2bHPUTQ%3d%3d&password=T6NiPfpN8kLQSGDeUamNAw%3d%3d&corporationID=9587&entityType=Placement&entityID=3
      2] Assign Onboard. (Suppose this tour have 10 steps)
      3] Login as a employee, take the tour.
      4] Go on completing the tour, on last step instead of clicking Finish button click on Back button.
      https://10.0.2.120/api/app/TourListing/ListTours?requestFrom=wRnQ7Y%2fZWlCOXjmz9IS4jw%3d%3d&userName=%2bsj2KXYNrgm8O4
      5] Observe the tour status.

      Actual Result:
      It is displaying as 100%, though the last step is not completed.
      Expected Result:
      Tour status should not be 100%

      Cc: Saurabh Sablaka, Prasad Pise

        Attachments

          Issue Links

            Activity

            kunal.kedari Kunal Kedari (Inactive) created issue -
            seema.gaikwad Seema Gaikwad (Inactive) logged work - 16/May/17 12:12 PM
            • Time Spent:
              1h
               

              Discussion with saurabh
              Issue debugging

            seema.gaikwad Seema Gaikwad (Inactive) made changes -
            Field Original Value New Value
            Status Open [ 1 ] In Development [ 10007 ]
            seema.gaikwad Seema Gaikwad (Inactive) made changes -
            Remaining Estimate 8h [ 28800 ]
            Original Estimate 8h [ 28800 ]
            seema.gaikwad Seema Gaikwad (Inactive) made changes -
            Item State Parent values: Development(10200)Level 1 values: In Analysis(10204)
            seema.gaikwad Seema Gaikwad (Inactive) made changes -
            Remaining Estimate 8h [ 28800 ] 7h [ 25200 ]
            Time Spent 1h [ 3600 ]
            Worklog Id 46381 [ 46381 ]
            seema.gaikwad Seema Gaikwad (Inactive) logged work - 17/May/17 12:17 PM
            • Time Spent:
              2.5h
               

              Implementation and testing

            seema.gaikwad Seema Gaikwad (Inactive) made changes -
            Remaining Estimate 7h [ 25200 ] 4.5h [ 16200 ]
            Time Spent 1h [ 3600 ] 3.5h [ 12600 ]
            Worklog Id 46390 [ 46390 ]
            seema.gaikwad Seema Gaikwad (Inactive) logged work - 18/May/17 11:35 AM - edited
            • Time Spent:
              4h
               

              Modification and testing

            seema.gaikwad Seema Gaikwad (Inactive) made changes -
            Item State Parent values: Development(10200)Level 1 values: In Analysis(10204) Parent values: Development(10200)Level 1 values: Ready for Review(10208)
            seema.gaikwad Seema Gaikwad (Inactive) made changes -
            Remaining Estimate 4.5h [ 16200 ] 0.5h [ 1800 ]
            Time Spent 3.5h [ 12600 ] 7.5h [ 27000 ]
            Worklog Id 46861 [ 46861 ]
            seema.gaikwad Seema Gaikwad (Inactive) made changes -
            Worklog Id 46861 [ 46861 ]
            seema.gaikwad Seema Gaikwad (Inactive) logged work - 19/May/17 11:19 AM - edited
            • Time Spent:
              0.75h
               

              Task discussion and its effect

            seema.gaikwad Seema Gaikwad (Inactive) made changes -
            Remaining Estimate 0.5h [ 1800 ] 0h [ 0 ]
            Time Spent 7.5h [ 27000 ] 9h [ 32400 ]
            Worklog Id 47504 [ 47504 ]
            seema.gaikwad Seema Gaikwad (Inactive) made changes -
            Remaining Estimate 0h [ 0 ] 0.75h [ 2700 ]
            Time Spent 9h [ 32400 ] 8.25h [ 29700 ]
            Worklog Id 47504 [ 47504 ]
            seema.gaikwad Seema Gaikwad (Inactive) made changes -
            Item State Parent values: Development(10200)Level 1 values: Ready for Review(10208) Parent values: Development(10200)Level 1 values: In Progress(10206)
            seema.gaikwad Seema Gaikwad (Inactive) made changes -
            Item State Parent values: Development(10200)Level 1 values: In Progress(10206) Parent values: Development(10200)Level 1 values: Ready for Review(10208)
            seema.gaikwad Seema Gaikwad (Inactive) logged work - 22/May/17 11:35 AM
            • Time Spent:
              1h
               

              Testing

            seema.gaikwad Seema Gaikwad (Inactive) made changes -
            Remaining Estimate 0.75h [ 2700 ] 0h [ 0 ]
            Time Spent 8.25h [ 29700 ] 9.25h [ 33300 ]
            Worklog Id 47811 [ 47811 ]
            seema.gaikwad Seema Gaikwad (Inactive) logged work - 23/May/17 11:39 AM
            • Time Spent:
              1.5h
               

              test functionaly working is as that of WT app

            saurabh.sablaka Saurabh Sablaka (Inactive) made changes -
            Item State Parent values: Development(10200)Level 1 values: Ready for Review(10208) Parent values: Development(10200)Level 1 values: Ready for Local Testing(10209)
            saurabh.sablaka Saurabh Sablaka (Inactive) made changes -
            Code Review Date 24/May/2017
            Code Reviewed By Saurabh Sablaka [ 11909 ]
            Hide
            seema.gaikwad Seema Gaikwad (Inactive) added a comment -

            Modified Files

            \App\BusinessLogic\OnBoarding\ManageTour.cs
            \Database Objects\MasterCompanyDB\04_Stored Procedures\ob.OES_SP_GetTourCompletionPercentage.sql
            \Database Objects\MasterCompanyDB\04_Stored Procedures\ob.OES_SP_GetTourStepsStatus.sql
            \Web\APIServices\APIServices\Implementations\OnBoard\ToursService.cs
            \Web\Web Projects\WorkterraAPI\WorkterraAPI\Controllers\OnBoard\TourListingController.cs
            \Web\Web Projects\WorkterraAPI\WorkterraAPI\Models\OnBoard\TourStepsStatus.cs

            Show
            seema.gaikwad Seema Gaikwad (Inactive) added a comment - Modified Files \App\BusinessLogic\OnBoarding\ManageTour.cs \Database Objects\MasterCompanyDB\04_Stored Procedures\ob.OES_SP_GetTourCompletionPercentage.sql \Database Objects\MasterCompanyDB\04_Stored Procedures\ob.OES_SP_GetTourStepsStatus.sql \Web\APIServices\APIServices\Implementations\OnBoard\ToursService.cs \Web\Web Projects\WorkterraAPI\WorkterraAPI\Controllers\OnBoard\TourListingController.cs \Web\Web Projects\WorkterraAPI\WorkterraAPI\Models\OnBoard\TourStepsStatus.cs
            Hide
            seema.gaikwad Seema Gaikwad (Inactive) added a comment -

            Hi Kunal Kedari,

            Issue solved now tour completion % is not 100% if employee not completed the tour and go back.
            Also Last step shown as pending and previous as in progress cause we press back button or navigate from sequence bar accordingly % are calculated.

            CC:Saurabh Sablaka

            Show
            seema.gaikwad Seema Gaikwad (Inactive) added a comment - Hi Kunal Kedari , Issue solved now tour completion % is not 100% if employee not completed the tour and go back. Also Last step shown as pending and previous as in progress cause we press back button or navigate from sequence bar accordingly % are calculated. CC: Saurabh Sablaka
            seema.gaikwad Seema Gaikwad (Inactive) made changes -
            Assignee Seema Gaikwad [ seema.gaikwad ] Kunal Kedari [ kunal.kedari ]
            seema.gaikwad Seema Gaikwad (Inactive) made changes -
            Time Spent 9.25h [ 33300 ] 10.75h [ 38700 ]
            Worklog Id 48335 [ 48335 ]
            khandu.kshirsagar Khandu Kshirsagar (Inactive) made changes -
            Item State Parent values: Development(10200)Level 1 values: Ready for Local Testing(10209) Parent values: LB QA(10201)Level 1 values: LB Deployed(11600)
            kunal.kedari Kunal Kedari (Inactive) logged work - 25/May/17 12:57 PM
            • Time Spent:
              1.5h
               

              Fix verification on Local

            kunal.kedari Kunal Kedari (Inactive) made changes -
            Time Spent 10.75h [ 38700 ] 12.25h [ 44100 ]
            Worklog Id 48909 [ 48909 ]
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Item State Parent values: LB QA(10201)Level 1 values: LB Deployed(11600) Parent values: LB QA(10201)Level 1 values: In Testing(10210)
            Hide
            kunal.kedari Kunal Kedari (Inactive) added a comment -

            We have verified the fix on Local (wt-stage), now tour completion status is not marked as 100% until employee completed the last steps.
            Marking it as Ready For Stage.

            Show
            kunal.kedari Kunal Kedari (Inactive) added a comment - We have verified the fix on Local (wt-stage), now tour completion status is not marked as 100% until employee completed the last steps. Marking it as Ready For Stage.
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Item State Parent values: LB QA(10201)Level 1 values: In Testing(10210) Parent values: LB QA(10201)Level 1 values: Ready for Stage(10213)
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Status In Development [ 10007 ] Local Testing [ 10200 ]
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Status Local Testing [ 10200 ] Stage Testing [ 10201 ]
            khandu.kshirsagar Khandu Kshirsagar (Inactive) made changes -
            Item State Parent values: LB QA(10201)Level 1 values: Ready for Stage(10213) Parent values: Stage QA(10202)Level 1 values: Stage Deployed(11602)
            kunal.kedari Kunal Kedari (Inactive) logged work - 29/May/17 04:58 PM
            • Time Spent:
              0.5h
               

              Fix verification on Stage

            kunal.kedari Kunal Kedari (Inactive) made changes -
            Item State Parent values: Stage QA(10202)Level 1 values: Stage Deployed(11602) Parent values: Stage QA(10202)Level 1 values: In Testing(10214)
            Hide
            kunal.kedari Kunal Kedari (Inactive) added a comment -

            We have verified the fix on Stage, working as expected. Marking "Production Deployment On Hold"

            Show
            kunal.kedari Kunal Kedari (Inactive) added a comment - We have verified the fix on Stage, working as expected. Marking "Production Deployment On Hold"
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Item State Parent values: Stage QA(10202)Level 1 values: In Testing(10214) Parent values: Stage QA(10202)Level 1 values: Production Deployment on Hold(10224)
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Link This issue relates to NF-948 [ NF-948 ]
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Time Spent 12.25h [ 44100 ] 12.75h [ 45900 ]
            Worklog Id 50290 [ 50290 ]
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Item State Parent values: Stage QA(10202)Level 1 values: Production Deployment on Hold(10224) Parent values: Stage QA(10202)Level 1 values: Ready for Production(10217)
            khandu.kshirsagar Khandu Kshirsagar (Inactive) made changes -
            Item State Parent values: Stage QA(10202)Level 1 values: Ready for Production(10217) Parent values: Production QA(10203)Level 1 values: Production Deployed(10221)
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Item State Parent values: Production QA(10203)Level 1 values: Production Deployed(10221) Parent values: Production QA(10203)Level 1 values: In Testing(10218)
            Hide
            kunal.kedari Kunal Kedari (Inactive) added a comment -

            We have verified the fix on Production, working as expected. Closing the ticket.

            Cc: Prasad Pise, Saurabh Sablaka

            Show
            kunal.kedari Kunal Kedari (Inactive) added a comment - We have verified the fix on Production, working as expected. Closing the ticket. Cc: Prasad Pise , Saurabh Sablaka
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Item State Parent values: Production QA(10203)Level 1 values: In Testing(10218) Parent values: Production Complete(10222)Level 1 values: Closed(10223)
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Status Stage Testing [ 10201 ] Production Testing [ 10202 ]
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Resolution Fixed [ 1 ]
            Status Production Testing [ 10202 ] Production Complete [ 10028 ]
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Status Production Complete [ 10028 ] Closed [ 6 ]
            kunal.kedari Kunal Kedari (Inactive) logged work - 23/Jun/17 05:27 PM
            • Time Spent:
              0.25h
               

              Testing on Production

            kunal.kedari Kunal Kedari (Inactive) made changes -
            Time Spent 12.75h [ 45900 ] 13h [ 46800 ]
            Worklog Id 59053 [ 59053 ]
            Transition Time In Source Status Execution Times
            Seema Gaikwad (Inactive) made transition -
            Open In Development
            21h 22m 1
            Kunal Kedari (Inactive) made transition -
            In Development In LB Testing
            9d 1h 6m 1
            Kunal Kedari (Inactive) made transition -
            In LB Testing Stage Testing
            3s 1
            Kunal Kedari (Inactive) made transition -
            Stage Testing In Production Testing
            27d 21h 57m 1
            Kunal Kedari (Inactive) made transition -
            In Production Testing Production Complete
            6s 1
            Kunal Kedari (Inactive) made transition -
            Production Complete Closed
            2s 1

              People

              Assignee:
              kunal.kedari Kunal Kedari (Inactive)
              Reporter:
              kunal.kedari Kunal Kedari (Inactive)
              QA:
              Kunal Kedari (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Code Review Date:

                  Time Tracking

                  Estimated:
                  Original Estimate - 8h Original Estimate - 8h
                  8h
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 13h
                  13h