New Features 2017Project Type: software

New Features 2017

Uploaded image for project: 'New Features 2017'
  1. New Features 2017
  2. NF-4063

TSR Integration>Regression>HoursPerWeek should not be get rounded while adding employee to WorkTerra

    Details

    • Type: Bug
    • Status: Resolution Setting
    • Priority: Medium
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Integrations
    • Labels:
      None
    • Environment:
      Stage
    • Bug Type:
      Functional
    • Bug Severity:
      Medium
    • Level:
      Admin
    • Module:
      TSR
    • Reported by:
      Harbinger
    • Item State:
      Stage QA - Production Deployment on Hold
    • Issue Importance:
      Q2

      Description

      Env - Stage
      Company - TSR Onboard

      Scenario 1
      1] Add employee to WT through API, while adding mentioned HoursPerWeek as 40.5
      2] Observe the HoursPerWeek on Demographics page. it is getting rounded to nearest value.
      Expected Result:
      Value should not be get rounded.

      Scenario 2
      1] Wehn HousrPerWeek passed as blank:
      "HoursPerWeek" : " "
      2] Below message is displaying:
      {
      "status": "Error",
      "message": "Bad parameters",
      "errorLevel": "Information",
      "code": 400,
      "description": ""
      }
      3] Please correct the message so user come to know exactly what went wrong.

      Cc: Saurabh Sablaka, Prasad Pise

        Attachments

          Issue Links

          relates to

          Support Activity - Support Activity NF-3998 Regression testing for TSR Integration with Old UI on Stage

          • High - Serious problem that could block progress.
          • Closed

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            seema.gaikwad Seema Gaikwad (Inactive) added a comment - - edited

            Hi Kunal Kedari,

            Scenario2 is not valid

            Show
            seema.gaikwad Seema Gaikwad (Inactive) added a comment - - edited Hi Kunal Kedari , Scenario2 is not valid
            Hide
            Permalink
            seema.gaikwad Seema Gaikwad (Inactive) added a comment - - edited

            Concern: HoursPerWeek should not be get rounded while adding employee to WorkTerra
            Cause: HoursPerWeek parameter of 'dbo.OES_SP_InsertEmployeeDetailsFromAPI' and dbo.OES_SP_Update_EmployeeDetailsFromAPI is given as int
            Correction: HoursPerWeek parameter of 'dbo.OES_SP_InsertEmployeeDetailsFromAPI' and 'dbo.OES_SP_Update_EmployeeDetailsFromAPI' is given as Decimal

            CC :Saurabh Sablaka Ramya Tantry

            Show
            seema.gaikwad Seema Gaikwad (Inactive) added a comment - - edited Concern: HoursPerWeek should not be get rounded while adding employee to WorkTerra Cause: HoursPerWeek parameter of 'dbo.OES_SP_InsertEmployeeDetailsFromAPI' and dbo.OES_SP_Update_EmployeeDetailsFromAPI is given as int Correction: HoursPerWeek parameter of 'dbo.OES_SP_InsertEmployeeDetailsFromAPI' and 'dbo.OES_SP_Update_EmployeeDetailsFromAPI' is given as Decimal CC : Saurabh Sablaka Ramya Tantry
            Hide
            Permalink
            seema.gaikwad Seema Gaikwad (Inactive) added a comment - - edited

            Modified files

            1.Database Objects\MasterCompanyDB\04_Stored Procedures\dbo.OES_SP_InsertEmployeeDetailsFromAPI.sql
            2.Database Objects\MasterCompanyDB\04_Stored Procedures\dbo.OES_SP_Update_EmployeeDetailsFromAPI.sql
            3.Shared Library\ValueObjects\ValueObjects\WORKTERRA\EmployeeTours.cs

            Show
            seema.gaikwad Seema Gaikwad (Inactive) added a comment - - edited Modified files 1.Database Objects\MasterCompanyDB\04_Stored Procedures\dbo.OES_SP_InsertEmployeeDetailsFromAPI.sql 2.Database Objects\MasterCompanyDB\04_Stored Procedures\dbo.OES_SP_Update_EmployeeDetailsFromAPI.sql 3.Shared Library\ValueObjects\ValueObjects\WORKTERRA\EmployeeTours.cs
            Hide
            Permalink
            kunal.kedari Kunal Kedari (Inactive) added a comment -

            We have verified the fix on Local (wt-stage), fix is not proper still values get rounded. We need to fix this for Post and Put.

            Show
            kunal.kedari Kunal Kedari (Inactive) added a comment - We have verified the fix on Local (wt-stage), fix is not proper still values get rounded. We need to fix this for Post and Put.
            Hide
            Permalink
            seema.gaikwad Seema Gaikwad (Inactive) added a comment -

            Hi Kunal Kedari,

            We have fixed this for both add and update employee now.

            Show
            seema.gaikwad Seema Gaikwad (Inactive) added a comment - Hi Kunal Kedari , We have fixed this for both add and update employee now.
            Hide
            Permalink
            kunal.kedari Kunal Kedari (Inactive) added a comment -

            Verified fix on LB, working as expected . We can deploy fix to stage.

            Show
            kunal.kedari Kunal Kedari (Inactive) added a comment - Verified fix on LB, working as expected . We can deploy fix to stage.
            Hide
            Permalink
            kunal.kedari Kunal Kedari (Inactive) added a comment -

            Verified fix on Stage, working as expected . We can deploy fix to production.

            Show
            kunal.kedari Kunal Kedari (Inactive) added a comment - Verified fix on Stage, working as expected . We can deploy fix to production.
            Hide
            Permalink
            kunal.kedari Kunal Kedari (Inactive) added a comment -

            Business decided to stop all the work related to TSR.

            Show
            kunal.kedari Kunal Kedari (Inactive) added a comment - Business decided to stop all the work related to TSR.

              People

              Assignee:
              kunal.kedari Kunal Kedari (Inactive)
              Reporter:
              kunal.kedari Kunal Kedari (Inactive)
              QA:
              Kunal Kedari (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Pre-Prod Due Date:
                Production Due Date:
                Code Review Date:

                  Time Tracking

                  Estimated:
                  Original Estimate - 6h Original Estimate - 6h
                  6h
                  Remaining:
                  Time Spent - 6.75h Remaining Estimate - 0.5h
                  0.5h
                  Logged:
                  Time Spent - 6.75h Remaining Estimate - 0.5h
                  6.75h