[NF-4063] TSR Integration>Regression>HoursPerWeek should not be get rounded while adding employee to WorkTerra - Workterra Jira

Details

Type: Bug
Status: Resolution Setting
Priority: Medium
Resolution: Done
Affects Version/s: None
Fix Version/s: None
Component/s: Integrations
Labels:
None

Environment:

Stage
Bug Type:
Functional
Bug Severity:
Medium
Level:

Admin
Module:
TSR
Reported by:
Harbinger
Item State:
Stage QA - Production Deployment on Hold
Issue Importance:
Q2

Description

Env - Stage
Company - TSR Onboard

Scenario 1
1] Add employee to WT through API, while adding mentioned HoursPerWeek as 40.5
2] Observe the HoursPerWeek on Demographics page. it is getting rounded to nearest value.
Expected Result:
Value should not be get rounded.

Scenario 2
1] Wehn HousrPerWeek passed as blank:
"HoursPerWeek" : " "
2] Below message is displaying:
{
"status": "Error",
"message": "Bad parameters",
"errorLevel": "Information",
"code": 400,
"description": ""
}
3] Please correct the message so user come to know exactly what went wrong.

Cc: Saurabh Sablaka, Prasad Pise

Attachments

Issue Links

relates to

NF-3998 Regression testing for TSR Integration with Old UI on Stage

Closed

Activity

Ascending order - Click to sort in descending order

Kunal Kedari (Inactive) created issue - 04/Aug/17 08:56 AM

Seema Gaikwad (Inactive) made changes - 04/Aug/17 01:19 PM

Field	Original Value	New Value
Status	Open [ 1 ]	In Development [ 10007 ]

Permalink

Seema Gaikwad (Inactive) logged work - 04/Aug/17 01:20 PM

Time Spent:

3h

Issue debugging.
Fixed issue
Unit testing

Seema Gaikwad (Inactive) made changes - 04/Aug/17 01:20 PM

Item State		Parent values: Development(10200)Level 1 values: Ready for Review(10208)
Remaining Estimate		6h [ 21600 ]
Original Estimate		6h [ 21600 ]

Seema Gaikwad (Inactive) made changes - 04/Aug/17 01:20 PM

Remaining Estimate	6h [ 21600 ]	3h [ 10800 ]
Time Spent		3h [ 10800 ]
Worklog Id		69583 [ 69583 ]

Hide

Permalink

Seema Gaikwad (Inactive) added a comment - 04/Aug/17 01:22 PM - edited

Hi Kunal Kedari,

Scenario2 is not valid

Show

Seema Gaikwad (Inactive) added a comment - 04/Aug/17 01:22 PM - edited Hi Kunal Kedari , Scenario2 is not valid

Hide

Permalink

Seema Gaikwad (Inactive) added a comment - 04/Aug/17 01:25 PM - edited

Concern: HoursPerWeek should not be get rounded while adding employee to WorkTerra
Cause: HoursPerWeek parameter of 'dbo.OES_SP_InsertEmployeeDetailsFromAPI' and dbo.OES_SP_Update_EmployeeDetailsFromAPI is given as int
Correction: HoursPerWeek parameter of 'dbo.OES_SP_InsertEmployeeDetailsFromAPI' and 'dbo.OES_SP_Update_EmployeeDetailsFromAPI' is given as Decimal

CC :Saurabh Sablaka Ramya Tantry

Show

Seema Gaikwad (Inactive) added a comment - 04/Aug/17 01:25 PM - edited Concern: HoursPerWeek should not be get rounded while adding employee to WorkTerra Cause: HoursPerWeek parameter of 'dbo.OES_SP_InsertEmployeeDetailsFromAPI' and dbo.OES_SP_Update_EmployeeDetailsFromAPI is given as int Correction: HoursPerWeek parameter of 'dbo.OES_SP_InsertEmployeeDetailsFromAPI' and 'dbo.OES_SP_Update_EmployeeDetailsFromAPI' is given as Decimal CC : Saurabh Sablaka Ramya Tantry

Hide

Permalink

Seema Gaikwad (Inactive) added a comment - 04/Aug/17 01:27 PM - edited

Modified files

1.Database Objects\MasterCompanyDB\04_Stored Procedures\dbo.OES_SP_InsertEmployeeDetailsFromAPI.sql
2.Database Objects\MasterCompanyDB\04_Stored Procedures\dbo.OES_SP_Update_EmployeeDetailsFromAPI.sql
3.Shared Library\ValueObjects\ValueObjects\WORKTERRA\EmployeeTours.cs

Show

Seema Gaikwad (Inactive) added a comment - 04/Aug/17 01:27 PM - edited Modified files 1.Database Objects\MasterCompanyDB\04_Stored Procedures\dbo.OES_SP_InsertEmployeeDetailsFromAPI.sql 2.Database Objects\MasterCompanyDB\04_Stored Procedures\dbo.OES_SP_Update_EmployeeDetailsFromAPI.sql 3.Shared Library\ValueObjects\ValueObjects\WORKTERRA\EmployeeTours.cs

Permalink

Ramya Tantry (Inactive) logged work - 07/Aug/17 05:30 AM

Time Spent:

0.25h

Code review and discussion

Ramya Tantry (Inactive) made changes - 07/Aug/17 05:30 AM

Remaining Estimate	3h [ 10800 ]	2.75h [ 9900 ]
Time Spent	3h [ 10800 ]	3.25h [ 11700 ]
Worklog Id		69629 [ 69629 ]

Seema Gaikwad (Inactive) made changes - 07/Aug/17 05:32 AM

Code Review Date		07/Aug/2017
Code Reviewed By		Ramya Tantry [ 13001 ]

Seema Gaikwad (Inactive) made changes - 07/Aug/17 05:32 AM

Item State

Parent values: Development(10200)Level 1 values: Ready for Review(10208)

Parent values: Development(10200)Level 1 values: Ready for Local Testing(10209)

Seema Gaikwad (Inactive) made changes - 07/Aug/17 05:34 AM

Description

Env - Stage
Company - TSR Onboard

*Scenario 1*
1] Add employee to WT through API, while adding mentioned HoursPerWeek as 40.5
2] Observe the HoursPerWeek on Demographics page. it is getting rounded to nearest value.
Expected Result:
Value should not be get rounded.

*Scenario 2 *
1] Wehn HousrPerWeek passed as blank:
"HoursPerWeek" : " "
2] Below message is displaying:
{
    "status": "Error",
    "message": "Bad parameters",
    "errorLevel": "Information",
    "code": 400,
    "description": ""
}
3] Please correct the message so user come to know exactly what went wrong.

Cc: [~saurabh.sablaka], [~prasadp]

Env - Stage
Company - TSR Onboard

*Scenario 1*
1] Add employee to WT through API, while adding mentioned HoursPerWeek as 40.5
2] Observe the HoursPerWeek on Demographics page. it is getting rounded to nearest value.
Expected Result:
Value should not be get rounded.

*Scenario 2*
1] Wehn HousrPerWeek passed as blank:
"HoursPerWeek" : " "
2] Below message is displaying:
{
    "status": "Error",
    "message": "Bad parameters",
    "errorLevel": "Information",
    "code": 400,
    "description": ""
}
3] Please correct the message so user come to know exactly what went wrong.

Cc: [~saurabh.sablaka], [~prasadp]

Seema Gaikwad (Inactive) made changes - 07/Aug/17 05:46 AM

Assignee

Seema Gaikwad [ seema.gaikwad ]

Kunal Kedari [ kunal.kedari ]

Khandu Kshirsagar (Inactive) made changes - 07/Aug/17 06:23 AM

Item State

Parent values: Development(10200)Level 1 values: Ready for Local Testing(10209)

Parent values: LB QA(10201)Level 1 values: LB Deployed(11600)

Seema Gaikwad (Inactive) made changes - 08/Aug/17 11:17 AM

Item State

Parent values: LB QA(10201)Level 1 values: LB Deployed(11600)

Parent values: Development(10200)Level 1 values: Ready for Local Testing(10209)

Seema Gaikwad (Inactive) made changes - 08/Aug/17 11:17 AM

Assignee

Kunal Kedari [ kunal.kedari ]

Seema Gaikwad [ seema.gaikwad ]

Seema Gaikwad (Inactive) made changes - 08/Aug/17 11:22 AM

Assignee

Seema Gaikwad [ seema.gaikwad ]

Kunal Kedari [ kunal.kedari ]

Permalink

Seema Gaikwad (Inactive) logged work - 08/Aug/17 11:44 AM - edited

Time Spent:

3h

Discussion with Kunal and Ramya
Implementation and unit testing for Update employee
Implementation and unit testing for Add employee

Seema Gaikwad (Inactive) made changes - 08/Aug/17 11:45 AM

Remaining Estimate	2.75h [ 9900 ]	1.25h [ 4500 ]
Time Spent	3.25h [ 11700 ]	4.75h [ 17100 ]
Worklog Id		70060 [ 70060 ]

Hide

Permalink

Kunal Kedari (Inactive) added a comment - 08/Aug/17 12:12 PM

We have verified the fix on Local (wt-stage), fix is not proper still values get rounded. We need to fix this for Post and Put.

Show

Kunal Kedari (Inactive) added a comment - 08/Aug/17 12:12 PM We have verified the fix on Local (wt-stage), fix is not proper still values get rounded. We need to fix this for Post and Put.

Kunal Kedari (Inactive) made changes - 08/Aug/17 12:12 PM

Item State

Parent values: Development(10200)Level 1 values: Ready for Local Testing(10209)

Parent values: LB QA(10201)Level 1 values: Re-open(10212)

Kunal Kedari (Inactive) made changes - 08/Aug/17 12:12 PM

Assignee

Kunal Kedari [ kunal.kedari ]

Seema Gaikwad [ seema.gaikwad ]

Kunal Kedari (Inactive) made changes - 08/Aug/17 12:12 PM

Status

In Development [ 10007 ]

Local Testing [ 10200 ]

Kunal Kedari (Inactive) made changes - 08/Aug/17 12:12 PM

Status

Local Testing [ 10200 ]

Reopen in Local [ 10018 ]

Permalink

Ramya Tantry (Inactive) logged work - 08/Aug/17 12:44 PM

Time Spent:

0.5h

Analysis and Discussion with Seema

Ramya Tantry (Inactive) made changes - 08/Aug/17 12:44 PM

Remaining Estimate	1.25h [ 4500 ]	0.75h [ 2700 ]
Time Spent	4.75h [ 17100 ]	5.25h [ 18900 ]
Worklog Id		70103 [ 70103 ]

Seema Gaikwad (Inactive) made changes - 08/Aug/17 12:55 PM

Remaining Estimate	0.75h [ 2700 ]	0h [ 0 ]
Time Spent	5.25h [ 18900 ]	6.75h [ 24300 ]
Worklog Id		70060 [ 70060 ]

Seema Gaikwad (Inactive) made changes - 08/Aug/17 01:09 PM

Item State

Parent values: LB QA(10201)Level 1 values: Re-open(10212)

Parent values: Development(10200)Level 1 values: Ready for Local Testing(10209)

Seema Gaikwad (Inactive) made changes - 08/Aug/17 01:10 PM

Status

Reopen in Local [ 10018 ]

In Development [ 10007 ]

Hide

Permalink

Seema Gaikwad (Inactive) added a comment - 08/Aug/17 01:12 PM

Hi Kunal Kedari,

We have fixed this for both add and update employee now.

Show

Seema Gaikwad (Inactive) added a comment - 08/Aug/17 01:12 PM Hi Kunal Kedari , We have fixed this for both add and update employee now.

Seema Gaikwad (Inactive) made changes - 08/Aug/17 01:13 PM

Assignee

Seema Gaikwad [ seema.gaikwad ]

Kunal Kedari [ kunal.kedari ]

Seema Gaikwad (Inactive) made changes - 08/Aug/17 01:18 PM

Time Spent	6.75h [ 24300 ]	7.25h [ 26100 ]
Worklog Id		70060 [ 70060 ]

Seema Gaikwad (Inactive) made changes - 08/Aug/17 01:19 PM

Remaining Estimate	0h [ 0 ]	0.5h [ 1800 ]
Time Spent	7.25h [ 26100 ]	6.75h [ 24300 ]
Worklog Id		70060 [ 70060 ]

Khandu Kshirsagar (Inactive) made changes - 09/Aug/17 06:03 AM

Item State

Parent values: Development(10200)Level 1 values: Ready for Local Testing(10209)

Parent values: LB QA(10201)Level 1 values: LB Deployed(11600)

Saurabh Sablaka (Inactive) made changes - 09/Aug/17 07:06 AM

Status

In Development [ 10007 ]

Local Testing [ 10200 ]

Kunal Kedari (Inactive) made changes - 10/Aug/17 04:59 AM

Item State

Parent values: LB QA(10201)Level 1 values: LB Deployed(11600)

Parent values: LB QA(10201)Level 1 values: In Testing(10210)

Kunal Kedari (Inactive) made changes - 10/Aug/17 04:59 AM

Production Due Date		17/Aug/2017
Stage Due Date		14/Aug/17 [ 2017-08-14 ]

Hide

Permalink

Kunal Kedari (Inactive) added a comment - 10/Aug/17 05:04 AM

Verified fix on LB, working as expected . We can deploy fix to stage.

Show

Kunal Kedari (Inactive) added a comment - 10/Aug/17 05:04 AM Verified fix on LB, working as expected . We can deploy fix to stage.

Kunal Kedari (Inactive) made changes - 10/Aug/17 05:04 AM

Item State

Parent values: LB QA(10201)Level 1 values: In Testing(10210)

Parent values: LB QA(10201)Level 1 values: Ready for Stage(10213)

Ashwin Wankhede (Inactive) made changes - 10/Aug/17 06:58 AM

Item State

Parent values: LB QA(10201)Level 1 values: Ready for Stage(10213)

Parent values: LB QA(10201)Level 1 values: LB Deployed(11600)

Kunal Kedari (Inactive) made changes - 10/Aug/17 08:56 AM

Item State

Parent values: LB QA(10201)Level 1 values: LB Deployed(11600)

Parent values: LB QA(10201)Level 1 values: In Testing(10210)

Kunal Kedari (Inactive) made changes - 10/Aug/17 08:56 AM

Item State

Parent values: LB QA(10201)Level 1 values: In Testing(10210)

Parent values: LB QA(10201)Level 1 values: Ready for Stage(10213)

Khandu Kshirsagar (Inactive) made changes - 14/Aug/17 07:00 AM

Item State

Parent values: LB QA(10201)Level 1 values: Ready for Stage(10213)

Parent values: Stage QA(10202)Level 1 values: Stage Deployed(11602)

Kunal Kedari (Inactive) made changes - 16/Aug/17 05:25 AM

Item State

Parent values: Stage QA(10202)Level 1 values: Stage Deployed(11602)

Parent values: Stage QA(10202)Level 1 values: In Testing(10214)

Kunal Kedari (Inactive) made changes - 16/Aug/17 05:31 AM

Item State

Parent values: Stage QA(10202)Level 1 values: In Testing(10214)

Parent values: Stage QA(10202)Level 1 values: Production Deployment on Hold(10224)

Kunal Kedari (Inactive) made changes - 16/Aug/17 05:31 AM

Status

Local Testing [ 10200 ]

Stage Testing [ 10201 ]

Hide

Permalink

Kunal Kedari (Inactive) added a comment - 16/Aug/17 05:32 AM

Verified fix on Stage, working as expected . We can deploy fix to production.

Show

Kunal Kedari (Inactive) added a comment - 16/Aug/17 05:32 AM Verified fix on Stage, working as expected . We can deploy fix to production.

Kunal Kedari (Inactive) made changes - 18/Aug/17 10:14 AM

Link

This issue relates to ~~NF-3998~~ [ ~~NF-3998~~ ]

Hide

Permalink

Kunal Kedari (Inactive) added a comment - 24/Aug/17 09:36 AM

Business decided to stop all the work related to TSR.

Show

Kunal Kedari (Inactive) added a comment - 24/Aug/17 09:36 AM Business decided to stop all the work related to TSR.

Satya made changes - 04/Nov/17 06:31 AM

Environment_New

Stage [ 18443 ]

Sachin Hingole (Inactive) made changes - 26/Apr/18 03:14 AM

Resolution		Done [ 10000 ]
Status	Stage Testing [ 10201 ]	Resolution Setting [ 11616 ]

Transition	Time In Source Status	Execution Times

Seema Gaikwad (Inactive) made transition - 04/Aug/17 01:19 PM

Open

In Development

4h 23m

Kunal Kedari (Inactive) made transition - 08/Aug/17 12:12 PM

In LB Testing

Reopen in Local

Seema Gaikwad (Inactive) made transition - 08/Aug/17 01:10 PM

Reopen in Local

In Development

57m 33s

Saurabh Sablaka (Inactive) made transition - 09/Aug/17 07:06 AM

In Development

In LB Testing

4d 16h 49m

Kunal Kedari (Inactive) made transition - 16/Aug/17 05:31 AM

In LB Testing

Stage Testing

6d 22h 25m

Sachin Hingole (Inactive) made transition - 26/Apr/18 03:14 AM

Stage Testing

Resolution Setting

252d 21h 42m

People

Assignee:: Kunal Kedari (Inactive)

Reporter:: Kunal Kedari (Inactive)

QA:: Kunal Kedari (Inactive)

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Dates

Created:: 04/Aug/17 08:56 AM

Updated:: 26/Apr/18 03:14 AM

Resolved:: 26/Apr/18 03:14 AM

Pre-Prod Due Date:: 14/Aug/2017

Production Due Date:: 17/Aug/2017

Code Review Date:: 07/Aug/2017

Time Tracking

Estimated:

Remaining:

0.5h

Logged:

6.75h