New Features 2017Project Type: software

New Features 2017

Uploaded image for project: 'New Features 2017'
  1. New Features 2017
  2. NF-4064

TSR Integration>Regression>Limit the maximum annual salary added through API

    Details

    • Type: Change Request
    • Status: Resolution Setting
    • Priority: Medium
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Integrations
    • Labels:
      None
    • Module:
      TSR
    • Reported by:
      Harbinger
    • Item State:
      Stage QA - Production Deployment on Hold
    • Issue Importance:
      Q2
    • Feature Category:
      Integration
    • Severity:
      Medium

      Description

      1] Add a employee through API while adding enter annual salary.
      2] There is no limit for maximum digit accepted in salary field.

      Suggestion:
      Can we make AnnualSalary in sync with application, application accepts 9 digit as max salary.

      Cc: Saurabh Sablaka, Prasad Pise

        Attachments

          Issue Links

          relates to

          Support Activity - Support Activity NF-3998 Regression testing for TSR Integration with Old UI on Stage

          • High - Serious problem that could block progress.
          • Closed

            Activity

            Ascending order - Click to sort in descending order
            kunal.kedari Kunal Kedari (Inactive) created issue -
            seema.gaikwad Seema Gaikwad (Inactive) made changes -
            Field Original Value New Value
            Status New Request [ 10029 ] Pending for Approval [ 10002 ]
            Permalink
            ramya.tantry Ramya Tantry (Inactive) logged work - 07/Aug/17 12:41 PM
            • Time Spent:
              1.5h
               

              Discussion with Seema
              Implementing changes

            ramya.tantry Ramya Tantry (Inactive) made changes -
            Item State Parent values: Development(10200)Level 1 values: In Progress(10206)
            Remaining Estimate 4h [ 14400 ]
            Original Estimate 4h [ 14400 ]
            ramya.tantry Ramya Tantry (Inactive) made changes -
            Remaining Estimate 4h [ 14400 ] 2.5h [ 9000 ]
            Time Spent 1.5h [ 5400 ]
            Worklog Id 69755 [ 69755 ]
            Permalink
            seema.gaikwad Seema Gaikwad (Inactive) logged work - 07/Aug/17 12:53 PM
            • Time Spent:
              0.5h
               

              Discussion with Ramya and Kunal

            seema.gaikwad Seema Gaikwad (Inactive) made changes -
            Remaining Estimate 2.5h [ 9000 ] 2h [ 7200 ]
            Time Spent 1.5h [ 5400 ] 2h [ 7200 ]
            Worklog Id 69758 [ 69758 ]
            seema.gaikwad Seema Gaikwad (Inactive) made changes -
            Status Pending for Approval [ 10002 ] Approved for Development [ 10003 ]
            seema.gaikwad Seema Gaikwad (Inactive) made changes -
            Status Approved for Development [ 10003 ] In Development [ 10007 ]
            ramya.tantry Ramya Tantry (Inactive) made changes -
            Assignee Seema Gaikwad [ seema.gaikwad ] Ramya Tantry [ ramya.tantry ]
            ramya.tantry Ramya Tantry (Inactive) made changes -
            Code Review Date 08/Aug/2017
            Code Reviewed By Saurabh Sablaka [ 11909 ]
            ramya.tantry Ramya Tantry (Inactive) made changes -
            Item State Parent values: Development(10200)Level 1 values: In Progress(10206) Parent values: Development(10200)Level 1 values: Ready for Local Testing(10209)
            Hide
            Permalink
            ramya.tantry Ramya Tantry (Inactive) added a comment -

            Files Affected:

            Shared Library/ValueObjects/ValueObjects/WORKTERRA/EmployeeTours.cs

            Show
            ramya.tantry Ramya Tantry (Inactive) added a comment - Files Affected: Shared Library/ValueObjects/ValueObjects/WORKTERRA/EmployeeTours.cs
            Hide
            Permalink
            ramya.tantry Ramya Tantry (Inactive) added a comment -

            Hi Kunal Kedari,

            We have changed the annual salary regex to accept 9 digits and up-to 5 decimal values.
            Message is also changed to "Parameter annualSalary should in the format XXXXXXXXX.XXXXX"

            Show
            ramya.tantry Ramya Tantry (Inactive) added a comment - Hi Kunal Kedari , We have changed the annual salary regex to accept 9 digits and up-to 5 decimal values. Message is also changed to "Parameter annualSalary should in the format XXXXXXXXX.XXXXX"
            Permalink
            ramya.tantry Ramya Tantry (Inactive) logged work - 08/Aug/17 09:33 AM
            • Time Spent:
              2h
               

              Discussion with Saurabh
              Unit testing
              Checkin to Local,LB and UI Refresh

            ramya.tantry Ramya Tantry (Inactive) made changes -
            Remaining Estimate 2h [ 7200 ] 0h [ 0 ]
            Time Spent 2h [ 7200 ] 4h [ 14400 ]
            Worklog Id 70019 [ 70019 ]
            khandu.kshirsagar Khandu Kshirsagar (Inactive) made changes -
            Item State Parent values: Development(10200)Level 1 values: Ready for Local Testing(10209) Parent values: LB QA(10201)Level 1 values: LB Deployed(11600)
            ramya.tantry Ramya Tantry (Inactive) made changes -
            Assignee Ramya Tantry [ ramya.tantry ] Kunal Kedari [ kunal.kedari ]
            Hide
            Permalink
            ramya.tantry Ramya Tantry (Inactive) added a comment -

            Hi Kunal Kedari,

            This is deployed on LB.Please verify.

            Show
            ramya.tantry Ramya Tantry (Inactive) added a comment - Hi Kunal Kedari , This is deployed on LB.Please verify.
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Item State Parent values: LB QA(10201)Level 1 values: LB Deployed(11600) Parent values: LB QA(10201)Level 1 values: In Testing(10210)
            Hide
            Permalink
            kunal.kedari Kunal Kedari (Inactive) added a comment -

            Verified the fix on LB (wt-stage), working as expected. We can deploy fix to Stage.

            Show
            kunal.kedari Kunal Kedari (Inactive) added a comment - Verified the fix on LB (wt-stage), working as expected. We can deploy fix to Stage.
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Item State Parent values: LB QA(10201)Level 1 values: In Testing(10210) Parent values: LB QA(10201)Level 1 values: Ready for Stage(10213)
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Status In Development [ 10007 ] Local Testing [ 10200 ]
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Status Local Testing [ 10200 ] Pending for Stage Approval [ 10300 ]
            saurabh.sablaka Saurabh Sablaka (Inactive) made changes -
            Developer Ramya Tantry [ ramya.tantry ]
            khandu.kshirsagar Khandu Kshirsagar (Inactive) made changes -
            Item State Parent values: LB QA(10201)Level 1 values: Ready for Stage(10213) Parent values: Stage QA(10202)Level 1 values: Stage Deployed(11602)
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Item State Parent values: Stage QA(10202)Level 1 values: Stage Deployed(11602) Parent values: Stage QA(10202)Level 1 values: In Testing(10214)
            Hide
            Permalink
            kunal.kedari Kunal Kedari (Inactive) added a comment -

            Verified fix on Stage, working as expected. We can deploy fix on Production.

            Show
            kunal.kedari Kunal Kedari (Inactive) added a comment - Verified fix on Stage, working as expected. We can deploy fix on Production.
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Production Due Date 17/Aug/2017
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Item State Parent values: Stage QA(10202)Level 1 values: In Testing(10214) Parent values: Stage QA(10202)Level 1 values: Production Deployment on Hold(10224)
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Status Pending for Stage Approval [ 10300 ] Approved for Stage [ 10030 ]
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Status Approved for Stage [ 10030 ] Stage Testing [ 10201 ]
            Permalink
            kunal.kedari Kunal Kedari (Inactive) logged work - 10/Aug/17 05:23 PM
            • Time Spent:
              0.5h
               

              Testing on Local

            Permalink
            saurabh.sablaka Saurabh Sablaka (Inactive) logged work - 11/Aug/17 11:58 AM
            • Time Spent:
              0.25h
               

              Code review

            saurabh.sablaka Saurabh Sablaka (Inactive) made changes -
            Time Spent 4h [ 14400 ] 4.25h [ 15300 ]
            Worklog Id 71210 [ 71210 ]
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Production Due Date 17/Aug/2017 24/Aug/2017
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Stage Due Date 9/Aug/17 [ 2017-08-09 ]
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Link This issue relates to NF-3998 [ NF-3998 ]
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Time Spent 4.25h [ 15300 ] 4.75h [ 17100 ]
            Worklog Id 73339 [ 73339 ]
            Hide
            Permalink
            kunal.kedari Kunal Kedari (Inactive) added a comment -

            Business decided to stop all the work related to TSR.

            Show
            kunal.kedari Kunal Kedari (Inactive) added a comment - Business decided to stop all the work related to TSR.
            sachin.hingole Sachin Hingole (Inactive) made changes -
            Resolution Done [ 10000 ]
            Status Stage Testing [ 10201 ] Resolution Setting [ 11616 ]
            Transition Time In Source Status Execution Times
            Seema Gaikwad (Inactive) made transition -
            New Request Pending for Approval
            		2h 13m 1
            Seema Gaikwad (Inactive) made transition -
            Pending for Approval Approved for Development
            		3d 1h 1m 1
            Seema Gaikwad (Inactive) made transition -
            Approved for Development In Development
            		3s 1
            Kunal Kedari (Inactive) made transition -
            In Development In LB Testing
            		23h 39m 1
            Kunal Kedari (Inactive) made transition -
            In LB Testing Pending for Stage Approval
            		3s 1
            Kunal Kedari (Inactive) made transition -
            Pending for Stage Approval Approved for Stage
            		1d 16h 14m 1
            Kunal Kedari (Inactive) made transition -
            Approved for Stage Stage Testing
            		2s 1
            Sachin Hingole (Inactive) made transition -
            Stage Testing Resolution Setting
            		258d 22h 23m 1

              People

              Assignee:
              kunal.kedari Kunal Kedari (Inactive)
              Reporter:
              kunal.kedari Kunal Kedari (Inactive)
              Developer:
              Ramya Tantry (Inactive)
              QA:
              Kunal Kedari (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Pre-Prod Due Date:
                Production Due Date:
                Code Review Date:

                  Time Tracking

                  Estimated:
                  Original Estimate - 4h Original Estimate - 4h
                  4h
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 4.75h
                  4.75h