Uploaded image for project: 'New Features 2017'
  1. New Features 2017
  2. NF-4126

TSR Integration->Regression>Currency is not reflecting properly on Payroll page

    Details

    • Type: Bug
    • Status: Resolution Setting
    • Priority: Medium
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Integrations
    • Labels:
      None
    • Environment:
      Stage
    • Bug Type:
      Functional
    • Bug Severity:
      Medium
    • Level:
      Admin
    • Module:
      TSR
    • Reported by:
      Harbinger
    • Item State:
      Stage QA - Production Deployment on Hold
    • Issue Importance:
      Q2
    • Browser:
      Google Chrome

      Description

      1] Add a employee through API.
      2] Login to the application by admin, observe the currency for added employee on "Payroll" page.

      Actual Result:
      Different currency type is displaying under "Currency & Date Format" drop down.
      Also currency updated from API is not reflecting properly on Payroll page. (All fields having salary)
      Refer attached screenshot for more details.

      Cc:Saurabh Sablaka, Prasad Pise

        Attachments

        1. Curreny.jpg
          Curreny.jpg
          173 kB
        2. Payroll.jpg
          Payroll.jpg
          173 kB

          Issue Links

            Activity

            sushodhan.vaishampayan Sushodhan Vaishampayan (Inactive) logged work - 09/Aug/17 02:03 PM
            • Time Spent:
              2h
               

              Tracking the issue and finding the solution.

            kunal.kedari Kunal Kedari (Inactive) created issue -
            seema.gaikwad Seema Gaikwad (Inactive) made changes -
            Field Original Value New Value
            Assignee Seema Gaikwad [ seema.gaikwad ] Sushodhan Vaishampayan [ sushodhan.vaishampayan ]
            sushodhan.vaishampayan Sushodhan Vaishampayan (Inactive) made changes -
            Status Open [ 1 ] In Development [ 10007 ]
            sushodhan.vaishampayan Sushodhan Vaishampayan (Inactive) made changes -
            Item State Parent values: Development(10200)Level 1 values: Ready for Review(10208)
            saurabh.sablaka Saurabh Sablaka (Inactive) made changes -
            Dev Estimates 3
            Developer Seema Gaikwad [ seema.gaikwad ] Sushodhan Vaishampayan [ sushodhan.vaishampayan ]
            Remaining Estimate 3h [ 10800 ]
            Original Estimate 3h [ 10800 ]
            saurabh.sablaka Saurabh Sablaka (Inactive) logged work - 11/Aug/17 12:47 PM
            • Time Spent:
              0.25h
               

              Script review

            saurabh.sablaka Saurabh Sablaka (Inactive) made changes -
            Remaining Estimate 3h [ 10800 ] 2.75h [ 9900 ]
            Time Spent 0.25h [ 900 ]
            Worklog Id 71227 [ 71227 ]
            Hide
            sushodhan.vaishampayan Sushodhan Vaishampayan (Inactive) added a comment -

            Concern : TSR Integration->Regression>Currency is not reflecting properly on Payroll page

            Cause : The issue was in the stored procedure "dbo.OES_SP_AssignDefaultPayroll". We were not allowing to update anything if payroll and annual salary is same.

            Correction : We are now allowing the payroll data to be updated if any of the three i.e currency format payroll and annual salary is different.

            CC :- Seema Gaikwad, Saurabh Sablaka, Kunal Kedari.

            Show
            sushodhan.vaishampayan Sushodhan Vaishampayan (Inactive) added a comment - Concern : TSR Integration->Regression>Currency is not reflecting properly on Payroll page Cause : The issue was in the stored procedure "dbo.OES_SP_AssignDefaultPayroll". We were not allowing to update anything if payroll and annual salary is same. Correction : We are now allowing the payroll data to be updated if any of the three i.e currency format payroll and annual salary is different. CC :- Seema Gaikwad , Saurabh Sablaka , Kunal Kedari .
            sushodhan.vaishampayan Sushodhan Vaishampayan (Inactive) made changes -
            Assignee Sushodhan Vaishampayan [ sushodhan.vaishampayan ] Kunal Kedari [ kunal.kedari ]
            sushodhan.vaishampayan Sushodhan Vaishampayan (Inactive) made changes -
            Code Review Date 11/Aug/2017
            Code Reviewed By Saurabh Sablaka [ 11909 ]
            khandu.kshirsagar Khandu Kshirsagar (Inactive) made changes -
            Item State Parent values: Development(10200)Level 1 values: Ready for Review(10208) Parent values: LB QA(10201)Level 1 values: LB Deployed(11600)
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Attachment Payroll.jpg [ 58702 ]
            Hide
            kunal.kedari Kunal Kedari (Inactive) added a comment -

            Hi Sushodhan Vaishampayan,

            The fix is not proper, the currency is still not reflecting properly after adding or updating employee from API.

            Cc: Saurabh Sablaka, Prasad Pise

            Show
            kunal.kedari Kunal Kedari (Inactive) added a comment - Hi Sushodhan Vaishampayan , The fix is not proper, the currency is still not reflecting properly after adding or updating employee from API. Cc: Saurabh Sablaka , Prasad Pise
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Item State Parent values: LB QA(10201)Level 1 values: LB Deployed(11600) Parent values: LB QA(10201)Level 1 values: In Testing(10210)
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Item State Parent values: LB QA(10201)Level 1 values: In Testing(10210) Parent values: LB QA(10201)Level 1 values: Re-open(10212)
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Status In Development [ 10007 ] Local Testing [ 10200 ]
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Assignee Kunal Kedari [ kunal.kedari ] Sushodhan Vaishampayan [ sushodhan.vaishampayan ]
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Status Local Testing [ 10200 ] Reopen in Local [ 10018 ]
            Hide
            sushodhan.vaishampayan Sushodhan Vaishampayan (Inactive) added a comment -

            Hi Kunal Kedari,

            The issue was present on LB due to discrepancy in the database of company. So please try testing the thing on another company and taking the discrepancy into consideration. Thank you.

            Regards
            Sushodhan Vaishampayan

            CC : Saurabh Sablaka, Prasad Pise.

            Show
            sushodhan.vaishampayan Sushodhan Vaishampayan (Inactive) added a comment - Hi Kunal Kedari , The issue was present on LB due to discrepancy in the database of company. So please try testing the thing on another company and taking the discrepancy into consideration. Thank you. Regards Sushodhan Vaishampayan CC : Saurabh Sablaka , Prasad Pise .
            sushodhan.vaishampayan Sushodhan Vaishampayan (Inactive) made changes -
            Assignee Sushodhan Vaishampayan [ sushodhan.vaishampayan ] Kunal Kedari [ kunal.kedari ]
            Hide
            kunal.kedari Kunal Kedari (Inactive) added a comment -

            Hi Sushodhan Vaishampayan,

            TSR is not linked to any other company on Local except "CityOfLakeWorth" on which issue is reproducible. As of now we are marking this issue "Ready for Stage" and will test on Stage once patch is deployed.

            Cc: Saurabh Sablaka, Prasad Pise

            Show
            kunal.kedari Kunal Kedari (Inactive) added a comment - Hi Sushodhan Vaishampayan , TSR is not linked to any other company on Local except "CityOfLakeWorth" on which issue is reproducible. As of now we are marking this issue "Ready for Stage" and will test on Stage once patch is deployed. Cc: Saurabh Sablaka , Prasad Pise
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Item State Parent values: LB QA(10201)Level 1 values: Re-open(10212) Parent values: LB QA(10201)Level 1 values: Ready for Stage(10213)
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Status Reopen in Local [ 10018 ] In Development [ 10007 ]
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Status In Development [ 10007 ] Local Testing [ 10200 ]
            sushodhan.vaishampayan Sushodhan Vaishampayan (Inactive) made changes -
            Remaining Estimate 2.75h [ 9900 ] 0.75h [ 2700 ]
            Time Spent 0.25h [ 900 ] 2.25h [ 8100 ]
            Worklog Id 71822 [ 71822 ]
            khandu.kshirsagar Khandu Kshirsagar (Inactive) made changes -
            Item State Parent values: LB QA(10201)Level 1 values: Ready for Stage(10213) Parent values: Stage QA(10202)Level 1 values: Stage Deployed(11602)
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Production Due Date 24/Aug/2017
            Stage Due Date 17/Aug/17 [ 2017-08-17 ]
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Link This issue relates to NF-3998 [ NF-3998 ]
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Item State Parent values: Stage QA(10202)Level 1 values: Stage Deployed(11602) Parent values: Stage QA(10202)Level 1 values: In Testing(10214)
            Hide
            kunal.kedari Kunal Kedari (Inactive) added a comment -

            Verified fix on Stage working as expected, after updating currency through API it is getting reflected properly on payroll page.

            Note - We need to revisit Employee Home page and again Payroll page to see the changes otherwise changes are not reflecting just reloading the payroll page.

            This fix will be deployed on Production with TSR changes. Hence marking it as "Production Deployment On Hold".

            Cc: Saurabh Sablaka, Prasad Pise

            Show
            kunal.kedari Kunal Kedari (Inactive) added a comment - Verified fix on Stage working as expected, after updating currency through API it is getting reflected properly on payroll page. Note - We need to revisit Employee Home page and again Payroll page to see the changes otherwise changes are not reflecting just reloading the payroll page. This fix will be deployed on Production with TSR changes. Hence marking it as "Production Deployment On Hold". Cc: Saurabh Sablaka , Prasad Pise
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Item State Parent values: Stage QA(10202)Level 1 values: In Testing(10214) Parent values: Stage QA(10202)Level 1 values: Production Deployment on Hold(10224)
            Hide
            kunal.kedari Kunal Kedari (Inactive) added a comment -

            Business decided to stop all the work related to TSR.

            Show
            kunal.kedari Kunal Kedari (Inactive) added a comment - Business decided to stop all the work related to TSR.
            satyap Satya made changes -
            Environment_New Stage [ 18443 ]
            rakeshr Rakesh Roy (Inactive) made changes -
            Status Local Testing [ 10200 ] Stage Testing [ 10201 ]
            sachin.hingole Sachin Hingole (Inactive) made changes -
            Resolution Done [ 10000 ]
            Status Stage Testing [ 10201 ] Resolution Setting [ 11616 ]
            Transition Time In Source Status Execution Times
            Sushodhan Vaishampayan (Inactive) made transition -
            Open In Development
            1d 1h 3m 1
            Kunal Kedari (Inactive) made transition -
            In LB Testing Reopen in Local
            16s 1
            Kunal Kedari (Inactive) made transition -
            Reopen in Local In Development
            3h 2m 1
            Kunal Kedari (Inactive) made transition -
            In Development In LB Testing
            4d 20h 32m 2
            Rakesh Roy (Inactive) made transition -
            In LB Testing Stage Testing
            91d 23h 9m 1
            Sachin Hingole (Inactive) made transition -
            Stage Testing Resolution Setting
            160d 16h 33m 1

              People

              Assignee:
              kunal.kedari Kunal Kedari (Inactive)
              Reporter:
              kunal.kedari Kunal Kedari (Inactive)
              Developer:
              Sushodhan Vaishampayan (Inactive)
              QA:
              Kunal Kedari (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Pre-Prod Due Date:
                Production Due Date:
                Code Review Date:

                  Time Tracking

                  Estimated:
                  Original Estimate - 3h
                  3h
                  Remaining:
                  Time Spent - 2.25h Remaining Estimate - 0.75h
                  0.75h
                  Logged:
                  Time Spent - 2.25h Remaining Estimate - 0.75h
                  2.25h