Uploaded image for project: 'New Features 2017'
  1. New Features 2017
  2. NF-5250

View Activity - Clearer indication of required fields + prompt with no record

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: UI Refresh
    • Labels:
      None
    • Environment:
      Others
    • Bug Type:
      Functional
    • Bug Severity:
      Medium
    • Level:
      Admin
    • Module:
      BenAdmin
    • Reported by:
      CareerBuilder
    • Company:
      All Clients/Multiple Clients
    • Item State:
      Stage QA - Production Deployment on Hold
    • Browser:
      Google Chrome

      Description

      Credential: demojenadmin Password@1 accessing employee Thomas Andrews

      Comments: Date is not marked as mandatory and there is no prompt if there is no record. Recording at https://screencast-o-matic.com/watch/cbXUhJ2xWf

      Action: Four enhancements
      (1) make date selection mandatory
      (2) have some date pre-set on the fields (recommend 2 years ago to today's date)
      (3) show a prompt if there is no records within selected period 'There is no record found'
      (4) reduce space between action button and the data table

        Attachments

          Issue Links

            Activity

            Hide
            nidhi.kaul Nidhi Kaul (Inactive) added a comment - - edited

            Diana Wong,
            In your email you mentioned this ti be a change request. Just confirming before i change the type.

            Vijayendra Shinde
            Thanks,
            Ndihi.

            Show
            nidhi.kaul Nidhi Kaul (Inactive) added a comment - - edited Diana Wong , In your email you mentioned this ti be a change request. Just confirming before i change the type. Vijayendra Shinde Thanks, Ndihi.
            Hide
            diana Diana Wong (Inactive) added a comment -

            Nidhi Kaul Yes, its change request. So sorry I created this from cloning, probably forgot to update the type.

            Show
            diana Diana Wong (Inactive) added a comment - Nidhi Kaul Yes, its change request. So sorry I created this from cloning, probably forgot to update the type.
            Hide
            nidhi.kaul Nidhi Kaul (Inactive) added a comment -

            No problem. I changed it.

            Thanks,
            nidhi.

            Show
            nidhi.kaul Nidhi Kaul (Inactive) added a comment - No problem. I changed it. Thanks, nidhi.
            Hide
            nidhi.kaul Nidhi Kaul (Inactive) added a comment - - edited

            Hi Prasanna Karlekar,
            Can you please check this on priority? This is reported by demo. My initial understanding was that is a change request, but upon talking to QA, it looks like this is an issue with one employee.

            See Hrishikesh's comment below. -

            Employee- Thomas Andrews
            Company - Demo Company_Jennifer
            View History -> Enrollment details
            Expected Result - Current Enrollment should show
            Actual Result - Nothing happens.

            ErrorID : 0
            ErrorSource : ControllerAppTier.GetCollection->WORKTERRAControllerAppTier.GetData->CollectionManager.GetCollection->CollectionManager.GetHistoryInformationCollection->CollectionManager.EnrollmentHistoryCollection
            ErrorMessage: Index and length must refer to a location within the string.
            Parameter name: length

            This issue is not reproducing for other employees. it is only with this employee.

            Thanks,
            Nidhi

            Vijayendra ShindeSachin HingoleHrishikesh Deshpande

            Show
            nidhi.kaul Nidhi Kaul (Inactive) added a comment - - edited Hi Prasanna Karlekar , Can you please check this on priority? This is reported by demo. My initial understanding was that is a change request, but upon talking to QA, it looks like this is an issue with one employee. See Hrishikesh's comment below. - Employee- Thomas Andrews Company - Demo Company_Jennifer View History -> Enrollment details Expected Result - Current Enrollment should show Actual Result - Nothing happens. ErrorID : 0 ErrorSource : ControllerAppTier.GetCollection->WORKTERRAControllerAppTier.GetData->CollectionManager.GetCollection->CollectionManager.GetHistoryInformationCollection->CollectionManager.EnrollmentHistoryCollection ErrorMessage: Index and length must refer to a location within the string. Parameter name: length This issue is not reproducing for other employees. it is only with this employee. Thanks, Nidhi Vijayendra Shinde Sachin Hingole Hrishikesh Deshpande
            Hide
            prasanna Prasanna Karlekar (Inactive) added a comment -

            Hi Nidhi Kaul,

            Analyzing this issue. Will provide an update in some time.

            Thank you!

            Show
            prasanna Prasanna Karlekar (Inactive) added a comment - Hi Nidhi Kaul , Analyzing this issue. Will provide an update in some time. Thank you!
            Hide
            prasanna Prasanna Karlekar (Inactive) added a comment -

            Following are the 3C's:
            Concern:
            Server error appearing on View History.

            Cause:
            When date range is not provided, by default changes are considered from start when employee did his first election. Analyzed the data for employee "Thomas Andrews". This employee had waived some benefits. Some of the benefits are currently deleted which is causing the error. These benefits are present in History table with Delete flag but are not there in main table. While fetching the data for employee View History, we do not refer history tables for plans and benefits information as it will degrade the performance.

            Correction:
            Currently, we are adding condition to show only those records whose plans and benefits information is available in their main tables.
            Whether this is an appropriate approach or not needs to be discussed.

            Thank you!

            cc: Vijayendra Shinde, Nidhi Kaul, Rakesh Roy

            Show
            prasanna Prasanna Karlekar (Inactive) added a comment - Following are the 3C's: Concern: Server error appearing on View History. Cause: When date range is not provided, by default changes are considered from start when employee did his first election. Analyzed the data for employee "Thomas Andrews". This employee had waived some benefits. Some of the benefits are currently deleted which is causing the error. These benefits are present in History table with Delete flag but are not there in main table. While fetching the data for employee View History, we do not refer history tables for plans and benefits information as it will degrade the performance. Correction: Currently, we are adding condition to show only those records whose plans and benefits information is available in their main tables. Whether this is an appropriate approach or not needs to be discussed. Thank you! cc: Vijayendra Shinde , Nidhi Kaul , Rakesh Roy
            Hide
            harshada.borole Harshada Borole (Inactive) added a comment -

            Below are the points mentioned in description for enhancement:

            1) make date selection mandatory- For now we are not considering this enhancement because we are allowing users to view history without selecting dates and this change will also affect other companies too.
            2) have some date pre-set on the fields (recommend 2 years ago to today's date)- As we are not considering above enhancement, this too will not be considered.
            3) show a prompt if there is no records within selected period 'There is no record found'- This is already implemented.

            For point #4 we have created new JIRA i.e NF-5316.

            Show
            harshada.borole Harshada Borole (Inactive) added a comment - Below are the points mentioned in description for enhancement: 1) make date selection mandatory- For now we are not considering this enhancement because we are allowing users to view history without selecting dates and this change will also affect other companies too. 2) have some date pre-set on the fields (recommend 2 years ago to today's date)- As we are not considering above enhancement, this too will not be considered. 3) show a prompt if there is no records within selected period 'There is no record found'- This is already implemented. For point #4 we have created new JIRA i.e NF-5316 .
            Hide
            mahendra.mungase Mahendra Mungase (Inactive) added a comment - - edited

            Hi Harshada Borole

            While testing search functionality on CodeMap we found two issues which is already linked with same JIRA.Hence reopening the same and assigned to you.Please revert once you fix all issue.

            Thanks,
            Mahendra

            Show
            mahendra.mungase Mahendra Mungase (Inactive) added a comment - - edited Hi Harshada Borole While testing search functionality on CodeMap we found two issues which is already linked with same JIRA.Hence reopening the same and assigned to you.Please revert once you fix all issue. Thanks, Mahendra
            Hide
            prasanna Prasanna Karlekar (Inactive) added a comment -

            Hi Mahendra Mungase,

            The fix that we made, is by no means related to the issues that you have logged(NF-5330 and NF-5331).
            Those needs to be fixed, but they are not because of the fix we gave for this ticket.
            Hence, kindly remove the linked issues from this JIRA and assign them separately.
            Also, if there is no issue in populating Enrollment History when no dates are provided then please let this fix move further.

            Thank you!

            cc: Harshada Borole, Vijayendra Shinde, Nidhi Kaul, Sachin Hingole

            Show
            prasanna Prasanna Karlekar (Inactive) added a comment - Hi Mahendra Mungase , The fix that we made, is by no means related to the issues that you have logged( NF-5330 and NF-5331 ). Those needs to be fixed, but they are not because of the fix we gave for this ticket. Hence, kindly remove the linked issues from this JIRA and assign them separately. Also, if there is no issue in populating Enrollment History when no dates are provided then please let this fix move further. Thank you! cc: Harshada Borole , Vijayendra Shinde , Nidhi Kaul , Sachin Hingole
            Hide
            nidhi.kaul Nidhi Kaul (Inactive) added a comment -

            Mahendra Mungase
            Please explain why this is re opened.

            Nidhi.

            Show
            nidhi.kaul Nidhi Kaul (Inactive) added a comment - Mahendra Mungase Please explain why this is re opened. Nidhi.
            Hide
            mahendra.mungase Mahendra Mungase (Inactive) added a comment -

            Hi Nidhi Kaul

            We did not remember to change the status after bug locked. Yesterday we read my comments and change the status.Now both bugs are fix and verified. So changing the status to on hold.

            Thanks,
            Mahendra

            Show
            mahendra.mungase Mahendra Mungase (Inactive) added a comment - Hi Nidhi Kaul We did not remember to change the status after bug locked. Yesterday we read my comments and change the status.Now both bugs are fix and verified. So changing the status to on hold. Thanks, Mahendra
            Hide
            mahendra.mungase Mahendra Mungase (Inactive) added a comment -

            We have verified this issue on Production and it is fixed.

            Thanks,
            Mahendra

            Show
            mahendra.mungase Mahendra Mungase (Inactive) added a comment - We have verified this issue on Production and it is fixed. Thanks, Mahendra

              People

              Assignee:
              mahendra.mungase Mahendra Mungase (Inactive)
              Reporter:
              diana Diana Wong (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Dev Due Date:

                  Time Tracking

                  Estimated:
                  Original Estimate - 0h
                  0h
                  Remaining:
                  Time Spent - 9.5h Remaining Estimate - 4.5h
                  4.5h
                  Logged:
                  Time Spent - 9.5h Remaining Estimate - 4.5h
                  9.5h