[NF-5455] CLONE - EOI: upload : Object referance error on save button - Workterra Jira

Details

Type: Bug
Status: Resolution Setting
Priority: Medium
Resolution: Done
Affects Version/s: None
Fix Version/s: None
Component/s: UI Refresh
Labels:
None

Environment:

QA
Bug Severity:
Medium
Level:

Partner
Module:
BenAdmin - EDS
Reported by:
Harbinger
Company:
All Clients/Multiple Clients
Item State:
Stage QA - Ready for Production

Description

Company name: For QA KinderCare
Eoi upload page

Upload EOI form:
Click on map filed:
Map filed with given values in drop down
click on save button: nothing happened

refer attached EOI form file and refer attached screenshots

Attachments

Issue Links

clones

NF-5437 EOI: upload : Save Button not working

Resolution Setting

Activity

Ascending order - Click to sort in descending order

Vishal Yadav (Inactive) created issue - 11/Dec/17 10:25 AM

Vishal Yadav (Inactive) made changes - 11/Dec/17 10:25 AM

Field	Original Value	New Value
Link		This issue clones ~~NF-5437~~ [ ~~NF-5437~~ ]

Permalink

Vishal Yadav (Inactive) logged work - 11/Dec/17 02:07 PM

Time Spent:

2h

Analysis for changes required
On traversing page, it is found that popup message validation not implemented.
Added code to add validations on save button click.
made changes to server side for data type conversion.

Vishal Yadav (Inactive) made changes - 12/Dec/17 04:20 AM

Status

Open [ 1 ]

In Development [ 10007 ]

Vishal Yadav (Inactive) made changes - 12/Dec/17 04:55 AM

Item State

Parent values: Development(10200)Level 1 values: In Progress(10206)

Parent values: Development(10200)Level 1 values: Ready for Review(10208)

Hide

Permalink

Vishal Yadav (Inactive) added a comment - 12/Dec/17 05:08 AM

While Development, it is found that, when user selects "Show in Popup" as "Yes" then Popup message gets enable. And if user don't fill any value in popup message then, it is treated as null at server side.

Concern : Error message validation should display if popup message field is editable and blank.
Cause : 1) validation was not handled.
2) ToString() used for converting null value to string.
Correction : 1) Validations added.
2) ToString() is replaced by Convert.ToString().

CC: Vijayendra Shinde

Show

Vishal Yadav (Inactive) added a comment - 12/Dec/17 05:08 AM While Development, it is found that, when user selects "Show in Popup" as "Yes" then Popup message gets enable. And if user don't fill any value in popup message then, it is treated as null at server side. Concern : Error message validation should display if popup message field is editable and blank. Cause : 1) validation was not handled. 2) ToString() used for converting null value to string. Correction : 1) Validations added. 2) ToString() is replaced by Convert.ToString(). CC: Vijayendra Shinde

Hide

Permalink

Vishal Yadav (Inactive) added a comment - 12/Dec/17 06:33 AM

affected files

/branches/UiRefresh/App/BusinessLogic/SystemSettings/EOIForm.vb
/branches/UiRefresh/Web/Web Projects/BenAdmin/Areas/Customization/Views/Customization/UploadEOI/UploadEOI.cshtml
/branches/UiRefresh/Web/Web Projects/BenAdmin/Areas/Customization/Views/Customization/UploadEOI/_UploadEOIPV.cshtml

Show

Vishal Yadav (Inactive) added a comment - 12/Dec/17 06:33 AM affected files /branches/UiRefresh/App/BusinessLogic/SystemSettings/EOIForm.vb /branches/UiRefresh/Web/Web Projects/BenAdmin/Areas/Customization/Views/Customization/UploadEOI/UploadEOI.cshtml /branches/UiRefresh/Web/Web Projects/BenAdmin/Areas/Customization/Views/Customization/UploadEOI/_UploadEOIPV.cshtml

Hide

Permalink

Vishal Yadav (Inactive) added a comment - 12/Dec/17 06:39 AM

Hi Rashmita Dudhe,

Show popup message validations were not handled previously. But now we have fixed that issue too.
Please check this issue after next build.

If any doubt, feel free to ask me.

Thanks,
Vishal Yadav

Show

Vishal Yadav (Inactive) added a comment - 12/Dec/17 06:39 AM Hi Rashmita Dudhe , Show popup message validations were not handled previously. But now we have fixed that issue too. Please check this issue after next build. If any doubt, feel free to ask me. Thanks, Vishal Yadav

Vishal Yadav (Inactive) made changes - 12/Dec/17 06:39 AM

Assignee

Vishal Yadav [ vishal.yadav ]

Rashmita Dudhe [ rashmita.dudhe ]

Vishal Yadav (Inactive) made changes - 12/Dec/17 01:56 PM

Item State

Parent values: Development(10200)Level 1 values: Ready for Review(10208)

Parent values: Development(10200)Level 1 values: Ready for Local Testing(10209)

Permalink

Vishal Yadav (Inactive) logged work - 12/Dec/17 02:09 PM

Time Spent:

1h

Unit Testing
Code review with Vijayendra
Jira Updation

Vishal Yadav (Inactive) made changes - 12/Dec/17 02:09 PM

Remaining Estimate	2h [ 7200 ]	0h [ 0 ]
Time Spent		2h [ 7200 ]
Worklog Id		95828 [ 95828 ]

Vishal Yadav (Inactive) made changes - 12/Dec/17 02:11 PM

Time Spent	2h [ 7200 ]	3h [ 10800 ]
Worklog Id		95829 [ 95829 ]

Khandu Kshirsagar (Inactive) made changes - 19/Dec/17 10:08 AM

Item State

Parent values: Development(10200)Level 1 values: Ready for Local Testing(10209)

Parent values: LB QA(10201)Level 1 values: LB Deployed(11600)

Permalink

Vishal Yadav (Inactive) logged work - 19/Dec/17 01:10 PM

Time Spent:

0.5h

code commit on codemap

Vishal Yadav (Inactive) made changes - 19/Dec/17 01:10 PM

Time Spent	3h [ 10800 ]	3.5h [ 12600 ]
Worklog Id		96935 [ 96935 ]

Hide

Permalink

Rashmita Dudhe (Inactive) added a comment - 20/Dec/17 06:48 AM

Verified on Code consider below scenarios:
1]Upload New EOI form
2]Mapp EOI file
3]Click on save button
4]EOI file save successfully.
Working fine as expected.

Show

Rashmita Dudhe (Inactive) added a comment - 20/Dec/17 06:48 AM Verified on Code consider below scenarios: 1]Upload New EOI form 2]Mapp EOI file 3]Click on save button 4]EOI file save successfully. Working fine as expected.

Rashmita Dudhe (Inactive) made changes - 20/Dec/17 06:48 AM

Time Spent	3.5h [ 12600 ]	4.5h [ 16200 ]
Worklog Id		97052 [ 97052 ]

Sanjana Jadhav (Inactive) made changes - 21/Dec/17 04:16 AM

Item State

Parent values: LB QA(10201)Level 1 values: LB Deployed(11600)

Parent values: LB QA(10201)Level 1 values: In Testing(10210)

Sanjana Jadhav (Inactive) made changes - 21/Dec/17 04:17 AM

Item State

Parent values: LB QA(10201)Level 1 values: In Testing(10210)

Parent values: LB QA(10201)Level 1 values: Ready for Stage(10213)

Sanjana Jadhav (Inactive) made changes - 21/Dec/17 04:17 AM

Status

In Development [ 10007 ]

Local Testing [ 10200 ]

Sanjana Jadhav (Inactive) made changes - 21/Dec/17 05:38 AM

Item State

Parent values: LB QA(10201)Level 1 values: Ready for Stage(10213)

Parent values: LB QA(10201)Level 1 values: On Hold(10211)

Permalink

Rashmita Dudhe (Inactive) logged work - 21/Dec/17 06:48 AM

Time Spent:

1h

<No comment>

Khandu Kshirsagar (Inactive) made changes - 28/Dec/17 07:09 AM

Item State

Parent values: LB QA(10201)Level 1 values: On Hold(10211)

Parent values: Stage QA(10202)Level 1 values: Stage Deployed(11602)

Rashmita Dudhe (Inactive) made changes - 28/Dec/17 08:27 AM

Item State

Parent values: Stage QA(10202)Level 1 values: Stage Deployed(11602)

Parent values: Stage QA(10202)Level 1 values: In Testing(10214)

Rashmita Dudhe (Inactive) made changes - 28/Dec/17 08:27 AM

Status

Local Testing [ 10200 ]

Stage Testing [ 10201 ]

Permalink

Rashmita Dudhe (Inactive) logged work - 28/Dec/17 11:34 AM

Time Spent:

1h

<No comment>

Hide

Permalink

Rashmita Dudhe (Inactive) added a comment - 28/Dec/17 11:34 AM

Verified on pre-prod consider below scenarios:
1]Upload New EOI form
2]Mapp EOI file
3]Click on save button
4]EOI file save successfully.
Working fine as expected.

Show

Rashmita Dudhe (Inactive) added a comment - 28/Dec/17 11:34 AM Verified on pre-prod consider below scenarios: 1]Upload New EOI form 2]Mapp EOI file 3]Click on save button 4]EOI file save successfully. Working fine as expected.

Rashmita Dudhe (Inactive) made changes - 28/Dec/17 11:34 AM

Time Spent	4.5h [ 16200 ]	5.5h [ 19800 ]
Worklog Id		98285 [ 98285 ]

Rashmita Dudhe (Inactive) made changes - 28/Dec/17 11:35 AM

Item State

Parent values: Stage QA(10202)Level 1 values: In Testing(10214)

Parent values: Stage QA(10202)Level 1 values: Ready for Production(10217)

Sachin Hingole (Inactive) made changes - 26/Apr/18 03:14 AM

Resolution		Done [ 10000 ]
Status	Stage Testing [ 10201 ]	Resolution Setting [ 11616 ]

Transition	Time In Source Status	Execution Times

Vishal Yadav (Inactive) made transition - 12/Dec/17 04:20 AM

Open

In Development

17h 54m

Sanjana Jadhav (Inactive) made transition - 21/Dec/17 04:17 AM

In Development

In LB Testing

8d 23h 57m

Rashmita Dudhe (Inactive) made transition - 28/Dec/17 08:27 AM

In LB Testing

Stage Testing

7d 4h 10m

Sachin Hingole (Inactive) made transition - 26/Apr/18 03:14 AM

Stage Testing

Resolution Setting

118d 17h 46m

People

Assignee:: Rashmita Dudhe (Inactive)

Reporter:: Vishal Yadav (Inactive)

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Dates

Created:: 11/Dec/17 10:25 AM

Updated:: 26/Apr/18 03:14 AM

Resolved:: 26/Apr/18 03:14 AM

Time Tracking

Estimated:

Remaining:

Logged:

5.5h