Uploaded image for project: 'New Features 2017'
  1. New Features 2017
  2. NF-5639

NF:- Invoice Management not loading once we edit an generated invoice and click on Generate Invoice tab

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Medium
    • Resolution: Bug Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: UI Refresh
    • Labels:
      None
    • Environment:
      Others
    • Bug Type:
      Functional
    • Bug Severity:
      Medium
    • Level:
      Partner
    • Module:
      BenAdmin - Report
    • Reported by:
      Harbinger
    • Company:
      All Clients/Multiple Clients
    • Item State:
      Stage QA - Production Deployment on Hold
    • Browser:
      Google Chrome

      Description

      Site - Codemap
      Steps:-
      1] Log onto Codmap site
      2] Search and select For QA-CHMC-Azure company
      3] Click on Invoice Management option from Reports menu in BenAdmin curtain
      4] Edit any invoice template which has generated invoices
      5] Now edit any generated invoice and try going back to generate invoice page

      Actual Result:
      System is just showing the loader loading but does not load the page

      Expected Result:-
      System should load the page without taking a lot of time.

        Attachments

          Issue Links

            Activity

            venkatesh.pujari Venkatesh Pujari (Inactive) created issue -
            venkatesh.pujari Venkatesh Pujari (Inactive) made changes -
            Field Original Value New Value
            Link This issue relates to NF-5537 [ NF-5537 ]
            Hide
            nidhi.kaul Nidhi Kaul (Inactive) added a comment -

            Venkatesh Pujari
            Is this issue introduced because of NF 5537?

            Nidhi.

            Show
            nidhi.kaul Nidhi Kaul (Inactive) added a comment - Venkatesh Pujari Is this issue introduced because of NF 5537? Nidhi.
            Hide
            venkatesh.pujari Venkatesh Pujari (Inactive) added a comment -

            Hi Nidhi Kaul,

            The issue is not introduced because of NF 5537. But logged while testing NF 5537.

            Thanks,
            Venkatesh

            Show
            venkatesh.pujari Venkatesh Pujari (Inactive) added a comment - Hi Nidhi Kaul , The issue is not introduced because of NF 5537. But logged while testing NF 5537. Thanks, Venkatesh
            Hide
            diana Diana Wong (Inactive) added a comment -

            I was able to reproduce the error in Preprod. Two things that team might want to note are

            • If I close the browser and log in again, it appear that the invoice was generated.
            • If I leave it running long enough, the invoice does get generated.
            Show
            diana Diana Wong (Inactive) added a comment - I was able to reproduce the error in Preprod. Two things that team might want to note are If I close the browser and log in again, it appear that the invoice was generated. If I leave it running long enough, the invoice does get generated.
            parmeshwar.jumbad Parmeshwar Jumbad (Inactive) made changes -
            Dev Due Date 11/Jan/2018
            nidhi.kaul Nidhi Kaul (Inactive) made changes -
            Status Open [ 1 ] In Development [ 10007 ]
            nidhi.kaul Nidhi Kaul (Inactive) made changes -
            Item State Parent values: Development(10200)Level 1 values: In Analysis(10204)
            parmeshwar.jumbad Parmeshwar Jumbad (Inactive) made changes -
            Item State Parent values: Development(10200)Level 1 values: In Analysis(10204) Parent values: Development(10200)Level 1 values: In Progress(10206)
            parmeshwar.jumbad Parmeshwar Jumbad (Inactive) made changes -
            Dev Due Date 11/Jan/2018 10/Jan/2018
            parmeshwar.jumbad Parmeshwar Jumbad (Inactive) logged work - 09/Jan/18 12:19 PM
            • Time Spent:
              4h
               

              Issue analysis
              Code changes and unit testing
              Internal discussion with QA
              Review request

            parmeshwar.jumbad Parmeshwar Jumbad (Inactive) made changes -
            Item State Parent values: Development(10200)Level 1 values: In Progress(10206) Parent values: Development(10200)Level 1 values: Ready for Review(10208)
            parmeshwar.jumbad Parmeshwar Jumbad (Inactive) made changes -
            Remaining Estimate 0h [ 0 ]
            Time Spent 4h [ 14400 ]
            Worklog Id 99772 [ 99772 ]
            parmeshwar.jumbad Parmeshwar Jumbad (Inactive) made changes -
            Assignee Parmeshwar Jumbad [ parmeshwar.jumbade ] Prasanna Karlekar [ prasanna ]
            Hide
            parmeshwar.jumbad Parmeshwar Jumbad (Inactive) added a comment -

            Below are the 3C's:

            Concern: Invoice Management not loading once we edit an generated invoice and click on Generate Invoice tab.
            Cause: After click on generate invoice one flag i.e. 'ResetloaderOnTimeOut' getting set to 0. This flag is responsible to hide loader after ajax call. But when this flag set to 0 it means there is no logic to hide normal loader on ajax stop event. Due to this on click on generate & view invoice loader was appeared.
            Correction: Now we have reset flag in the response of generate invoice. Due to this change ajax stop function will stop ajax loader and normal loader will get hide using this flag settings.
            Affected Areas: Generate and View Invoice
            Affected Files: ViewInvoicePV.cshtml
            Tested Scenarios:
            1. Verified loader in case of Add and Edit template
            2. Verified loader with different scenarios (i.e. Without click on Generate Invoice, After click on Generate invoice/Edit invoice/Finalize invoice, etc.)

            Known issue: While click on Generate & view Invoice tab it takes 10 second to stop loader after ajax call starts. But this is generic change related to ajax call start and stop due to this have not done any changes in it.

            CC: Prasanna Karlekar Gaurav Sodani

            Show
            parmeshwar.jumbad Parmeshwar Jumbad (Inactive) added a comment - Below are the 3C's : Concern : Invoice Management not loading once we edit an generated invoice and click on Generate Invoice tab. Cause : After click on generate invoice one flag i.e. 'ResetloaderOnTimeOut' getting set to 0. This flag is responsible to hide loader after ajax call. But when this flag set to 0 it means there is no logic to hide normal loader on ajax stop event. Due to this on click on generate & view invoice loader was appeared. Correction : Now we have reset flag in the response of generate invoice. Due to this change ajax stop function will stop ajax loader and normal loader will get hide using this flag settings. Affected Areas : Generate and View Invoice Affected Files : ViewInvoicePV.cshtml Tested Scenarios : 1. Verified loader in case of Add and Edit template 2. Verified loader with different scenarios (i.e. Without click on Generate Invoice, After click on Generate invoice/Edit invoice/Finalize invoice, etc.) Known issue : While click on Generate & view Invoice tab it takes 10 second to stop loader after ajax call starts. But this is generic change related to ajax call start and stop due to this have not done any changes in it. CC: Prasanna Karlekar Gaurav Sodani
            prasanna Prasanna Karlekar (Inactive) made changes -
            Item State Parent values: Development(10200)Level 1 values: Ready for Review(10208) Parent values: Development(10200)Level 1 values: Ready for Local Testing(10209)
            prasanna Prasanna Karlekar (Inactive) made changes -
            Assignee Prasanna Karlekar [ prasanna ] Parmeshwar Jumbad [ parmeshwar.jumbade ]
            prasanna Prasanna Karlekar (Inactive) logged work - 10/Jan/18 08:30 PM
            • Time Spent:
              0.25h
               

              Code and functionality review

            parmeshwar.jumbad Parmeshwar Jumbad (Inactive) logged work - 11/Jan/18 04:02 AM
            • Time Spent:
              0.25h
               

              Discussion while code review
              JIRA update

            parmeshwar.jumbad Parmeshwar Jumbad (Inactive) made changes -
            Time Spent 4h [ 14400 ] 4.25h [ 15300 ]
            Worklog Id 99936 [ 99936 ]
            khandu.kshirsagar Khandu Kshirsagar (Inactive) made changes -
            Item State Parent values: Development(10200)Level 1 values: Ready for Local Testing(10209) Parent values: LB QA(10201)Level 1 values: LB Deployed(11600)
            prasanna Prasanna Karlekar (Inactive) made changes -
            Assignee Parmeshwar Jumbad [ parmeshwar.jumbade ] Sachin Hingole [ sachin.hingole ]
            prasanna Prasanna Karlekar (Inactive) made changes -
            Time Spent 4.25h [ 15300 ] 4.5h [ 16200 ]
            Worklog Id 99970 [ 99970 ]
            sachin.hingole Sachin Hingole (Inactive) made changes -
            Status In Development [ 10007 ] Local Testing [ 10200 ]
            sachin.hingole Sachin Hingole (Inactive) made changes -
            Item State Parent values: LB QA(10201)Level 1 values: LB Deployed(11600) Parent values: LB QA(10201)Level 1 values: In Testing(10210)
            sachin.hingole Sachin Hingole (Inactive) made changes -
            Assignee Sachin Hingole [ sachin.hingole ] Venkatesh Pujari [ venkatesh.pujari ]
            Hide
            venkatesh.pujari Venkatesh Pujari (Inactive) added a comment -

            Hi [~parmeshwar.jumbade],

            This is tested on Codemap. Now the system is loading properly once we edit an generated invoice and click on Generate Invoice tab. This is ready for Stage.

            Sachin Hingole

            Thanks,
            Venkatesh

            Show
            venkatesh.pujari Venkatesh Pujari (Inactive) added a comment - Hi [~parmeshwar.jumbade] , This is tested on Codemap. Now the system is loading properly once we edit an generated invoice and click on Generate Invoice tab. This is ready for Stage. Sachin Hingole Thanks, Venkatesh
            venkatesh.pujari Venkatesh Pujari (Inactive) logged work - 11/Jan/18 12:21 PM
            • Time Spent:
              0.5h
               

              Testing on Codemap

            venkatesh.pujari Venkatesh Pujari (Inactive) made changes -
            Item State Parent values: LB QA(10201)Level 1 values: In Testing(10210) Parent values: LB QA(10201)Level 1 values: Ready for Stage(10213)
            venkatesh.pujari Venkatesh Pujari (Inactive) made changes -
            Time Spent 4.5h [ 16200 ] 5h [ 18000 ]
            Worklog Id 100045 [ 100045 ]
            khandu.kshirsagar Khandu Kshirsagar (Inactive) made changes -
            Item State Parent values: LB QA(10201)Level 1 values: Ready for Stage(10213) Parent values: Stage QA(10202)Level 1 values: Stage Deployed(11602)
            sachin.hingole Sachin Hingole (Inactive) made changes -
            Status Local Testing [ 10200 ] Stage Testing [ 10201 ]
            sachin.hingole Sachin Hingole (Inactive) made changes -
            Item State Parent values: Stage QA(10202)Level 1 values: Stage Deployed(11602) Parent values: Stage QA(10202)Level 1 values: Production Deployment on Hold(10224)
            venkatesh.pujari Venkatesh Pujari (Inactive) made changes -
            Status Stage Testing [ 10201 ] Production Testing [ 10202 ]
            venkatesh.pujari Venkatesh Pujari (Inactive) logged work - 14/Mar/18 09:10 AM
            • Time Spent:
              10m
               
              <No comment>
            venkatesh.pujari Venkatesh Pujari (Inactive) made changes -
            Resolution Bug Fixed [ 10402 ]
            Status Production Testing [ 10202 ] Production Complete [ 10028 ]
            venkatesh.pujari Venkatesh Pujari (Inactive) made changes -
            Status Production Complete [ 10028 ] Closed [ 6 ]
            venkatesh.pujari Venkatesh Pujari (Inactive) made changes -
            Time Spent 5h [ 18000 ] 5h 10m [ 18600 ]
            Worklog Id 108220 [ 108220 ]
            Transition Time In Source Status Execution Times
            Nidhi Kaul (Inactive) made transition -
            Open In Development
            2d 6h 23m 1
            Sachin Hingole (Inactive) made transition -
            In Development In LB Testing
            5d 17h 42m 1
            Sachin Hingole (Inactive) made transition -
            In LB Testing Stage Testing
            1d 3h 47m 1
            Venkatesh Pujari (Inactive) made transition -
            Stage Testing In Production Testing
            60d 21h 35m 1
            Venkatesh Pujari (Inactive) made transition -
            In Production Testing Production Complete
            4m 12s 1
            Venkatesh Pujari (Inactive) made transition -
            Production Complete Closed
            3s 1

              People

              Assignee:
              venkatesh.pujari Venkatesh Pujari (Inactive)
              Reporter:
              venkatesh.pujari Venkatesh Pujari (Inactive)
              Developer:
              Parmeshwar Jumbad (Inactive)
              QA:
              Venkatesh Pujari (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Dev Due Date:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 5h 10m
                  5h 10m