Uploaded image for project: 'New Features 2017'
  1. New Features 2017
  2. NF-5813

Button to start self serve mode button should not be available when Allow Company Admin Workflow is no

    Details

    • Type: Bug
    • Status: Stage Testing
    • Priority: Medium
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: UI Refresh
    • Labels:
      None
    • Environment:
      Pre Production
    • Bug Type:
      Functional
    • Bug Severity:
      Medium
    • Level:
      Admin
    • Module:
      BenAdmin
    • Reported by:
      Harbinger
    • Company:
      All Clients/Multiple Clients
    • Item State:
      Stage QA - Production Deployment on Hold
    • Browser:
      IE 11, Google Chrome
    • UAT For:
      UI Refresh

      Description

      Admin is created with "Allow Company Admin Workflow = NO"

      Log is as admin to pre-prod (hsplbiorad/Password@1)
      select EE 222222222
      go to dashboard and observe the button

      Actual result - Should not show button to start self serve mode

        Attachments

          Issue Links

            Activity

            sachin.hingole Sachin Hingole (Inactive) created issue -
            komal.barde Komal Barde (Inactive) made changes -
            Field Original Value New Value
            Item State Parent values: Development(10200)Level 1 values: In Analysis(10204)
            komal.barde Komal Barde (Inactive) made changes -
            Status Open [ 1 ] In Development [ 10007 ]
            komal.barde Komal Barde (Inactive) made changes -
            Item State Parent values: Development(10200)Level 1 values: In Analysis(10204) Parent values: Development(10200)Level 1 values: In Progress(10206)
            komal.barde Komal Barde (Inactive) made changes -
            Item State Parent values: Development(10200)Level 1 values: In Progress(10206) Parent values: Development(10200)Level 1 values: Ready for Review(10208)
            komal.barde Komal Barde (Inactive) made changes -
            Remaining Estimate 20h [ 72000 ]
            Original Estimate 20h [ 72000 ]
            komal.barde Komal Barde (Inactive) logged work - 29/Jan/18 12:41 PM
            • Time Spent:
              7.5h
               
              • Issue debugging
              • Discussion with Swapnil
              • Issue fixing
              • Unit testing
            komal.barde Komal Barde (Inactive) made changes -
            Remaining Estimate 20h [ 72000 ] 12.5h [ 45000 ]
            Time Spent 7.5h [ 27000 ]
            Worklog Id 102289 [ 102289 ]
            Hide
            komal.barde Komal Barde (Inactive) added a comment -

            Concern :
            Button to start self serve mode button should not be available when Allow Company Admin Workflow is no

            Cause :
            The "Allow Company Admin Workflow" flag values are not checked on "Check election" notification.

            Correction :
            Added validation of "Allow Company Admin Workflow" flag on on "Check election" notification.

            Show
            komal.barde Komal Barde (Inactive) added a comment - Concern : Button to start self serve mode button should not be available when Allow Company Admin Workflow is no Cause : The "Allow Company Admin Workflow" flag values are not checked on "Check election" notification. Correction : Added validation of "Allow Company Admin Workflow" flag on on "Check election" notification.
            komal.barde Komal Barde (Inactive) made changes -
            Code Reviewed By Swapnil Pandhare [ 11900 ]
            komal.barde Komal Barde (Inactive) made changes -
            Item State Parent values: Development(10200)Level 1 values: Ready for Review(10208) Parent values: Development(10200)Level 1 values: Ready for Local Testing(10209)
            komal.barde Komal Barde (Inactive) made changes -
            Assignee Komal Barde [ komal.barde ] Sachin Hingole [ sachin.hingole ]
            Hide
            komal.barde Komal Barde (Inactive) added a comment -

            Hi Sachin Hingole,

            The changes related to this jira are committed on code branch.
            So assigning this jira to you.

            Thanks,
            Komal

            Show
            komal.barde Komal Barde (Inactive) added a comment - Hi Sachin Hingole , The changes related to this jira are committed on code branch. So assigning this jira to you. Thanks, Komal
            Hide
            komal.barde Komal Barde (Inactive) added a comment -

            List of modified files:

            • /branches/UiRefresh-LB/Web/SharedFunctionWebTier/SharedFunctionWebTier/Models/WTHomePage/OnBoard/TourProgressPVModel.cs
            • /branches/UiRefresh-LB/Web/SharedFunctionWebTier/SharedFunctionWebTier/Views/Common/Dashboard/Employee/_EmployeeNotificationsPV.cshtml
            • /branches/UiRefresh-LB/Web/SharedFunctionWebTier/SharedFunctionWebTier/Views/Common/Dashboard/Employee/_EmployeeNotificationsPV.generated.cs
            Show
            komal.barde Komal Barde (Inactive) added a comment - List of modified files : /branches/UiRefresh-LB/Web/SharedFunctionWebTier/SharedFunctionWebTier/Models/WTHomePage/OnBoard/TourProgressPVModel.cs /branches/UiRefresh-LB/Web/SharedFunctionWebTier/SharedFunctionWebTier/Views/Common/Dashboard/Employee/_EmployeeNotificationsPV.cshtml /branches/UiRefresh-LB/Web/SharedFunctionWebTier/SharedFunctionWebTier/Views/Common/Dashboard/Employee/_EmployeeNotificationsPV.generated.cs
            Hide
            komal.barde Komal Barde (Inactive) added a comment -

            Unit testing done:

            1) Allow Company Admin Workflow = No And Employee status= Incomplete
            Result: No workflow for admin login

            2) Allow Company Admin Workflow = No And Employee status= Complete And Mode is available
            Result: No workflow for admin login

            3) Allow Company Admin Workflow = No And Employee status= Complete And Mode is not available
            Result: No workflow for admin login

            4) Allow Company Admin Workflow = Yes And Employee status= Incomplete
            Result: admin will get workflow

            5) Allow Company Admin Workflow = Yes And Employee status= Complete And Mode is available
            Result: admin will get workflow

            6) Allow Company Admin Workflow = Yes And Employee status= Complete And Mode is not available
            Result: No workflow for admin login

            Show
            komal.barde Komal Barde (Inactive) added a comment - Unit testing done : 1) Allow Company Admin Workflow = No And Employee status= Incomplete Result: No workflow for admin login 2) Allow Company Admin Workflow = No And Employee status= Complete And Mode is available Result: No workflow for admin login 3) Allow Company Admin Workflow = No And Employee status= Complete And Mode is not available Result: No workflow for admin login 4) Allow Company Admin Workflow = Yes And Employee status= Incomplete Result: admin will get workflow 5) Allow Company Admin Workflow = Yes And Employee status= Complete And Mode is available Result: admin will get workflow 6) Allow Company Admin Workflow = Yes And Employee status= Complete And Mode is not available Result: No workflow for admin login
            khandu.kshirsagar Khandu Kshirsagar (Inactive) made changes -
            Item State Parent values: Development(10200)Level 1 values: Ready for Local Testing(10209) Parent values: LB QA(10201)Level 1 values: LB Deployed(11600)
            priya.dhamande Priya Dhamande (Inactive) made changes -
            Item State Parent values: LB QA(10201)Level 1 values: LB Deployed(11600) Parent values: LB QA(10201)Level 1 values: In Testing(10210)
            priya.dhamande Priya Dhamande (Inactive) made changes -
            Status In Development [ 10007 ] Local Testing [ 10200 ]
            sachin.hingole Sachin Hingole (Inactive) made changes -
            Assignee Sachin Hingole [ sachin.hingole ] Priya Dhamande [ priya.dhamande ]
            nidhi.kaul Nidhi Kaul (Inactive) made changes -
            Reported by Implementation (Workterra) [ 18439 ] Harbinger [ 10700 ]
            priya.dhamande Priya Dhamande (Inactive) made changes -
            Link This issue relates to NF-5486 [ NF-5486 ]
            priya.dhamande Priya Dhamande (Inactive) made changes -
            Link This issue relates to NF-5486 [ NF-5486 ]
            priya.dhamande Priya Dhamande (Inactive) made changes -
            Link This issue relates to NF-5846 [ NF-5846 ]
            priya.dhamande Priya Dhamande (Inactive) logged work - 31/Jan/18 10:23 AM
            • Time Spent:
              2h
               

              Codemap testing

            Hide
            priya.dhamande Priya Dhamande (Inactive) added a comment -

            Environment: Codemap
            Company: For QA Kindercare
            Login: Company Admin
            Scenarios covered:

            Sr. No Scenario Expected Result Actual Result
            1 Allow Company Admin Workflow = No And Employee status= Incomplete  No workflow for Admin login Pass
            2 Allow Company Admin Workflow = No And Employee status= Incomplete And Mode is available No workflow for Admin login Pass
            3 Allow Company Admin Workflow = No And Employee status= Complete And Mode is available No workflow for Admin login Pass
            4 Allow Company Admin Workflow = No And Employee status= Complete And Mode is not available No workflow for Admin login Pass
            5 Allow Company Admin Workflow = Yes And Employee status= Incomplete And Mode is not available No workflow for Admin login Pass
            6 Allow Company Admin Workflow = Yes And Employee status= Incomplete And Mode is available Admin will get workflow directly Pass
            7 Allow Company Admin Workflow = Yes And Employee status= Complete And Mode is available Admin will get Button on Home page and on clicking work flow will start Pass
            8 Allow Company Admin Workflow = Yes And Employee status= Complete And Mode is not available No workflow for Admin login Pass

            Sachin Hingole Hrishikesh Deshpande

            Show
            priya.dhamande Priya Dhamande (Inactive) added a comment - Environment: Codemap Company: For QA Kindercare Login: Company Admin Scenarios covered: Sr. No Scenario Expected Result Actual Result 1 Allow Company Admin Workflow = No And Employee status= Incomplete  No workflow for Admin login Pass 2 Allow Company Admin Workflow = No And Employee status= Incomplete And Mode is available No workflow for Admin login Pass 3 Allow Company Admin Workflow = No And Employee status= Complete And Mode is available No workflow for Admin login Pass 4 Allow Company Admin Workflow = No And Employee status= Complete And Mode is not available No workflow for Admin login Pass 5 Allow Company Admin Workflow = Yes And Employee status= Incomplete And Mode is not available No workflow for Admin login Pass 6 Allow Company Admin Workflow = Yes And Employee status= Incomplete And Mode is available Admin will get workflow directly Pass 7 Allow Company Admin Workflow = Yes And Employee status= Complete And Mode is available Admin will get Button on Home page and on clicking work flow will start Pass 8 Allow Company Admin Workflow = Yes And Employee status= Complete And Mode is not available No workflow for Admin login Pass Sachin Hingole Hrishikesh Deshpande
            priya.dhamande Priya Dhamande (Inactive) made changes -
            Item State Parent values: LB QA(10201)Level 1 values: In Testing(10210) Parent values: LB QA(10201)Level 1 values: Ready for Stage(10213)
            priya.dhamande Priya Dhamande (Inactive) made changes -
            Remaining Estimate 12.5h [ 45000 ] 10.5h [ 37800 ]
            Time Spent 7.5h [ 27000 ] 9.5h [ 34200 ]
            Worklog Id 102838 [ 102838 ]
            khandu.kshirsagar Khandu Kshirsagar (Inactive) made changes -
            Item State Parent values: LB QA(10201)Level 1 values: Ready for Stage(10213) Parent values: Stage QA(10202)Level 1 values: Stage Deployed(11602)
            sachin.hingole Sachin Hingole (Inactive) made changes -
            Status Local Testing [ 10200 ] Stage Testing [ 10201 ]
            priya.dhamande Priya Dhamande (Inactive) made changes -
            Item State Parent values: Stage QA(10202)Level 1 values: Stage Deployed(11602) Parent values: Stage QA(10202)Level 1 values: In Testing(10214)
            Hide
            priya.dhamande Priya Dhamande (Inactive) added a comment -

            Environment: PreProd
            Company: FDu for hspl
            Login: CA

            Sr. No Scenario Expected Result Actual Result
            1 Allow Company Admin Workflow = No And Mode is not available No workflow for Admin login Pass
            2 Allow Company Admin Workflow = No And Mode is available No workflow for Admin login Pass
            3 Allow Company Admin Workflow = Yes And Mode is not available No workflow for Admin login Pass
            4 Allow Company Admin Workflow = Yes And Mode is available Workflow for Admin Pass

            The issue is checked for mentioned scenarios and worked as expected. So, making jira Production deployment on Hold.

            Yamilka Coca, please verify and confirm the same.

            Sachin Hingole Hrishikesh Deshpande

            Show
            priya.dhamande Priya Dhamande (Inactive) added a comment - Environment: PreProd Company: FDu for hspl Login: CA Sr. No Scenario Expected Result Actual Result 1 Allow Company Admin Workflow = No And Mode is not available No workflow for Admin login Pass 2 Allow Company Admin Workflow = No And Mode is available No workflow for Admin login Pass 3 Allow Company Admin Workflow = Yes And Mode is not available No workflow for Admin login Pass 4 Allow Company Admin Workflow = Yes And Mode is available Workflow for Admin Pass The issue is checked for mentioned scenarios and worked as expected. So, making jira Production deployment on Hold. Yamilka Coca , please verify and confirm the same. Sachin Hingole Hrishikesh Deshpande
            priya.dhamande Priya Dhamande (Inactive) made changes -
            Item State Parent values: Stage QA(10202)Level 1 values: In Testing(10214) Parent values: Stage QA(10202)Level 1 values: Production Deployment on Hold(10224)
            priya.dhamande Priya Dhamande (Inactive) made changes -
            Assignee Priya Dhamande [ priya.dhamande ] Yamilka Coca [ yamilka.coca ]
            priya.dhamande Priya Dhamande (Inactive) made changes -
            Remaining Estimate 10.5h [ 37800 ] 9.75h [ 35100 ]
            Time Spent 9.5h [ 34200 ] 10.25h [ 36900 ]
            Worklog Id 103035 [ 103035 ]
            priya.dhamande Priya Dhamande (Inactive) logged work - 02/Feb/18 07:25 AM - edited
            • Time Spent:
              1h
               

              Preprod testing

            priya.dhamande Priya Dhamande (Inactive) made changes -
            Remaining Estimate 9.75h [ 35100 ] 9.5h [ 34200 ]
            Time Spent 10.25h [ 36900 ] 10.5h [ 37800 ]
            Worklog Id 103035 [ 103035 ]
            Hide
            Yamilka.Coca Yamilka Coca (Inactive) added a comment -

            This item is closed.

            Show
            Yamilka.Coca Yamilka Coca (Inactive) added a comment - This item is closed.
            Transition Time In Source Status Execution Times
            Komal Barde (Inactive) made transition -
            Open In Development
            1h 45m 1
            Priya Dhamande (Inactive) made transition -
            In Development In LB Testing
            1d 22h 54m 1
            Sachin Hingole (Inactive) made transition -
            In LB Testing Stage Testing
            23h 23m 1

              People

              Assignee:
              Yamilka.Coca Yamilka Coca (Inactive)
              Reporter:
              sachin.hingole Sachin Hingole (Inactive)
              Account Executive:
              Yamilka Coca (Inactive)
              Developer:
              Komal Barde (Inactive)
              QA:
              Venkatesh Pujari (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:

                  Time Tracking

                  Estimated:
                  Original Estimate - 20h
                  20h
                  Remaining:
                  Time Spent - 10.5h Remaining Estimate - 9.5h
                  9.5h
                  Logged:
                  Time Spent - 10.5h Remaining Estimate - 9.5h
                  10.5h