New Features 2017Project Type: software

New Features 2017

Uploaded image for project: 'New Features 2017'
  1. New Features 2017
  2. NF-5949

Clone company gives error message, when company name already exit for inactive company

    Details

    • Type: Bug
    • Status: Production Complete
    • Priority: Low
    • Resolution: Bug Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: UI Refresh
    • Labels:
      None
    • Environment:
      Pre Production
    • Bug Type:
      Functional
    • Bug Severity:
      Low
    • Level:
      Partner
    • Module:
      Platform
    • Reported by:
      Harbinger
    • Company:
      All Clients/Multiple Clients
    • Item State:
      Stage QA - Stage Deployed
    • Browser:
      IE 11, Google Chrome

      Description

      Log in as partner
      go to Clone a company
      select any company to clone
      put name (Make sure this name is already in use for inactive company)
      click on clone

      actual result - gives message "Company already exists"
      expected result - Should created company if company is inactive

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          Permalink
          komal.barde Komal Barde (Inactive) logged work - 21/Feb/18 09:21 AM - edited
          • Time Spent:
            1.5h
             

            Verify company clone flow
            Discussion with Sachin and Swapnil

          sachin.hingole Sachin Hingole (Inactive) created issue -
          komal.barde Komal Barde (Inactive) made changes -
          Field Original Value New Value
          Status Open [ 1 ] In Development [ 10007 ]
          komal.barde Komal Barde (Inactive) made changes -
          Item State Parent values: Development(10200)Level 1 values: In Analysis(10204)
          Permalink
          komal.barde Komal Barde (Inactive) logged work - 22/Feb/18 09:21 AM
          • Time Spent:
            7.5h
             

            Issue debugging and fixing
            Unit testing

          komal.barde Komal Barde (Inactive) made changes -
          Remaining Estimate 50h [ 180000 ]
          Original Estimate 50h [ 180000 ]
          komal.barde Komal Barde (Inactive) made changes -
          Remaining Estimate 50h [ 180000 ] 48.5h [ 174600 ]
          Time Spent 1.5h [ 5400 ]
          Worklog Id 105581 [ 105581 ]
          komal.barde Komal Barde (Inactive) made changes -
          Remaining Estimate 48.5h [ 174600 ] 41h [ 147600 ]
          Time Spent 1.5h [ 5400 ] 9h [ 32400 ]
          Worklog Id 105583 [ 105583 ]
          komal.barde Komal Barde (Inactive) made changes -
          Worklog Id 105581 [ 105581 ]
          komal.barde Komal Barde (Inactive) made changes -
          Item State Parent values: Development(10200)Level 1 values: In Analysis(10204) Parent values: Development(10200)Level 1 values: Ready for Review(10208)
          komal.barde Komal Barde (Inactive) made changes -
          Code Reviewed By Vijayendra Shinde [ 11901 ]
          Hide
          Permalink
          komal.barde Komal Barde (Inactive) added a comment -

          List of modified files:

          • /branches/UiRefresh-LB/App/BusinessLogic/Company/Company.vb
          • /branches/UiRefresh-LB/Database Objects/OnlineEnrollment/04_Stored Procedures/dbo.OES_SP_CloneCompany.StoredProcedure.sql
          • /branches/UiRefresh-LB/Web/Web Projects/WORKTERRA/Areas/Configuration/Models/CompanyInformation/CloneCompanyModel.cs
          Show
          komal.barde Komal Barde (Inactive) added a comment - List of modified files : /branches/UiRefresh-LB/App/BusinessLogic/Company/Company.vb /branches/UiRefresh-LB/Database Objects/OnlineEnrollment/04_Stored Procedures/dbo.OES_SP_CloneCompany.StoredProcedure.sql /branches/UiRefresh-LB/Web/Web Projects/WORKTERRA/Areas/Configuration/Models/CompanyInformation/CloneCompanyModel.cs
          komal.barde Komal Barde (Inactive) made changes -
          Item State Parent values: Development(10200)Level 1 values: Ready for Review(10208) Parent values: Development(10200)Level 1 values: Ready for Local Testing(10209)
          Hide
          Permalink
          komal.barde Komal Barde (Inactive) added a comment -

          Hi Sachin Hingole,

          The changes related to this jira are committed on code branch and it will get deployed in next build.
          So assigning this jira to you.

          Thanks,
          Komal

          Show
          komal.barde Komal Barde (Inactive) added a comment - Hi Sachin Hingole , The changes related to this jira are committed on code branch and it will get deployed in next build. So assigning this jira to you. Thanks, Komal
          komal.barde Komal Barde (Inactive) made changes -
          Assignee Komal Barde [ komal.barde ] Sachin Hingole [ sachin.hingole ]
          Hide
          Permalink
          komal.barde Komal Barde (Inactive) added a comment -

          3C's

          Concern:- Clone company gives error message, when company name already exit for inactive company

          Cause :- Clone company was checking for inactive companies.

          Correction :- Removed inactive company flag check while clone company.

          Show
          komal.barde Komal Barde (Inactive) added a comment - 3C's Concern :- Clone company gives error message, when company name already exit for inactive company Cause :- Clone company was checking for inactive companies. Correction :- Removed inactive company flag check while clone company.
          komal.barde Komal Barde (Inactive) made changes -
          Attachment unit testing.png [ 73730 ]
          Hide
          Permalink
          komal.barde Komal Barde (Inactive) added a comment -

          Unit testing done:

          Show
          komal.barde Komal Barde (Inactive) added a comment - Unit testing done :
          khandu.kshirsagar Khandu Kshirsagar (Inactive) made changes -
          Item State Parent values: Development(10200)Level 1 values: Ready for Local Testing(10209) Parent values: LB QA(10201)Level 1 values: LB Deployed(11600)
          sachin.hingole Sachin Hingole (Inactive) made changes -
          Status In Development [ 10007 ] Local Testing [ 10200 ]
          sachin.hingole Sachin Hingole (Inactive) made changes -
          Item State Parent values: LB QA(10201)Level 1 values: LB Deployed(11600) Parent values: LB QA(10201)Level 1 values: In Testing(10210)
          sachin.hingole Sachin Hingole (Inactive) made changes -
          Item State Parent values: LB QA(10201)Level 1 values: In Testing(10210) Parent values: LB QA(10201)Level 1 values: Ready for Stage(10213)
          Hide
          Permalink
          sachin.hingole Sachin Hingole (Inactive) added a comment -

          Verified on CODEMAP using IE and chrome for SA and partner login.
          We are able to clone company (With and without data) for company exists but is inactive also able to create company which does not exist in system.

          Show
          sachin.hingole Sachin Hingole (Inactive) added a comment - Verified on CODEMAP using IE and chrome for SA and partner login. We are able to clone company (With and without data) for company exists but is inactive also able to create company which does not exist in system.
          Permalink
          komal.barde Komal Barde (Inactive) logged work - 23/Feb/18 05:20 PM
          • Time Spent:
            0.5h
             

            Discussion with Sachin and Ashwin about clone compnay

          komal.barde Komal Barde (Inactive) made changes -
          Remaining Estimate 41h [ 147600 ] 40.5h [ 145800 ]
          Time Spent 9h [ 32400 ] 9.5h [ 34200 ]
          Worklog Id 106151 [ 106151 ]
          khandu.kshirsagar Khandu Kshirsagar (Inactive) made changes -
          Item State Parent values: LB QA(10201)Level 1 values: Ready for Stage(10213) Parent values: Stage QA(10202)Level 1 values: Stage Deployed(11602)
          sachin.hingole Sachin Hingole (Inactive) made changes -
          Status Local Testing [ 10200 ] Stage Testing [ 10201 ]
          sachin.hingole Sachin Hingole (Inactive) made changes -
          Status Stage Testing [ 10201 ] Production Testing [ 10202 ]
          sachin.hingole Sachin Hingole (Inactive) made changes -
          Resolution Bug Fixed [ 10402 ]
          Status Production Testing [ 10202 ] Production Complete [ 10028 ]
          Transition Time In Source Status Execution Times
          Komal Barde (Inactive) made transition -
          Open In Development
          		3m 11s 1
          Sachin Hingole (Inactive) made transition -
          In Development In LB Testing
          		1d 3h 2m 1
          Sachin Hingole (Inactive) made transition -
          In LB Testing Stage Testing
          		4d 13m 1
          Sachin Hingole (Inactive) made transition -
          Stage Testing In Production Testing
          		23d 20h 40m 1
          Sachin Hingole (Inactive) made transition -
          In Production Testing Production Complete
          		1m 54s 1

            People

            Assignee:
            sachin.hingole Sachin Hingole (Inactive)
            Reporter:
            sachin.hingole Sachin Hingole (Inactive)
            Developer:
            Komal Barde (Inactive)
            QA:
            Mahendra Mungase (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 50h
                50h
                Remaining:
                Time Spent - 9.5h Remaining Estimate - 40.5h
                40.5h
                Logged:
                Time Spent - 9.5h Remaining Estimate - 40.5h
                9.5h