New Features 2017Project Type: software

New Features 2017

Uploaded image for project: 'New Features 2017'
  1. New Features 2017
  2. NF-738

TSR Integration -> Check for BenAdmin Module Mapping and bypass APICall Flag

    Details

    • Type: Change Request
    • Status: Closed
    • Priority: Medium
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Integrations
    • Labels:
      None
    • Module:
      TSR
    • Reported by:
      Harbinger
    • Item State:
      Production Complete - Closed
    • Issue Importance:
      Good To Have
    • Sprint:
      TSR OnBoard - 28 Mar - 12 May
    • Severity:
      Simple

      Description

      Check for BenAdmin Module Mapping and bypass APICall Flag
      Currently,when employee is added through API,plan allocation routines are not fired.

      Change the implementation to accommodate that if company has BenAdmin mapped,then routines will be executed.

      CC: Saurabh Sablaka

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          Permalink
          ramya.tantry Ramya Tantry (Inactive) logged work - 29/Mar/17 06:09 PM
          • Time Spent:
            2h
             

            Changes to check benadmin module mapped
            Unit testing

          ramya.tantry Ramya Tantry (Inactive) created issue -
          ramya.tantry Ramya Tantry (Inactive) made changes -
          Field Original Value New Value
          Remaining Estimate 8h [ 28800 ] 6h [ 21600 ]
          Time Spent 2h [ 7200 ]
          Worklog Id 34559 [ 34559 ]
          saurabh.sablaka Saurabh Sablaka (Inactive) made changes -
          Component/s Integrations [ 10907 ]
          Component/s TSR [ 11001 ]
          Issue Importance Good To Have [ 11802 ]
          Item State Parent values: Development(10200)Level 1 values: Ready for Review(10208)
          saurabh.sablaka Saurabh Sablaka (Inactive) made changes -
          Status New Request [ 10029 ] Pending for Approval [ 10002 ]
          saurabh.sablaka Saurabh Sablaka (Inactive) made changes -
          Status Pending for Approval [ 10002 ] Approved for Development [ 10003 ]
          saurabh.sablaka Saurabh Sablaka (Inactive) made changes -
          Status Approved for Development [ 10003 ] In Development [ 10007 ]
          saurabh.sablaka Saurabh Sablaka (Inactive) made changes -
          Status In Development [ 10007 ] Local Testing [ 10200 ]
          Permalink
          ramya.tantry Ramya Tantry (Inactive) logged work - 13/Apr/17 03:47 PM
          • Time Spent:
            20m
             

            Code review files creation

          ramya.tantry Ramya Tantry (Inactive) made changes -
          Remaining Estimate 6h [ 21600 ] 5h 40m [ 20400 ]
          Time Spent 2h [ 7200 ] 2h 20m [ 8400 ]
          Worklog Id 38077 [ 38077 ]
          ramya.tantry Ramya Tantry (Inactive) made changes -
          Code Review Date 14/Apr/2017
          Code Reviewed By Saurabh Sablaka [ 11909 ]
          Item State Parent values: Development(10200)Level 1 values: Ready for Review(10208) Parent values: Development(10200)Level 1 values: Ready for Local Testing(10209)
          Hide
          Permalink
          ramya.tantry Ramya Tantry (Inactive) added a comment -

          Files Affected:

          /App/BusinessLogic/Employee/EmployeeData.vb

          Show
          ramya.tantry Ramya Tantry (Inactive) added a comment - Files Affected: /App/BusinessLogic/Employee/EmployeeData.vb
          Permalink
          ramya.tantry Ramya Tantry (Inactive) logged work - 14/Apr/17 10:02 AM
          • Time Spent:
            1.5h
             

            Code review changes
            Testing
            Checkins to LB,Local and UI refresh

          ramya.tantry Ramya Tantry (Inactive) made changes -
          Remaining Estimate 5h 40m [ 20400 ] 4h 10m [ 15000 ]
          Time Spent 2h 20m [ 8400 ] 3h 50m [ 13800 ]
          Worklog Id 38283 [ 38283 ]
          khandu.kshirsagar Khandu Kshirsagar (Inactive) made changes -
          Item State Parent values: Development(10200)Level 1 values: Ready for Local Testing(10209) Parent values: LB QA(10201)Level 1 values: LB Deployed(11600)
          Hide
          Permalink
          ramya.tantry Ramya Tantry (Inactive) added a comment -

          Hi Prasad Pise,

          Please verify this enhancement.
          Scenario:
          If BenAdmin is mapped then ,plan allocation routines should get fired for employees added through API else not.

          Show
          ramya.tantry Ramya Tantry (Inactive) added a comment - Hi Prasad Pise , Please verify this enhancement. Scenario: If BenAdmin is mapped then ,plan allocation routines should get fired for employees added through API else not.
          ramya.tantry Ramya Tantry (Inactive) made changes -
          Assignee Ramya Tantry [ ramya.tantry ] Prasad Pise [ prasadp ]
          prasadp Prasad Pise (Inactive) made changes -
          Assignee Prasad Pise [ prasadp ] Kunal Kedari [ kunal.kedari ]
          Permalink
          kunal.kedari Kunal Kedari (Inactive) logged work - 15/Apr/17 04:50 AM
          • Time Spent:
            2h
             

            Discussion, Analysis and testing on Local (wt-stage) environment

          Permalink
          kunal.kedari Kunal Kedari (Inactive) logged work - 18/Apr/17 08:33 AM
          • Time Spent:
            1h
             

            Testing on Local after rollback

          Hide
          Permalink
          ramya.tantry Ramya Tantry (Inactive) added a comment - - edited

          Hi Kunal Kedari,

          As per our discussion,we will be reverting this enhancement as allowing plan allocation routines to get fired for employees added through API results in error in cases where age eligibility is added.
          This issue is because we are not passing DOB of EE added through API to the system.So while calculating age,it throws error.
          I have reverted my changes and checked in LB.Please verify normal flow of EE after patch deployment.

          CC: Prasad Pise,Saurabh Sablaka

          Show
          ramya.tantry Ramya Tantry (Inactive) added a comment - - edited Hi Kunal Kedari , As per our discussion,we will be reverting this enhancement as allowing plan allocation routines to get fired for employees added through API results in error in cases where age eligibility is added. This issue is because we are not passing DOB of EE added through API to the system.So while calculating age,it throws error. I have reverted my changes and checked in LB.Please verify normal flow of EE after patch deployment. CC: Prasad Pise , Saurabh Sablaka
          ramya.tantry Ramya Tantry (Inactive) made changes -
          Assignee Kunal Kedari [ kunal.kedari ] Ramya Tantry [ ramya.tantry ]
          ramya.tantry Ramya Tantry (Inactive) made changes -
          Item State Parent values: LB QA(10201)Level 1 values: LB Deployed(11600) Parent values: Development(10200)Level 1 values: Ready for Local Testing(10209)
          Permalink
          ramya.tantry Ramya Tantry (Inactive) logged work - 19/Apr/17 09:54 AM
          • Time Spent:
            2h
             

            Discussion with Kunal and Saurabh.
            Reverting changes
            Testing
            Checkins to LB,Local and UI refresh

          ramya.tantry Ramya Tantry (Inactive) made changes -
          Remaining Estimate 4h 10m [ 15000 ] 2h 10m [ 7800 ]
          Time Spent 3h 50m [ 13800 ] 5h 50m [ 21000 ]
          Worklog Id 39275 [ 39275 ]
          khandu.kshirsagar Khandu Kshirsagar (Inactive) made changes -
          Item State Parent values: Development(10200)Level 1 values: Ready for Local Testing(10209) Parent values: LB QA(10201)Level 1 values: LB Deployed(11600)
          ramya.tantry Ramya Tantry (Inactive) made changes -
          Assignee Ramya Tantry [ ramya.tantry ] Kunal Kedari [ kunal.kedari ]
          shyam.sharma shyam sharma (Inactive) made changes -
          Sprint TSR OnBoard - 28 Mar - 30 Apr [ 60 ]
          shyam.sharma shyam sharma (Inactive) made changes -
          Rank Ranked higher
          kunal.kedari Kunal Kedari (Inactive) made changes -
          Remaining Estimate 2h 10m [ 7800 ] 10m [ 600 ]
          Time Spent 5h 50m [ 21000 ] 7h 50m [ 28200 ]
          Worklog Id 39521 [ 39521 ]
          Hide
          Permalink
          kunal.kedari Kunal Kedari (Inactive) added a comment -

          Added QA estimations to original

          Show
          kunal.kedari Kunal Kedari (Inactive) added a comment - Added QA estimations to original
          kunal.kedari Kunal Kedari (Inactive) made changes -
          Original Estimate 8h [ 28800 ] 12h [ 43200 ]
          kunal.kedari Kunal Kedari (Inactive) made changes -
          Item State Parent values: LB QA(10201)Level 1 values: LB Deployed(11600) Parent values: LB QA(10201)Level 1 values: In Testing(10210)
          kunal.kedari Kunal Kedari (Inactive) made changes -
          Remaining Estimate 10m [ 600 ] 0h [ 0 ]
          Time Spent 7h 50m [ 28200 ] 8h 50m [ 31800 ]
          Worklog Id 39911 [ 39911 ]
          Hide
          Permalink
          kunal.kedari Kunal Kedari (Inactive) added a comment -

          We are not implementing this change and roll back it from Local Environment. Closing the ticket.

          Cc: Saurabh Sablaka, Prasad Pise

          Show
          kunal.kedari Kunal Kedari (Inactive) added a comment - We are not implementing this change and roll back it from Local Environment. Closing the ticket. Cc: Saurabh Sablaka , Prasad Pise
          kunal.kedari Kunal Kedari (Inactive) made changes -
          Item State Parent values: LB QA(10201)Level 1 values: In Testing(10210) Parent values: Production Complete(10222)Level 1 values: Closed(10223)
          kunal.kedari Kunal Kedari (Inactive) made changes -
          Status Local Testing [ 10200 ] Pending for Stage Approval [ 10300 ]
          kunal.kedari Kunal Kedari (Inactive) made changes -
          Status Pending for Stage Approval [ 10300 ] Approved for Stage [ 10030 ]
          kunal.kedari Kunal Kedari (Inactive) made changes -
          Status Approved for Stage [ 10030 ] Stage Testing [ 10201 ]
          kunal.kedari Kunal Kedari (Inactive) made changes -
          Status Stage Testing [ 10201 ] Pending for Production Approval [ 10301 ]
          kunal.kedari Kunal Kedari (Inactive) made changes -
          Status Pending for Production Approval [ 10301 ] Approved for production [ 10034 ]
          kunal.kedari Kunal Kedari (Inactive) made changes -
          Status Approved for production [ 10034 ] Production Testing [ 10202 ]
          kunal.kedari Kunal Kedari (Inactive) made changes -
          Resolution Won't Do [ 10001 ]
          Status Production Testing [ 10202 ] Production Complete [ 10028 ]
          kunal.kedari Kunal Kedari (Inactive) made changes -
          Resolution Won't Do [ 10001 ] Fixed [ 1 ]
          Status Production Complete [ 10028 ] Closed [ 6 ]
          Transition Time In Source Status Execution Times
          Saurabh Sablaka (Inactive) made transition -
          New Request Pending for Approval
          		5h 14m 1
          Saurabh Sablaka (Inactive) made transition -
          Pending for Approval Approved for Development
          		2s 1
          Saurabh Sablaka (Inactive) made transition -
          Approved for Development In Development
          		1s 1
          Saurabh Sablaka (Inactive) made transition -
          In Development In LB Testing
          		2s 1
          Kunal Kedari (Inactive) made transition -
          In LB Testing Pending for Stage Approval
          		28d 23h 40m 1
          Kunal Kedari (Inactive) made transition -
          Pending for Stage Approval Approved for Stage
          		3s 1
          Kunal Kedari (Inactive) made transition -
          Approved for Stage Stage Testing
          		2s 1
          Kunal Kedari (Inactive) made transition -
          Stage Testing Pending for Production Approval
          		6s 1
          Kunal Kedari (Inactive) made transition -
          Pending for Production Approval Approved for production
          		4s 1
          Kunal Kedari (Inactive) made transition -
          Approved for production In Production Testing
          		4s 1
          Kunal Kedari (Inactive) made transition -
          In Production Testing Production Complete
          		20s 1
          Kunal Kedari (Inactive) made transition -
          Production Complete Closed
          		7s 1

            People

            Assignee:
            kunal.kedari Kunal Kedari (Inactive)
            Reporter:
            ramya.tantry Ramya Tantry (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Code Review Date:

                Time Tracking

                Estimated:
                Original Estimate - 12h
                12h
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 8h 50m Time Not Required
                8h 50m