New Features 2017Project Type: software

New Features 2017

Uploaded image for project: 'New Features 2017'
  1. New Features 2017
  2. NF-780

TSR Integration->Issues for OB tour reports.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: High
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Integrations
    • Labels:
      None
    • Module:
      TSR
    • Reported by:
      Harbinger
    • Item State:
      Production Complete - Closed
    • Issue Importance:
      Q1

      Description

      1] Add employee through API on Stage environment.
      2] Start traversing assigned tour.
      3] Login as a partner and try to view different tour reports from Onboarding module.

      Issues -
      1] Tour Status Report -> Data is not getting loaded.
      2] Tour Step Completion Rate Report -> Completion time is displaying as 0 sec.
      3] Incomplete Tour Report-> "No Records Found" message displaying.

      Cc: Prasad Pise

        Attachments

          Issue Links

          relates to

          Enhancement - An improvement or enhancement to an existing feature or task. NF-408 TSR : Consider new eligibility criteria for all reports in WT

          • High - Serious problem that could block progress.
          • Closed

            Activity

            Ascending order - Click to sort in descending order
            kunal.kedari Kunal Kedari (Inactive) created issue -
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Field Original Value New Value
            Link This issue relates to NF-408 [ NF-408 ]
            ramya.tantry Ramya Tantry (Inactive) made changes -
            Assignee Saurabh Sablaka [ saurabh.sablaka ] Ramya Tantry [ ramya.tantry ]
            Developer Ramya Tantry [ ramya.tantry ]
            Item State Parent values: Development(10200)Level 1 values: In Progress(10206)
            Remaining Estimate 12h [ 43200 ]
            Original Estimate 12h [ 43200 ]
            ramya.tantry Ramya Tantry (Inactive) made changes -
            Status Open [ 1 ] In Development [ 10007 ]
            Permalink
            ramya.tantry Ramya Tantry (Inactive) logged work - 12/May/17 01:08 PM
            • Time Spent:
              6.25h
               

              New Company setup on local for API testing
              Discussion with Saurabh
              Issue debugging and analysis and issue fixing

            ramya.tantry Ramya Tantry (Inactive) made changes -
            Remaining Estimate 12h [ 43200 ] 5.75h [ 20700 ]
            Time Spent 6.25h [ 22500 ]
            Worklog Id 45277 [ 45277 ]
            Permalink
            saurabh.sablaka Saurabh Sablaka (Inactive) logged work - 15/May/17 07:22 AM
            • Time Spent:
              0.25h
               

              Code review

            saurabh.sablaka Saurabh Sablaka (Inactive) made changes -
            Remaining Estimate 5.75h [ 20700 ] 5.5h [ 19800 ]
            Time Spent 6.25h [ 22500 ] 6.5h [ 23400 ]
            Worklog Id 45576 [ 45576 ]
            Hide
            Permalink
            ramya.tantry Ramya Tantry (Inactive) added a comment -

            Files Affected:

            1. Database Objects/MasterCompanyDB/04_Stored Procedures/ob.OES_SP_GetTourChart_Details.StoredProcedure.sql
            2. Web/Web Projects/OnBoard/Areas/Customization/Views/Customization/Reports/Reports.cshtml
            Show
            ramya.tantry Ramya Tantry (Inactive) added a comment - Files Affected: Database Objects/MasterCompanyDB/04_Stored Procedures/ob.OES_SP_GetTourChart_Details.StoredProcedure.sql Web/Web Projects/OnBoard/Areas/Customization/Views/Customization/Reports/Reports.cshtml
            ramya.tantry Ramya Tantry (Inactive) made changes -
            Comment [ *Files Affected:*

            # Database Objects/MasterCompanyDB/04_Stored Procedures/ob.OES_SP_GetTourChart_Details.StoredProcedure.sql
            # Web/Web Projects/OnBoard/Areas/Customization/Views/Customization/Reports/Reports.cshtml
            ]
            Hide
            Permalink
            ramya.tantry Ramya Tantry (Inactive) added a comment - - edited

            Concern:Issues for OB tour reports.
            Cause:
            1] Tour Status Report -> Data is not getting loaded.
            – Employee's added through API do not have classes until classes are assigned. Tour Status chart uses the eligibility rule to process the employees. As these Employees do not satisfy the rule due to lack of classes,they do not show up on the report.
            2] Tour Step Completion Rate Report -> Completion time is displaying as 0 sec.
            – Instead of selected value ,selected Index of drop down is used as tour id. Due to this, tour id was getting mismatched with the data in the system,hence it always returned 0 sec.
            Correction :
            1] We have added code to consider Employees added through API in tour chart
            2] We are now considering selected value of drop down as tour id.

            Show
            ramya.tantry Ramya Tantry (Inactive) added a comment - - edited Concern :Issues for OB tour reports. Cause: 1] Tour Status Report -> Data is not getting loaded. – Employee's added through API do not have classes until classes are assigned. Tour Status chart uses the eligibility rule to process the employees. As these Employees do not satisfy the rule due to lack of classes,they do not show up on the report. 2] Tour Step Completion Rate Report -> Completion time is displaying as 0 sec. – Instead of selected value ,selected Index of drop down is used as tour id. Due to this, tour id was getting mismatched with the data in the system,hence it always returned 0 sec. Correction : 1] We have added code to consider Employees added through API in tour chart 2] We are now considering selected value of drop down as tour id.
            Hide
            Permalink
            ramya.tantry Ramya Tantry (Inactive) added a comment - - edited

            Point 3 is non repro.
            Scenario tried:
            1. Created a tour with window period as 1 day
            2. Assigned this tour to an employee added through API whose employment date is 4/20/2017.
            3. Verified the Incomplete tour Report. This employee's record came up on report with tour status as Not started.

            Show
            ramya.tantry Ramya Tantry (Inactive) added a comment - - edited Point 3 is non repro. Scenario tried: 1. Created a tour with window period as 1 day 2. Assigned this tour to an employee added through API whose employment date is 4/20/2017. 3. Verified the Incomplete tour Report. This employee's record came up on report with tour status as Not started.
            Permalink
            ramya.tantry Ramya Tantry (Inactive) logged work - 15/May/17 07:39 AM
            • Time Spent:
              3.5h
               

              Code fix
              Unit Testing
              Code review
              Code checkin to local,LB,UI refresh branch
              3C's updation.

            ramya.tantry Ramya Tantry (Inactive) made changes -
            Remaining Estimate 5.5h [ 19800 ] 2h [ 7200 ]
            Time Spent 6.5h [ 23400 ] 10h [ 36000 ]
            Worklog Id 45579 [ 45579 ]
            ramya.tantry Ramya Tantry (Inactive) made changes -
            Code Review Date 15/May/2017
            Code Reviewed By Saurabh Sablaka [ 11909 ]
            Item State Parent values: Development(10200)Level 1 values: In Progress(10206) Parent values: Development(10200)Level 1 values: Ready for Local Testing(10209)
            khandu.kshirsagar Khandu Kshirsagar (Inactive) made changes -
            Item State Parent values: Development(10200)Level 1 values: Ready for Local Testing(10209) Parent values: LB QA(10201)Level 1 values: LB Deployed(11600)
            Hide
            Permalink
            ramya.tantry Ramya Tantry (Inactive) added a comment -

            Hi Kunal Kedari,

            Please verify the issues(pts. 1 and 2).
            Point 3 is non repro.
            Please go through my earlier comment for more details on point 3.

            Show
            ramya.tantry Ramya Tantry (Inactive) added a comment - Hi Kunal Kedari , Please verify the issues(pts. 1 and 2). Point 3 is non repro. Please go through my earlier comment for more details on point 3.
            ramya.tantry Ramya Tantry (Inactive) made changes -
            Assignee Ramya Tantry [ ramya.tantry ] Kunal Kedari [ kunal.kedari ]
            ramya.tantry Ramya Tantry (Inactive) made changes -
            Status In Development [ 10007 ] Local Testing [ 10200 ]
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Item State Parent values: LB QA(10201)Level 1 values: LB Deployed(11600) Parent values: LB QA(10201)Level 1 values: In Testing(10210)
            Hide
            Permalink
            kunal.kedari Kunal Kedari (Inactive) added a comment -

            Hi Ramya Tantry,

            We have verified the fixes for the "Tour Status" and "Tour Step Completion Rate Report", working as expected. We can deploy fix to Stage.

            Cc: Saurabh Sablaka, Prasad Pise

            Show
            kunal.kedari Kunal Kedari (Inactive) added a comment - Hi Ramya Tantry , We have verified the fixes for the "Tour Status" and "Tour Step Completion Rate Report", working as expected. We can deploy fix to Stage. Cc: Saurabh Sablaka , Prasad Pise
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Item State Parent values: LB QA(10201)Level 1 values: In Testing(10210) Parent values: LB QA(10201)Level 1 values: Ready for Stage(10213)
            Permalink
            kunal.kedari Kunal Kedari (Inactive) logged work - 19/May/17 05:44 PM
            • Time Spent:
              2h
               

              Testing on Local environment

            kunal.kedari Kunal Kedari (Inactive) made changes -
            Remaining Estimate 2h [ 7200 ] 0h [ 0 ]
            Time Spent 10h [ 36000 ] 12h [ 43200 ]
            Worklog Id 47477 [ 47477 ]
            ashwin.wankhede Ashwin Wankhede (Inactive) made changes -
            Item State Parent values: LB QA(10201)Level 1 values: Ready for Stage(10213) Parent values: Stage QA(10202)Level 1 values: Stage Deployed(11602)
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Item State Parent values: Stage QA(10202)Level 1 values: Stage Deployed(11602) Parent values: Stage QA(10202)Level 1 values: In Testing(10214)
            Hide
            Permalink
            kunal.kedari Kunal Kedari (Inactive) added a comment -

            Verified the mentioned report on Stage, working as expected. We can deploy fix to Production.

            Cc: Saurabh Sablaka, Prasad Pise

            Show
            kunal.kedari Kunal Kedari (Inactive) added a comment - Verified the mentioned report on Stage, working as expected. We can deploy fix to Production. Cc: Saurabh Sablaka , Prasad Pise
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Item State Parent values: Stage QA(10202)Level 1 values: In Testing(10214) Parent values: Stage QA(10202)Level 1 values: Ready for Production(10217)
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Status Local Testing [ 10200 ] Stage Testing [ 10201 ]
            Permalink
            kunal.kedari Kunal Kedari (Inactive) logged work - 22/May/17 12:46 PM
            • Time Spent:
              1.5h
               

              Testing on Stage

            ashwin.wankhede Ashwin Wankhede (Inactive) made changes -
            Item State Parent values: Stage QA(10202)Level 1 values: Ready for Production(10217) Parent values: Production QA(10203)Level 1 values: Production Deployed(10221)
            Permalink
            ramya.tantry Ramya Tantry (Inactive) logged work - 23/May/17 09:18 AM
            • Time Spent:
              20m
               

              production checkins

            ramya.tantry Ramya Tantry (Inactive) made changes -
            Time Spent 12h [ 43200 ] 12h 20m [ 44400 ]
            Worklog Id 47917 [ 47917 ]
            Permalink
            kunal.kedari Kunal Kedari (Inactive) logged work - 23/May/17 12:50 PM
            • Time Spent:
              1.5h
               

              Testing on Production

            kunal.kedari Kunal Kedari (Inactive) made changes -
            Item State Parent values: Production QA(10203)Level 1 values: Production Deployed(10221) Parent values: Production QA(10203)Level 1 values: In Testing(10218)
            Hide
            Permalink
            kunal.kedari Kunal Kedari (Inactive) added a comment -

            Verified the fix on Production, working as expected. Closing the ticket.

            Show
            kunal.kedari Kunal Kedari (Inactive) added a comment - Verified the fix on Production, working as expected. Closing the ticket.
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Item State Parent values: Production QA(10203)Level 1 values: In Testing(10218) Parent values: Production Complete(10222)Level 1 values: Closed(10223)
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Status Stage Testing [ 10201 ] Production Testing [ 10202 ]
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Resolution Fixed [ 1 ]
            Status Production Testing [ 10202 ] Production Complete [ 10028 ]
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Status Production Complete [ 10028 ] Closed [ 6 ]
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Time Spent 12h 20m [ 44400 ] 13h 50m [ 49800 ]
            Worklog Id 48867 [ 48867 ]
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Time Spent 13h 50m [ 49800 ] 15h 20m [ 55200 ]
            Worklog Id 48887 [ 48887 ]
            Transition Time In Source Status Execution Times
            Ramya Tantry (Inactive) made transition -
            Open In Development
            		42d 1h 24m 1
            Ramya Tantry (Inactive) made transition -
            In Development In LB Testing
            		5d 15h 22m 1
            Kunal Kedari (Inactive) made transition -
            In LB Testing Stage Testing
            		4d 8h 26m 1
            Kunal Kedari (Inactive) made transition -
            Stage Testing In Production Testing
            		1d 22m 1
            Kunal Kedari (Inactive) made transition -
            In Production Testing Production Complete
            		6s 1
            Kunal Kedari (Inactive) made transition -
            Production Complete Closed
            		2s 1

              People

              Assignee:
              kunal.kedari Kunal Kedari (Inactive)
              Reporter:
              kunal.kedari Kunal Kedari (Inactive)
              Developer:
              Ramya Tantry (Inactive)
              QA:
              Kunal Kedari (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Code Review Date:

                  Time Tracking

                  Estimated:
                  Original Estimate - 12h Original Estimate - 12h
                  12h
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 15h 20m
                  15h 20m