Details

    • Module:
      UK Benefits
    • Reported by:
      Harbinger
    • Item State:
      Stage QA - On Hold

      Description

      User can set blank date of OE at company information.
      Also User can set either of OE start date or OE End date as blank.

      Suggestion : Its better if we make this mandatory as there are chances of human error that dates may kept blank in OE period.

        Attachments

        1. WR-54_Review Checklist.doc
          26 kB
        2. WR-54-FilesAffected.txt
          0.1 kB
        3. server error.png
          server error.png
          198 kB
        4. WR-54-FilesAffected .txt
          0.1 kB

          Issue Links

            Activity

            Hide
            akshay.mukkawar Akshay Mukkawar (Inactive) added a comment -

            Hi Hrishikesh Deshpande,

            Please find below 3C's of the issue,

            Concern: EDS -> OE Date setting
            Cause : Enrollment Opening Date and Enrollment Closing Date make these field mandatory.
            Correction: java script Validation for Enrollment Opening Date and Enrollment Closing Date mandatory is done now.

            Please check this issues.

            CC : Satya,Sheetal Bodhale
            Thanks,
            Akshay Mukkawar

            Show
            akshay.mukkawar Akshay Mukkawar (Inactive) added a comment - Hi Hrishikesh Deshpande , Please find below 3C's of the issue, Concern: EDS -> OE Date setting Cause : Enrollment Opening Date and Enrollment Closing Date make these field mandatory. Correction: java script Validation for Enrollment Opening Date and Enrollment Closing Date mandatory is done now. Please check this issues. CC : Satya , Sheetal Bodhale Thanks, Akshay Mukkawar
            Hide
            hrishikesh.deshpande Hrishikesh Deshpande (Inactive) added a comment -

            Its throwing server error on one scenario -

            Steps -
            Enter Start date
            Enter End date as 0/0. here it throws serer error when we enter the date.

            Exception : String was not recognized as a valid DateTime.
            App Error Log : -
            Employee ID : 0
            Action Name : CompareEnrollmentDate
            Model : System.Web.Mvc.HandleErrorInfo
            Controller : Configuration
            Web Error Log : at System.DateTimeParse.ParseExact(String s, String format, DateTimeFormatInfo dtfi, DateTimeStyles style)
            at WORKTERRA.SharedFunctionWebTier.ConvertToUSFormat(String ControlValue, String OutputFomat) in d:\WT\branches\LB\Web\SharedFunctionWebTier\SharedFunctionWebTier\CommonClasses\SharedFunctionWebTier.cs:line 3357
            at WORKTERRA.Shared.Areas.Configuration.Controllers.ConfigurationController.CompareEnrollmentDate(String strEnrollmentClosingDate, String strEnrollmentOpeningDate) in d:\WT\branches\LB\Web\Web Projects\WORKTERRA\Areas\Configuration\Controllers\CompanyInformation\ClasswiseOEEffectiveDateRulesController.cs:line 83
            at lambda_method(Closure , ControllerBase , Object[] )
            at System.Web.Mvc.ReflectedActionDescriptor.Execute(ControllerContext controllerContext, IDictionary`2 parameters)
            at System.Web.Mvc.ControllerActionInvoker.InvokeActionMethod(ControllerContext controllerContext, ActionDescriptor actionDescriptor, IDictionary`2 parameters)
            at System.Web.Mvc.ControllerActionInvoker.<>c_DisplayClass15.b_12()
            at System.Web.Mvc.ControllerActionInvoker.InvokeActionMethodFilter(IActionFilter filter, ActionExecutingContext preContext, Func`1 continuation)
            at System.Web.Mvc.ControllerActionInvoker.InvokeActionMethodFilter(IActionFilter filter, ActionExecutingContext preContext, Func`1 continuation)
            at System.Web.Mvc.ControllerActionInvoker.InvokeActionMethodWithFilters(ControllerContext controllerContext, IList`1 filters, ActionDescriptor actionDescriptor, IDictionary`2 parameters)
            at System.Web.Mvc.ControllerActionInvoker.InvokeAction(ControllerContext controllerContext, String actionName)

            Show
            hrishikesh.deshpande Hrishikesh Deshpande (Inactive) added a comment - Its throwing server error on one scenario - Steps - Enter Start date Enter End date as 0/0. here it throws serer error when we enter the date. Exception : String was not recognized as a valid DateTime. App Error Log : - Employee ID : 0 Action Name : CompareEnrollmentDate Model : System.Web.Mvc.HandleErrorInfo Controller : Configuration Web Error Log : at System.DateTimeParse.ParseExact(String s, String format, DateTimeFormatInfo dtfi, DateTimeStyles style) at WORKTERRA.SharedFunctionWebTier.ConvertToUSFormat(String ControlValue, String OutputFomat) in d:\WT\branches\LB\Web\SharedFunctionWebTier\SharedFunctionWebTier\CommonClasses\SharedFunctionWebTier.cs:line 3357 at WORKTERRA.Shared.Areas.Configuration.Controllers.ConfigurationController.CompareEnrollmentDate(String strEnrollmentClosingDate, String strEnrollmentOpeningDate) in d:\WT\branches\LB\Web\Web Projects\WORKTERRA\Areas\Configuration\Controllers\CompanyInformation\ClasswiseOEEffectiveDateRulesController.cs:line 83 at lambda_method(Closure , ControllerBase , Object[] ) at System.Web.Mvc.ReflectedActionDescriptor.Execute(ControllerContext controllerContext, IDictionary`2 parameters) at System.Web.Mvc.ControllerActionInvoker.InvokeActionMethod(ControllerContext controllerContext, ActionDescriptor actionDescriptor, IDictionary`2 parameters) at System.Web.Mvc.ControllerActionInvoker.<>c_ DisplayClass15.b _12() at System.Web.Mvc.ControllerActionInvoker.InvokeActionMethodFilter(IActionFilter filter, ActionExecutingContext preContext, Func`1 continuation) at System.Web.Mvc.ControllerActionInvoker.InvokeActionMethodFilter(IActionFilter filter, ActionExecutingContext preContext, Func`1 continuation) at System.Web.Mvc.ControllerActionInvoker.InvokeActionMethodWithFilters(ControllerContext controllerContext, IList`1 filters, ActionDescriptor actionDescriptor, IDictionary`2 parameters) at System.Web.Mvc.ControllerActionInvoker.InvokeAction(ControllerContext controllerContext, String actionName)
            Hide
            sheetal.bodhale Sheetal Bodhale (Inactive) added a comment -

            This is existing issue.
            We will take this in next sprint.

            CC:SatyaHrishikesh DeshpandeAkshay Mukkawar

            Thanks,
            Sheetal Bodhale.

            Show
            sheetal.bodhale Sheetal Bodhale (Inactive) added a comment - This is existing issue. We will take this in next sprint. CC: Satya Hrishikesh Deshpande Akshay Mukkawar Thanks, Sheetal Bodhale.
            Hide
            aarati.sabnis Aarati Sabnis (Inactive) added a comment -

            When start date is given and end date is given as 0/0/0 then we will get server error.
            It gives error message as well. The server error is because of JavaScript.
            Devlopment is in progress.

            Thanks,
            Aarati R. Sabnis

            Show
            aarati.sabnis Aarati Sabnis (Inactive) added a comment - When start date is given and end date is given as 0/0/0 then we will get server error. It gives error message as well. The server error is because of JavaScript. Devlopment is in progress. Thanks, Aarati R. Sabnis
            Hide
            aarati.sabnis Aarati Sabnis (Inactive) added a comment -

            Impacted areas :
            1] OE date in company information
            2] Classwise OE date

            Show
            aarati.sabnis Aarati Sabnis (Inactive) added a comment - Impacted areas : 1] OE date in company information 2] Classwise OE date
            Hide
            aarati.sabnis Aarati Sabnis (Inactive) added a comment -

            Affected Files : WR-54-FilesAffected.txt

            Show
            aarati.sabnis Aarati Sabnis (Inactive) added a comment - Affected Files : WR-54-FilesAffected.txt
            Hide
            aarati.sabnis Aarati Sabnis (Inactive) added a comment -

            Hello Hrishikesh Deshpande,

            Concern : When start date is given and end date is given as 0/0/0 then we will get server error.

            Cause :Invalid date format for 0/0/0 was not handled. So it was giving server error.

            Correction : Now Invalid date format for 0/0/0 is handled and it is working properly.

            Thanks,
            Aarati R. Sabnis

            Show
            aarati.sabnis Aarati Sabnis (Inactive) added a comment - Hello Hrishikesh Deshpande , Concern : When start date is given and end date is given as 0/0/0 then we will get server error. Cause :Invalid date format for 0/0/0 was not handled. So it was giving server error. Correction : Now Invalid date format for 0/0/0 is handled and it is working properly. Thanks, Aarati R. Sabnis
            Hide
            sanjana.jadhav Sanjana Jadhav (Inactive) added a comment - - edited

            Hi Aarati Sabnis

            This issue is still exist.
            Steps -
            Enter Start date
            Enter End date as 0/0. here it throws serer error when we enter the date.

            error log:
            Exception : This request has been blocked because sensitive information could be disclosed to third party web sites when this is used in a GET request. To allow GET requests, set JsonRequestBehavior to AllowGet.
            App Error Log : -
            Employee ID : 0
            Action Name : CompareEnrollmentDate
            Model : System.Web.Mvc.HandleErrorInfo
            Controller : Configuration
            Web Error Log : at System.Web.Mvc.JsonResult.ExecuteResult(ControllerContext context)
            at System.Web.Mvc.ControllerActionInvoker.InvokeActionResultFilterRecursive(IList`1 filters, Int32 filterIndex, ResultExecutingContext preContext, ControllerContext controllerContext, ActionResult actionResult)
            at System.Web.Mvc.ControllerActionInvoker.InvokeActionResultFilterRecursive(IList`1 filters, Int32 filterIndex, ResultExecutingContext preContext, ControllerContext controllerContext, ActionResult actionResult)
            at System.Web.Mvc.ControllerActionInvoker.InvokeActionResultFilterRecursive(IList`1 filters, Int32 filterIndex, ResultExecutingContext preContext, ControllerContext controllerContext, ActionResult actionResult)
            at System.Web.Mvc.ControllerActionInvoker.InvokeActionResultWithFilters(ControllerContext controllerContext, IList`1 filters, ActionResult actionResult)
            at System.Web.Mvc.ControllerActionInvoker.InvokeAction(ControllerContext controllerContext, String actionName)

            CC: Hrishikesh Deshpande

            Thanks
            Sanjana Jadhav

            Show
            sanjana.jadhav Sanjana Jadhav (Inactive) added a comment - - edited Hi Aarati Sabnis This issue is still exist. Steps - Enter Start date Enter End date as 0/0. here it throws serer error when we enter the date. error log: Exception : This request has been blocked because sensitive information could be disclosed to third party web sites when this is used in a GET request. To allow GET requests, set JsonRequestBehavior to AllowGet. App Error Log : - Employee ID : 0 Action Name : CompareEnrollmentDate Model : System.Web.Mvc.HandleErrorInfo Controller : Configuration Web Error Log : at System.Web.Mvc.JsonResult.ExecuteResult(ControllerContext context) at System.Web.Mvc.ControllerActionInvoker.InvokeActionResultFilterRecursive(IList`1 filters, Int32 filterIndex, ResultExecutingContext preContext, ControllerContext controllerContext, ActionResult actionResult) at System.Web.Mvc.ControllerActionInvoker.InvokeActionResultFilterRecursive(IList`1 filters, Int32 filterIndex, ResultExecutingContext preContext, ControllerContext controllerContext, ActionResult actionResult) at System.Web.Mvc.ControllerActionInvoker.InvokeActionResultFilterRecursive(IList`1 filters, Int32 filterIndex, ResultExecutingContext preContext, ControllerContext controllerContext, ActionResult actionResult) at System.Web.Mvc.ControllerActionInvoker.InvokeActionResultWithFilters(ControllerContext controllerContext, IList`1 filters, ActionResult actionResult) at System.Web.Mvc.ControllerActionInvoker.InvokeAction(ControllerContext controllerContext, String actionName) CC: Hrishikesh Deshpande Thanks Sanjana Jadhav
            Hide
            aarati.sabnis Aarati Sabnis (Inactive) added a comment -

            Hello Sanjana Jadhav,

            Concern : When start date is given and end date is given as 0/0/0 then we will get server error

            Cause :Exception was thrown as request has been blocked because of Json. It was not reproduced on local environment.

            Correction : Condition of exception for request has been blocked is handled properly.

            Thanks,
            Aarati R. Sabnis

            Show
            aarati.sabnis Aarati Sabnis (Inactive) added a comment - Hello Sanjana Jadhav , Concern : When start date is given and end date is given as 0/0/0 then we will get server error Cause :Exception was thrown as request has been blocked because of Json. It was not reproduced on local environment. Correction : Condition of exception for request has been blocked is handled properly. Thanks, Aarati R. Sabnis
            Hide
            akshay.mukkawar Akshay Mukkawar (Inactive) added a comment - - edited

            Hi Sanjana Jadhav,

            This problem has been solved on LB , Please check.

            Thanks,
            Akshay Mukkawar
            CC: Sheetal Bodhale,Satya

            Show
            akshay.mukkawar Akshay Mukkawar (Inactive) added a comment - - edited Hi Sanjana Jadhav , This problem has been solved on LB , Please check. Thanks, Akshay Mukkawar CC: Sheetal Bodhale , Satya
            Hide
            aarati.sabnis Aarati Sabnis (Inactive) added a comment -

            Hello Sanjana Jadhav,

            As these changes are related to UK- benefits and UK- benefits changes are only upto the stage.
            So we are making the status as On Hold.

            Thanks,
            Aarati R. Sabnis

            CC Hrishikesh Deshpande,Sheetal BodhaleSatya

            Show
            aarati.sabnis Aarati Sabnis (Inactive) added a comment - Hello Sanjana Jadhav , As these changes are related to UK- benefits and UK- benefits changes are only upto the stage. So we are making the status as On Hold. Thanks, Aarati R. Sabnis CC Hrishikesh Deshpande , Sheetal Bodhale Satya

              People

              Assignee:
              sanjana.jadhav Sanjana Jadhav (Inactive)
              Reporter:
              hrishikesh.deshpande Hrishikesh Deshpande (Inactive)
              Developer:
              Aarati Sabnis (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Code Review Date:

                  Time Tracking

                  Estimated:
                  Original Estimate - 14h Original Estimate - 14h
                  14h
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 29.55h
                  29.55h