Uploaded image for project: 'WORKTERRA'
  1. WORKTERRA
  2. WT-10100

IsApprovlPending is Null in Employee_Enrollment_WaivedbenefitTypes

    Details

    • Type: Bug
    • Status: Closed
    • Priority: High
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Environment:
      Production
    • Bug Severity:
      Medium
    • Module:
      BenAdmin - Enrollment
    • Reported by:
      Harbinger
    • Item State:
      Production Complete - Closed
    • Sprint:
      WT Sprint 32-Bugs

      Description

      The eligibility routine was getting failed after import. When analysed, we found the value for IsApprovalPending is null in given table.

      We could not judge the reason but there's no default constraint for the column as it exists on Employee_Enrollment.

      The Default constraint may solve the issue.

      CC- Jaideep Vinchurkar, Amruta Lohiya, Avnish Yadav

        Attachments

          Activity

          suraj.sokasane Suraj Sokasane (Inactive) created issue -
          abhilash.warkari Abhilash Warkari (Inactive) made changes -
          Field Original Value New Value
          Status Open [ 1 ] In Development [ 10007 ]
          abhilash.warkari Abhilash Warkari (Inactive) made changes -
          Item State Parent values: Development(10200)Level 1 values: In Progress(10206)
          abhilash.warkari Abhilash Warkari (Inactive) made changes -
          Assignee Jyoti Mayne [ jyoti.mayne ] Abhilash Warkari [ abhilash.warkari ]
          abhilash.warkari Abhilash Warkari (Inactive) made changes -
          Developer Abhilash Warkari [ abhilash.warkari ]
          abhilash.warkari Abhilash Warkari (Inactive) made changes -
          Dev Due Date 13/Jul/2017
          gaurav.sodani Gaurav Sodani (Inactive) made changes -
          Sprint WT Sprint 32-Bugs [ 76 ]
          abhilash.warkari Abhilash Warkari (Inactive) made changes -
          Code Review Date 13/Jul/2017
          Code Reviewed By Umesh Kadam [ 15302 ]
          abhilash.warkari Abhilash Warkari (Inactive) made changes -
          Item State Parent values: Development(10200)Level 1 values: In Progress(10206) Parent values: Development(10200)Level 1 values: Ready for Local Testing(10209)
          abhilash.warkari Abhilash Warkari (Inactive) made changes -
          Attachment WT-10100 Affected Files.txt [ 55334 ]
          abhilash.warkari Abhilash Warkari (Inactive) made changes -
          Attachment WT-10100 Code Review Checklist.doc [ 55335 ]
          Hide
          abhilash.warkari Abhilash Warkari (Inactive) added a comment -

          HI

          Please find below 3Cs :

          Concern IsApprovlPending is Null in Employee_Enrollment_WaivedbenefitTypes
          Cause There was no default constraint on IsApprovalPending column so value was set as Null
          Correction We have added default constraint on IsApprovalPending column to avoid value to be set as null

          Thanks and Regards
          Abhilash Warkari

          CC :Jyoti Mayne,Umesh Kadam

          Show
          abhilash.warkari Abhilash Warkari (Inactive) added a comment - HI Please find below 3Cs : Concern IsApprovlPending is Null in Employee_Enrollment_WaivedbenefitTypes Cause There was no default constraint on IsApprovalPending column so value was set as Null Correction We have added default constraint on IsApprovalPending column to avoid value to be set as null Thanks and Regards Abhilash Warkari CC : Jyoti Mayne , Umesh Kadam
          umesh.kadam Umesh Kadam (Inactive) logged work - 13/Jul/17 04:30 PM
          • Time Spent:
            1h
             

            Issue discussion
            Default constraint Query Optimization R&D and discussion
            Code review
            Unit testing

          abhilash.warkari Abhilash Warkari (Inactive) logged work - 13/Jul/17 04:30 PM - edited
          • Time Spent:
            4h
             

            Analysis of the issue .
            Added a script for adding Default constraint on the column.

          abhilash.warkari Abhilash Warkari (Inactive) made changes -
          Attachment WT-10100 Affected Files.txt [ 55334 ]
          abhilash.warkari Abhilash Warkari (Inactive) made changes -
          Attachment WT-10100 Affected Files.txt [ 55503 ]
          khandu.kshirsagar Khandu Kshirsagar (Inactive) made changes -
          Item State Parent values: Development(10200)Level 1 values: Ready for Local Testing(10209) Parent values: LB QA(10201)Level 1 values: LB Deployed(11600)
          abhilash.warkari Abhilash Warkari (Inactive) made changes -
          Assignee Abhilash Warkari [ abhilash.warkari ] Prasad Pise [ prasadp ]
          umesh.kadam Umesh Kadam (Inactive) made changes -
          Remaining Estimate 0h [ 0 ]
          Time Spent 1h [ 3600 ]
          Worklog Id 63396 [ 63396 ]
          umesh.kadam Umesh Kadam (Inactive) made changes -
          Time Spent 1h [ 3600 ] 2h [ 7200 ]
          Worklog Id 63407 [ 63407 ]
          umesh.kadam Umesh Kadam (Inactive) logged work - 14/Jul/17 04:30 PM
          • Time Spent:
            1h
             

            LB and UiRefresh code commit issue discussion with Kumar, Ashwin and Abhilash
            DB Code revert and correction

          prasadp Prasad Pise (Inactive) made changes -
          Assignee Prasad Pise [ prasadp ] Alankar Chavan [ alankar.chavan ]
          prasadp Prasad Pise (Inactive) made changes -
          Item State Parent values: LB QA(10201)Level 1 values: LB Deployed(11600) Parent values: LB QA(10201)Level 1 values: In Testing(10210)
          gaurav.sodani Gaurav Sodani (Inactive) made changes -
          Status In Development [ 10007 ] Local Testing [ 10200 ]
          Hide
          alankar.chavan Alankar Chavan (Inactive) added a comment -

          This is tested on WT Stage - Worked Well

          Default constraint has been added with the column IsApprovalPending.
          By default the value for this field is Zero. When a Waive request goes for admin approval - this value becomes 1

          Ready for Stage

          CC - Sachin Hingole Prasad Pise Rakesh Roy Hrishikesh Deshpande

          Show
          alankar.chavan Alankar Chavan (Inactive) added a comment - This is tested on WT Stage - Worked Well Default constraint has been added with the column IsApprovalPending. By default the value for this field is Zero. When a Waive request goes for admin approval - this value becomes 1 Ready for Stage CC - Sachin Hingole Prasad Pise Rakesh Roy Hrishikesh Deshpande
          alankar.chavan Alankar Chavan (Inactive) made changes -
          Item State Parent values: LB QA(10201)Level 1 values: In Testing(10210) Parent values: LB QA(10201)Level 1 values: Ready for Stage(10213)
          alankar.chavan Alankar Chavan (Inactive) logged work - 18/Jul/17 12:48 PM
          • Time Spent:
            3h
             

            wt stage testing

          alankar.chavan Alankar Chavan (Inactive) made changes -
          Time Spent 2h [ 7200 ] 5h [ 18000 ]
          Worklog Id 64299 [ 64299 ]
          khandu.kshirsagar Khandu Kshirsagar (Inactive) made changes -
          Item State Parent values: LB QA(10201)Level 1 values: Ready for Stage(10213) Parent values: Stage QA(10202)Level 1 values: Stage Deployed(11602)
          Hide
          alankar.chavan Alankar Chavan (Inactive) added a comment -

          This is tested on Stage - Worked Well

          Default constraint has been added with the column IsApprovalPending.
          By default the value for this field is Zero. When a Waive request goes for admin approval - this value becomes 1

          Ready for Production

          CC - Sachin Hingole Prasad Pise Rakesh Roy Hrishikesh Deshpande

          Show
          alankar.chavan Alankar Chavan (Inactive) added a comment - This is tested on Stage - Worked Well Default constraint has been added with the column IsApprovalPending. By default the value for this field is Zero. When a Waive request goes for admin approval - this value becomes 1 Ready for Production CC - Sachin Hingole Prasad Pise Rakesh Roy Hrishikesh Deshpande
          alankar.chavan Alankar Chavan (Inactive) made changes -
          Item State Parent values: Stage QA(10202)Level 1 values: Stage Deployed(11602) Parent values: Stage QA(10202)Level 1 values: Ready for Production(10217)
          alankar.chavan Alankar Chavan (Inactive) made changes -
          Status Local Testing [ 10200 ] Stage Testing [ 10201 ]
          alankar.chavan Alankar Chavan (Inactive) logged work - 19/Jul/17 12:49 PM
          • Time Spent:
            1h
             

            stage testing

          alankar.chavan Alankar Chavan (Inactive) made changes -
          Time Spent 5h [ 18000 ] 6h [ 21600 ]
          Worklog Id 64715 [ 64715 ]
          khandu.kshirsagar Khandu Kshirsagar (Inactive) made changes -
          Item State Parent values: Stage QA(10202)Level 1 values: Ready for Production(10217) Parent values: Production QA(10203)Level 1 values: Production Deployed(10221)
          Hide
          alankar.chavan Alankar Chavan (Inactive) added a comment -

          This is tested on Production - Worked Well

          CC - Prasad Pise Rakesh Roy

          Show
          alankar.chavan Alankar Chavan (Inactive) added a comment - This is tested on Production - Worked Well CC - Prasad Pise Rakesh Roy
          alankar.chavan Alankar Chavan (Inactive) made changes -
          Status Stage Testing [ 10201 ] Production Testing [ 10202 ]
          alankar.chavan Alankar Chavan (Inactive) made changes -
          Resolution Fixed [ 1 ]
          Status Production Testing [ 10202 ] Production Complete [ 10028 ]
          alankar.chavan Alankar Chavan (Inactive) made changes -
          Status Production Complete [ 10028 ] Closed [ 6 ]
          alankar.chavan Alankar Chavan (Inactive) made changes -
          Item State Parent values: Production QA(10203)Level 1 values: Production Deployed(10221) Parent values: Production Complete(10222)Level 1 values: Closed(10223)
          abhilash.warkari Abhilash Warkari (Inactive) made changes -
          Time Spent 6h [ 21600 ] 10h [ 36000 ]
          Worklog Id 66392 [ 66392 ]
          abhilash.warkari Abhilash Warkari (Inactive) made changes -
          Worklog Id 66392 [ 66392 ]
          satyap Satya made changes -
          Environment_New Production [ 18442 ]
          Transition Time In Source Status Execution Times
          Abhilash Warkari (Inactive) made transition -
          Open In Development
          1d 16h 31m 1
          Gaurav Sodani (Inactive) made transition -
          In Development In LB Testing
          4d 2h 18m 1
          Alankar Chavan (Inactive) made transition -
          In LB Testing Stage Testing
          2d 4h 4m 1
          Alankar Chavan (Inactive) made transition -
          Stage Testing In Production Testing
          1d 11m 1
          Alankar Chavan (Inactive) made transition -
          In Production Testing Production Complete
          9s 1
          Alankar Chavan (Inactive) made transition -
          Production Complete Closed
          13s 1

            People

            Assignee:
            alankar.chavan Alankar Chavan (Inactive)
            Reporter:
            suraj.sokasane Suraj Sokasane (Inactive)
            Developer:
            Abhilash Warkari (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Dev Due Date:
              Code Review Date:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 10h
                10h