Uploaded image for project: 'WORKTERRA'
  1. WORKTERRA
  2. WT-7949

Server Error gets displayed on 'Design System Messages' tab when blank spaces are saved in System Message title/name.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: High
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Environment:
      QA
    • Bug Severity:
      Medium
    • Module:
      BenAdmin - EDS
    • Reported by:
      Harbinger
    • Item State:
      Production Complete - Closed

      Description

      Server Error gets displayed on 'Design System Messages' tab when blank spaces are saved in System Message title/name.
      Repro Steps:
      1. Login as Admin user
      2. Go to Test Company -> Form Builder
      3. Click on 'Enroll Now' form OR 'Upload Documents' form
      4. Go to Design System Messages tab.
      5. Insert blank spaces in 'System Message(s)' field. Do not enter any text.
      6. Select values in other necessary fields.
      7. Click on Save button.
      8. Check for the Server error displayed.

      Actual Result:
      Server Error gets displayed on 'Design System Messages' tab when blank spaces are saved in System Message title/name.

      Expected Result:
      User should not be allowed to enter and save the blank spaces in System Message title/name. OR Blank space at first places should be handled.
      Server Error should not get displayed on 'Design System Messages' tab.

        Attachments

          Activity

          prasadp Prasad Pise (Inactive) created issue -
          prasadp Prasad Pise (Inactive) made changes -
          Field Original Value New Value
          Description Server Error gets displayed on 'Design System Messages' tab when blank spaces are saved in System Message title/name.
          Repro Steps:
          1. Login as Admin user
          2. Go to Test Company -> Form Builder
          3. Click on 'Enroll Now' form
          4. Go to Design System Messages tab.
          5. Insert blank spaces in 'System Message(s)' field. Do not enter any text.
          6. Select values in other necessary fields.
          7. Click on Save button.
          8. Check for the Server error displayed.

          Actual Result:
          Server Error gets displayed on 'Design System Messages' tab when blank spaces are saved in System Message title/name.

          Expected Result:
          User should not be allowed to enter and save the blank spaces in System Message title/name. OR Blank space at first places should be handled.
          Server Error should not get displayed on 'Design System Messages' tab.
          Server Error gets displayed on 'Design System Messages' tab when blank spaces are saved in System Message title/name.
          Repro Steps:
          1. Login as Admin user
          2. Go to Test Company -> Form Builder
          3. Click on 'Enroll Now' form OR 'Upload Documents' form
          4. Go to Design System Messages tab.
          5. Insert blank spaces in 'System Message(s)' field. Do not enter any text.
          6. Select values in other necessary fields.
          7. Click on Save button.
          8. Check for the Server error displayed.

          Actual Result:
          Server Error gets displayed on 'Design System Messages' tab when blank spaces are saved in System Message title/name.

          Expected Result:
          User should not be allowed to enter and save the blank spaces in System Message title/name. OR Blank space at first places should be handled.
          Server Error should not get displayed on 'Design System Messages' tab.
          aarati.sabnis Aarati Sabnis (Inactive) made changes -
          Status Open [ 1 ] In Development [ 10007 ]
          aarati.sabnis Aarati Sabnis (Inactive) logged work - 23/Jan/17 01:02 PM - edited
          • Time Spent:
            1.5h
             
            <No comment>
          aarati.sabnis Aarati Sabnis (Inactive) made changes -
          Remaining Estimate 0h [ 0 ]
          Time Spent 2.5h [ 9000 ]
          Worklog Id 20606 [ 20606 ]
          aarati.sabnis Aarati Sabnis (Inactive) made changes -
          Remaining Estimate 0h [ 0 ] 1h [ 3600 ]
          Time Spent 2.5h [ 9000 ] 1.5h [ 5400 ]
          Worklog Id 20606 [ 20606 ]
          prasadp Prasad Pise (Inactive) logged work - 23/Jan/17 01:24 PM
          • Time Spent:
            1h
             

            Issue confirmed for multiple companies and JIRA Logged.

          prasadp Prasad Pise (Inactive) made changes -
          Remaining Estimate 1h [ 3600 ] 0h [ 0 ]
          Time Spent 1.5h [ 5400 ] 2.5h [ 9000 ]
          Worklog Id 20629 [ 20629 ]
          prasadp Prasad Pise (Inactive) made changes -
          Remaining Estimate 0h [ 0 ] 2.5h [ 9000 ]
          Original Estimate 5h [ 18000 ]
          aarati.sabnis Aarati Sabnis (Inactive) logged work - 24/Jan/17 12:54 PM
          • Time Spent:
            2.5h
             

            Unit testing
            Checking system message details in Database
            Checking system message for spaces
            Unit testing for server error
            Coding in view foe spaces in name of system message
            Unit testing

          aarati.sabnis Aarati Sabnis (Inactive) made changes -
          Remaining Estimate 2.5h [ 9000 ] 0h [ 0 ]
          Time Spent 2.5h [ 9000 ] 5h [ 18000 ]
          Worklog Id 20771 [ 20771 ]
          rakeshr Rakesh Roy (Inactive) made changes -
          Module Parent values: BenAdmin(10100) Parent values: BenAdmin(10100)Level 1 values: EDS(10108)
          sheetal.bodhale Sheetal Bodhale (Inactive) made changes -
          Time Spent 5h [ 18000 ] 5.15h [ 18540 ]
          Worklog Id 20862 [ 20862 ]
          Hide
          aarati.sabnis Aarati Sabnis (Inactive) added a comment -

          Hello Prasad Pise,

          Concern : Server Error gets displayed on 'Design System Messages' tab when blank spaces are saved in System Message title/name.

          Cause : Condition for Blank spaces in system message title/name was not checked. So blank value was getting stored in database. So because of this,while fetching value from database it was giving server error.

          Correction : Condition for Blank spaces in system message title/name is checked now and it is working properly.

          LB check-in is done.

          Thanks,
          Aarati R. Sabnis

          CC Satya,Sheetal Bodhale

          Show
          aarati.sabnis Aarati Sabnis (Inactive) added a comment - Hello Prasad Pise , Concern : Server Error gets displayed on 'Design System Messages' tab when blank spaces are saved in System Message title/name. Cause : Condition for Blank spaces in system message title/name was not checked. So blank value was getting stored in database. So because of this,while fetching value from database it was giving server error. Correction : Condition for Blank spaces in system message title/name is checked now and it is working properly. LB check-in is done. Thanks, Aarati R. Sabnis CC Satya , Sheetal Bodhale
          aarati.sabnis Aarati Sabnis (Inactive) made changes -
          Time Spent 5.15h [ 18540 ] 5.4h [ 19440 ]
          Worklog Id 20877 [ 20877 ]
          aarati.sabnis Aarati Sabnis (Inactive) made changes -
          Code Review Date 25/Jan/2017
          Code Reviewed By Sheetal Bodhale [ 11905 ]
          Developer Aarati Sabnis [ aarati.sabnis ]
          khandu.kshirsagar Khandu Kshirsagar (Inactive) made changes -
          Item State Parent values: LB QA(10201)Level 1 values: LB Deployed(11600)
          aarati.sabnis Aarati Sabnis (Inactive) made changes -
          Assignee Aarati Sabnis [ aarati.sabnis ] Prasad Pise [ prasadp ]
          aarati.sabnis Aarati Sabnis (Inactive) made changes -
          Status In Development [ 10007 ] Local Testing [ 10200 ]
          prasadp Prasad Pise (Inactive) logged work - 25/Jan/17 12:55 PM
          • Time Spent:
            0.75h
             

            Testing on LB, JIRA Updates

          Hide
          prasadp Prasad Pise (Inactive) added a comment -

          Hi Aarati Sabnis

          I have verified the Server Error related fix on LB for Enroll now and Upload documents form. Now, User is not allowed to save the blank spaces in System Message title/name at start position.
          Updating as Ready for Stage

          Thanks

          Show
          prasadp Prasad Pise (Inactive) added a comment - Hi Aarati Sabnis I have verified the Server Error related fix on LB for Enroll now and Upload documents form. Now, User is not allowed to save the blank spaces in System Message title/name at start position. Updating as Ready for Stage Thanks Prasad CC: Satya Sheetal Bodhale Rakesh Roy
          prasadp Prasad Pise (Inactive) made changes -
          Item State Parent values: LB QA(10201)Level 1 values: LB Deployed(11600) Parent values: LB QA(10201)Level 1 values: Ready for Stage(10213)
          prasadp Prasad Pise (Inactive) made changes -
          Time Spent 5.4h [ 19440 ] 6.15h [ 22140 ]
          Worklog Id 21068 [ 21068 ]
          sheetal.bodhale Sheetal Bodhale (Inactive) logged work - 25/Jan/17 06:32 PM
          • Time Spent:
            0.15h
             

            code review

          aarati.sabnis Aarati Sabnis (Inactive) logged work - 26/Jan/17 07:04 AM
          • Time Spent:
            0.25h
             

            Code review by Sheetal
            LB-check-in

          Hide
          prasadp Prasad Pise (Inactive) added a comment -

          HI Aarati Sabnis

          As discussed, This issue is closed since code check-in for this is included in WT-7378 itself.

          Thanks
          -Prasad

          Show
          prasadp Prasad Pise (Inactive) added a comment - HI Aarati Sabnis As discussed, This issue is closed since code check-in for this is included in WT-7378 itself. Thanks -Prasad
          prasadp Prasad Pise (Inactive) made changes -
          Status Local Testing [ 10200 ] Stage Testing [ 10201 ]
          prasadp Prasad Pise (Inactive) made changes -
          Status Stage Testing [ 10201 ] Production Testing [ 10202 ]
          prasadp Prasad Pise (Inactive) made changes -
          Resolution Fixed [ 1 ]
          Status Production Testing [ 10202 ] Production Complete [ 10028 ]
          prasadp Prasad Pise (Inactive) made changes -
          Status Production Complete [ 10028 ] Closed [ 6 ]
          prasadp Prasad Pise (Inactive) made changes -
          Item State Parent values: LB QA(10201)Level 1 values: Ready for Stage(10213) Parent values: Production Complete(10222)Level 1 values: Closed(10223)
          ashwin.wankhede Ashwin Wankhede (Inactive) made changes -
          Item State Parent values: Production Complete(10222)Level 1 values: Closed(10223) Parent values: Stage QA(10202)Level 1 values: Stage Deployed(11602)
          prasadp Prasad Pise (Inactive) made changes -
          Item State Parent values: Stage QA(10202)Level 1 values: Stage Deployed(11602) Parent values: Production Complete(10222)Level 1 values: Closed(10223)
          rakeshr Rakesh Roy (Inactive) made changes -
          Bug Severity Medium [ 16702 ]
          satyap Satya made changes -
          Environment_New LB [ 18444 ]
          Transition Time In Source Status Execution Times
          Aarati Sabnis (Inactive) made transition -
          Open In Development
          2h 18m 1
          Aarati Sabnis (Inactive) made transition -
          In Development In LB Testing
          1d 22h 46m 1
          Prasad Pise (Inactive) made transition -
          In LB Testing Stage Testing
          4d 17h 21m 1
          Prasad Pise (Inactive) made transition -
          Stage Testing In Production Testing
          3s 1
          Prasad Pise (Inactive) made transition -
          In Production Testing Production Complete
          20s 1
          Prasad Pise (Inactive) made transition -
          Production Complete Closed
          2s 1

            People

            Assignee:
            prasadp Prasad Pise (Inactive)
            Reporter:
            prasadp Prasad Pise (Inactive)
            Developer:
            Aarati Sabnis (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Code Review Date:

                Time Tracking

                Estimated:
                Original Estimate - 5h Original Estimate - 5h
                5h
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 6.15h
                6.15h