Details

    • Type: Bug
    • Status: Done
    • Priority: Medium
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      Upload Forms:
      Please see picture for more details:

      • Spacing issue on this page, as well - where it is fitting to page vs. looking visual appealing, you can see at top / on teh template status it looks funny.
      • Banner at top does not match CB standards
      • All of the dropdowns at the top are required - but what if my form doesn't match the criteria / how do these dropdowns get updated? These aren't all necessarily going to make sense to be required?
      • Drag and Drop box look rather large / not like her mock-up; as well we should not capitalize 'And'., and it says that .doc is accepted, but then i got an errors, and it says on PDF? see image
      • Editable boxes look rather large on page - and the font of the titles look so tiny?
      • As well, throughout the page, it doesn't appear to match the font / boldness of Aruna's mock-ups?
      • Lastly, the Mapping shouldn't be all required - what if they upload a reference doc, or doc that has nothing to map.
      • What happens when i say that it's an e-signed document? What does that actually do? Put in the stamp?
      • When i uploaded a template, it took awhile to upload, as well as i didnt' have an indication anything was happening, i almost x'ed out. Lastly, once it was done,you would think it would take you back to the template library, but it doesn't it just stays on the page.

        Attachments

        1. custom-variables.scss
          2 kB
        2. documentTemplate.component.html
          15 kB
        3. image-2018-11-20-15-25-30-836.png
          image-2018-11-20-15-25-30-836.png
          189 kB
        4. image-2018-11-20-15-25-36-975.png
          image-2018-11-20-15-25-36-975.png
          37 kB
        5. style.scss
          23 kB

          Activity

          molly.ronovsky Molly Ronovsky (Inactive) created issue -
          molly.ronovsky Molly Ronovsky (Inactive) made changes -
          Field Original Value New Value
          Epic Link DMS-3 [ 69340 ]
          swapnil.pandhare Swapnil Pandhare (Inactive) made changes -
          Assignee Samir [ samir ] Narendra Kumar [ narendra.kumar ]
          swapnil.pandhare Swapnil Pandhare (Inactive) made changes -
          Sprint DMS - Sprint 6 [ 134 ]
          Remaining Estimate 16h [ 57600 ]
          Original Estimate 16h [ 57600 ]
          narendra.kumar Narendra Kumar made changes -
          Status To Do [ 10000 ] In Progress [ 3 ]
          Hide
          narendra.kumar Narendra Kumar added a comment -

          Hi Swapnil Pandhare

          Done with the following:

          • All of the dropdowns at the top are required - but what if my form doesn't match the criteria / how do these dropdowns get updated? These aren't all necessarily going to make sense to be required? - FIXED
          • Drag and drop box look rather large / not like her mock-up; as well we should not capitalize 'And'., and it says that .doc is accepted, but then I got an errors, and it says on PDF? see image - FIXED
          • As well, throughout the page, it doesn't appear to match the font/boldness of Aruna's mock-ups? - DONE**
          Show
          narendra.kumar Narendra Kumar added a comment - Hi Swapnil Pandhare Done with the following: All of the dropdowns at the top are required - but what if my form doesn't match the criteria / how do these dropdowns get updated? These aren't all necessarily going to make sense to be required? - FIXED Drag and drop box look rather large / not like her mock-up; as well we should not capitalize 'And'., and it says that .doc is accepted, but then I got an errors, and it says on PDF? see image - FIXED As well, throughout the page, it doesn't appear to match the font/boldness of Aruna's mock-ups? - DONE **
          Hide
          narendra.kumar Narendra Kumar added a comment -

          Based on the discussion with Swapnil Pandhare assigning this task to Smita Pawar.

          Show
          narendra.kumar Narendra Kumar added a comment - Based on the discussion with Swapnil Pandhare assigning this task to Smita Pawar .
          narendra.kumar Narendra Kumar made changes -
          Assignee Narendra Kumar [ narendra.kumar ] Smita Pawar [ smita.v.pawar ]
          smita.v.pawar Smita Pawar (Inactive) logged work - 26/Dec/18 10:10 PM
          • Time Spent:
            4h
             

            Resolved the mentioned issues.

          smita.v.pawar Smita Pawar (Inactive) made changes -
          Attachment documentTemplate.component.html [ 93597 ]
          smita.v.pawar Smita Pawar (Inactive) made changes -
          Attachment style.scss [ 93598 ]
          Hide
          smita.v.pawar Smita Pawar (Inactive) added a comment -

          Hi Swapnil Pandhare,

          All issues mentioned in the image-2018-11-20-15-25-30-836.png are resolved. Please find attached style.scss and documentTemplate.component,html for few classes changes to adjust.

          Show
          smita.v.pawar Smita Pawar (Inactive) added a comment - Hi Swapnil Pandhare , All issues mentioned in the image-2018-11-20-15-25-30-836.png are resolved. Please find attached style.scss and documentTemplate.component,html for few classes changes to adjust.
          Hide
          smita.v.pawar Smita Pawar (Inactive) added a comment -

          Hi Narendra Kumar,

          Your mentioned points:

          • Drag and drop box look rather large / not like her mock-up; as well we should not capitalize 'And'., and it says that .doc is accepted, but then I got an errors, and it says on PDF? see image - FIXED
          • As well, throughout the page, it doesn't appear to match the font/boldness of Aruna's mock-ups? - DONE**

          For these fixes have you changes the style.scss? Please let me know.

          Show
          smita.v.pawar Smita Pawar (Inactive) added a comment - Hi Narendra Kumar , Your mentioned points: Drag and drop box look rather large / not like her mock-up; as well we should not capitalize 'And'., and it says that .doc is accepted, but then I got an errors, and it says on PDF? see image -  FIXED As well, throughout the page, it doesn't appear to match the font/boldness of Aruna's mock-ups? -  DONE ** For these fixes have you changes the style.scss? Please let me know.
          smita.v.pawar Smita Pawar (Inactive) made changes -
          Remaining Estimate 16h [ 57600 ] 12h [ 43200 ]
          Time Spent 4h [ 14400 ]
          Worklog Id 152968 [ 152968 ]
          Hide
          narendra.kumar Narendra Kumar added a comment -

          Hi Smita Pawar,

          Yes, I made changes in style.scss. See my changes below

           

          Previous  My changes
          .control-label {
          font-size: 12px;
          font-weight: normal;
          margin-bottom: 0;
          color: #A3A3A3;
          }
          .control-label {
          font-size: 12px;
          font-weight: bolder;
          margin-bottom: 0;
          color: #A3A3A3;
          }
          .files:before {
          position: absolute;
          top: 72px;
          left: 0;
          pointer-events: none;
          width: auto;
          right: 0;
          height: 57px;
          content: "Drag and Drop";
          display: block;
          margin: 0 auto;
          color: #182642;
          font-weight: 600;
          text-transform: capitalize;
          text-align: center;
          }
          .files:before {
          position: absolute;
          top: 72px;
          left: 0;
          pointer-events: none;
          width: auto;
          right: 0;
          height: 57px;
          content: "Drag and Drop";
          display: block;
          margin: 0 auto;
          color: #182642;
          font-weight: 600;
          // text-transform: capitalize;
          text-align: center;
          }
            .bold { font-weight: bolder; }

          to make font bolder I assigned this .bold class to label where nedded.

           

          Thanks

          Narendra Kumar

           

          Show
          narendra.kumar Narendra Kumar added a comment - Hi Smita Pawar , Yes, I made changes in style.scss. See my changes below   Previous  My changes .control-label { font-size: 12px; font-weight: normal; margin-bottom: 0; color: #A3A3A3; } .control-label { font-size: 12px; font-weight: bolder; margin-bottom: 0; color: #A3A3A3; } .files:before { position: absolute; top: 72px; left: 0; pointer-events: none; width: auto; right: 0; height: 57px; content: "Drag and Drop"; display: block; margin: 0 auto; color: #182642; font-weight: 600; text-transform: capitalize; text-align: center; } .files:before { position: absolute; top: 72px; left: 0; pointer-events: none; width: auto; right: 0; height: 57px; content: "Drag and Drop"; display: block; margin: 0 auto; color: #182642; font-weight: 600; // text-transform: capitalize; text-align: center; }   .bold { font-weight: bolder; } to make font bolder I assigned this .bold class to label where nedded.   Thanks Narendra Kumar  
          narendra.kumar Narendra Kumar made changes -
          Assignee Smita Pawar [ smita.v.pawar ] Narendra Kumar [ narendra.kumar ]
          Hide
          narendra.kumar Narendra Kumar added a comment -

          Hi Smita Pawar,

          I'm getting the following error with your style.scss file.

          Undefined variable: "$action".

          I think you also need to share the custom-variables.scss file.

          Please update

           

          Thanks 

          Narendra Kumar

          Show
          narendra.kumar Narendra Kumar added a comment - Hi Smita Pawar , I'm getting the following error with your style.scss file. Undefined variable: "$action". I think you also need to share the custom-variables.scss file. Please update   Thanks  Narendra Kumar
          smita.v.pawar Smita Pawar (Inactive) made changes -
          Attachment custom-variables.scss [ 93624 ]
          Hide
          smita.v.pawar Smita Pawar (Inactive) added a comment -

          Narendra Kumar, Attached custom-variables.scss.

          Show
          smita.v.pawar Smita Pawar (Inactive) added a comment - Narendra Kumar , Attached custom-variables.scss.
          Hide
          smita.v.pawar Smita Pawar (Inactive) added a comment -

          Hi Narendra Kumar,

          As discussed, all points mentioned above are done and CSS merged. Except below mentioned point. Please confirm from Aruna Raheja and update.

          • .doc and .pdf is accepted
          Show
          smita.v.pawar Smita Pawar (Inactive) added a comment - Hi Narendra Kumar , As discussed, all points mentioned above are done and CSS merged. Except below mentioned point. Please confirm from Aruna Raheja and update. .doc and .pdf is accepted
          narendra.kumar Narendra Kumar made changes -
          Status In Progress [ 3 ] Code Review [ 11801 ]
          swapnil.pandhare Swapnil Pandhare (Inactive) made changes -
          Status Code Review [ 11801 ] In QA Testing [ 11901 ]
          jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
          Assignee Narendra Kumar [ narendra.kumar ] Jayshree Nagpure [ jayshree.nagpure ]
          jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
          Assignee Jayshree Nagpure [ jayshree.nagpure ] Narendra Kumar [ narendra.kumar ]
          swapnil.pandhare Swapnil Pandhare (Inactive) made changes -
          Assignee Narendra Kumar [ narendra.kumar ] Jayshree Nagpure [ jayshree.nagpure ]
          Sprint DMS - Sprint 6 [ 134 ] DMS - Sprint 7 [ 148 ]
          Hide
          priya.dhamande Priya Dhamande (Inactive) added a comment -

          As per above comment few points are pending, so assigning back to Narendra. We will verifying all the points simultaneously.

          Swapnil Pandhare Smita Pawar Jayshree Nagpure

          Show
          priya.dhamande Priya Dhamande (Inactive) added a comment - As per above comment few points are pending, so assigning back to Narendra. We will verifying all the points simultaneously. Swapnil Pandhare Smita Pawar Jayshree Nagpure
          priya.dhamande Priya Dhamande (Inactive) made changes -
          Assignee Jayshree Nagpure [ jayshree.nagpure ] Narendra Kumar [ narendra.kumar ]
          priya.dhamande Priya Dhamande (Inactive) made changes -
          Status In QA Testing [ 11901 ] In Progress [ 3 ]
          Hide
          aruna.raheja Aruna Raheja added a comment -

          @Samir : Kindly confirm which documents we are supported now (.doc and .pdf is accepted)

          CC: Narendra Kumar

          Show
          aruna.raheja Aruna Raheja added a comment - @Samir : Kindly confirm which documents we are supported now (.doc and .pdf is accepted) CC: Narendra Kumar
          Hide
          narendra.kumar Narendra Kumar added a comment -

          Hi Priya Dhamande,

          I just discuss with Samir, we will accept PDF file only. Doc files are not allowed so the current process is fine. Based on this, marking task in code review.

           

          cc - Samir

           

          Thanks

          Narendra 

          Show
          narendra.kumar Narendra Kumar added a comment - Hi Priya Dhamande , I just discuss with Samir , we will accept PDF file only. Doc files are not allowed so the current process is fine. Based on this, marking task in code review.   cc - Samir   Thanks Narendra 
          narendra.kumar Narendra Kumar made changes -
          Status In Progress [ 3 ] Code Review [ 11801 ]
          swapnil.pandhare Swapnil Pandhare (Inactive) made changes -
          Sprint DMS - Sprint 7 [ 148 ] DMS - Sprint 1 [ 149 ]
          narendra.kumar Narendra Kumar made changes -
          Assignee Narendra Kumar [ narendra.kumar ] Jayshree Nagpure [ jayshree.nagpure ]
          Hide
          jayshree.nagpure Jayshree Nagpure (Inactive) added a comment -

          Hi Narendra Kumar,

          As the Jira status is on Code review state hence assigning this ticket to you.
          Assign me back once this is deployed on preproduction.

          Thanks,
          Jayshree

          cc - Swapnil Pandhare Samir ShashiKant Mishra Priya Dhamande

          Show
          jayshree.nagpure Jayshree Nagpure (Inactive) added a comment - Hi Narendra Kumar , As the Jira status is on Code review state hence assigning this ticket to you. Assign me back once this is deployed on preproduction. Thanks, Jayshree cc - Swapnil Pandhare Samir ShashiKant Mishra Priya Dhamande
          jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
          Assignee Jayshree Nagpure [ jayshree.nagpure ] Narendra Kumar [ narendra.kumar ]
          rohan.khandave Rohan J Khandave (Inactive) made changes -
          Sprint DMS - Sprint 1 [ 149 ] DMS - Sprint 1, DMS - Sprint 2 [ 149, 150 ]
          narendra.kumar Narendra Kumar logged work - 31/Jan/19 12:00 AM
          • Time Spent:
            8h
             
            <No comment>
          narendra.kumar Narendra Kumar logged work - 06/Feb/19 02:10 AM - edited
          • Time Spent:
            7h
             
            <No comment>
          Hide
          narendra.kumar Narendra Kumar added a comment -

          Hi Jayshree Nagpure,

          This is already deployed in Pre Prod environment. So assigning you for testing.

           

          cc - Swapnil Pandhare, Samir

           

          Show
          narendra.kumar Narendra Kumar added a comment - Hi Jayshree Nagpure , This is already deployed in Pre Prod environment. So assigning you for testing.   cc - Swapnil Pandhare , Samir  
          narendra.kumar Narendra Kumar made changes -
          Status Code Review [ 11801 ] In QA Testing [ 11901 ]
          narendra.kumar Narendra Kumar made changes -
          Assignee Narendra Kumar [ narendra.kumar ] Jayshree Nagpure [ jayshree.nagpure ]
          Hide
          jayshree.nagpure Jayshree Nagpure (Inactive) added a comment -

          Now only PDf is accepted.
          Issue is fixed

          Closing this ticket

          Priya Dhamande Swapnil Pandhare Samir

          Show
          jayshree.nagpure Jayshree Nagpure (Inactive) added a comment - Now only PDf is accepted. Issue is fixed Closing this ticket Priya Dhamande Swapnil Pandhare Samir
          jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
          Resolution Done [ 10000 ]
          Status In QA Testing [ 11901 ] Done [ 10001 ]
          jayshree.nagpure Jayshree Nagpure (Inactive) logged work - 07/Feb/19 03:58 AM
          • Time Spent:
            0.5h
             

            Testing

          jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
          Remaining Estimate 12h [ 43200 ] 11.5h [ 41400 ]
          Time Spent 4h [ 14400 ] 4.5h [ 16200 ]
          Worklog Id 159667 [ 159667 ]
          narendra.kumar Narendra Kumar logged work - 27/Feb/19 12:00 AM
          • Time Spent:
            8h
             
            <No comment>
          prasad.patil Prasad Patil (Inactive) made changes -
          Assignee Jayshree Nagpure [ jayshree.nagpure ] Narendra Kumar [ narendra.kumar ]
          narendra.kumar Narendra Kumar made changes -
          Remaining Estimate 11.5h [ 41400 ] 0.5h [ 1800 ]
          Time Spent 4.5h [ 16200 ] 15.5h [ 55800 ]
          Worklog Id 205688 [ 205688 ]
          narendra.kumar Narendra Kumar made changes -
          Original Estimate 16h [ 57600 ] 24h [ 86400 ]
          narendra.kumar Narendra Kumar made changes -
          Remaining Estimate 0.5h [ 1800 ] 8.5h [ 30600 ]
          narendra.kumar Narendra Kumar made changes -
          Remaining Estimate 8.5h [ 30600 ] 0.5h [ 1800 ]
          Time Spent 15.5h [ 55800 ] 23.5h [ 84600 ]
          Worklog Id 206202 [ 206202 ]
          narendra.kumar Narendra Kumar made changes -
          Remaining Estimate 0.5h [ 1800 ] 0h [ 0 ]
          Time Spent 23.5h [ 84600 ] 31.5h [ 113400 ]
          Worklog Id 206499 [ 206499 ]
          narendra.kumar Narendra Kumar made changes -
          Remaining Estimate 0h [ 0 ] 8h [ 28800 ]
          Time Spent 31.5h [ 113400 ] 23.5h [ 84600 ]
          Worklog Id 206202 [ 206202 ]
          Worklog Time Spent 8h [ 28800 ]
          narendra.kumar Narendra Kumar made changes -
          Remaining Estimate 8h [ 28800 ] 12h [ 43200 ]
          Time Spent 23.5h [ 84600 ] 19.5h [ 70200 ]
          Worklog Id 205688 [ 205688 ]
          narendra.kumar Narendra Kumar made changes -
          Remaining Estimate 12h [ 43200 ] 4h [ 14400 ]
          Time Spent 19.5h [ 70200 ] 27.5h [ 99000 ]
          Worklog Id 206535 [ 206535 ]
          Transition Time In Source Status Execution Times
          Narendra Kumar made transition -
          To Do In Progress
          35d 12h 10m 1
          Priya Dhamande (Inactive) made transition -
          In QA Testing In Progress
          1d 2h 58m 1
          Narendra Kumar made transition -
          In Progress Code Review
          2d 21h 1m 2
          Narendra Kumar made transition -
          Code Review In QA Testing
          38d 31m 2
          Jayshree Nagpure (Inactive) made transition -
          In QA Testing Done
          22h 12m 1

            People

            Assignee:
            narendra.kumar Narendra Kumar
            Reporter:
            molly.ronovsky Molly Ronovsky (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 24h Original Estimate - 24h
                24h
                Remaining:
                Time Spent - 27.5h Remaining Estimate - 4h
                4h
                Logged:
                Time Spent - 27.5h Remaining Estimate - 4h
                27.5h