-
Type:
Bug
-
Status: Done
-
Priority:
Medium
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:None
-
Company:CareerBuilder
-
Epic Link:
Upload Forms:
Please see picture for more details:
- Spacing issue on this page, as well - where it is fitting to page vs. looking visual appealing, you can see at top / on teh template status it looks funny.
- Banner at top does not match CB standards
- All of the dropdowns at the top are required - but what if my form doesn't match the criteria / how do these dropdowns get updated? These aren't all necessarily going to make sense to be required?
- Drag and Drop box look rather large / not like her mock-up; as well we should not capitalize 'And'., and it says that .doc is accepted, but then i got an errors, and it says on PDF? see image
- Editable boxes look rather large on page - and the font of the titles look so tiny?
- As well, throughout the page, it doesn't appear to match the font / boldness of Aruna's mock-ups?
- Lastly, the Mapping shouldn't be all required - what if they upload a reference doc, or doc that has nothing to map.
- What happens when i say that it's an e-signed document? What does that actually do? Put in the stamp?
- When i uploaded a template, it took awhile to upload, as well as i didnt' have an indication anything was happening, i almost x'ed out. Lastly, once it was done,you would think it would take you back to the template library, but it doesn't it just stays on the page.
Based on the discussion with Swapnil Pandhare assigning this task to Smita Pawar.
Hi Swapnil Pandhare,
All issues mentioned in the image-2018-11-20-15-25-30-836.png are resolved. Please find attached style.scss and documentTemplate.component,html for few classes changes to adjust.
Hi Narendra Kumar,
Your mentioned points:
- Drag and drop box look rather large / not like her mock-up; as well we should not capitalize 'And'., and it says that .doc is accepted, but then I got an errors, and it says on PDF? see image - FIXED
- As well, throughout the page, it doesn't appear to match the font/boldness of Aruna's mock-ups? - DONE**
For these fixes have you changes the style.scss? Please let me know.
Hi Smita Pawar,
Yes, I made changes in style.scss. See my changes below
| Previous | My changes |
|---|---|
| .control-label { font-size: 12px; font-weight: normal; margin-bottom: 0; color: #A3A3A3; } |
.control-label { font-size: 12px; font-weight: bolder; margin-bottom: 0; color: #A3A3A3; } |
| .files:before { position: absolute; top: 72px; left: 0; pointer-events: none; width: auto; right: 0; height: 57px; content: "Drag and Drop"; display: block; margin: 0 auto; color: #182642; font-weight: 600; text-transform: capitalize; text-align: center; } |
.files:before { position: absolute; top: 72px; left: 0; pointer-events: none; width: auto; right: 0; height: 57px; content: "Drag and Drop"; display: block; margin: 0 auto; color: #182642; font-weight: 600; // text-transform: capitalize; text-align: center; } |
| .bold { font-weight: bolder; } |
to make font bolder I assigned this .bold class to label where nedded.
Thanks
Narendra Kumar
Hi Smita Pawar,
I'm getting the following error with your style.scss file.
Undefined variable: "$action".
I think you also need to share the custom-variables.scss file.
Please update
Thanks
Narendra Kumar
Narendra Kumar, Attached custom-variables.scss.
Hi Narendra Kumar,
As discussed, all points mentioned above are done and CSS merged. Except below mentioned point. Please confirm from Aruna Raheja and update.
- .doc and .pdf is accepted
As per above comment few points are pending, so assigning back to Narendra. We will verifying all the points simultaneously.
@Samir : Kindly confirm which documents we are supported now (.doc and .pdf is accepted)
CC: Narendra Kumar
Aruna Raheja
added a comment - @Samir : Kindly confirm which documents we are supported now (.doc and .pdf is accepted)
CC: Narendra Kumar Hi Priya Dhamande,
I just discuss with Samir, we will accept PDF file only. Doc files are not allowed so the current process is fine. Based on this, marking task in code review.
cc - Samir
Thanks
Narendra
Hi Narendra Kumar,
As the Jira status is on Code review state hence assigning this ticket to you.
Assign me back once this is deployed on preproduction.
Thanks,
Jayshree
cc - Swapnil Pandhare Samir ShashiKant Mishra Priya Dhamande
Jayshree Nagpure (Inactive)
added a comment - Hi Narendra Kumar ,
As the Jira status is on Code review state hence assigning this ticket to you.
Assign me back once this is deployed on preproduction.
Thanks,
Jayshree
cc - Swapnil Pandhare Samir ShashiKant Mishra Priya Dhamande Hi Jayshree Nagpure,
This is already deployed in Pre Prod environment. So assigning you for testing.
cc - Swapnil Pandhare, Samir
Jayshree Nagpure (Inactive)
added a comment - Now only PDf is accepted.
Issue is fixed
Closing this ticket
Priya Dhamande Swapnil Pandhare Samir 
Hi Swapnil Pandhare
Done with the following: