Document Management SystemProject Type: software

Document Management System

Uploaded image for project: 'Document Management System'
  1. Document Management System
  2. DMS-1336

Text | Uploaded image not reflected on review and sign

    Details

    • Type: Bug
    • Status: Done
    • Priority: Medium
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: Enhancements - Fall
    • Labels:
      None
    • Company:
      All Clients/Multiple Clients

      Description

      File Type: Text
      1.Create the document template with file type TEXT, upload the image in the body
      2. Send the document
      3. In Email, we are not getting the images added in document template with file type TEXT

      PFA -

        Attachments

        1. AFFTECTED_FILES_DEV_1336.txt
          0.2 kB
        2. image_3g.png
          image_3g.png
          10 kB
        3. Screenshot (3479).png
          Screenshot (3479).png
          113 kB
        4. Screenshot (3480).png
          Screenshot (3480).png
          139 kB
        5. Screenshot (3481).png
          Screenshot (3481).png
          133 kB
        6. Screenshot (3482).png
          Screenshot (3482).png
          131 kB
        7. TextPreview.jpg
          TextPreview.jpg
          254 kB
        8. TextReviewAndSign.jpg
          TextReviewAndSign.jpg
          71 kB

          Activity

          Ascending order - Click to sort in descending order
          jayshree.nagpure Jayshree Nagpure (Inactive) created issue -
          shashikant.mishra ShashiKant Mishra (Inactive) made changes -
          Field Original Value New Value
          Fix Version/s Enhancements - Fall [ 10610 ]
          samir Samir made changes -
          Sprint DMS - Fall Sprint 3 [ 162 ]
          samir Samir made changes -
          Remaining Estimate 8h [ 28800 ]
          Original Estimate 8h [ 28800 ]
          swapnil.pandhare Swapnil Pandhare (Inactive) made changes -
          Assignee Swapnil Pandhare [ swapnil.pandhare ] Samir [ samir ]
          samir Samir made changes -
          Assignee Samir [ samir ] Mohd Belal [ mohd.belal ]
          shashikant.mishra ShashiKant Mishra (Inactive) made changes -
          Sprint DMS - Fall Sprint 3 [ 162 ] DMS - Fall Sprint 3, DMS - Fall Sprint 4 [ 162, 163 ]
          mohd.belal Mohd Belal (Inactive) made changes -
          Status To Do [ 10000 ] In Progress [ 3 ]
          Permalink
          mohd.belal Mohd Belal (Inactive) logged work - 27/May/19 10:23 PM
          • Time Spent:
            3h
             

            Checked and verified the case.

          mohd.belal Mohd Belal (Inactive) made changes -
          Remaining Estimate 8h [ 28800 ] 5h [ 18000 ]
          Time Spent 3h [ 10800 ]
          Worklog Id 180049 [ 180049 ]
          Hide
          Permalink
          mohd.belal Mohd Belal (Inactive) added a comment - - edited

          In Review and Sign page the images are getting populated, but in email we are not getting the images added in Text document.

          Show
          mohd.belal Mohd Belal (Inactive) added a comment - - edited In Review and Sign page the images are getting populated, but in email we are not getting the images added in Text document.
          mohd.belal Mohd Belal (Inactive) made changes -
          Status In Progress [ 3 ] In QA Testing [ 11901 ]
          mohd.belal Mohd Belal (Inactive) made changes -
          Status In QA Testing [ 11901 ] In Progress [ 3 ]
          mohd.belal Mohd Belal (Inactive) made changes -
          Assignee Mohd Belal [ mohd.belal ] Samir [ samir ]
          samir Samir made changes -
          Assignee Samir [ samir ] Akash Thakur [ akash.thakur ]
          Permalink
          akash.thakur Akash Thakur (Inactive) logged work - 10/Jun/19 12:35 AM
          • Time Spent:
            8h
             

            R & D.

            Re-verification.

            Approach the discussion with Rohan.

            trial & error methods.

            testing feasibility of approach.

            etc

             

             

             

          shashikant.mishra ShashiKant Mishra (Inactive) made changes -
          Sprint DMS - Fall Sprint 3, DMS - Fall Sprint 4 [ 162, 163 ] DMS - Fall Sprint 3, DMS - Fall Sprint 4, DMS - Fall Sprint 5 [ 162, 163, 164 ]
          akash.thakur Akash Thakur (Inactive) made changes -
          Status In Progress [ 3 ] Code Review [ 11801 ]
          akash.thakur Akash Thakur (Inactive) made changes -
          Attachment AFFTECTED_FILES_DEV_1336.txt [ 110115 ]
          akash.thakur Akash Thakur (Inactive) made changes -
          Dev Estimates 16
          Developer Akash Thakur [ akash.thakur ]
          Permalink
          akash.thakur Akash Thakur (Inactive) logged work - 11/Jun/19 12:36 AM
          • Time Spent:
            4h
             

            Code review by Rohan at the development level.

            code merge & testing.

            checking the possibility of broken paths.

            assumptions of the path at the server level.

             

          akash.thakur Akash Thakur (Inactive) made changes -
          Remaining Estimate 5h [ 18000 ] 0h [ 0 ]
          Time Spent 3h [ 10800 ] 11h [ 39600 ]
          Worklog Id 182527 [ 182527 ]
          akash.thakur Akash Thakur (Inactive) made changes -
          Time Spent 11h [ 39600 ] 15h [ 54000 ]
          Worklog Id 182528 [ 182528 ]
          akash.thakur Akash Thakur (Inactive) made changes -
          Description File Type : Text
          1.Create the document template with file type TEXT, upload the image in body
          2.Send the document
          3.Review and sign
          4.Image is not observed
          PFA -

          		File Type: Text
           1.Create the document template with file type TEXT, upload the image in the body
           2. Send the document
           3. In Email, we are not getting the images added in document template with file type TEXT

           PFA -
          akash.thakur Akash Thakur (Inactive) made changes -
          Attachment image_3g.png [ 110135 ]
          Hide
          Permalink
          akash.thakur Akash Thakur (Inactive) added a comment - - edited

          Hi All,

          Please Find below 3'Cs for this Jira

          Concern:-  In Email we are not getting the images added in document template with file type TEXT.

          Cause:-  For Template type TEXT we are using CKEditor for HTML body Creation. & it uses Base64 encoding by default to embed images inserted in the body which is almost blocked on email servers for security purpose thus images are not displayed in the received email.

          Correction:- We are converting Base64 encoded string used as a source in image tags from the HTML body of template to the actual image and writing them on fileserver once this is done we move these images from file server to web server and replace the respective image source with the total absolute path of the image  copied to web server folder.

          Rohan J Khandave please request you to review the code.

          PFA:- Affected Files & image_3g.png for reference.

           

          Thanks,

          Akash Thakur

          Swapnil Pandhare Rohan J Khandave Samir

          Show
          akash.thakur Akash Thakur (Inactive) added a comment - - edited Hi All, Please Find below 3'Cs for this Jira Concern :-  In Email we are not getting the images added in document template with file type TEXT. Cause :-  For Template type TEXT we are using CKEditor for HTML body Creation. & it uses Base64 encoding by default to embed images inserted in the body which is almost blocked on email servers for security purpose thus images are not displayed in the received email. Correction :- We are converting Base64 encoded string used as a source in image tags from the HTML body of template to the actual image and writing them on fileserver once this is done we move these images from file server to web server and replace the respective image source with the total absolute path of the image  copied to web server folder. Rohan J Khandave please request you to review the code. PFA:- Affected Files &  image_3g.png  for reference.   Thanks, Akash Thakur Swapnil Pandhare Rohan J Khandave Samir
          akash.thakur Akash Thakur (Inactive) made changes -
          Status Code Review [ 11801 ] CODE REVIEW ON HOLD [ 12000 ]
          akash.thakur Akash Thakur (Inactive) made changes -
          Assignee Akash Thakur [ akash.thakur ] Rohan J Khandave [ rohan.khandave ]
          Hide
          Permalink
          akash.thakur Akash Thakur (Inactive) added a comment - - edited

          Hi Rohan J Khandave ,

          Please have a review of the changes suggested.

          PR:- https://github.com/cbdr/DMS/pull/620

          Thanks,

          Akash Thakur

           

          Rohan J Khandave

          Show
          akash.thakur Akash Thakur (Inactive) added a comment - - edited Hi Rohan J Khandave , Please have a review of the changes suggested. PR:-  https://github.com/cbdr/DMS/pull/620 Thanks, Akash Thakur   Rohan J Khandave
          Permalink
          akash.thakur Akash Thakur (Inactive) logged work - 11/Jun/19 06:05 AM
          • Time Spent:
            2h
             

            Code review changes.

            refactoring.

            logic changed again.

             

          akash.thakur Akash Thakur (Inactive) made changes -
          Time Spent 15h [ 54000 ] 17h [ 61200 ]
          Worklog Id 182585 [ 182585 ]
          rohan.khandave Rohan J Khandave (Inactive) made changes -
          Status CODE REVIEW ON HOLD [ 12000 ] Code Review [ 11801 ]
          rohan.khandave Rohan J Khandave (Inactive) made changes -
          Status Code Review [ 11801 ] In Progress [ 3 ]
          Hide
          Permalink
          rohan.khandave Rohan J Khandave (Inactive) added a comment -

          Please review comments from code review.

          Show
          rohan.khandave Rohan J Khandave (Inactive) added a comment - Please review comments from code review.
          rohan.khandave Rohan J Khandave (Inactive) made changes -
          Assignee Rohan J Khandave [ rohan.khandave ] Akash Thakur [ akash.thakur ]
          Permalink
          akash.thakur Akash Thakur (Inactive) logged work - 13/Jun/19 07:06 AM
          • Time Spent:
            4h
             

            unit test cases. R & D

          akash.thakur Akash Thakur (Inactive) made changes -
          Time Spent 17h [ 61200 ] 21h [ 75600 ]
          Worklog Id 183054 [ 183054 ]
          akash.thakur Akash Thakur (Inactive) made changes -
          Status In Progress [ 3 ] Code Review [ 11801 ]
          akash.thakur Akash Thakur (Inactive) made changes -
          Assignee Akash Thakur [ akash.thakur ] Rohan J Khandave [ rohan.khandave ]
          Hide
          Permalink
          akash.thakur Akash Thakur (Inactive) added a comment -

          Hi Samir,

          I have completed all the changes suggested by Rohan J Khandave & Harshveer Singh the code is refactored multiple time in order to be optimized. I have written a test case for the changes but it requires session data so once Ganesh Sadawarte commits his structure changes we will update the test case for this bug.

          Rohan J Khandave (Harshveer Singh has reviewed all the changes he suggested). please request you to review the template date related changes & test case wrote.

          Thanks,
          Akash Thakur
          Ganesh Sadawarte

          Show
          akash.thakur Akash Thakur (Inactive) added a comment - Hi Samir , I have completed all the changes suggested by Rohan J Khandave & Harshveer Singh the code is refactored multiple time in order to be optimized. I have written a test case for the changes but it requires session data so once Ganesh Sadawarte commits his structure changes we will update the test case for this bug. Rohan J Khandave ( Harshveer Singh has reviewed all the changes he suggested). please request you to review the template date related changes & test case wrote. Thanks, Akash Thakur Ganesh Sadawarte
          Permalink
          akash.thakur Akash Thakur (Inactive) logged work - 14/Jun/19 03:56 AM
          • Time Spent:
            4h
             

            discussion with harshveer & Rohan.

            code changes as suggested.

            multiple refactoring as there was the approach change a bit.

            unit testing.

            test cases.

            sent for review again.

             

             

             

          akash.thakur Akash Thakur (Inactive) made changes -
          Time Spent 21h [ 75600 ] 25h [ 90000 ]
          Worklog Id 183256 [ 183256 ]
          akash.thakur Akash Thakur (Inactive) made changes -
          Dev Estimates 16 24
          Original Estimate 8h [ 28800 ] 24h [ 86400 ]
          rohan.khandave Rohan J Khandave (Inactive) made changes -
          Assignee Rohan J Khandave [ rohan.khandave ] Akash Thakur [ akash.thakur ]
          rohan.khandave Rohan J Khandave (Inactive) made changes -
          Status Code Review [ 11801 ] In Progress [ 3 ]
          Ganesh.sadawarte Ganesh Sadawarte (Inactive) made changes -
          Time Spent 25h [ 90000 ] 25h 20m [ 91200 ]
          Worklog Id 183298 [ 183298 ]
          Permalink
          Ganesh.sadawarte Ganesh Sadawarte (Inactive) logged work - 14/Jun/19 06:17 PM
          • Time Spent:
            20m
             
            • Xunit test cases discussion.
          akash.thakur Akash Thakur (Inactive) made changes -
          Status In Progress [ 3 ] In Progress [ 3 ]
          akash.thakur Akash Thakur (Inactive) made changes -
          Status In Progress [ 3 ] In Progress [ 3 ]
          samir Samir made changes -
          Status In Progress [ 3 ] Code Review [ 11801 ]
          samir Samir made changes -
          Assignee Akash Thakur [ akash.thakur ] Rohan J Khandave [ rohan.khandave ]
          shashikant.mishra ShashiKant Mishra (Inactive) made changes -
          Sprint DMS - Fall Sprint 3, DMS - Fall Sprint 4, DMS - Fall Sprint 5 [ 162, 163, 164 ] DMS - Fall Sprint 3, DMS - Fall Sprint 4, DMS - Fall Sprint 5, DMS - Fall Sprint 6 [ 162, 163, 164, 165 ]
          rohan.khandave Rohan J Khandave (Inactive) made changes -
          Assignee Rohan J Khandave [ rohan.khandave ] Ganesh Sadawarte [ ganesh.sadawarte ]
          Permalink
          akash.thakur Akash Thakur (Inactive) logged work - 26/Jun/19 05:29 AM
          • Time Spent:
            1.5h
             

            testing after dependency merge.

          Hide
          Permalink
          akash.thakur Akash Thakur (Inactive) added a comment -

          Hi All,

          This branch will be merged after DMS-1342 changes.it was pending for test case structure changes done inside 1342 branch.

          performing a test to make it ready to merge into develop.

          Thanks,

          Akash Thakur

          Samir Narendra Kumar Harshveer Singh Rohan J Khandave Ganesh Sadawarte

          Show
          akash.thakur Akash Thakur (Inactive) added a comment - Hi All, This branch will be merged after DMS-1342 changes.it was pending for test case structure changes done inside 1342 branch. performing a test to make it ready to merge into develop. Thanks, Akash Thakur Samir Narendra Kumar Harshveer Singh Rohan J Khandave Ganesh Sadawarte
          akash.thakur Akash Thakur (Inactive) made changes -
          Time Spent 25h 20m [ 91200 ] 26h 50m [ 96600 ]
          Worklog Id 185262 [ 185262 ]
          Raj.Hawaldar Raj Hawaldar (Inactive) made changes -
          Status Code Review [ 11801 ] In QA Testing [ 11901 ]
          Raj.Hawaldar Raj Hawaldar (Inactive) made changes -
          Assignee Ganesh Sadawarte [ ganesh.sadawarte ] Samir [ samir ]
          shashikant.mishra ShashiKant Mishra (Inactive) made changes -
          Sprint DMS - Fall Sprint 3, DMS - Fall Sprint 4, DMS - Fall Sprint 5, DMS - Fall Sprint 6 [ 162, 163, 164, 165 ] DMS - Fall Sprint 3, DMS - Fall Sprint 4, DMS - Fall Sprint 5, DMS - Fall Sprint 6, DMS - Fall Sprint 7 [ 162, 163, 164, 165, 166 ]
          priya.dhamande Priya Dhamande (Inactive) made changes -
          Assignee Samir [ samir ] Priya Dhamande [ priya.dhamande ]
          shashikant.mishra ShashiKant Mishra (Inactive) made changes -
          Sprint DMS - Fall Sprint 3, DMS - Fall Sprint 4, DMS - Fall Sprint 5, DMS - Fall Sprint 6, DMS - Fall Sprint 7 [ 162, 163, 164, 165, 166 ] DMS - Fall Sprint 3, DMS - Fall Sprint 4, DMS - Fall Sprint 5, DMS - Fall Sprint 6, DMS - Fall Sprint 7, DMS - Fall Sprint 8 [ 162, 163, 164, 165, 166, 167 ]
          Permalink
          priya.dhamande Priya Dhamande (Inactive) logged work - 22/Jul/19 05:26 AM
          • Time Spent:
            1h
             

            discussion and prod testing

          priya.dhamande Priya Dhamande (Inactive) made changes -
          Attachment Screenshot (3298).png [ 114033 ]
          Attachment Screenshot (3297).png [ 114034 ]
          Attachment Screenshot (3296).png [ 114035 ]
          Attachment Screenshot (3299).png [ 114036 ]
          priya.dhamande Priya Dhamande (Inactive) made changes -
          Resolution Done [ 10000 ]
          Status In QA Testing [ 11901 ] Done [ 10001 ]
          priya.dhamande Priya Dhamande (Inactive) made changes -
          Time Spent 26h 50m [ 96600 ] 27h 50m [ 100200 ]
          Worklog Id 190451 [ 190451 ]
          priya.dhamande Priya Dhamande (Inactive) made changes -
          Comment [ Environment: Production
          Login: Admin
          Browser: FF and Chrome
          Page: Send Forms Preview

          Prerequisite: 2 companies with different logo

          The issue of Preview page getting default logo for any company is resolved and verified on production.
          Now, the Preview page displays logo as per company.

          Refer screen capture. So, marking jira done.
          [~sachin.hingole] [~hrishikesh.deshpande] [~rohan.khandave] [~samir] ]
          priya.dhamande Priya Dhamande (Inactive) made changes -
          Resolution Done [ 10000 ]
          Status Done [ 10001 ] In Progress [ 3 ]
          priya.dhamande Priya Dhamande (Inactive) made changes -
          Status In Progress [ 3 ] In QA Testing [ 11901 ]
          priya.dhamande Priya Dhamande (Inactive) made changes -
          Attachment Screenshot (3299).png [ 114036 ]
          priya.dhamande Priya Dhamande (Inactive) made changes -
          Attachment Screenshot (3296).png [ 114035 ]
          priya.dhamande Priya Dhamande (Inactive) made changes -
          Attachment Screenshot (3298).png [ 114033 ]
          priya.dhamande Priya Dhamande (Inactive) made changes -
          Attachment Screenshot (3297).png [ 114034 ]
          Hide
          Permalink
          priya.dhamande Priya Dhamande (Inactive) added a comment -

          Environment: Production
          Login: Admin and Candidate
          Browser: FF and Chrome
          Page: Review and Sign
          File Type: text

          Image in Text File Type

          • Can be seen on Preview of Admin
          • Review and Sign of Candidate
          • Able to Submit text Image document
          • Able to Decline text Image document

          Refer screen capture. So, marking jira done.

          Sachin Hingole Hrishikesh Deshpande Samir Rohan J Khandave

          Refer screen capture. So, marking jira done.

          Show
          priya.dhamande Priya Dhamande (Inactive) added a comment - Environment: Production Login: Admin and Candidate Browser: FF and Chrome Page: Review and Sign File Type: text Image in Text File Type Can be seen on Preview of Admin Review and Sign of Candidate Able to Submit text Image document Able to Decline text Image document Refer screen capture. So, marking jira done. Sachin Hingole Hrishikesh Deshpande Samir Rohan J Khandave Refer screen capture. So, marking jira done.
          Permalink
          priya.dhamande Priya Dhamande (Inactive) logged work - 25/Jul/19 10:53 PM - edited
          • Time Spent:
            0.5h
             

            Prod testing

          priya.dhamande Priya Dhamande (Inactive) made changes -
          Attachment Screenshot (3481).png [ 114539 ]
          Attachment Screenshot (3480).png [ 114540 ]
          Attachment Screenshot (3479).png [ 114541 ]
          Attachment Screenshot (3482).png [ 114542 ]
          priya.dhamande Priya Dhamande (Inactive) made changes -
          Resolution Done [ 10000 ]
          Status In QA Testing [ 11901 ] Done [ 10001 ]
          priya.dhamande Priya Dhamande (Inactive) made changes -
          Time Spent 27h 50m [ 100200 ] 57h 50m [ 208200 ]
          Worklog Id 191510 [ 191510 ]
          priya.dhamande Priya Dhamande (Inactive) made changes -
          Assignee Priya Dhamande [ priya.dhamande ] Akash Thakur [ akash.thakur ]
          priya.dhamande Priya Dhamande (Inactive) made changes -
          Remaining Estimate 0h [ 0 ] 29.5h [ 106200 ]
          Time Spent 57h 50m [ 208200 ] 28h 20m [ 102000 ]
          Worklog Id 191510 [ 191510 ]
          Transition Time In Source Status Execution Times
          Mohd Belal (Inactive) made transition -
          To Do In Progress
          		25d 19h 38m 1
          Mohd Belal (Inactive) made transition -
          In QA Testing In Progress
          		1d 8m 1
          Akash Thakur (Inactive) made transition -
          Code Review CODE REVIEW ON HOLD
          		3h 8m 1
          Rohan J Khandave (Inactive) made transition -
          CODE REVIEW ON HOLD Code Review
          		19h 52m 1
          Rohan J Khandave (Inactive) made transition -
          Code Review In Progress
          		1d 5h 20m 2
          Akash Thakur (Inactive) made transition -
          In Progress In Progress
          		2d 16h 2
          Samir made transition -
          In Progress Code Review
          		14d 3h 28m 3
          Raj Hawaldar (Inactive) made transition -
          Code Review In QA Testing
          		10d 5h 17m 1
          Priya Dhamande (Inactive) made transition -
          Done In Progress
          		1m 38s 1
          Priya Dhamande (Inactive) made transition -
          In Progress In QA Testing
          		23m 34s 2
          Priya Dhamande (Inactive) made transition -
          In QA Testing Done
          		28d 19h 9m 2

            People

            Assignee:
            akash.thakur Akash Thakur (Inactive)
            Reporter:
            jayshree.nagpure Jayshree Nagpure (Inactive)
            Developer:
            Akash Thakur (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 24h Original Estimate - 24h
                24h
                Remaining:
                Time Spent - 28h 20m Remaining Estimate - 29.5h
                29.5h
                Logged:
                Time Spent - 28h 20m Remaining Estimate - 29.5h
                28h 20m